| *** persia has quit IRC | 01:41 | |
| *** persia has joined #storyboard | 01:43 | |
| *** r1chardj0n3s is now known as r1chardj0n3s_afk | 05:49 | |
| *** jcoufal has joined #storyboard | 07:24 | |
| *** k4n0 has joined #storyboard | 07:24 | |
| *** alexismonville has joined #storyboard | 07:37 | |
| *** mrmartin has joined #storyboard | 07:39 | |
| *** wdutch has joined #storyboard | 07:52 | |
| *** mrmartin has quit IRC | 08:18 | |
| *** mrmartin has joined #storyboard | 08:20 | |
| *** jtomasek has joined #storyboard | 08:24 | |
| *** MaxV has joined #storyboard | 08:47 | |
| *** yolanda has joined #storyboard | 09:08 | |
| openstackgerrit | Merged openstack-infra/storyboard: Add API call to return task statuses https://review.openstack.org/135221 | 09:31 |
|---|---|---|
| *** jedimike has joined #storyboard | 09:32 | |
| openstackgerrit | Merged openstack-infra/storyboard: Fixed bug in working directories. https://review.openstack.org/137197 | 09:33 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Story project is defaulted to the current project if available https://review.openstack.org/137057 | 09:49 |
| *** openstackgerrit has quit IRC | 09:50 | |
| *** openstackgerrit has joined #storyboard | 09:50 | |
| *** CTtpollard has joined #storyboard | 10:09 | |
| CTtpollard | has anyone had chance to look at https://storyboard.openstack.org/#!/story/2000037 ? | 10:54 |
| *** mase_x200 has joined #storyboard | 10:57 | |
| yolanda | hi CTtpollard, do you have a change to review? | 11:11 |
| CTtpollard | I'm am in the process of getting it ready to push to gerrit | 11:14 |
| yolanda | CTtpollar, i'll be happy to review it | 11:18 |
| *** jcoufal has quit IRC | 11:22 | |
| openstackgerrit | Tom Pollard proposed openstack-infra/storyboard-webclient: Change Gruntfile Connect Hostname to 0.0.0.0 https://review.openstack.org/138053 | 12:23 |
| jedimike | i need to run the webclient on my local machine, but use the api running on another machine. Where's the config to set that up? | 12:24 |
| persia | jedimike: I edited Gruntfile.js to mirror the production API target with another target, which worked for me. | 12:29 |
| jedimike | persia, ah, thanks! I'd overlooked that file | 12:30 |
| persia | I'd be curious *why* you need this. I was hoping to create a generic deployment for it, but was advised that only I was crazy enough to want to run my API on a server other than my development environment | 12:31 |
| persia | If several of us could use this, then adding a generic handler (taking an argument to provide the server) might make sense. | 12:32 |
| jedimike | persia, there's a bug with timezones, i need to run my api server on a vm with a different timezone to the client | 12:40 |
| persia | Excellent. That's the sort of use case that may come up not infrequently. | 12:40 |
| jedimike | hmmm, does anyone know what timezone the production api server is configured with? | 13:21 |
| persia | I would have expected to find something in http://git.openstack.org/cgit/openstack-infra/system-config , but don't see anything timezone related. | 13:44 |
| persia | Perhaps set one system to UTC+8 and the other to UTC-8 for a wide difference? Hong Kong and Portland may be useful cities for this. | 13:44 |
| *** mase_x200 has quit IRC | 13:52 | |
| jedimike | sounds like a plan | 13:58 |
| jedimike | mysql + python + json is a horrible combination for getting timezones right :) | 13:59 |
| *** mattfarina has joined #storyboard | 14:00 | |
| openstackgerrit | yolanda.robla proposed openstack-infra/storyboard-webclient: hide events filter if not logged in https://review.openstack.org/138077 | 14:36 |
| jedimike | so far I've tried the api server and client server in different timezones, and the api server and client server in the same timezone, but the web browser in a different timezone, I can't reproduce this bug | 14:48 |
| jedimike | krotscheck, when you're around, can you help me with the login/loading bug? I'm struggling to reproduce. I have VMs set up, able to switch them to different timezones to help test locally | 14:57 |
| krotscheck | jedimike: It really is. | 15:06 |
| jedimike | krotscheck, good morning :) | 15:07 |
| krotscheck | jedimike: Hey there! | 15:07 |
| krotscheck | jedimike: Good afternoon to you :) | 15:07 |
| CTtpollard | morning krotscheck | 15:07 |
| krotscheck | Hey there, CTtpollard. | 15:07 |
| krotscheck | jedimike: Let me see what I can do about the login piece. | 15:10 |
| jedimike | thanks, no matter what I try, it works! | 15:10 |
| yolanda | jedimike, works locally for me as well | 15:11 |
| yolanda | but it fails in production every time | 15:11 |
| jedimike | fails for me in production *sometimes* | 15:13 |
| *** k4n0 has quit IRC | 15:16 | |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard-webclient: Eabled custom dev configuration. https://review.openstack.org/138087 | 15:18 |
| krotscheck | persia: ^^ | 15:18 |
| openstackgerrit | Nikita Konovalov proposed openstack-infra/python-storyboardclient: Initial Cookiecutter Commit. https://review.openstack.org/138090 | 15:23 |
| openstackgerrit | Nikita Konovalov proposed openstack-infra/python-storyboardclient: Addind apiclient from oslo incubator https://review.openstack.org/138091 | 15:23 |
| openstackgerrit | Nikita Konovalov proposed openstack-infra/python-storyboardclient: Setting up base classes https://review.openstack.org/138092 | 15:23 |
| *** jtomasek has quit IRC | 15:32 | |
| *** jtomasek has joined #storyboard | 15:33 | |
| krotscheck | jedimike: still poking on your issue. Have to suspend for meeting prep, will pick up again at 9AM PST. | 15:34 |
| jedimike | krotscheck, thanks! I'll catch you later, I should be around further into my evening today, I really want to get this figured out :) | 15:35 |
| krotscheck | jedimike: Yeah, I do too. | 15:35 |
| krotscheck | Storyboard meeting in #openstack-meeting-3 | 16:00 |
| *** mattfari_ has joined #storyboard | 16:02 | |
| *** mattfarina has quit IRC | 16:02 | |
| *** mattfari_ has quit IRC | 16:04 | |
| *** mattfarina has joined #storyboard | 16:06 | |
| krotscheck | mbitard | 16:10 |
| *** alexismonville has quit IRC | 16:56 | |
| krotscheck | Meeting Agenda: http://eavesdrop.openstack.org/meetings/storyboard/2014/storyboard.2014-12-01-16.00.html | 17:01 |
| krotscheck | Sorry | 17:01 |
| krotscheck | Summary! | 17:01 |
| krotscheck | For those who weren’t there :) | 17:01 |
| *** mrmartin has quit IRC | 17:03 | |
| CTtpollard | could some provide me a url to the python client please? :) | 17:03 |
| rcarrillocruz | http://git.openstack.org/cgit/openstack-infra/python-storyboardclient | 17:08 |
| rcarrillocruz | https://review.openstack.org/#/q/project:openstack-infra/python-storyboardclient,n,z | 17:08 |
| *** mrmartin has joined #storyboard | 17:08 | |
| rcarrillocruz | CTtpollard: ^ | 17:09 |
| CTtpollard | ty | 17:09 |
| *** mrmartin has quit IRC | 17:10 | |
| *** mrmartin has joined #storyboard | 17:11 | |
| *** mrmartin has quit IRC | 17:13 | |
| yolanda | krotscheck, i left a comment for the add new task bug... i suppose priority and description should not be propagated when a new task is added after another one? | 17:17 |
| krotscheck | Perhaps. Will look into that | 17:18 |
| * krotscheck needs to go commute, back in 15 | 17:18 | |
| krotscheck | I mean 45 | 17:18 |
| *** jesusaurus has quit IRC | 17:21 | |
| *** jesusaurus has joined #storyboard | 17:28 | |
| *** MaxV has quit IRC | 17:31 | |
| *** reed has joined #storyboard | 17:51 | |
| *** lifeless has quit IRC | 18:10 | |
| *** lifeless has joined #storyboard | 18:23 | |
| *** MaxV has joined #storyboard | 18:44 | |
| *** jedimike is now known as jedimike|afk | 18:48 | |
| *** MaxV has quit IRC | 19:17 | |
| *** MaxV has joined #storyboard | 19:24 | |
| *** mrmartin has joined #storyboard | 19:32 | |
| *** MaxV has quit IRC | 19:49 | |
| krotscheck | jedimike|afk: Ok, I’m going to dump some of the things I’ve discovered. | 19:52 |
| *** jedimike|afk is now known as jedimike | 19:52 | |
| jedimike | krotscheck, cool | 19:52 |
| krotscheck | First of all: To reproduce the login error, what you need to do is login first, then add the following to the end of /src/app/storyboard/module.js -> http://paste.openstack.org/show/142849/ | 19:53 |
| krotscheck | That will invalidate the current access token, and after another refresh will attempt to get a refresh token, which breaks. | 19:53 |
| krotscheck | After that happens, storyboard issues _two_ requests to refresh the token. The second one always fails, but that triggers a permission refresh. | 19:54 |
| krotscheck | The permission refresh forces a user load, but at that point the system thinks it’s logged out, and doesn’t have a user_id in memory. | 19:55 |
| krotscheck | So it loads /api/v1/users rather than /api/v1/users/ID, and that throws an exception causing the javascript parser to lock the app. | 19:55 |
| *** MaxV has joined #storyboard | 19:56 | |
| krotscheck | I’m still tracking down the timestamp bit, doing that now. | 19:56 |
| *** jtomasek has quit IRC | 19:57 | |
| jedimike | ah, that explains the "array not object" error | 19:57 |
| krotscheck | Yep | 19:57 |
| krotscheck | jedimike: Actually, I stand corrected. The timestamp thing I sent you down is a red herring. | 19:57 |
| * krotscheck feels sheepish | 19:57 | |
| jedimike | krotscheck, that makes me feel better for not being able to reproduce it then :) | 19:57 |
| krotscheck | The oauth response uses the default http date header, which I don’t think is set by the API, it’s rather set by apache and contains a timezone, | 19:58 |
| krotscheck | So that should be accurate. | 19:58 |
| jedimike | yeah, no matter what timezone combinations i used, the expiry date in the db always worked as expected | 19:58 |
| krotscheck | jedimike: I’m really sorry about that :( | 20:00 |
| jedimike | krotscheck, no, it's fine, I learned about how grunt is configured while looking at it, so time was still well spent! | 20:01 |
| jedimike | so now i guess we need to figure out how the tokens are becoming invalid, or how they're generated with an invalid state? | 20:02 |
| krotscheck | jedimike: Honestly, I think they’re invalidating as expected, it’s the “Why are we trying to refresh the token twice” question. | 20:04 |
| krotscheck | And I think I know why. | 20:04 |
| jedimike | race condition? two requests from the client at the same time? | 20:04 |
| krotscheck | jedimike: Look at line 53 in refresh_manager.js. Notice something interesting about the function call to getAccessToken()? | 20:06 |
| * jedimike goes to look | 20:06 | |
| krotscheck | Sorry | 20:06 |
| krotscheck | 63 | 20:06 |
| *** MaxV has quit IRC | 20:07 | |
| jedimike | !!nextRefreshPromise ? | 20:07 |
| openstack | jedimike: Error: "!nextRefreshPromise" is not a valid command. | 20:07 |
| krotscheck | jedimike: The fact that there’s no () at the end of it. | 20:08 |
| krotscheck | jedimike: It’s comparing a string to a function | 20:08 |
| krotscheck | That’s totally my fault :/ | 20:08 |
| *** r1chardj0n3s_afk is now known as r1chardj0n3s | 20:10 | |
| jedimike | that's one of the "here be dragons" bits of javascript, what happens when you treat a function as a boolean without calling it? I wouldn't have been able to say off the tp of my head, I'd have thought it would have been truthy | 20:11 |
| krotscheck | Yeah, but we’re using a strict equal | 20:12 |
| krotscheck | so that’s always going to be false. | 20:13 |
| krotscheck | Also, neither the refreshtokenpromise nor the schedulefortoken are ever cleared. | 20:13 |
| krotscheck | Usually that wouldn’t be a problem, but a long running session will have problems. | 20:13 |
| jedimike | krotscheck, thing is, nextRefreshPromise starts out as null, so you need to deal with that case too don't you? | 20:13 |
| krotscheck | jedimike: Yep | 20:13 |
| jedimike | hmmm | 20:14 |
| krotscheck | I feel like scheduleForRefresh is doing a lot of things that tryRefresh should be handling. | 20:15 |
| jedimike | so !!nextRefreshPromise seems correct, that's just checking if you don't have a nextRefreshPromise, it's just the () on getAccessToken that's missing, because if you *don't* have nextRefreshPromise, it gets assigned in that block | 20:15 |
| jedimike | or am i reading it wrong? | 20:15 |
| krotscheck | That’s correct. | 20:16 |
| jedimike | cool :) | 20:18 |
| krotscheck | jedimike: I think I have a fix | 20:31 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard-webclient: Fixed refresh token. https://review.openstack.org/138174 | 20:33 |
| krotscheck | jedimike: ^^ | 20:34 |
| jedimike | krotscheck, looking now | 20:34 |
| krotscheck | Ooops | 20:34 |
| krotscheck | need to fix the module.js | 20:34 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard-webclient: Fixed refresh token. https://review.openstack.org/138174 | 20:35 |
| krotscheck | Much better. | 20:35 |
| jedimike | ah you took out the debug before i could leave my comment :) | 20:37 |
| jedimike | krotscheck, that looks good | 20:38 |
| krotscheck | jedimike: Thanks! I’m off ot lunch, bbiab. | 20:44 |
| jedimike | off for the evening, working on the search results spec tomorrow! | 20:57 |
| *** jedimike has quit IRC | 20:58 | |
| *** MaxV has joined #storyboard | 21:23 | |
| *** jesusaur has joined #storyboard | 21:29 | |
| *** jesusaurus has quit IRC | 21:31 | |
| *** jesusaur is now known as jesusaurus | 21:31 | |
| *** MaxV has quit IRC | 21:35 | |
| *** mrmartin has quit IRC | 21:35 | |
| krotscheck | NikitaKonovalov: Comment for you here https://review.openstack.org/#/c/135739/ | 21:38 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Add more details on event dashboard https://review.openstack.org/135954 | 21:40 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard-webclient: Streamlined task edit form. https://review.openstack.org/135739 | 21:47 |
| reed | I cannot find the UX project in gerrit/projects.yaml.. Is it supposed to be there? https://storyboard.openstack.org/#!/project/707 | 21:56 |
| persia | reed: There is no associated git repo | 22:01 |
| reed | persia, right... so how was that project created in SB? | 22:01 |
| persia | I always presumed it to have been a manual administrative action. I could be wrong. | 22:02 |
| reed | ah | 22:02 |
| krotscheck | It’s not. | 22:03 |
| krotscheck | Looks like the jenkins merge that immediately followed my ux patch erased it. | 22:04 |
| * krotscheck pings infra about this. | 22:04 | |
| *** mattfarina has quit IRC | 22:06 | |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Streamlined task edit form. https://review.openstack.org/135739 | 22:49 |
| reed | thanks for investigating krotscheck | 22:53 |
| krotscheck | No prob reed | 23:09 |
| *** MaxV has joined #storyboard | 23:18 | |
| *** r1chardj0n3s is now known as r1chardj0n3s_afk | 23:27 | |
| *** MaxV has quit IRC | 23:29 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!