| openstackgerrit | Michael Krotscheck proposed a change to openstack-infra/storyboard-webclient: Subscription https://review.openstack.org/104004 | 00:02 |
|---|---|---|
| openstackgerrit | Aishwarya Thangappa proposed a change to openstack-infra/storyboard: Added a subscription_events table & subscription hander https://review.openstack.org/113016 | 00:09 |
| openstackgerrit | Michael Krotscheck proposed a change to openstack-infra/storyboard: Exposed subscription_events in API https://review.openstack.org/114399 | 00:12 |
| *** wenlock has quit IRC | 00:14 | |
| *** Ish__ has left #storyboard | 00:17 | |
| openstackgerrit | Michael Krotscheck proposed a change to openstack-infra/storyboard-webclient: [WIP] Subscription events now appear in UI https://review.openstack.org/114404 | 00:49 |
| openstackgerrit | Michael Krotscheck proposed a change to openstack-infra/storyboard: Added a subscription_events table & subscription hander https://review.openstack.org/113016 | 00:55 |
| openstackgerrit | Michael Krotscheck proposed a change to openstack-infra/storyboard: Added a subscription_events table & subscription hander https://review.openstack.org/113016 | 00:57 |
| krotscheck | ttx, NikitaKonovalov: If y’all could take a look at the reviews leading up to this one, that’d be neat: https://review.openstack.org/#/c/114353/1 | 00:59 |
| krotscheck | Good night! | 00:59 |
| *** Ish__ has joined #storyboard | 01:48 | |
| openstackgerrit | Aishwarya Thangappa proposed a change to openstack-infra/storyboard: Added a subscription_events table & subscription hander https://review.openstack.org/113016 | 02:34 |
| *** Ish__ has quit IRC | 02:38 | |
| *** Ish__ has joined #storyboard | 04:18 | |
| *** reed has quit IRC | 05:24 | |
| *** Ish__ has quit IRC | 05:29 | |
| krotscheck | Good morning everyone :) | 05:59 |
| *** jcoufal has joined #storyboard | 06:44 | |
| *** jtomasek_ has joined #storyboard | 07:03 | |
| *** jtomasek_ is now known as jtomasek | 07:27 | |
| openstackgerrit | Nikita Konovalov proposed a change to openstack-infra/storyboard: Refactor WSME models https://review.openstack.org/114225 | 10:49 |
| *** MaxV has joined #storyboard | 10:58 | |
| *** MaxV has quit IRC | 10:58 | |
| *** mfer has joined #storyboard | 13:06 | |
| *** Ish__ has joined #storyboard | 13:42 | |
| openstackgerrit | Nikita Konovalov proposed a change to openstack-infra/storyboard: Rest controllers fix https://review.openstack.org/114534 | 13:42 |
| krotscheck | NikitaKonovalov: Still around? | 14:09 |
| NikitaKonovalov | krotscheck: yep | 14:10 |
| krotscheck | Did you catch the conversation in -infra yesterday about how I got credit on a patch that I shouldn’t have? | 14:10 |
| NikitaKonovalov | No. I'll try to find logs | 14:11 |
| krotscheck | NikitaKonovalov: I can summarize | 14:11 |
| krotscheck | NikitaKonovalov: Basically it has to do with this patch - http://git.openstack.org/cgit/openstack-infra/storyboard/commit/?id=9a5a5b59d6d0701cb1a1cfa5f7ec777d438ec969 | 14:12 |
| krotscheck | According to Gerrit, you and I did most of the work on that, while in reality all I did was rebase a lot. Ish__ should have gotten the credit there. | 14:12 |
| krotscheck | And, in order to make sure her internship gets full accounting, I spoke to infra to see how we could get her name on that. | 14:13 |
| krotscheck | The consensus was to do a double-revert: revert that patch, and follow it up with a revert-revert that includes exactly the same code, but correctly marks you and her as the authors. | 14:13 |
| krotscheck | NikitaKonovalov: That’s this - https://review.openstack.org/#/c/114346/, and this https://review.openstack.org/#/c/114353/ | 14:14 |
| NikitaKonovalov | Why no just add Ish__ as co-authored by | 14:14 |
| krotscheck | NikitaKonovalov: Because the patch landed and we can’t rewrite the git history | 14:14 |
| NikitaKonovalov | oh | 14:15 |
| NikitaKonovalov | now I see | 14:15 |
| krotscheck | I tried that :/ | 14:15 |
| krotscheck | Are you ok with the solution we came up with? It sets her up as owner as you as co-authored. | 14:15 |
| NikitaKonovalov | I'm ok | 14:16 |
| krotscheck | NikitaKonovalov: We can also submit a patch where you’re the official author and she’s the co-author… | 14:16 |
| krotscheck | Do you have a preference? | 14:16 |
| NikitaKonovalov | No preference there | 14:16 |
| krotscheck | Alright, cool. I’ll approve them then. | 14:17 |
| Ish__ | Thank you krotscheck and NikitaKonovalov for giving me the credits. :) | 14:17 |
| krotscheck | Ish__: Of course! You two did the work :) | 14:18 |
| Ish__ | krotscheck: yes.. But you took the efforts to get my credits :) | 14:19 |
| openstackgerrit | A change was merged to openstack-infra/storyboard: Revert "Added subscriber and publisher modules" https://review.openstack.org/114346 | 14:20 |
| openstackgerrit | Nikita Konovalov proposed a change to openstack-infra/storyboard: Rest controllers fix https://review.openstack.org/114534 | 14:21 |
| openstackgerrit | A change was merged to openstack-infra/storyboard: Added subscriber and publisher modules https://review.openstack.org/114353 | 14:22 |
| krotscheck | Ish__: http://git.openstack.org/cgit/openstack-infra/storyboard/commit/?id=c8cbc9720d671e796f05f88b3e9900660da7b3ee | 14:26 |
| krotscheck | ttx: You around? https://review.openstack.org/#/c/109439/6 | 14:29 |
| *** wenlock has joined #storyboard | 14:37 | |
| *** MaxV has joined #storyboard | 14:42 | |
| *** Ish__ has quit IRC | 14:45 | |
| *** david-lyle has joined #storyboard | 15:12 | |
| *** reed has joined #storyboard | 15:25 | |
| krotscheck | Anyone want to review https://review.openstack.org/#/c/113016/ ? :) | 16:14 |
| *** openstackgerrit has quit IRC | 17:02 | |
| *** openstackgerrit has joined #storyboard | 17:03 | |
| openstackgerrit | Monty Taylor proposed a change to openstack-infra/storyboard: Add loader subcommand to sync from launchpad https://review.openstack.org/113624 | 17:55 |
| *** cody-somerville has quit IRC | 18:46 | |
| openstackgerrit | Aishwarya Thangappa proposed a change to openstack-infra/storyboard: Added a subscription_events table & subscription hander https://review.openstack.org/113016 | 18:51 |
| *** cody-somerville has joined #storyboard | 19:11 | |
| *** cody-somerville has quit IRC | 19:31 | |
| *** MaxV has quit IRC | 19:33 | |
| *** jcoufal has quit IRC | 19:34 | |
| *** Ish__ has joined #storyboard | 19:41 | |
| *** Ish__ has quit IRC | 19:41 | |
| *** ruhe has quit IRC | 19:51 | |
| *** NikitaKonovalov has quit IRC | 19:51 | |
| *** SergeyLukjanov has quit IRC | 19:52 | |
| *** SergeyLukjanov has joined #storyboard | 20:00 | |
| *** NikitaKonovalov has joined #storyboard | 20:02 | |
| *** ruhe has joined #storyboard | 20:03 | |
| *** MaxV has joined #storyboard | 20:04 | |
| *** MaxV has quit IRC | 20:08 | |
| *** cody-somerville has joined #storyboard | 20:17 | |
| *** jtomasek has quit IRC | 20:30 | |
| *** Ish__ has joined #storyboard | 20:35 | |
| *** david-ly_ has joined #storyboard | 20:43 | |
| *** david-lyle has quit IRC | 20:45 | |
| *** Mattry has joined #storyboard | 20:54 | |
| *** Mattry has left #storyboard | 20:54 | |
| *** MaxV has joined #storyboard | 21:05 | |
| *** david-ly_ is now known as david-lyle | 21:05 | |
| *** MaxV has quit IRC | 21:09 | |
| *** mfer has quit IRC | 21:14 | |
| *** coolsvap has quit IRC | 21:50 | |
| *** Ish__ has left #storyboard | 21:53 | |
| *** coolsvap has joined #storyboard | 21:53 | |
| *** MaxV has joined #storyboard | 22:05 | |
| *** MaxV has quit IRC | 22:10 | |
| *** reed has quit IRC | 23:01 | |
| *** MaxV has joined #storyboard | 23:06 | |
| *** MaxV has quit IRC | 23:10 | |
| *** david-lyle has quit IRC | 23:13 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!