| *** openstackgerrit has joined #storyboard | 00:30 | |
| *** mfer has joined #storyboard | 01:18 | |
| *** mfer has quit IRC | 02:40 | |
| *** david-lyle has joined #storyboard | 02:56 | |
| *** david-lyle has quit IRC | 03:14 | |
| *** saju_m has joined #storyboard | 06:39 | |
| *** jcoufal has joined #storyboard | 07:17 | |
| *** saju_m has quit IRC | 07:42 | |
| *** saju_m has joined #storyboard | 07:52 | |
| *** jcoufal_ has joined #storyboard | 08:29 | |
| *** jcoufal has quit IRC | 08:30 | |
| *** jcoufal_ is now known as jcoufal | 08:30 | |
| *** saju_m has quit IRC | 08:48 | |
| *** saju_m has joined #storyboard | 08:49 | |
| *** jcoufal has quit IRC | 08:54 | |
| *** saju_m has quit IRC | 09:24 | |
| *** saju_m has joined #storyboard | 09:25 | |
| *** hashar has joined #storyboard | 09:26 | |
| *** saju_m has quit IRC | 09:31 | |
| *** saju_m has joined #storyboard | 09:37 | |
| *** jcoufal has joined #storyboard | 10:10 | |
| *** hashar has quit IRC | 10:56 | |
| *** openstackgerrit has quit IRC | 11:08 | |
| *** openstackgerrit has joined #storyboard | 11:08 | |
| *** hashar has joined #storyboard | 12:00 | |
| *** saju_m has quit IRC | 12:17 | |
| *** saju_m has joined #storyboard | 12:47 | |
| *** jcoufal has quit IRC | 13:08 | |
| *** jcoufal has joined #storyboard | 13:11 | |
| *** saju_m has quit IRC | 13:36 | |
| *** hashar has quit IRC | 14:22 | |
| *** hashar has joined #storyboard | 14:23 | |
| *** david-lyle has joined #storyboard | 14:43 | |
| *** david_lyle_ has joined #storyboard | 15:07 | |
| *** dklyle has joined #storyboard | 15:08 | |
| *** dklyle has quit IRC | 15:10 | |
| *** dklyle has joined #storyboard | 15:10 | |
| *** david-lyle has quit IRC | 15:10 | |
| *** dklyle is now known as david-lyle | 15:11 | |
| *** david_lyle_ has quit IRC | 15:11 | |
| *** mtaylor is now known as mordred | 15:19 | |
| *** mordred has quit IRC | 15:19 | |
| *** mordred has joined #storyboard | 15:19 | |
| *** openstackgerrit has quit IRC | 15:21 | |
| *** openstackgerrit has joined #storyboard | 15:21 | |
| *** denis_makogon has joined #storyboard | 15:28 | |
| *** hashar has quit IRC | 15:42 | |
| * ttx files storyboard stories | 15:43 | |
| *** jcoufal has quit IRC | 17:05 | |
| krotscheck | om nom nom stories | 17:23 |
|---|---|---|
| krotscheck | (Interviewing, back in 30) | 17:24 |
| *** jcoufal has joined #storyboard | 17:41 | |
| krotscheck | Ok, back | 17:52 |
| *** denis_makogon_ has joined #storyboard | 18:15 | |
| *** denis_makogon has quit IRC | 18:18 | |
| *** denis_makogon_ is now known as denis_makogon | 18:30 | |
| *** hashar has joined #storyboard | 18:38 | |
| krotscheck | NikitaKonovalov: I feel that the APi should validate an OAuth token no matter what endpoint it is passed to. Even if an anoymous user can GET a user, the request is attempting to assert an invalid identity. | 18:41 |
| krotscheck | If we don’t it’ll require that the session confirmation logic must execute some kind of a POST, PUT, or DELETE request to see whether the current token is still valid | 18:41 |
| NikitaKonovalov | krotscheck: so it should be 401, if an expired token comes | 18:42 |
| krotscheck | Right | 18:42 |
| NikitaKonovalov | sounds reasonable | 18:42 |
| krotscheck | So right now, if I get a /users/ID with an expired token, it lets me. | 18:42 |
| krotscheck | The Session validation logic in the client performs that check to see if the auth token is valid. | 18:43 |
| krotscheck | And right now it always passes, so once the user tries to actually modify data - Say, add a comment - It receives a 401 and the user’s submission is lost. | 18:43 |
| NikitaKonovalov | oh, now I understand why I am logged off after posting a comment | 18:44 |
| krotscheck | Right | 18:44 |
| krotscheck | That’s a combination of that initial check plus the 1 hour expiration | 18:44 |
| NikitaKonovalov | The config for 24-hour token will be merged soon I hope | 18:45 |
| NikitaKonovalov | this one https://review.openstack.org/#/c/84111/ | 18:45 |
| krotscheck | NikitaKonovalov: jeblair posted a question on that. | 18:46 |
| NikitaKonovalov | I see, I've just missed that | 18:46 |
| NikitaKonovalov | krotscheck: BTW, I've finally got to your etherpad about permissions | 18:49 |
| krotscheck | Oh, cool. Any thoughts? | 18:50 |
| NikitaKonovalov | I've written what I think, but that's a topic for the next meeting to discuss | 18:50 |
| NikitaKonovalov | The models you offer will definitlly cover everything we need, but our database will be struggling to handle that | 18:51 |
| NikitaKonovalov | If you are looking for a ling, it's here https://etherpad.openstack.org/p/StoryboardPerms | 18:52 |
| NikitaKonovalov | *link | 18:52 |
| krotscheck | I’m reading through what I wrote, trying to get it back into memory | 18:54 |
| *** jcoufal has quit IRC | 19:44 | |
| *** denis_makogon has quit IRC | 20:42 | |
| *** hashar has quit IRC | 21:18 | |
| *** david-lyle has quit IRC | 22:11 | |
| openstackgerrit | Michael Krotscheck proposed a change to openstack-infra/storyboard-webclient: Tightened up story detail UI https://review.openstack.org/84882 | 22:21 |
| krotscheck | Ok, so, given how consistently our build breaks because NPM or some other nonsense is down, I’m seriously thinking of committing the raw npm and bower dependencies to source control. | 22:34 |
| openstackgerrit | Michael Krotscheck proposed a change to openstack-infra/storyboard-webclient: Adds metadata to story detail page https://review.openstack.org/84888 | 22:48 |
| mordred | krotscheck: I would rather we figure out how to fix the use of npm/bower | 23:25 |
| mordred | krotscheck: because I want to use the toolchain stuff in horizon and zuul too | 23:25 |
| mordred | krotscheck: I'll try to brainstorm some better solutions with you ... next time I'm not on back to back phone calls | 23:25 |
| krotscheck | mordred: There’s only so much we can do there. Yesterday’s build failures were because someone upstream decided including a git repo as a dependency was a good idea, and github was down. | 23:26 |
| krotscheck | I just want the NPM guys to get their act together so there can be an official debian package. | 23:27 |
| mordred | well... we can mimic waht we do elsewhere | 23:27 |
| mordred | oh - wait | 23:27 |
| mordred | npm added a ... | 23:27 |
| * mordred cries | 23:27 | |
| mordred | ok - still - let's brainstormo - I need to a call - I'll ping you and stuff | 23:28 |
| mordred | krotscheck: isn't there an official npm pacakge? the one in precise is jut too old, right/ | 23:28 |
| *** krotscheck has quit IRC | 23:30 | |
| *** krotscheck has joined #storyboard | 23:31 | |
| krotscheck | Hrm - I wonder why my server restarted... | 23:32 |
| krotscheck | mordred: Yeah, there’s a package, it’s just WAY out of date. | 23:33 |
| krotscheck | Looks like it’s 0.6.x | 23:33 |
| mordred | krotscheck: trusty has 1.3.10 | 23:34 |
| krotscheck | Wha? | 23:35 |
| krotscheck | Of what, np,? | 23:35 |
| krotscheck | npm? | 23:35 |
| mordred | yah | 23:35 |
| krotscheck | … I think that still has the self-signed certificate in it :/ | 23:41 |
| krotscheck | mordred: Yeah, that one’s 7 months old. The Cert change happened in february | 23:43 |
| krotscheck | That’s encouraging though | 23:44 |
| krotscheck | Maybe in a year we’ll have something we can use :) | 23:44 |
| mordred | sigh | 23:46 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!