| *** jeblair_ has joined #storyboard | 01:08 | |
| *** ruhe2 has joined #storyboard | 01:13 | |
| *** cody-somerville has quit IRC | 01:13 | |
| *** jeblair has quit IRC | 01:13 | |
| *** ruhe has quit IRC | 01:13 | |
| *** che-arne has quit IRC | 01:13 | |
| *** NikitaKonovalov has quit IRC | 01:13 | |
| *** ruhe2 is now known as ruhe | 01:13 | |
| *** cody-somerville has joined #storyboard | 01:20 | |
| *** che-arne has joined #storyboard | 01:21 | |
| *** NikitaKonovalov has joined #storyboard | 01:31 | |
| *** NikitaKonovalov2 has joined #storyboard | 04:38 | |
| *** NikitaKonovalov has quit IRC | 04:39 | |
| *** NikitaKonovalov2 is now known as NikitaKonovalov | 04:39 | |
| *** jcoufal has joined #storyboard | 06:20 | |
| *** jcoufal has quit IRC | 06:40 | |
| *** hashar has joined #storyboard | 07:24 | |
| *** jcoufal has joined #storyboard | 07:58 | |
| *** jcoufal has quit IRC | 08:12 | |
| *** jcoufal has joined #storyboard | 08:13 | |
| *** jcoufal has quit IRC | 09:01 | |
| *** jcoufal has joined #storyboard | 09:51 | |
| *** jcoufal has quit IRC | 10:33 | |
| *** jcoufal has joined #storyboard | 10:43 | |
| openstackgerrit | Nikita Konovalov proposed a change to openstack-infra/storyboard: Making a token expiration time configurable https://review.openstack.org/84107 | 11:34 |
|---|---|---|
| *** saju_m has joined #storyboard | 11:51 | |
| *** saju_m has quit IRC | 12:00 | |
| *** saju_m has joined #storyboard | 12:06 | |
| *** saju_m has quit IRC | 12:08 | |
| ttx | NikitaKonovalov: I'm a bit confused by this ^. It sets expiration to 86400, must be merged before https://review.openstack.org/#/c/84107/ which sets expiration to 3600. Why is the first one needed ? | 12:31 |
| ttx | I mean, I'm confused by https://review.openstack.org/#/c/84111 | 12:32 |
| ttx | Oh, config. I get it now. | 12:33 |
| *** hashar has quit IRC | 13:00 | |
| *** hashar has joined #storyboard | 13:05 | |
| *** jcoufal has quit IRC | 13:49 | |
| openstackgerrit | A change was merged to openstack-infra/storyboard: Making a token expiration time configurable https://review.openstack.org/84107 | 13:51 |
| *** david-lyle has joined #storyboard | 14:25 | |
| *** hashar_ has joined #storyboard | 14:45 | |
| *** hashar has quit IRC | 14:48 | |
| *** jeblair_ is now known as jeblair | 14:59 | |
| jeblair | new meeting time is now in #openstack-meeting-3 | 15:04 |
| jeblair | cody-somerville, gothicmindfood, krotscheck, NikitaKonovalov, SergeyLukjanov, ilyashakhat, ruhe: anyone around for a meeting? ^ | 15:05 |
| *** mfer has joined #storyboard | 15:48 | |
| *** hashar_ has quit IRC | 15:56 | |
| *** jcoufal has joined #storyboard | 15:58 | |
| persia | jeblair: counting business days is tricky. The last two meetings were on successive business days for me (Friday/Monday). | 16:01 |
| ruhe | jeblair: re "we'll have a few more people next week" is it the people we already know, or new hires? | 16:01 |
| persia | Or new interested parties. | 16:01 |
| jeblair | ruhe: i meant people we know; but the other thing would be cool too. :) | 16:02 |
| persia | Part of why I'm more active now than I have been since early Feb is because I've a need for a means to discuss issues and activities for a different project, and despite the pre-MVP state, storyboard seems better than anything else for that purpose. | 16:03 |
| ttx | persia: cool! Happy to have you on board! | 16:04 |
| persia | For some value of "on board" :) | 16:05 |
| * ttx goes back to his favorite activity: get LP to accept status changes on busy bugs | 16:06 | |
| persia | On that note: What's the policy on branding (images, etc.)? Ideally I'd like to not use the OpenStack logo for non-OpenStack stuff, but preserve as much of the "Storyboard" identity as possible. | 16:06 |
| ttx | persia: jeblair might know better than me | 16:08 |
| jeblair | persia: i think it's hardcoded currently, but i believe krotscheck said it should be possible to set up logos in a config file; i think that's what we should do | 16:09 |
| persia | I'm certain it's hardcoded currently. I mostly wanted to know how much I should be changing. | 16:09 |
| persia | If I can do logos only, and clean up some of the text that implies Storyboard is OpenStack only, and have the logos/colors build-time configurable, then I'm happy to write all the patches. | 16:10 |
| persia | If there's complications there for reasons of Storyboard identity, or some unexpected "look & feel" concern, etc., then I'd want to be more careful. | 16:11 |
| persia | And if it shouldn't be configurable, then I'd carry out-of-tree patches. | 16:11 |
| persia | (so I'll proceed with making images configurable, and we can decide from there later) | 16:11 |
| ttx | I'm pretty sure we can and should make things configurable. It's designed for OpenStack needs, but doesn't raelly want to prevent others from using it | 16:12 |
| persia | Let's defer until I have a patch. | 16:12 |
| persia | Knowing there is at least prior discussion of the concept of skinning gives me enough confidence that it becomes worth writing. | 16:13 |
| *** mfer has quit IRC | 16:24 | |
| *** che-arne has quit IRC | 16:27 | |
| krotscheck | persia: https://storyboard.openstack.org/#!/story/43 | 16:55 |
| krotscheck | Sorry about missing the meeting. Insomnia struck | 16:55 |
| *** krotscheck has quit IRC | 17:00 | |
| *** krotscheck has joined #storyboard | 17:01 | |
| persia | krotscheck: The approach I was considering was a third option: to have it be build-time configurable. Is there a strong reason to make it deploy-time configurable instead? | 17:22 |
| krotscheck | persia: Not really. Honestly, if you’re going to do it that way, adding a .gitignore for a theme.less file, and tweaking the grunt less invocation to collect less files instead of just reading main? | 17:25 |
| persia | Ooh. I like that. | 17:26 |
| krotscheck | That way you can override any of the less variables. | 17:26 |
| krotscheck | padding, color, font, etc etc etc | 17:26 |
| krotscheck | Fair warning, I don’t know how feasible that is. I know LESS doesn’t do if-file-exists includes. | 17:26 |
| persia | No worries. Gives me a reason to learn Grunt. | 17:26 |
| krotscheck | So it would have to be grunt that collects/compiles it all | 17:27 |
| krotscheck | persia: Make sure theme.less is the _last_ file in the less invocation then. Last variable wins. | 17:27 |
| persia | What about the logo images. Should that be openstack because that's also the storyboard logo, or should it be the logo of the project? | 17:27 |
| persia | Right. theme.less will be last. | 17:27 |
| krotscheck | persia: Sec, I know there’s a way to have less include an image as a base64 in the CSS. | 17:28 |
| krotscheck | That would take care of the app project. | 17:28 |
| krotscheck | sorry | 17:28 |
| krotscheck | the app logo | 17:28 |
| krotscheck | Individual project logos would probably be upload based. | 17:29 |
| persia | I don't mind telling folk to put stuff in images/theme | 17:29 |
| *** jcoufal has quit IRC | 17:29 | |
| persia | And have grunt only use those if they exist, otherwise use images/openstack | 17:29 |
| persia | Well, "project" is overloaded. | 17:29 |
| krotscheck | persia: Same with favicon | 17:29 |
| persia | There's "project" the data-level component in storyboard | 17:29 |
| persia | and "project" the governance entity that supervises the projects | 17:30 |
| persia | I'm thinking the logo of the latter. | 17:30 |
| krotscheck | You know, we could always give storyboard its own logo | 17:30 |
| krotscheck | That’s how Jira handles it I believe. | 17:30 |
| persia | That works too, but it needs someone other than I to generate it. | 17:30 |
| krotscheck | Let’s put that on the agenda | 17:31 |
| krotscheck | Need to make sure we have consensus there. | 17:31 |
| krotscheck | I can generate something, that’s no problem. | 17:31 |
| persia | Whether to create a logo for storyboard or use the logo of the governing body (e.g. OpenStack)? | 17:31 |
| krotscheck | Yup | 17:31 |
| persia | I'd really prefer the latter because I think it provides brand identity to the users. | 17:31 |
| krotscheck | I’m ambivalent. Giving storyboard its own logo seems easier. | 17:32 |
| persia | Whereas the storyboard.foo URL and name "Storyboard" would provide brand identity for storyboard in all environments. | 17:32 |
| persia | If you're ambivalent, I'll submit a patch for the way I like (if I can get it to work in time), and we can discuss at the meeting. | 17:33 |
| krotscheck | WOrks for me | 17:33 |
| persia | If you cared, I'd defer to your decision, since you wrote so much of it and probably have the best sense of it's identity | 17:33 |
| *** hashar has joined #storyboard | 17:34 | |
| krotscheck | Well, my ask is always: Make it as easy as possible to adopt. | 17:37 |
| persia | As an adopter, I'm very much considering that aspect :) | 17:38 |
| krotscheck | I want someone to go “pip install storyboard” and have them be run through a questionnaire that works like magic. | 17:38 |
| krotscheck | “Would you like us to configure mod_wsgi for you?” kind of things. | 17:38 |
| persia | Hmmm. I tend to build systems from sources, so hadn't really considered that. | 17:39 |
| persia | If you want pip install, then build-time isn't really the right time, is it? | 17:39 |
| krotscheck | I want to hit the startup that needs a ticketing system. | 17:39 |
| krotscheck | persia: Well, for a one command install, our separation of webclient and api won’t work that well either. | 17:40 |
| persia | It works just fine. pip supports dependencies. | 17:40 |
| krotscheck | Oh. Well then! | 17:41 |
| persia | So `pip install storyboard` just installs the API server, and `pip install storyboard-webclient` installs both (or vice versa) | 17:41 |
| persia | Yep. Just checked. We'd just add one to the other's requirements.txt, and it ought just install both. | 17:43 |
| persia | And folk like me that like discrete and complicated probably aren't using pip anyway, so don't mind. | 17:43 |
| persia | Looking through what documentation, hints, tutorials, and questions I can find, I don't believe we can have less support alternate themes *except* at build-time. | 17:50 |
| *** hashar has quit IRC | 17:51 | |
| persia | There seem to be several folk trying to do workarounds, but all the workarounds they report end up still being essentially build-time, or involve compiling the less in the browser, which seems wrong. | 17:51 |
| persia | so `pip install storyboard-webclient` will end up being the Openstack theme, and the user will need to do some local build to get their own theme. | 17:51 |
| krotscheck | persia: Well, let’s think about this. pip installs from source, yes? Given that it’ll have to pull down nodeenv to generate the js compile, would it be possible to have the webclient install be ‘download’ -> ‘configure/theme’ -> ‘compile’ -> ‘install’? | 17:54 |
| persia | So make it happen in setup.py? | 17:55 |
| persia | But we don't even *have* that for storyboard-webclient | 17:56 |
| krotscheck | Well, we set up the webclient with just enough to get it to build and test. | 17:56 |
| persia | That works, but it ends up replicating a lot of what Gruntfile.js is doing. | 17:57 |
| krotscheck | Maybe the first question to ask is: Should we be using a python-style installer for something that lives in a javascript toolchain? | 17:57 |
| persia | Ah, so maybe `pip install storyboard-webclient` isn't the right command? | 17:57 |
| krotscheck | Maybe, yeah | 17:58 |
| krotscheck | THere’s the whole “npm” way of doing things. | 17:58 |
| krotscheck | Which doesn’t actually have a package-style installer | 17:58 |
| persia | WHat do you like instead? npm? bower? something else? | 17:58 |
| krotscheck | Or does it. | 17:58 |
| krotscheck | Hrm. | 17:58 |
| persia | I don't see a way to have npm do any sort of build step. It seems to just put tarballs in place. | 18:00 |
| krotscheck | persia: There’s a way to execute scripts | 18:01 |
| krotscheck | persia: https://www.npmjs.org/doc/misc/npm-scripts.html | 18:02 |
| persia | Then we're done. | 18:02 |
| persia | So https://storyboard.openstack.org/#!/story/43 becomes a matter of | 18:02 |
| krotscheck | Not so fast: that command requires that we publish storyboard to the npm repo | 18:02 |
| persia | 1) make it all npm-oackaged nicely | 18:02 |
| persia | 2) have the package recompile the less after installed (or when reconfigured, etc.) | 18:03 |
| krotscheck | persia: .... | 18:03 |
| krotscheck | yeeessssss | 18:03 |
| krotscheck | I can see where you’re going | 18:03 |
| krotscheck | It could even autogenerate the theme.less file | 18:03 |
| persia | This will break all the nice grunt automation stuff that is in place now. | 18:03 |
| persia | Mind you, much of it could be rewritten differently, but it will require some significant work to get back to the current edit/test cycle speed. | 18:04 |
| krotscheck | persia: It sounds to me like we can get there incrementally. The first step would be to add the theme.less piece. | 18:05 |
| persia | Makes sense. | 18:05 |
| krotscheck | I don’t think that’d break much | 18:05 |
| persia | For reference, I get the impression from some looking about that node-gyp replaces npm-scripts | 18:05 |
| persia | And there's a grunt-node-gyp module, which reduces the gruntfile transition pain. | 18:06 |
| krotscheck | That might be trying to make grunt serve two purposes | 18:06 |
| krotscheck | It’s great as a build/test automation tool, | 18:07 |
| krotscheck | ...but do we want it handling our install? | 18:07 |
| persia | My thought was for transition: initially as various bits transition to use npm and node-gyp, the gruntfile can preserve developer UI. | 18:07 |
| persia | Once we have enough in place, we can transition developer UI without losing too much functionality. | 18:08 |
| persia | Ooh, and gyp uses Makefiles, so I don't have to learn a new syntax :) | 18:09 |
| krotscheck | Maaaaybe. | 18:09 |
| krotscheck | Let’s get as far as whitelabeling it, and then work our way through the installer. | 18:09 |
| krotscheck | I’m not convinced having npm doing our dev setup is a good idea. | 18:09 |
| persia | Ah, so folk can manually add to the (initially mostly comments) theme.less, and get their theme that way? | 18:10 |
| persia | And I didn't mean to imply npm would do dev setup, only that Grunt would rely on npm for things like compiling less, compressing images, etc. | 18:11 |
| persia | On the other hand, keeping it fairly small increases the chance I do something before the next storyboard meeting | 18:11 |
| krotscheck | So, I was thinking: Grunt remains the compiler. If someone on some machine somewhere invokes ‘npm -g install storyboard’, it’ll run a series of helpful preconfiguration scripts that eventually kick off grunt, but handle creation of a default theme.less, etc. | 18:12 |
| persia | So grunt needs to be installed on all end-user nodes? | 18:13 |
| persia | I was thinking make was more likely to be already installed. | 18:14 |
| krotscheck | Well, grunt is an npm package. During setup it’ll just install that in node_modules and invoke it from node_modules/.bin/grunt | 18:15 |
| persia | OK. | 18:15 |
| krotscheck | AFK for a bit, I have an inspector I have to talk to. | 18:16 |
| krotscheck | He might have gadgets | 18:16 |
| persia | No worries. I'm expecting to be pulled into a meeting anytime in the last 10 15 minutes. | 18:17 |
| *** david-lyle has quit IRC | 19:00 | |
| *** hashar has joined #storyboard | 19:01 | |
| *** jcoufal has joined #storyboard | 19:04 | |
| *** david-lyle has joined #storyboard | 19:47 | |
| *** jcoufal has quit IRC | 21:34 | |
| openstackgerrit | A change was merged to openstack-infra/storyboard-webclient: Fixed contenteditable https://review.openstack.org/83847 | 22:00 |
| *** hashar has quit IRC | 22:09 | |
| *** mfer has joined #storyboard | 22:23 | |
| *** mfer has quit IRC | 22:32 | |
| *** david-lyle has quit IRC | 23:30 | |
| *** david-lyle has joined #storyboard | 23:53 | |
| *** david-lyle has quit IRC | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!