*** david-lyle has joined #storyboard | 00:06 | |
*** che-arne has quit IRC | 00:16 | |
*** saju_m has quit IRC | 00:48 | |
openstackgerrit | Michael Krotscheck proposed a change to openstack-infra/storyboard-webclient: [WIP] Tag input control https://review.openstack.org/83945 | 01:51 |
---|---|---|
cody-somerville | krotscheck: Hey. If I click on a story title or description then click off, the text changes to 'undefined'. | 03:20 |
persia | For my testing, I'm using a different API server than web server (so not 127.0.0.1). Is there an easy way to have grunt pull the value from a config file? My current workflow involves cherry-picking my Gruntfile.js changes for server:cluster onto each patchset I review. | 03:23 |
persia | cody-somerville: Are you using firefox? If so, https://review.openstack.org/#/c/83847/ may help | 03:23 |
cody-somerville | ah, thanks. | 03:24 |
persia | krotscheck: What is the tag UI supposed to do? It only shows tags on my master project list, and while I can add/remove, they don't seem to do anything else. | 03:30 |
persia | (which makes sense, given the code) | 03:30 |
persia | But what doesn't make sense is why I would want tags there at all, rather than for individual projects or stories. | 03:30 |
persia | Oh, nevermind. Missed the WIP tag. | 03:31 |
krotscheck | cody-somerville: THat’s a firefox bug that the conteneditable fix is for | 04:42 |
krotscheck | persia: The tagging is for multiple different things- statuses, project assignments, search filters, role assignment, etc. | 04:43 |
persia | Right. The part that didn't make sense was where I saw changes, and what they did. Once I noticed WIP, I realised you'd probably focused on making something work, and were planning to make it appear useful later before updating the change. | 04:44 |
krotscheck | persia: Grunt can take both commandline parameters and ENV parameters. I’m not certain adding those kinds of overrides into the gruntfile are super useful though - at least, not unless _everything_ can be overridden from the commandline. | 04:45 |
krotscheck | persia: In which case we end up in the situation of ‘It’s too pluggable to be useful' | 04:45 |
persia | How about supporting server:env, and having that pull the server address from the environment? | 04:45 |
persia | Or server:foo, and try to resolve that as a name (so server:storyboard.openstack.org for production)? | 04:47 |
persia | Hrm. No, the latter isn't easier, because then we have to specify ports and SSL. | 04:48 |
persia | Anyway, I'm mostly just looking for a way to not rebase http://paste.openstack.org/show/74604/, not reconfigure for every pull, and not add cruft to the master repo. | 04:52 |
persia | For the API server, ./etc/storyboard.conf isn't git-tracked: I have to manually merge changes from storyboard.conf.sample if they happen, but mostly just fetch and test if I want to play. | 04:52 |
persia | I'm more than happy to implement something, but guidance on what sort of thing seems sensible would be appreciated. | 04:53 |
krotscheck | I don’t expect the configuration to change that often. I’ve got mine copied to global /etc/storyboard.conf, so it doesn’t get overwritten. Most everything else should have sane defaults, no? | 04:54 |
krotscheck | Hrm. | 04:55 |
persia | Am I missing something key then? I have the impression that I need to configure the webclient UI to know where to find the API server if I'm using the grunt-driven proxy. | 04:55 |
persia | But I don't know how to do that configuration somewhere that isn't being git-tracked. | 04:56 |
krotscheck | persia: Urm - well the dev biuld makes the assumption that you’re running storyboard-api from the dev tox environment. | 04:56 |
persia | I am running it from *a* dev tox environment, just not the same one :) | 04:56 |
krotscheck | Right, and the host listens on 0.0.0.0? | 04:57 |
persia | So I suppose I'd like to fix that assumption, but wanted some guidance on a way to do it that wasn't insane. | 04:57 |
persia | The API host listens on 0.0.0.0. The grunt-driven UI server only listens on 127.0.0.1. I tunnel my browser requests from my desktop to that server with ssh. | 04:57 |
krotscheck | Oh. Hrm. | 04:59 |
krotscheck | I’d say, update the grunt connect plugin to 0.7.0 or greater. | 04:59 |
krotscheck | And then get rid of the explicit IP binding | 05:00 |
krotscheck | Wiat, no | 05:00 |
krotscheck | That won’t work | 05:00 |
persia | Yeah, that's solving the browser<->grunt part :) | 05:00 |
krotscheck | Why exaclty do you have it set up in such a complex fashion anyway? | 05:00 |
persia | Separation of concerns. Three parts (DB, API, UI), means I have three servers. | 05:00 |
persia | That way I have more confidence that various magic bits (grunt, tox, pip, etc.) can't change things other than the one under test. | 05:01 |
persia | I suppose I could just set up a webserver, and only use grunt to build dist/, and serve that and have a constant rewrite to handle the API proxy. | 05:02 |
krotscheck | Yeah, sorry, that’s needlessly complex. The webclient is designed to be served off of the same host as the API - we haven’t implemented CORS support after all. | 05:02 |
persia | Then I suppose I'll just install the webserver. | 05:04 |
persia | To confirm, I would then use grunt build to update dist/ for new branches? | 05:05 |
*** saju_m has joined #storyboard | 05:38 | |
*** saju_m has quit IRC | 06:56 | |
*** saju_m has joined #storyboard | 08:05 | |
*** david-lyle has quit IRC | 09:17 | |
*** saju_m has quit IRC | 13:18 | |
*** saju_m has joined #storyboard | 14:52 | |
openstackgerrit | Monty Taylor proposed a change to openstack-infra/storyboard-webclient: Make build slightly less chatty https://review.openstack.org/83974 | 16:37 |
openstackgerrit | A change was merged to openstack-infra/storyboard-webclient: Fixed #37, project UI shows edit buttons when not superuser. https://review.openstack.org/83856 | 16:47 |
openstackgerrit | A change was merged to openstack-infra/storyboard-webclient: Remove unimplemented features in list view. https://review.openstack.org/83865 | 16:50 |
*** saju_m has quit IRC | 16:52 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!