| mordred | krotscheck, SergeyLukjanov I actually have a script I used in zuul-status (And now in a patch to zuul)_ | 00:06 |
|---|---|---|
| mordred | wait - maybe it's krotscheck that has the script | 00:06 |
| mordred | I'm consued | 00:06 |
| mordred | https://review.openstack.org/#/c/82307/2/tools/install-js.sh | 00:07 |
| mordred | https://review.openstack.org/#/c/82307/2/tox.ini | 00:07 |
| mordred | fwiw | 00:07 |
| mordred | krotscheck: ^^ let me know if you think we should do that in storyboard-webclient? | 00:08 |
| krotscheck | mordred: Maybe, but there’s a problem with your script. I’ll comment on the review. | 00:08 |
| mordred | yay! | 00:09 |
| *** openstack has joined #storyboard | 00:19 | |
| openstackgerrit | Michael Krotscheck proposed a change to openstack-infra/storyboard-webclient: Task status updates https://review.openstack.org/82690 | 01:53 |
| *** david-lyle has joined #storyboard | 03:17 | |
| *** saju_m has joined #storyboard | 07:30 | |
| *** che-arne has quit IRC | 08:04 | |
| *** saju_m has quit IRC | 08:50 | |
| *** saju_m has joined #storyboard | 08:52 | |
| *** jcoufal has joined #storyboard | 08:57 | |
| *** hashar has joined #storyboard | 09:02 | |
| *** saju_m has quit IRC | 09:38 | |
| *** che-arne has joined #storyboard | 09:41 | |
| *** saju_m has joined #storyboard | 09:56 | |
| *** saju_m has quit IRC | 11:07 | |
| *** saju_m has joined #storyboard | 11:08 | |
| *** hashar has quit IRC | 11:08 | |
| *** saju_m has quit IRC | 11:09 | |
| *** saju_m has joined #storyboard | 11:15 | |
| *** hashar has joined #storyboard | 11:17 | |
| *** miqui has joined #storyboard | 11:26 | |
| *** saju_m has quit IRC | 11:38 | |
| *** saju_m has joined #storyboard | 11:38 | |
| *** hashar has quit IRC | 11:40 | |
| *** david-lyle has quit IRC | 12:23 | |
| *** saju_m has quit IRC | 12:41 | |
| *** hashar has joined #storyboard | 12:46 | |
| *** saju_m has joined #storyboard | 12:54 | |
| *** saju_m has quit IRC | 12:59 | |
| *** saju_m has joined #storyboard | 13:00 | |
| *** saju_m has quit IRC | 13:04 | |
| *** saju_m has joined #storyboard | 13:05 | |
| *** saju_m has quit IRC | 13:09 | |
| *** saju_m has joined #storyboard | 13:10 | |
| *** ChanServ changes topic to "the gerrit event stream is currently hung, blocking all testing. troubleshooting is in progress (next update at 14:00 utc)" | 13:22 | |
| *** ChanServ changes topic to "Storyboard | http://git.openstack.org/cgit/openstack-infra/storyboard/ | Weekly Meeting: Thursdays at 16:00 UTC in #openstack-meeting" | 13:30 | |
| *** hashar_ has joined #storyboard | 14:04 | |
| *** hashar has quit IRC | 14:05 | |
| *** david-lyle has joined #storyboard | 14:31 | |
| *** mfer has joined #storyboard | 14:46 | |
| *** saju_m has quit IRC | 15:13 | |
| *** hashar has joined #storyboard | 15:33 | |
| *** hashar_ has quit IRC | 15:36 | |
| *** hashar_ has joined #storyboard | 15:38 | |
| *** hashar has quit IRC | 15:41 | |
| *** hashar_ has quit IRC | 15:49 | |
| *** hashar has joined #storyboard | 16:20 | |
| *** jcoufal has quit IRC | 17:00 | |
| openstackgerrit | A change was merged to openstack-infra/storyboard: Remove legacy priority column from stories table https://review.openstack.org/82504 | 17:06 |
| openstackgerrit | James E. Blair proposed a change to openstack-infra/storyboard: Use MySQL for unit tests https://review.openstack.org/82872 | 17:11 |
| jeblair | mordred, krotscheck: a starting point if we want to use mysql for unit tests: ^ | 17:12 |
| jeblair | i say a starting point because it's all kinds of failing tests | 17:13 |
| krotscheck | No love for postgres, eh? | 17:13 |
| jeblair | due to mysql/sqlite isms | 17:13 |
| krotscheck | Gotcha | 17:13 |
| jeblair | krotscheck: the same technique should work with postgres too | 17:13 |
| jeblair | krotscheck: but i'm in the "test on what we run" camp, so i prioritized that :) | 17:14 |
| krotscheck | Change of topci | 17:14 |
| krotscheck | I feel like we’re really starting to overload the db api… :/ | 17:14 |
| krotscheck | (Unrelated to your patch) | 17:15 |
| jeblair | krotscheck: what do you mean by that? (i may not have the vocabulary to know what you're referring to when you say "the db api") | 17:16 |
| krotscheck | https://review.openstack.org/#/c/82101/4/storyboard/db/api.py | 17:16 |
| krotscheck | We have this one DB API class, which seems to be the single point of access for all things DB interaciton. | 17:16 |
| krotscheck | I just don’t want it to end up the dumping ground for millions of specialized methods. | 17:17 |
| *** gothicmindfood has quit IRC | 17:35 | |
| NikitaKonovalov | krotscheck, I've also noticed that the db api file is getting too big | 17:46 |
| NikitaKonovalov | I think a separate module with a bunch of files for each object type would look better | 17:47 |
| *** hashar has quit IRC | 17:47 | |
| krotscheck | NikitaKonovalov: Yeah - we might even overload the ORM Models with their own static getters | 17:49 |
| *** gothicmindfood has joined #storyboard | 17:54 | |
| openstackgerrit | James E. Blair proposed a change to openstack-infra/storyboard: Use MySQL for unit tests https://review.openstack.org/82872 | 18:18 |
| jeblair | okay, that version passes pep8 and actually works; hopefully the test output from that should actually indicate sqlite-isms | 18:23 |
| openstackgerrit | Michael Krotscheck proposed a change to openstack-infra/storyboard-webclient: Comments UI https://review.openstack.org/82213 | 18:36 |
| krotscheck | NikitaKonovalov: I agree with your comment on author_id, I stripped it out of the client. | 18:37 |
| openstackgerrit | Michael Krotscheck proposed a change to openstack-infra/storyboard-webclient: Task status updates https://review.openstack.org/82690 | 18:41 |
| krotscheck | NikitaKonovalov: Also updated the missing jsdoc. My bad. | 18:42 |
| krotscheck | This one’s for ttx: https://review.openstack.org/#/c/82571/ | 18:45 |
| krotscheck | https://github.com/Snugug/north#outdated-ux-patterns | 18:50 |
| krotscheck | Actually, that entire doc is a good read. Opinionated in sections, but a good read. | 18:52 |
| krotscheck | All that talk yesterday about a common CSS library for openstack UI that can be easily whitelabeled got me noodling on a project name. OpenStrap anyone? :) | 18:57 |
| krotscheck | The logo could be a belt :) | 18:58 |
| *** che-arne has quit IRC | 18:59 | |
| *** openstackgerrit has quit IRC | 19:18 | |
| *** openstackgerrit has joined #storyboard | 19:18 | |
| *** hashar has joined #storyboard | 19:38 | |
| ttx | krotscheck: +2ed | 19:50 |
| krotscheck | Thanks! | 19:51 |
| jeblair | http://logs.openstack.org/72/82872/2/check/gate-storyboard-python27/6a6fbf7/testr_results.html.gz | 20:02 |
| jeblair | krotscheck, mordred: ^ that's down to just one sqlitism i think. | 20:02 |
| krotscheck | sqlitism? | 20:02 |
| krotscheck | Nice. | 20:03 |
| mordred | jeblair: I support your mysql overlords | 20:03 |
| jeblair | mordred: the default engine on the slaves is myisam; based on what i'm seeing comparing my local tests to the slaves, i think the tests aren't doing anything to specify innodb | 21:14 |
| jeblair | mordred: did you do something to cause the production tables to be innodb? | 21:14 |
| jeblair | oh, we're using trove, right? maybe trove defaults to innodb | 21:16 |
| jeblair | i assume so | 21:17 |
| *** hashar has quit IRC | 21:33 | |
| *** jeblair_ has joined #storyboard | 21:42 | |
| *** jeblair_ is now known as corvus | 21:43 | |
| corvus | oh! the tests don't use the migrations to create the db, they use the model directly | 21:44 |
| corvus | ^ not sure if that made it through earlier | 21:45 |
| *** jeblair has quit IRC | 21:45 | |
| *** corvus is now known as jeblair | 21:45 | |
| *** wendar has quit IRC | 21:47 | |
| *** wendar has joined #storyboard | 21:49 | |
| *** mfer has quit IRC | 21:50 | |
| * gothicmindfood was confused for a second by jeblair being logged in twice | 21:54 | |
| jeblair | the freenode server i was on died | 21:55 |
| gothicmindfood | :) | 22:00 |
| gothicmindfood | jeblair: I'd just never seen your alternate-nick | 22:00 |
| jeblair | alternick? | 22:01 |
| gothicmindfood | your dark-side is a crow, I gather? ;) | 22:03 |
| * gothicmindfood will stop polluting the channel with chatter now | 22:03 | |
| krotscheck | I like pollution | 22:06 |
| gothicmindfood | krotscheck: you *would* | 22:07 |
| krotscheck | gothicmindfood: It makes me feel like something’s happening with storyboard. Like I’m not all alone over here :) | 22:08 |
| krotscheck | Is six a python package or an external package? | 22:32 |
| krotscheck | I’m guessing it’s not stdlib | 22:32 |
| openstackgerrit | Michael Krotscheck proposed a change to openstack-infra/storyboard: Added paging to list endpoints https://review.openstack.org/79757 | 22:34 |
| openstackgerrit | Michael Krotscheck proposed a change to openstack-infra/storyboard: Added paging to list endpoints https://review.openstack.org/79757 | 22:52 |
| krotscheck | ttx, jeblair: Sorry, looks like most of your comments came from a rather agressive autoformatter ^ | 22:53 |
| jeblair | krotscheck: cool, lgtm | 23:06 |
| jeblair | krotscheck: six is an external lib on pypi | 23:06 |
| mordred | jeblair: yeah - that's a good catch though - we should be explicit in our stuff to specify innodb just on general principle | 23:07 |
| *** david-lyle has quit IRC | 23:08 | |
| jeblair | mordred: i brain dumped here: https://review.openstack.org/#/c/82872/ | 23:08 |
| jeblair | we don't have to actually have that discussion in the review if we don't want to; i just needed to get it down somewhere before i context switched again | 23:08 |
| jeblair | for additional context, we actually set the default engine on jenkins nodes to myisam specifically so that we can detect if tests don't set that themselves | 23:10 |
| mordred | yah - and we have tests in the nova test suite to double check that all tables are created as innodb (that's a single direct test) | 23:16 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!