| *** psahoo has joined #starlingx | 02:57 | |
| *** mugsie has quit IRC | 02:59 | |
| *** mugsie has joined #starlingx | 03:02 | |
| *** sgw has quit IRC | 03:07 | |
| *** psahoo has quit IRC | 04:50 | |
| *** psahoo has joined #starlingx | 04:52 | |
| *** yaawang has quit IRC | 06:38 | |
| *** zbsarash1 has quit IRC | 06:42 | |
| *** yaawang has joined #starlingx | 06:44 | |
| *** yaawang has quit IRC | 07:17 | |
| *** hoonetorg has joined #starlingx | 07:27 | |
| *** yaawang has joined #starlingx | 07:31 | |
| *** born2bake has joined #starlingx | 07:33 | |
| *** bengates has joined #starlingx | 07:47 | |
| *** bengates has quit IRC | 07:51 | |
| *** bengates has joined #starlingx | 07:51 | |
| *** psahoo has quit IRC | 10:25 | |
| *** psahoo has joined #starlingx | 10:38 | |
| *** psahoo has quit IRC | 10:46 | |
| *** psahoo has joined #starlingx | 10:58 | |
| *** psahoo has quit IRC | 11:49 | |
| *** ijolliffe has joined #starlingx | 11:54 | |
| *** psahoo has joined #starlingx | 11:56 | |
| *** hoonetorg has quit IRC | 13:26 | |
| *** hoonetorg has joined #starlingx | 13:30 | |
| *** rcw has joined #starlingx | 13:31 | |
| *** psahoo has quit IRC | 13:39 | |
| *** psahoo has joined #starlingx | 13:45 | |
| *** sgw has joined #starlingx | 13:57 | |
| *** ijolliffe has quit IRC | 14:02 | |
| *** zbsarash1 has joined #starlingx | 14:14 | |
| *** ijolliffe has joined #starlingx | 14:27 | |
| *** dpanech has joined #starlingx | 14:45 | |
| dpanech | sgw: so can I /should I create a single gerrit review with all these cherry picks? 4 in total. Or just the 2 with a dependency in a single review, and the other 2 separately? | 14:46 |
|---|---|---|
| sgw | If they are all in a single repo, yes it can be multiple commits in a single git review will be OK | 15:07 |
| sgw | sorry I was on the MultiOS call | 15:07 |
| *** hyunsikyang__ has joined #starlingx | 15:08 | |
| *** hyunsikyang has quit IRC | 15:14 | |
| *** irclogbot_0 has quit IRC | 15:14 | |
| *** sgw has quit IRC | 15:14 | |
| *** sgw1 has joined #starlingx | 15:16 | |
| *** ijolliffe has quit IRC | 15:18 | |
| *** irclogbot_3 has joined #starlingx | 15:19 | |
| dpanech | sgw: should I be using any other gerrit tags in commit messages? Neither of these commits by itself closes the launchpad, so I think I can't use "Closes-Bug" right? | 15:40 |
| dpanech | sgw: I guess they all have to have the same Change-Id yes? | 15:42 |
| sgw1 | Yeah, there us a Partial-fixes (I think), let me look it up | 15:43 |
| sgw1 | No each commit has it's own ChangeID | 15:43 |
| dpanech | sgw: but which review will they go to? After cherry picking change-ids remained unchanged from original commits. | 15:45 |
| dpanech | anyway I think it's Partial-Bug: https://wiki.openstack.org/wiki/GitCommitMessages#Including_external_references | 15:50 |
| sgw1 | Right, I was going from a bad memory | 15:51 |
| sgw1 | I am not following your prior comment | 15:51 |
| dpanech | If a type a git review with 4 unpushed commits in a branch, what would I expect to see in the review interface? One review or 4? | 15:52 |
| dpanech | Doesn't it match commits with reviews by change id? | 15:52 |
| dpanech | is this really supported by gerrit? Google gives conflicting info | 15:53 |
| dpanech | come to think of it... I'm guessing it will create 4 reviews after all. I should probably push them one by one from the same branch and remove the original change ids from cherry picked comments. And add Depends-On where a conflict would otherwise happen... makes sense? Sorry O've never done this | 15:57 |
| sgw1 | Yes, it should create 4 reviews that are linked together and depneded on. Best to git review them together not one-by-one | 15:59 |
| dpanech | Am I supposed to keep the old Change-IDs from cherry picks or not? | 16:10 |
| sgw1 | No there should be new Change-Ids for each commit and just have a cherry-picked from line | 16:12 |
| sgw1 | https://review.opendev.org/#/c/737906/ | 16:12 |
| sgw1 | is a sort of example | 16:13 |
| dpanech | But what re0generates the old change id in the cherry-picked message? Am I supposed to remove them after cherry picking? | 16:14 |
| dpanech | I don't understand what step creates a new change id | 16:15 |
| sgw1 | dpanech: maybe a quick phone call will resolve this, I think I am not completely understanding and chat does not seem to help | 16:16 |
| dpanech | zoom? | 16:17 |
| sgw1 | sure that can work | 16:17 |
| dpanech | I think you should accept an invitation because I don't have you in my contacts: https://zoom.us/im/add?code=3mjxhPJMp86zkwu9QiNjp0gaa7F5Kg3AE6OOj__Xbvw.BQgAAAFzD9CG-QAnjQAWRVJLdkRHa3JTdEc1VWNpMGlBeHM4QQQAZQAAFkljSUlkei03UzY2Tmk4d1NiQ1hqYmcAAAAAAAAAAA | 16:18 |
| sgw1 | please see PM | 16:19 |
| *** billzvonar has joined #starlingx | 16:28 | |
| *** bengates has quit IRC | 16:33 | |
| *** psahoo has quit IRC | 17:08 | |
| *** billzvonar has quit IRC | 20:01 | |
| *** born2bake has quit IRC | 23:22 | |
| *** dpanech has quit IRC | 23:44 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!