*** Blue^NeXuS has joined #softwarefactory | 01:11 | |
*** bhavikdbavishi has joined #softwarefactory | 01:45 | |
*** bhavikdbavishi has quit IRC | 01:52 | |
*** Blue^NeXuS has quit IRC | 04:16 | |
*** bhavikdbavishi has joined #softwarefactory | 04:26 | |
*** sshnaidm|off has quit IRC | 05:01 | |
*** flepied has joined #softwarefactory | 07:33 | |
*** jpena|off is now known as jpena | 07:52 | |
*** sshnaidm has joined #softwarefactory | 08:08 | |
*** hashar has joined #softwarefactory | 08:11 | |
*** sshnaidm has quit IRC | 08:14 | |
*** sshnaidm has joined #softwarefactory | 08:17 | |
flepied | fbo, tristanC: does Depends-On work with github? sileht has some trouble getting it to work... | 08:49 |
---|---|---|
tristanC | flepied: yes, you have to give it the full url though, the UI reduces it to "project/pr#XXX" but it needs to be a fully qualified url, e.g. https://github.com/owner/project/pull/XXX" | 08:51 |
tristanC | flepied: also, it needs to be defined in the first comment of the PR | 08:51 |
sileht | tristanC, I have done that here: https://github.com/wazo-pbx/wazo-webhookd/pull/20 | 08:51 |
sileht | tristanC, and the inventory doesn't have this 3 Depends-On: | 08:52 |
sileht | We have declared all these repositories: https://github.com/wazo-pbx/sf-config/blob/master/resources/resources.yaml | 08:53 |
tristanC | sileht: looking | 08:55 |
sileht | And logs saids: | 08:55 |
sileht | 2019-06-17 08:42:27,042 DEBUG zuul.Pipeline.local.check: Checking for changes needed by <Change 0x7f37b86e3f28 wazo-pbx/wazo-webhookd 20,6e7968381a930b1081a752c8a1f56469ecc48ab1>: | 08:55 |
sileht | 2019-06-17 08:42:27,042 DEBUG zuul.Pipeline.local.check: No changes needed | 08:55 |
tristanC | sileht: which seems correct as all the depends-on PR are merged | 08:56 |
sileht | tristanC, hum, merged don't mean released | 09:00 |
sileht | ok I will created opened PR | 09:00 |
tristanC | sileht: depends-on only check for open/merged status, zuul doesn't know what "released" mean | 09:01 |
tristanC | sileht: in jobs artifacts, depends-on information is recorded in zuul-info/inventory.yaml zuul.items variable | 09:02 |
sileht | ok, I have expected zuul will just pick what I put and don't filter merged PR | 09:03 |
sileht | tristanC, I don't remember gerrit source was filtering out closed changeset | 09:10 |
sileht | filtering closed PR is a bit annoying: | 09:12 |
sileht | imagine you Depends-On: my-client-lib#3 | 09:12 |
sileht | you're check pass because in tox virtualenv my-client-lib lib is replaced by the PR | 09:13 |
sileht | then the my-client-lib#3 PR is merged | 09:13 |
sileht | On your PR the gate run | 09:13 |
sileht | and it fails because you're back on the old lib | 09:13 |
sileht | now I have to wait the my-client-lib is published on pypi when my #3 PR inside | 09:15 |
sileht | Maybe we should just use required-projects: in such case | 09:16 |
tristanC | sileht: good point, using required-projects would force my-client-lib in the items list and tox would run with branch tips | 09:22 |
sileht | yeah that can work for us | 09:22 |
tristanC | flepied: sileht: zuul/nodepool questions can also be asked on #zuul | 09:24 |
*** jpena is now known as jpena|lunch | 11:15 | |
*** spredzy has quit IRC | 11:25 | |
*** spredzy has joined #softwarefactory | 11:26 | |
*** hashar has quit IRC | 11:27 | |
*** rfolco has joined #softwarefactory | 12:01 | |
*** hashar has joined #softwarefactory | 12:38 | |
*** jpena|lunch is now known as jpena | 12:49 | |
*** bhavikdbavishi has quit IRC | 13:33 | |
*** hashar_ has joined #softwarefactory | 14:03 | |
*** hashar_ has quit IRC | 14:03 | |
*** hashar has quit IRC | 14:29 | |
*** hashar has joined #softwarefactory | 15:13 | |
*** hashar has quit IRC | 17:13 | |
*** jpena is now known as jpena|off | 17:14 | |
*** sshnaidm is now known as sshnaidm|afk | 17:28 | |
*** chandankumar is now known as raukadah | 17:33 | |
*** hashar has joined #softwarefactory | 17:56 | |
*** hashar has quit IRC | 18:53 | |
*** hashar has joined #softwarefactory | 20:38 | |
*** hashar has quit IRC | 20:40 | |
*** hashar has joined #softwarefactory | 20:40 | |
*** rfolco has quit IRC | 21:16 | |
*** hashar has quit IRC | 21:45 | |
*** ChanServ has quit IRC | 22:09 | |
*** ChanServ has joined #softwarefactory | 22:14 | |
*** niven.freenode.net sets mode: +o ChanServ | 22:14 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!