| *** ssbarnea_ has joined #softwarefactory | 09:47 | |
| gundalow | nhicher: corvus GREEN integration tests against a VyOS network VM https://ansible.softwarefactory-project.io/logs/13/13/5594ce5c0e7d2fefeff876e41843edf5f448b536/check/ansible-test-network-integration-vyos-devel/b74a89f/ara/ I need to tidy my PR up a fair bit, and do a new image build though looking good. Thanks again for your help | 10:05 |
|---|---|---|
| *** ssbarnea_ has quit IRC | 11:00 | |
| *** ssbarnea_ has joined #softwarefactory | 12:08 | |
| *** ssbarnea_ has quit IRC | 12:34 | |
| corvus | gundalow: \o/ | 13:21 |
| gundalow | I'm seeing "Waiting on logger" in the console.log, which I assume means I've not got the firewall port opened correctly: firewall-cmd --zone=public --permanent --add-port=19885/tcp | 13:26 |
| gundalow | Though looking good | 13:26 |
| corvus | gundalow: that was working yesterday, right? | 13:30 |
| gundalow | Nop | 13:32 |
| gundalow | It's only an issue when looking at the live logs (ie while it's running) ara & txt.gz logs are all good | 13:33 |
| corvus | i could have sworn we looked at a live log right after you made the base-test change yesterday | 13:33 |
| corvus | when you spotted the rsync thing | 13:33 |
| gundalow | corvus: oh, live logs work, just for long running tasks you don't get output | 13:34 |
| corvus | gundalow: oh, i see | 13:34 |
| gundalow | https://github.com/ansible-network/ansible-zuul-jobs/pull/13#issuecomment-388555494 \o/ py2.7 & 3.6 tested | 13:34 |
| corvus | gundalow: https://github.com/ansible-network/zuul-config/pull/22 | 13:37 |
| corvus | gundalow: that should mean that you don't have to have 'override-checkout: devel' in your PR anymore (but it's fine to leave it there for clarity if you want). | 13:38 |
| gundalow | corvus: ah, so I don't have to define it for every job in jobs.yaml? | 13:38 |
| corvus | yup | 13:38 |
| gundalow | With your PR do I still need to do required-projects? | 13:39 |
| gundalow | I'll think on that one | 13:39 |
| corvus | gundalow: you'll still need it in required projects if the job is going to run on any repos other than ansible; right now at least it's running on changes to ansible-zuul-jobs, so it'll need to be there at least as long as it's running there. | 13:40 |
| gundalow | Thanks :) | 13:40 |
| corvus | gundalow: you also have a fixme note there saying to run it against stable-2.5 -- you'll need an override-checkout for that. | 13:41 |
| gundalow | Yup, might change how I'll do that | 13:41 |
| corvus | gundalow: so i don't give bad advice -- what's the ultimate goal for this job? what repos will it run on and what kind of changes? | 13:42 |
| gundalow | Possibly scheduled Zuul job once a day with code coverage enabled against the other branches | 13:42 |
| gundalow | when this vyos test moves to ansible/ansible the required-projects will not matter as the PR Zuul is running against will be Ansible source | 13:43 |
| corvus | okay, then yeah, you'll want to explicitly identify the override-branches in the job, since, in the case of scheduled jobs, there's no pr to run against | 13:44 |
| corvus | er... actually, strike that | 13:44 |
| corvus | zuul will even run scheduled jobs in the context of a branch (it will run them with all of the branch tips) | 13:45 |
| corvus | sorry -- i'm still waking up :) | 13:45 |
| corvus | so anyway -- i think ultimately you probably just want to drop the override-checkout altogether and in the case of scheduled jobs, zuul will automatically run it on both branches. | 13:46 |
| corvus | but right now, since you're writing it as a PR to a different repo, if you want to run it on stable-2.5 to make sure it works, you'll need an override-checkout, at least temporarily. | 13:47 |
| gundalow | :0 | 13:47 |
| gundalow | :) | 13:47 |
| gundalow | even | 13:47 |
| gundalow | Yup, there is a certain about of "Just get it doing something sensible" going on here, which will not exist in the end solution | 13:48 |
| corvus | gundalow: i have one more suggestion; typing it up real quick | 13:50 |
| corvus | gundalow: you can refactor those 2 jobs to use inheritance like this, so they're smaller and just change the one thing that's different between them: https://etherpad.openstack.org/p/owt3FmrDjo | 13:54 |
| gundalow | corvus: Ah, nice. I assumed there was something like that. Thank you. | 14:07 |
| corvus | gundalow: yep, every job uses inheritance; if you don't have a 'parent:' attribute, it defaults to 'parent: base'. so the hierarchy for the terminal jobs there is like: ansible...vyos-py2 -> ansible...vyos -> base | 14:09 |
| *** ssbarnea_ has joined #softwarefactory | 14:13 | |
| *** ssbarnea_ has quit IRC | 16:02 | |
| gundalow | Suggestion: In sofwarefactory bot if you print the error message in GitHub such as `The error appears in the following project or project-template stanza:` if you use 4 (rather than 2) spaces, or wrapp it in tripple-back-quotes ``` that will add the correct formatting and make it a lot more readable, example bonus points for ```yaml https://gist.github.com/gundalow/cf8b2327ffe36c166dc08bb5e70fa605 | 19:37 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!