| *** spatel has quit IRC | 00:01 | |
| *** sapd1 has joined #senlin | 02:38 | |
| *** spatel has joined #senlin | 03:29 | |
| *** spatel has quit IRC | 03:32 | |
| *** spatel has joined #senlin | 03:33 | |
| *** spatel has quit IRC | 03:49 | |
| *** sapd1 has quit IRC | 05:45 | |
| *** sapd1 has joined #senlin | 06:19 | |
| *** sapd1 has quit IRC | 06:51 | |
| *** sapd1 has joined #senlin | 09:47 | |
| *** sapd1 has quit IRC | 09:51 | |
| *** sapd1 has joined #senlin | 10:12 | |
| *** sapd1 has quit IRC | 10:16 | |
| *** spatel has joined #senlin | 10:35 | |
| *** spatel has quit IRC | 10:40 | |
| *** sapd1 has joined #senlin | 11:09 | |
| *** sapd1 has quit IRC | 11:14 | |
| *** sapd1 has joined #senlin | 11:33 | |
| *** sapd1 has quit IRC | 11:37 | |
| *** spatel has joined #senlin | 12:52 | |
| *** spatel has quit IRC | 12:57 | |
| *** __ministry1 has joined #senlin | 13:53 | |
| *** __ministry1 has quit IRC | 13:53 | |
| *** spatel has joined #senlin | 15:11 | |
| spatel | dtruong: are you around? | 20:15 |
|---|---|---|
| dtruong | spatel Yes, I'm here | 21:42 |
| spatel | hey! | 21:42 |
| dtruong | Hi. What's up? | 21:43 |
| spatel | https://review.opendev.org/c/openstack/senlin/+/765215 | 21:43 |
| spatel | Build is keep failing and i believe we need to make some more adjustment to Test definition | 21:44 |
| spatel | I meant here /home/spatel/opendev/senlin/senlin/tests/unit/profiles/ | 21:45 |
| *** jmlowe has quit IRC | 21:45 | |
| spatel | If you see i have added this key-value here but look like its looking for more references - https://review.opendev.org/c/openstack/senlin/+/765215/6/senlin/tests/unit/profiles/test_nova_server_update.py#147 | 21:45 |
| *** jmlowe has joined #senlin | 21:47 | |
| spatel | If you give me clue then i can fix it | 21:48 |
| dtruong | It looks like the majority of failures in test_nova_server_validate. See the test result output: https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_c96/765215/6/check/openstack-tox-py36/c968192/testr_results.html | 21:50 |
| dtruong | If you click the fail link to open up the error message for 'test_validation_with_project_scope(validate:net-n:port-n:fixed_ip-n:sgroups-n)', it says 'testtools.matchers._impl.MismatchError: {'port': 'PORT_ID'} != {'port': 'PORT_ID', 'vnic_type': None}' | 21:51 |
| spatel | Yes i can see that | 21:52 |
| dtruong | Your change added the vnic_type to the return of validate_network, so you have to change the expected value in the test file here: https://github.com/openstack/senlin/blob/master/senlin/tests/unit/profiles/test_nova_server_validate.py#L539 | 21:52 |
| dtruong | That line needs to add 'vnic_type': None in the result. | 21:53 |
| dtruong | It should be like this: | 21:53 |
| dtruong | result={'port': 'PORT_ID', 'vnic_type': None}, | 21:53 |
| spatel | that is the only change? | 21:54 |
| spatel | or i need to go through each error and make that change in every block | 21:54 |
| dtruong | You have to fix each failure in the test results page. You can search in https://github.com/openstack/senlin/blob/master/senlin/tests/unit/profiles/test_nova_server_validate.py for the test scenario that failed. The test scenario name is in the parenthesis after the test function in the test result file. | 21:55 |
| spatel | For example at this location https://github.com/openstack/senlin/blob/master/senlin/tests/unit/profiles/test_nova_server_validate.py#L698 | 21:59 |
| spatel | I will add {'network': 'NET_ID', 'security_groups': ['SG_ID'], 'vnic_type': None} | 21:59 |
| spatel | something like that | 21:59 |
| spatel | Should i remove my earlier change from test_nova_server_update.py file https://review.opendev.org/c/openstack/senlin/+/765215/6/senlin/tests/unit/profiles/test_nova_server_update.py#147 | 22:01 |
| dtruong | The change you mentioned in test_nova_server_validate on line 698 is needed. | 22:08 |
| spatel | i used "normal" instead of None that is ok right? | 22:08 |
| dtruong | You should probably remove the change in test_nova_server_update. That test case should pass even without specifying the vnic_type. | 22:08 |
| spatel | Okay! will remove that from test_nova_server_update | 22:09 |
| dtruong | I just left a comment in your code. I think you need to add the default value in one of the lines to make that test pass. | 22:10 |
| spatel | Will do that | 22:11 |
| spatel | otherwise everything looks good in my lab, i am able to spin up sriov based instances. | 22:11 |
| dtruong | awesome | 22:13 |
| spatel | dtruong: https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_c96/765215/6/check/openstack-tox-py36/c968192/testr_results.html | 22:33 |
| spatel | first two fail one from different file | 22:33 |
| spatel | senlin.tests.unit.profiles.test_nova_server_update.TestNovaServerUpdate | 22:34 |
| spatel | senlin.tests.unit.profiles.test_nova_server.TestNovaServerBasic | 22:34 |
| openstackgerrit | Satish Patel proposed openstack/senlin master: Add support of vnic_type to Profile https://review.opendev.org/c/openstack/senlin/+/765215 | 22:36 |
| openstackgerrit | Satish Patel proposed openstack/senlin master: Add support of vnic_type to Profile https://review.opendev.org/c/openstack/senlin/+/765215 | 22:38 |
| spatel | Gotta go, lets see if it fail then we will make changes to those file | 22:40 |
| *** spatel has quit IRC | 22:40 | |
| dtruong | I added another comment | 22:40 |
| dtruong | the vnic_type should only be added to result if it was not None | 22:40 |
| *** spatel has joined #senlin | 23:57 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!