*** spatel has joined #senlin | 01:48 | |
spatel | dtruong: i am trying now | 02:25 |
---|---|---|
spatel | dtruong: didn't work port_attr['binding_vnic_type'] = 'direct' | 02:29 |
*** sapd1_x has joined #senlin | 02:30 | |
spatel | how do i verify this value getting through or not | 02:30 |
*** sapd1_x has quit IRC | 02:42 | |
*** sapd1_x has joined #senlin | 04:23 | |
*** sapd1_x has quit IRC | 05:01 | |
*** spatel has quit IRC | 06:37 | |
*** sapd1_x has joined #senlin | 09:00 | |
*** sapd1_x has quit IRC | 10:00 | |
*** sapd1_x has joined #senlin | 10:15 | |
*** sapd1_x has quit IRC | 10:43 | |
*** sapd1_x has joined #senlin | 11:15 | |
*** sapd1_x has quit IRC | 11:40 | |
*** sapd1_x has joined #senlin | 13:24 | |
*** spatel has joined #senlin | 13:52 | |
*** spatel has quit IRC | 13:53 | |
*** spatel has joined #senlin | 14:00 | |
spatel | dtruong: morning, | 14:41 |
*** sapd1_x has quit IRC | 15:44 | |
*** Intervals79 has joined #senlin | 17:48 | |
*** Intervals79 has quit IRC | 19:00 | |
spatel | dtruong: you might be busy but i figured it out how we can add vnic_type support, I am going to submit patch | 20:48 |
eandersson | spatel maybe just add a log line there | 20:52 |
spatel | eandersson: Hey, i didn't get you | 20:53 |
eandersson | sorry was replying to > how do i verify this value getting through or not | 20:53 |
spatel | i put validation around code to make sure value is valid also some logs but again i am not super expert in python so i am sure someone will review and make cosmetic changes | 20:54 |
spatel | lets me first my patch get it out so you can see what i did (may be you have better way to handle it ) | 20:55 |
eandersson | Sounds good | 20:55 |
spatel | give me 10 min.. just preparing my git review | 20:56 |
openstackgerrit | Satish Patel proposed openstack/senlin master: Add support of vnic_type to Profile https://review.opendev.org/c/openstack/senlin/+/765215 | 23:21 |
spatel | dtruong: eandersson https://review.opendev.org/c/openstack/senlin/+/765215 | 23:21 |
spatel | Please review it and let me know if anything we can improve. | 23:22 |
*** spatel has quit IRC | 23:56 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!