*** sapd1 has joined #senlin | 03:00 | |
*** sapd1 has quit IRC | 05:43 | |
*** sapd1 has joined #senlin | 06:30 | |
*** phuochc has joined #senlin | 07:08 | |
*** phuoc has quit IRC | 07:08 | |
*** phuochoang has joined #senlin | 07:09 | |
*** phuochc has quit IRC | 07:13 | |
*** sapd1 has quit IRC | 08:22 | |
*** sapd1 has joined #senlin | 09:55 | |
*** sapd1_ has quit IRC | 11:18 | |
*** sapd1 has quit IRC | 11:21 | |
*** jmlowe has quit IRC | 15:49 | |
*** jmlowe has joined #senlin | 16:04 | |
mordred | dtruong: sweet! I'll add that approach to the other resources taht need it | 18:53 |
---|---|---|
mordred | do al of the senlin resources follow this pattern on delete? | 18:53 |
* mordred goes to read the api docs | 18:54 | |
dtruong | mordred: it's only for cluster delete and node delete since those async operations | 18:57 |
dtruong | others like profile delete or policy delete do not follow this pattern | 18:57 |
dtruong | #startmeeting senlin | 19:00 |
openstack | Meeting started Thu Jan 31 19:00:35 2019 UTC and is due to finish in 60 minutes. The chair is dtruong. Information about MeetBot at http://wiki.debian.org/MeetBot. | 19:00 |
openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 19:00 |
*** openstack changes topic to " (Meeting topic: senlin)" | 19:00 | |
openstack | The meeting name has been set to 'senlin' | 19:00 |
dtruong | anybody here to join today? | 19:00 |
problem_v | o/ | 19:02 |
dtruong | hi problem_v | 19:02 |
dtruong | ok, let's get started | 19:03 |
dtruong | #topic announcements | 19:03 |
*** openstack changes topic to "announcements (Meeting topic: senlin)" | 19:03 | |
dtruong | There are two Senlin related talks proposed by us for the Denver summit | 19:04 |
dtruong | If you are interested, please vote them in the community voting | 19:04 |
dtruong | #link https://www.openstack.org/summit/denver-2019/vote-for-speakers#/23379 | 19:04 |
dtruong | #link https://www.openstack.org/summit/denver-2019/vote-for-speakers#/23385 | 19:04 |
dtruong | moving on | 19:06 |
dtruong | #topic blueprints | 19:07 |
*** openstack changes topic to "blueprints (Meeting topic: senlin)" | 19:07 | |
dtruong | I don't think there are any updates on the existing blueprints | 19:07 |
dtruong | #topic Code Reviews | 19:08 |
*** openstack changes topic to "Code Reviews (Meeting topic: senlin)" | 19:08 | |
dtruong | problem_v can you update us on the status of https://review.openstack.org/#/c/629952/ | 19:08 |
problem_v | Kind of on hold for now. | 19:08 |
problem_v | I think I want to approach this issue differently. | 19:09 |
problem_v | Than what I have up for review right now. | 19:09 |
problem_v | As soon as I get some cycles I will get a new patch set up to address this proble, | 19:09 |
problem_v | problem* | 19:09 |
dtruong | Cool. Thanks for the update. | 19:10 |
dtruong | This one has been open for awhile: https://review.openstack.org/#/c/629087/ | 19:10 |
dtruong | It looks good but just needs a unit test | 19:10 |
dtruong | If anybody has time, maybe we can help this person out and add the unit test | 19:10 |
problem_v | I will do it if I can find the time. | 19:11 |
dtruong | Thanks | 19:11 |
dtruong | This one needs another +2: https://review.openstack.org/#/c/633100/ | 19:11 |
dtruong | eandersson can you review that one ^ | 19:12 |
dtruong | problem_v this one has a comment: https://review.openstack.org/#/c/633161/ | 19:12 |
dtruong | can you reply to the comment left in the review | 19:13 |
problem_v | Yep :) | 19:13 |
dtruong | These ones need another +2: https://review.openstack.org/#/c/631365 https://review.openstack.org/#/c/633844/ | 19:15 |
dtruong | eandersson ^ when you get a chance | 19:15 |
dtruong | This one is a workaround for memory leak with connections: https://review.openstack.org/#/c/627215/ | 19:17 |
dtruong | I was not able to reproduce this issue in devstack | 19:17 |
dtruong | I will try to reproduce it with latest code from master in our environment | 19:17 |
dtruong | But I feel like this not something that should be done in Senlin. | 19:18 |
dtruong | Anyways, we'll see if I can reproduce it | 19:18 |
dtruong | Last one is a backport for a bug fix to rocky: https://review.openstack.org/#/c/634079/ | 19:19 |
dtruong | For some reason all the tests are failing | 19:19 |
dtruong | I'll take a look at that one | 19:19 |
dtruong | That covers all the open code reviews | 19:20 |
dtruong | #topic open discussion | 19:20 |
*** openstack changes topic to "open discussion (Meeting topic: senlin)" | 19:20 | |
dtruong | that's all i have for today | 19:21 |
dtruong | anybody else have anything to discuss? | 19:21 |
problem_v | I dont have anything else either. | 19:21 |
dtruong | ok, let's end the meeting | 19:23 |
dtruong | thanks for attending | 19:23 |
dtruong | next week's meeting will be on Friday at 530 UTC | 19:24 |
dtruong | #endmeeting | 19:24 |
*** openstack changes topic to "IRCLog: http://eavesdrop.openstack.org/irclogs/%23senlin/ | Bugs: bugs.launchpad.net/senlin | Review: https://review.openstack.org/#/q/project:openstack/senlin,n,z" | 19:24 | |
openstack | Meeting ended Thu Jan 31 19:24:23 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 19:24 |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/senlin/2019/senlin.2019-01-31-19.00.html | 19:24 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/senlin/2019/senlin.2019-01-31-19.00.txt | 19:24 |
openstack | Log: http://eavesdrop.openstack.org/meetings/senlin/2019/senlin.2019-01-31-19.00.log.html | 19:24 |
mordred | dtruong: sweet | 19:37 |
*** sapd1 has joined #senlin | 19:42 | |
mordred | dtruong: https://review.openstack.org/631362 Fix resource deletion in clustering - updated to do node as well | 19:48 |
*** sapd1 has quit IRC | 19:48 | |
dtruong | mordred: thanks. i'll take a look at it. | 19:53 |
mordred | thanks! once that's happy we can land it and get a new sdk release cut for you | 19:59 |
*** jmlowe has quit IRC | 20:04 | |
*** jmlowe has joined #senlin | 20:24 | |
dtruong | mordred LGTM. I fixed the failing unit test in latest patch set. | 22:04 |
dtruong | problem_v eandersson: can you also take a look at that patch set: https://review.openstack.org/#/c/631362/ | 22:05 |
eandersson | dtruong, git rm .idea/* | 22:05 |
dtruong | oops. done | 22:08 |
*** openstackgerrit has joined #senlin | 22:09 | |
*** ChanServ sets mode: +v openstackgerrit | 22:09 | |
openstackgerrit | Duc Truong proposed openstack/python-senlinclient master: Fix getting action id in Location header https://review.openstack.org/634326 | 22:09 |
eandersson | LGTM | 22:09 |
eandersson | dtruong, will the above break on all previous versions of the sdk ? | 22:15 |
dtruong | it's already with the current version of sdk 0.23.0 | 22:16 |
dtruong | it's already broken | 22:16 |
eandersson | I see | 22:16 |
dtruong | but yea, older versions of the sdk like 0.17.2 with this change in senlinclient will break it | 22:17 |
dtruong | we can bump the sdk version in the requirements.txt once the sdk change gets merged and released | 22:18 |
eandersson | kk sounds good | 22:18 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!