openstackgerrit | Duc Truong proposed openstack/senlin master: Miscellaneous fixes https://review.openstack.org/631317 | 00:11 |
---|---|---|
*** Qiming has quit IRC | 00:59 | |
*** Qiming has joined #senlin | 01:00 | |
openstackgerrit | Duc Truong proposed openstack/senlin master: Do not set parent action status if stop node failed https://review.openstack.org/631365 | 01:33 |
*** sapd1_x has joined #senlin | 03:10 | |
*** sapd1_x has quit IRC | 04:08 | |
*** sapd1_x has joined #senlin | 05:12 | |
*** sapd1_x has quit IRC | 11:42 | |
*** irclogbot_3 has quit IRC | 12:47 | |
*** irclogbot_3 has joined #senlin | 12:58 | |
*** sapd1_x has joined #senlin | 13:21 | |
*** irclogbot_3 has quit IRC | 13:35 | |
*** irclogbot_3 has joined #senlin | 13:48 | |
*** mordred has joined #senlin | 15:09 | |
mordred | eandersson, dtruong: the location header - if I do DELETE /clusters/{cluster_id} - am I right in understanding that the Loication header is going to have http://example.com/v1/clusters/{cluster_id}/{action_id}? | 15:10 |
mordred | (like, there is an additional id it's returning) | 15:11 |
mordred | if so - if one hits taht url - what is returned? the api docs don't indicate the content - is it just there until the action is done and then a 404 once it is? | 15:30 |
mordred | remote: https://review.openstack.org/631362 Add class to override clustering delete responses | 15:31 |
mordred | I updated dtruong's patch with a nother approach - but I think that's incomplete without knowing what one is supposed to do with that location url | 15:32 |
mordred | once I know that - I think we should update clustering.wait_for_delete to do the right thing | 15:32 |
*** sapd1_x has quit IRC | 15:33 | |
*** jmlowe has quit IRC | 15:47 | |
*** sapd1_x has joined #senlin | 16:24 | |
*** sapd1_x has quit IRC | 17:08 | |
*** jmlowe has joined #senlin | 19:22 | |
*** phuoc_ has joined #senlin | 20:11 | |
*** phuoc has quit IRC | 20:14 | |
*** irclogbot_3 has quit IRC | 20:41 | |
*** irclogbot_3 has joined #senlin | 20:51 | |
*** openstackgerrit has quit IRC | 20:56 | |
*** jmlowe has quit IRC | 21:19 | |
*** openstackgerrit has joined #senlin | 21:37 | |
*** ChanServ sets mode: +v openstackgerrit | 21:37 | |
openstackgerrit | Jude Cross proposed openstack/senlin master: Add action_purge to senlin-manage https://review.openstack.org/631652 | 21:37 |
*** jmlowe has joined #senlin | 21:41 | |
*** sapd1_ has joined #senlin | 22:57 | |
*** sapd1 has quit IRC | 23:01 | |
dtruong | mordred: the location header for a cluster delete would be http://example.com/v1/actions/{action_id} | 23:03 |
dtruong | see http://paste.openstack.org/show/742902/ for a full capture of the response | 23:03 |
dtruong | the senlin client gets the location from the response header and strips out the action_id and prints it out to the user | 23:04 |
dtruong | https://github.com/openstack/python-senlinclient/blob/master/senlinclient/v1/cluster.py#L363 | 23:06 |
dtruong | Hitting that url returned in the location header will give you the action details: https://developer.openstack.org/api-ref/clustering/?expanded=show-action-details-detail#show-action-details | 23:10 |
dtruong | The clustering.wait_for_delete should query the location url and check the status returned by it. | 23:35 |
dtruong | it should wait for the status to become either SUCCEEDED or FAILED | 23:36 |
dtruong | That's what we also expect users of gophercloud to do when calling cluster delete: | 23:37 |
dtruong | https://github.com/gophercloud/gophercloud/blob/master/acceptance/openstack/clustering/v1/clustering.go#L292 | 23:37 |
dtruong | https://github.com/gophercloud/gophercloud/blob/master/acceptance/openstack/clustering/v1/clustering.go#L399 | 23:37 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!