| *** liyi_ has quit IRC | 00:37 | |
| *** liyi has joined #senlin | 00:37 | |
| *** fabian_ has joined #senlin | 00:55 | |
| *** blkart has quit IRC | 01:57 | |
| *** blkart has joined #senlin | 01:57 | |
| *** blkart has quit IRC | 02:01 | |
| *** blkart has joined #senlin | 02:10 | |
| *** fabian_ is now known as chenyb4 | 02:16 | |
| openstackgerrit | Merged openstack/senlin master: Fix stop node before delete error handling https://review.openstack.org/580773 | 02:32 |
|---|---|---|
| openstackgerrit | Merged openstack/senlin master: Add cluster.stop_node_before_delete documentation https://review.openstack.org/580520 | 02:32 |
| *** jmlowe has quit IRC | 02:35 | |
| chenyb4 | hi, dtruong | 02:58 |
| *** dtruong2 has joined #senlin | 03:16 | |
| dtruong2 | Hi chenyb4 | 03:17 |
| chenyb4 | dtruong2, About this patch https://review.openstack.org/#/c/521892/, I have no idea start listener | 03:18 |
| chenyb4 | dtruong2, Engine start, the listener will begin running | 03:21 |
| chenyb4 | dtruong2, if event listener cluster enable health check,execute recover operation. | 03:22 |
| *** dtruong2_ has joined #senlin | 03:24 | |
| *** liyi has quit IRC | 03:25 | |
| *** dtruong2 has quit IRC | 03:34 | |
| chenyb4 | dtruong2_, Can you give me advice? | 03:45 |
| dtruong2_ | i was looking at the original bug report | 03:48 |
| dtruong2_ | trying to understand what the problem was | 03:48 |
| dtruong2_ | I think we should just follow what other projects are doing for notification endpoints: | 03:55 |
| dtruong2_ | http://git.openstack.org/cgit/openstack/searchlight/tree/searchlight/listener.py#n179 | 03:55 |
| dtruong2_ | most projects start the the listener inside their start() function | 03:55 |
| dtruong2_ | and stop and wait for the listener inside their stop() function | 03:56 |
| chenyb4 | dtruong2_, Looks like this patch was fix it. https://review.openstack.org/#/c/521892/ Only the listener start or stop func name not same. | 04:02 |
| dtruong2_ | so does it work with that patch? | 04:04 |
| chenyb4 | Yes, that patch work ok. | 04:08 |
| dtruong2_ | so what is the question then? | 04:09 |
| chenyb4 | Ruiji wants to optimize the event health, start the listener when the engine starts, recover according to the listener's listener message, remove each engine will start a listener。 | 04:13 |
| dtruong2_ | it should be already doing that | 04:14 |
| dtruong2_ | because it is running dummy_task as a timer | 04:14 |
| dtruong2_ | so it loads the registry every so often and checks if the health manager needs to add a listener | 04:15 |
| dtruong2_ | for example if there is engine A and B running, and engine A has the listener added | 04:17 |
| dtruong2_ | if engine A dies, then the health manager in engine B will detect that and add the listener when it runs the dummy_task | 04:18 |
| chenyb4 | So here only need to implement the call? | 04:24 |
| dtruong2_ | To me what you have in the patch should be enough to fix the bug | 04:30 |
| dtruong2_ | unless there is something that i'm missing | 04:31 |
| dtruong2_ | but i have never used the health policy with lifecycle events so you will have test it and make sure it works ok | 04:32 |
| dtruong2_ | when i tested health policy with node poll, i tried with two engines and tested what happens when one engine dies | 04:33 |
| dtruong2_ | the other engine was able to pick up the health check and continue doing the node poll | 04:34 |
| chenyb4 | That patch work ok and test is right. | 04:34 |
| dtruong2_ | i see ruijie comment in the patch that listener.wait() blocks the current thread | 04:43 |
| dtruong2_ | did you have any problems like that? | 04:43 |
| chenyb4 | dtruong2_, that is he want to optimize the event health. So he commit https://review.openstack.org/#/c/529457/ split event health check. | 04:55 |
| dtruong2_ | Interesting. I never noticed the separate endpoint implementation. | 05:13 |
| dtruong2_ | Does that implementation work? It looks like it's not all finished | 05:18 |
| dtruong2_ | Because from the looks of it, I don't think the plugin will solve the problem in the original bug report | 05:26 |
| chenyb4 | Yes, ruijie commit patch change event health check not finish | 05:27 |
| chenyb4 | he was commit 3 patch in event health check. https://review.openstack.org/#/c/529457/ https://review.openstack.org/#/c/529279/ https://review.openstack.org/#/c/529235/ | 05:29 |
| *** liyi has joined #senlin | 05:44 | |
| dtruong2_ | i'm sure how that event health check would make it more efficient, unless he has time to continue it. | 05:46 |
| dtruong2_ | i can try out your patch tomorrow and see if the wait call is blocking the thread | 05:47 |
| chenyb4 | Yes, I think so. | 05:48 |
| chenyb4 | I think use that patch fix event health first. https://review.openstack.org/#/c/521892/ | 05:48 |
| chenyb4 | thanks | 05:48 |
| *** dtruong2_ has quit IRC | 05:57 | |
| openstackgerrit | chenyb4 proposed openstack/python-senlinclient master: Change CURRENT_API_VERSION to "1.9" https://review.openstack.org/581963 | 06:42 |
| *** liyi has quit IRC | 07:20 | |
| *** liyi has joined #senlin | 07:24 | |
| openstackgerrit | Duc Nguyen proposed openstack/senlin-dashboard master: Add py36 testenv https://review.openstack.org/582057 | 08:05 |
| *** chenyb4 has quit IRC | 10:25 | |
| *** liyi has quit IRC | 11:02 | |
| *** liyi has joined #senlin | 12:06 | |
| *** liyi has quit IRC | 12:11 | |
| *** liyi has joined #senlin | 13:03 | |
| *** liyi has quit IRC | 13:08 | |
| *** chenyb4 has joined #senlin | 13:52 | |
| *** chenyb4 has quit IRC | 14:24 | |
| *** chenyb4 has joined #senlin | 14:40 | |
| *** jmlowe has joined #senlin | 15:02 | |
| *** liyi has joined #senlin | 15:14 | |
| *** liyi has quit IRC | 15:19 | |
| *** jmlowe has quit IRC | 15:47 | |
| openstackgerrit | chenyb4 proposed openstack/python-senlinclient master: Change CURRENT_API_VERSION to "1.10" https://review.openstack.org/581963 | 16:29 |
| openstackgerrit | chenyb4 proposed openstack/senlin master: Fix doc history.rst format error https://review.openstack.org/582306 | 17:14 |
| *** chenyb4 has quit IRC | 17:24 | |
| openstackgerrit | Duc Truong proposed openstack/senlin master: Fix doc format errors https://review.openstack.org/582316 | 17:50 |
| openstackgerrit | Duc Truong proposed openstack/senlin master: Treat sphinx warnings as errors https://review.openstack.org/582320 | 18:02 |
| *** liyi has joined #senlin | 18:23 | |
| *** jmlowe has joined #senlin | 18:24 | |
| *** liyi has quit IRC | 18:27 | |
| *** liyi has joined #senlin | 20:32 | |
| *** liyi has quit IRC | 20:36 | |
| openstackgerrit | Duc Truong proposed openstack/senlin master: [DNM] Test sphinx CI job https://review.openstack.org/582379 | 20:53 |
| *** liyi has joined #senlin | 22:22 | |
| *** liyi has quit IRC | 22:26 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!