| *** elynn__ has joined #senlin | 01:21 | |
| *** elynn__ has quit IRC | 01:26 | |
| *** elynn__ has joined #senlin | 01:29 | |
| *** zhurong has joined #senlin | 02:05 | |
| *** yuanying has joined #senlin | 03:24 | |
| *** openstackgerrit has joined #senlin | 03:37 | |
| *** ChanServ sets mode: +v openstackgerrit | 03:37 | |
| openstackgerrit | RUIJIE YUAN proposed openstack/senlin master: model ClusterRecoverRequest object https://review.openstack.org/467863 | 03:37 |
|---|---|---|
| *** ruijie__ is now known as ruijie | 03:38 | |
| *** XueFeng has quit IRC | 03:42 | |
| *** XueFeng has joined #senlin | 03:43 | |
| *** zhurong has quit IRC | 04:08 | |
| *** zhurong has joined #senlin | 04:16 | |
| *** XueFeng has quit IRC | 04:32 | |
| *** XueFeng has joined #senlin | 04:33 | |
| openstackgerrit | chenyb4 proposed openstack/senlin master: delete profile base invalid variable https://review.openstack.org/467895 | 05:40 |
| openstackgerrit | RUIJIE YUAN proposed openstack/senlin master: service support modeled ClusterRecoverRequest obj https://review.openstack.org/467896 | 05:55 |
| openstackgerrit | RUIJIE YUAN proposed openstack/senlin master: api support modeled ClusterRecoverRequest object https://review.openstack.org/467900 | 06:09 |
| openstackgerrit | RUIJIE YUAN proposed openstack/senlin master: remove useless request obj https://review.openstack.org/467902 | 06:17 |
| openstackgerrit | RUIJIE YUAN proposed openstack/senlin master: remove useless cluster_recover() in service https://review.openstack.org/467907 | 06:32 |
| Qiming | ruijie, hi | 06:40 |
| openstackgerrit | RUIJIE YUAN proposed openstack/senlin master: service support modeled ClusterRecoverRequest obj https://review.openstack.org/467896 | 06:43 |
| ruijie | yes Qiming | 06:43 |
| Qiming | hi, noticed that you are building a train of changes to cluster recover | 06:44 |
| ruijie | yes Qiming, I am trying to model it and then add 'check_capacity' parameter into it | 06:44 |
| Qiming | however, I'm concerning that the very first patch needs some reconsideration | 06:44 |
| Qiming | we are not supposed to break backward compatibility | 06:44 |
| Qiming | we can impose more constraints when needed | 06:45 |
| Qiming | https://review.openstack.org/#/c/467863/ | 06:46 |
| Qiming | in the initial version, we have identity and params as request parameters | 06:46 |
| ruijie | em, I revised it in api layer to support it | 06:47 |
| Qiming | in the revised version, 'params' is gone, it is replaced by some flattened fields | 06:47 |
| Qiming | there are two layers of compatiblity | 06:47 |
| Qiming | one is about client <-> senlin-api | 06:47 |
| Qiming | the other is about senlin-api <-> senlin-engine | 06:48 |
| Qiming | your change in patch 467863 has broken the second layer | 06:48 |
| ruijie | but the request body is always {'recover': {'operation': '', 'check': False}} | 06:48 |
| ruijie | the 'params' field is added in api layer | 06:49 |
| Qiming | an new version of senlin-api won't be able to talk to an old version of senlin-engine | 06:49 |
| Qiming | when people are upgrading his openstack from Ocata to Pike, they will upgrade each component one by one | 06:50 |
| Qiming | breaking the 2nd layer will make smooth upgrade impossible | 06:50 |
| Qiming | hope you can consider a workaround of that | 06:51 |
| ruijie | https://git.openstack.org/cgit/openstack/senlin/tree/senlin/api/openstack/v1/clusters.py#n226 | 06:51 |
| Qiming | for example, we wrap operation, check, check_capacity into 'params' | 06:51 |
| Qiming | then we are not breaking the existing logic | 06:51 |
| Qiming | or another option is to keep 'params' but we don't expect other parametes to be extracted from it? | 06:52 |
| ruijie | I see, I treat api and engine as one component | 06:53 |
| ruijie | that is the problem? | 06:53 |
| Qiming | yes | 06:54 |
| Qiming | I'd suggest we try keep that compability as well | 06:55 |
| ruijie | em, but we will not be able to model the request obj, I mean change JsonField to XYZField | 06:56 |
| *** dixiaoli has joined #senlin | 07:13 | |
| Qiming | then we may have to keep the 'params' field | 07:16 |
| Qiming | for 1.0 version of the object, we use it | 07:17 |
| Qiming | for higher version, we do a conversion | 07:17 |
| ruijie | got it, Qiming. keep the compatible capability before we release pike | 07:30 |
| *** zhurong has quit IRC | 07:30 | |
| Qiming | one key requirement for keeping compatibility is that we don't remove fields | 07:30 |
| ruijie | okay, Qiming | 07:33 |
| *** zhurong has joined #senlin | 07:45 | |
| *** elynn__ has quit IRC | 08:09 | |
| *** elynn__ has joined #senlin | 08:19 | |
| *** XueFeng has quit IRC | 08:44 | |
| *** XueFeng has joined #senlin | 08:44 | |
| *** elynn__ has quit IRC | 08:45 | |
| openstackgerrit | Vu Cong Tuan proposed openstack/senlin master: Trivial fix typos https://review.openstack.org/467931 | 08:50 |
| *** elynn__ has joined #senlin | 08:52 | |
| *** zhurong has quit IRC | 08:54 | |
| *** elynn__ has quit IRC | 08:56 | |
| *** elynn__ has joined #senlin | 08:57 | |
| *** zhurong has joined #senlin | 09:04 | |
| *** elynn has joined #senlin | 09:10 | |
| *** elynn__ has quit IRC | 09:10 | |
| *** XueFeng has quit IRC | 09:14 | |
| *** XueFeng has joined #senlin | 09:14 | |
| *** elynn_ has joined #senlin | 09:14 | |
| *** elynn has quit IRC | 09:15 | |
| *** zhurong has quit IRC | 09:35 | |
| *** dixiaoli has quit IRC | 10:39 | |
| *** XueFeng has quit IRC | 10:54 | |
| *** XueFeng has joined #senlin | 10:55 | |
| *** elynn_ has quit IRC | 11:09 | |
| *** sharatss has joined #senlin | 11:22 | |
| *** XueFeng has quit IRC | 11:45 | |
| *** XueFeng has joined #senlin | 11:45 | |
| *** chenyb4_ has joined #senlin | 12:01 | |
| *** chenyb4_ has quit IRC | 13:19 | |
| *** dixiaoli has joined #senlin | 13:26 | |
| *** dixiaoli has quit IRC | 13:28 | |
| *** sharatss has quit IRC | 13:40 | |
| *** chenyb4_ has joined #senlin | 13:41 | |
| *** chenyb4_ has quit IRC | 13:42 | |
| *** chenyb4_ has joined #senlin | 13:42 | |
| *** chenyb4_ has quit IRC | 14:12 | |
| *** chenyb4_ has joined #senlin | 14:13 | |
| *** chenyb4_ has quit IRC | 14:17 | |
| *** XueFeng has quit IRC | 14:26 | |
| *** XueFeng has joined #senlin | 14:26 | |
| *** XueFeng has quit IRC | 14:37 | |
| *** chohoor has quit IRC | 15:58 | |
| *** chohoor has joined #senlin | 15:58 | |
| *** chohoor has quit IRC | 16:08 | |
| *** chohoor has joined #senlin | 16:10 | |
| *** chohoor has quit IRC | 16:33 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!