| openstackgerrit | xu-haiwei proposed openstack/senlin: Rename node dependency key name https://review.openstack.org/404547 | 00:22 |
|---|---|---|
| *** XueFengLiu has quit IRC | 00:40 | |
| openstackgerrit | xu-haiwei proposed openstack/senlin: Rename node/cluster dependency key name https://review.openstack.org/404547 | 00:45 |
| *** guoshan has joined #senlin | 00:52 | |
| *** XueFengLiu has joined #senlin | 00:55 | |
| *** catintheroof has joined #senlin | 01:05 | |
| *** catintheroof has quit IRC | 01:08 | |
| *** zhurong has joined #senlin | 01:11 | |
| *** guoshan_ has joined #senlin | 01:20 | |
| *** guoshan has quit IRC | 01:20 | |
| *** yanyanhu has joined #senlin | 01:30 | |
| *** devlaps has quit IRC | 01:32 | |
| *** XueFengLiu has quit IRC | 01:40 | |
| *** XueFengLiu has joined #senlin | 01:45 | |
| *** XueFengLiu has quit IRC | 01:47 | |
| *** XueFengLiu has joined #senlin | 01:49 | |
| *** elynn has joined #senlin | 01:54 | |
| *** Drago2 has quit IRC | 01:58 | |
| *** elynn_ has joined #senlin | 01:58 | |
| *** elynn has quit IRC | 01:58 | |
| *** Drago1 has joined #senlin | 02:07 | |
| *** XueFengLiu has quit IRC | 02:07 | |
| openstackgerrit | Merged openstack/senlin: Rename node/cluster dependency key name https://review.openstack.org/404547 | 02:11 |
| *** elynn_ has quit IRC | 02:12 | |
| openstackgerrit | Merged openstack/senlin: API support for receiver-delete2 https://review.openstack.org/404704 | 02:13 |
| *** elynn has joined #senlin | 02:16 | |
| *** elynn has quit IRC | 02:21 | |
| *** elynn has joined #senlin | 02:21 | |
| openstackgerrit | Merged openstack/senlin: Remove dead code about receiver-delete https://review.openstack.org/404705 | 02:22 |
| openstackgerrit | Merged openstack/senlin: Add consts definition for notification priority and phase https://review.openstack.org/404609 | 02:22 |
| openstackgerrit | Merged openstack/senlin: Minor change on event code in action modules https://review.openstack.org/404594 | 02:22 |
| *** catintheroof has joined #senlin | 02:24 | |
| fabian4 | Qiming, 现在senlin项目1.0的版本安装最低要求与openstack 那个版本结合部署？只能从m版本开始吗？ | 02:50 |
| *** yuanying has quit IRC | 02:51 | |
| *** yuanying has joined #senlin | 02:51 | |
| *** catintheroof has quit IRC | 03:28 | |
| Qiming | 按说没有 | 03:28 |
| *** catintheroof has joined #senlin | 03:28 | |
| Qiming | 我们试过Juno都可以 | 03:28 |
| *** catintheroof has quit IRC | 03:28 | |
| fabian4 | Qiming, Juno可以，有文档吗？ | 03:29 |
| Qiming | no doc | 03:29 |
| Qiming | just deploy it | 03:29 |
| Qiming | one thing you will need to check is the openstacksdk version | 03:29 |
| Qiming | and we only support keystone v3 | 03:30 |
| *** catintheroof has joined #senlin | 03:30 | |
| *** catintheroof has quit IRC | 03:30 | |
| fabian4 | Qiming, heat use v3, my Environment has install | 03:30 |
| *** catintheroof has joined #senlin | 03:31 | |
| *** catintheroof has quit IRC | 03:31 | |
| fabian4 | my environment install openstack juno, | 03:32 |
| Qiming | cool | 03:35 |
| Qiming | let us know if you encounter problems then | 03:35 |
| fabian4 | Qiming, when install senlin to juno version ,What is the use of the platform and platform version? | 03:37 |
| *** yuanying has quit IRC | 03:46 | |
| *** guoshan_ has quit IRC | 04:02 | |
| xuhaiwei | fabian4, I once installed Senlin master to Openstack Kilo version, the server side has no problem, but the client side should be a lower version, because openstacksdk's version may conflict | 04:03 |
| fabian4 | xuhaiwei, thaks | 04:04 |
| *** LHB_ has joined #senlin | 04:20 | |
| *** elynn has quit IRC | 04:32 | |
| *** guoshan has joined #senlin | 04:45 | |
| *** yuanying has joined #senlin | 04:48 | |
| *** guoshan has quit IRC | 04:49 | |
| *** yuanying_ has joined #senlin | 04:55 | |
| *** yuanying has quit IRC | 04:57 | |
| *** elynn has joined #senlin | 05:00 | |
| *** yuanying has joined #senlin | 05:02 | |
| *** yuanying_ has quit IRC | 05:04 | |
| *** elynn has quit IRC | 05:04 | |
| *** elynn has joined #senlin | 05:05 | |
| *** yuanying_ has joined #senlin | 05:10 | |
| *** yuanying has quit IRC | 05:11 | |
| xuhaiwei | Qiming, yanyanhu, hi, I got a bug from openstacksdk, currently node/cluster update action will fail because the server side got an expected property 'id' | 05:12 |
| xuhaiwei | this is the error log http://paste.openstack.org/show/591054/ | 05:13 |
| xuhaiwei | the error is caused by here https://github.com/openstack/python-openstacksdk/blob/master/openstack/proxy2.py#L62 | 05:14 |
| *** Drago1 has quit IRC | 05:16 | |
| openstackgerrit | Shu Muto proposed openstack/senlin-dashboard: Add node create/update actions https://review.openstack.org/396975 | 05:17 |
| *** Drago1 has joined #senlin | 05:18 | |
| Qiming | xuhaiwei, looking | 05:39 |
| yanyanhu | xuhaiwei, I guess it is because we are now performing stricter request validation based on versioned object. | 05:40 |
| yanyanhu | I recall I met similar situation before when I was working on versioned request support for node-update | 05:41 |
| xuhaiwei | the update body should not contain 'id', right? | 05:41 |
| yanyanhu | but the problem just disappeared after sdk version was updated | 05:41 |
| yanyanhu | yes | 05:41 |
| xuhaiwei | the specified identity (node or cluster) will be filtered out from the url? | 05:42 |
| yanyanhu | yes, the identity is from url | 05:42 |
| Qiming | haiwei is using 0.9.9 version | 05:43 |
| Qiming | major change from 0.9.9 to 0.9.10 is about reverting neutron error patch was impacting all exception handling | 05:45 |
| yanyanhu | let me try in my local env | 05:46 |
| xuhaiwei | https://github.com/openstack/python-openstacksdk/blob/master/openstack/proxy2.py#L53 | 05:47 |
| xuhaiwei | in the get_resource method, the 'value' should be an ID of an object of a class, but obviously the ID doesn't meet any of the conditions | 05:48 |
| yanyanhu | got the same error with sdk0.9.9 | 05:48 |
| yanyanhu | problem still remains using sdk0.9.11 | 05:52 |
| *** xuhaiwei__ has joined #senlin | 05:56 | |
| Qiming | a qiuck fix would be have senlinclient pass in the cluster instance instead of cluster id | 05:57 |
| Qiming | just tried, it works | 05:57 |
| *** xuhaiwei has quit IRC | 05:57 | |
| Qiming | change this line: http://git.openstack.org/cgit/openstack/python-senlinclient/tree/senlinclient/v1/shell.py#n785 | 05:57 |
| Qiming | to: service.update_cluster(cluster, **attrs) | 05:58 |
| Qiming | if we pass in just a cluster id, it is difficult for sdk to guess whether the id refers to an existing cluster | 05:58 |
| Qiming | the _get_resource() method in proxy2 module is hard to fix | 05:59 |
| xuhaiwei__ | Qiming, yes, got it | 05:59 |
| Qiming | I also considered a specialization of the _update() method of proxy2 module, seems no straightforward fix either | 05:59 |
| Qiming | even if we fix it, we will still have problem in waiting for a next version bump of sdk | 06:00 |
| Qiming | so ... pls help fix senlinclient | 06:00 |
| Qiming | for all update commands | 06:00 |
| xuhaiwei__ | ok | 06:00 |
| Qiming | btw, yanyanhu | 06:00 |
| yanyanhu | so using this way, self._body.dirty of resource(cluster/node) will not include "id" attr? | 06:01 |
| yanyanhu | yes? | 06:01 |
| Qiming | yes | 06:01 |
| Qiming | dumped request | 06:03 |
| Qiming | curl -g -i -X PATCH http://192.168.42.11:8778/v1/clusters/4c2cead2-fd74-418a-9d12-bd2d9bd7a812 -H "openstack-api-version: clustering 1.2" -H "User-Agent: python-senlinclient openstacksdk/0.9.11 keystoneauth1/2.15.0 python-requests/2.11.1 CPython/2.7.12" -H "Content-Type: application/json" -H "X-Auth-Token: {SHA1}4b90ca3a581804097ffb2e7561e952b4383ac767" -d '{"cluster": {"profile_id": null, "timeout": null}}' | 06:03 |
| Qiming | strange thing is ... | 06:04 |
| Qiming | the output from the update command is not showing the cluster name changed | 06:04 |
| Qiming | I have to do another cluster-list or cluster-show to get it | 06:04 |
| Qiming | looks like a bug at server side | 06:04 |
| Qiming | right, server side bug: | 06:06 |
| Qiming | http://git.openstack.org/cgit/openstack/senlin/tree/senlin/engine/service.py#n962 | 06:06 |
| yanyanhu | yes, this should be a bug | 06:06 |
| Qiming | this line is still referencing the "old" cluster | 06:06 |
| yanyanhu | yes, so need to get the updated cluster object and convert it to dict before returning in service calll | 06:08 |
| Qiming | yes, could be just a object call rather than a Cluster deserialization call | 06:09 |
| Qiming | filed a bug 1645355 | 06:10 |
| openstack | bug 1645355 in QEMU "x86: singlestepping through SYSCALL instruction causes exception in kernelspace" [Undecided,New] https://launchpad.net/bugs/1645355 | 06:10 |
| Qiming | oh, no, not this | 06:10 |
| Qiming | bug 1646355 | 06:10 |
| openstack | bug 1646355 in senlin "output cluster update is not showing the latest cluster property" [Medium,Confirmed] https://launchpad.net/bugs/1646355 | 06:10 |
| Qiming | thanks, bug bot | 06:10 |
| yanyanhu | yes. The only issue is cluster name is changed during action execution. | 06:11 |
| yanyanhu | let me think about it | 06:11 |
| Qiming | even with that, we should try show the "latest" result | 06:11 |
| yanyanhu | yes, that is for sure | 06:11 |
| yanyanhu | will check how to fix it | 06:12 |
| Qiming | okay, seems all attributes are designed to be changed inside an action ... | 06:13 |
| Qiming | em ... | 06:13 |
| Qiming | that makes sense | 06:13 |
| Qiming | also, this line: | 06:14 |
| Qiming | http://git.openstack.org/cgit/openstack/senlin/tree/senlin/engine/service.py#n912 | 06:14 |
| Qiming | seems a huge overhead | 06:14 |
| Qiming | I don't think we need a Cluster object througout the cluster_update2 function, ... | 06:15 |
| *** guoshan has joined #senlin | 06:15 | |
| Qiming | just use the db_cluster object from line 911 would suffice | 06:16 |
| Qiming | alright, yanyanhu | 06:16 |
| Qiming | I was pinging you for senlinclient | 06:16 |
| yanyanhu | yes, class obj is unnecessary | 06:17 |
| yanyanhu | Qiming, you mean the "id" issue? | 06:17 |
| xuhaiwei__ | Qiming, got this error when doing 'cluster-policy-update' 'True' is not of type 'boolean', 'null' | 06:17 |
| Qiming | we released senlinclient 1.0.0 back on 08-31 | 06:17 |
| Qiming | it has been three months | 06:17 |
| Qiming | there have been a lot of bug fixes | 06:17 |
| xuhaiwei__ | yanyanhu, I am fixing the client side of ID issue | 06:17 |
| yanyanhu | xuhaiwei__, great, thanks :) | 06:17 |
| yanyanhu | Qiming, so we need a release cut for client? | 06:18 |
| Qiming | yes, definitely | 06:18 |
| yanyanhu | but I guess the milestone1 has passed | 06:18 |
| yanyanhu | so we need to wait for milestone2? | 06:18 |
| Qiming | we cannot assume users are all using master branch | 06:18 |
| *** yuanying_ has quit IRC | 06:18 | |
| Qiming | we didn't release client at milestone 1 | 06:18 |
| yanyanhu | yes, | 06:18 |
| yanyanhu | yes, I didn't propose it for senlinclient | 06:18 |
| Qiming | we were not FORCED to | 06:19 |
| xuhaiwei__ | it seems I got a bug from the cluster-policy-update api | 06:19 |
| Qiming | senlinclient is cycles-with-intermediary | 06:19 |
| xuhaiwei__ | 'True' is not of type 'boolean', 'null' | 06:19 |
| xuhaiwei__ | what does this mean? | 06:19 |
| Qiming | not cycles-with-milestone | 06:19 |
| yanyanhu | I see | 06:19 |
| Qiming | we are in complete control of when to release senlinclient | 06:20 |
| Qiming | so I don't get why we have to wait for milestone2 | 06:20 |
| Qiming | you can check it here: | 06:21 |
| Qiming | http://git.openstack.org/cgit/openstack/releases/log/ | 06:21 |
| yanyanhu | I see | 06:21 |
| Qiming | mistralclient, gnocchiclient all released new versions this week | 06:21 |
| yanyanhu | so what we should do is proposing patch to release repo for client? | 06:21 |
| Qiming | yes I think so | 06:22 |
| yanyanhu | as we did for senlin service repo before | 06:22 |
| yanyanhu | understand | 06:22 |
| yanyanhu | will propose for it | 06:22 |
| Qiming | just we don't have to sync with other service type of projects | 06:22 |
| Qiming | judging from https://bugs.launchpad.net/python-senlinclient | 06:23 |
| Qiming | we are in good shape to release a new version (after merging haiwei's fix and related fixes to 'update' command) | 06:23 |
| yanyanhu | I see | 06:24 |
| yanyanhu | do need a new release for client | 06:25 |
| yanyanhu | will wait for haiwei's patch | 06:25 |
| Qiming | thanks! | 06:26 |
| yanyanhu | no problem | 06:28 |
| openstackgerrit | xu-haiwei proposed openstack/python-senlinclient: Fix resource update issues https://review.openstack.org/405123 | 06:32 |
| *** Drago1 has quit IRC | 06:45 | |
| *** Drago1 has joined #senlin | 06:46 | |
| openstackgerrit | Merged openstack/python-senlinclient: Fix resource update issues https://review.openstack.org/405123 | 06:51 |
| openstackgerrit | Merged openstack/python-senlinclient: Show team and repo badges on README https://review.openstack.org/403084 | 06:51 |
| *** Drago1 has quit IRC | 06:54 | |
| yanyanhu | hi, xuhaiwei__, could you please help to confirm the patch for cluster/node update issue works? If it does, I will cut a release for senlinclient. Thanks | 06:56 |
| Qiming | yanyanhu, you will have a lot of reno items to create, :) | 06:57 |
| yanyanhu | oh, forgot this part... | 06:57 |
| Qiming | although we treated senlinclient 1.0.0 as a stable release | 06:57 |
| xuhaiwei__ | yes, I have tried the commands, it works, but for cluster-policy-update, I got an error , it seems a server bug | 06:57 |
| yanyanhu | I plan to set the release version to 1.1.0 | 06:57 |
| openstackgerrit | Merged openstack/senlin-dashboard: Improve translate attribute for profile creation workflow https://review.openstack.org/396970 | 06:58 |
| yanyanhu | xuhaiwei__, got it, thanks | 06:58 |
| Qiming | ttx asked me if I was confident at releasing senlinclient 1.0.0 and I answered yes | 06:58 |
| Qiming | he was encouraging, but ... we still found and fixed a lot of issues | 06:58 |
| yanyanhu | Qiming, if so, maybe setting the release version to 1.1.0 is ok? | 06:59 |
| yanyanhu | for most changes are bug fix | 06:59 |
| yanyanhu | not feature or architecture change | 06:59 |
| *** Drago1 has joined #senlin | 07:00 | |
| openstackgerrit | Merged openstack/python-senlinclient: Fix project_id show in 'senlin xyz_list -g' https://review.openstack.org/401929 | 07:00 |
| Qiming | yes, mostly bug fixes | 07:00 |
| yanyanhu | ok, will try to collect the changes and add release note for them | 07:01 |
| *** zhurong__ has joined #senlin | 07:07 | |
| *** zhurong has quit IRC | 07:10 | |
| *** guoshan has quit IRC | 07:28 | |
| *** guoshan has joined #senlin | 07:29 | |
| fabian4 | hi， senlin file etc/senlin/senlin.conf.sample why not exist ? | 07:51 |
| openstackgerrit | Yanyan Hu proposed openstack/python-senlinclient: Release note for python-senlinclient 1.1.0 https://review.openstack.org/405158 | 08:02 |
| yanyanhu | hi, fabian4, you can run "tools/gen-config" to generate one | 08:04 |
| fabian4 | yanyanhu, thnaks | 08:06 |
| yanyanhu | my pleasure | 08:06 |
| *** yuanying has joined #senlin | 08:27 | |
| *** Drago1 has quit IRC | 08:47 | |
| openstackgerrit | Merged openstack/senlin-dashboard: Add JS tests for profile create service https://review.openstack.org/396968 | 09:24 |
| *** guoshan has quit IRC | 09:35 | |
| *** yuanying_ has joined #senlin | 09:38 | |
| *** yuanying has quit IRC | 09:41 | |
| Qiming | yanyanhu, the release notes | 09:49 |
| Qiming | mostly good | 09:49 |
| Qiming | just one thing, the change about MagicMock is not supposed to be included I think | 09:50 |
| Qiming | it is a developer thing, not something we want to notify users | 09:50 |
| yanyanhu | Qiming, I see. | 09:50 |
| yanyanhu | yes, you're right. it's for test | 09:50 |
| yanyanhu | will remove it | 09:50 |
| yanyanhu | and will cut 1.1.0 release based on this patch | 09:51 |
| openstackgerrit | Yanyan Hu proposed openstack/python-senlinclient: Release note for python-senlinclient 1.1.0 https://review.openstack.org/405158 | 09:51 |
| *** openstack has joined #senlin | 10:07 | |
| *** yanyanhu has quit IRC | 10:13 | |
| openstackgerrit | Shu Muto proposed openstack/senlin-dashboard: Add node create/update actions https://review.openstack.org/396975 | 10:33 |
| *** fabian4 has quit IRC | 10:39 | |
| *** fabian4 has joined #senlin | 10:43 | |
| *** LHB_ has quit IRC | 11:13 | |
| *** elynn has quit IRC | 11:27 | |
| *** catintheroof has joined #senlin | 12:25 | |
| *** catintheroof has quit IRC | 12:48 | |
| *** catintheroof has joined #senlin | 13:13 | |
| *** catinthe_ has joined #senlin | 13:18 | |
| *** catintheroof has quit IRC | 13:19 | |
| openstackgerrit | Merged openstack/senlin: Remove dead codes related to profile_validate in engine layer https://review.openstack.org/403466 | 14:46 |
| openstackgerrit | Merged openstack/senlin: Remove request id TODO item https://review.openstack.org/404181 | 14:46 |
| *** guoshan has joined #senlin | 14:49 | |
| *** guoshan_ has joined #senlin | 14:52 | |
| *** guoshan has quit IRC | 14:52 | |
| *** devlaps has joined #senlin | 15:01 | |
| *** guoshan_ has quit IRC | 15:04 | |
| *** Drago1 has joined #senlin | 15:24 | |
| *** Drago1 has quit IRC | 15:36 | |
| *** Drago1 has joined #senlin | 15:41 | |
| *** Drago1 has quit IRC | 18:04 | |
| *** Drago1 has joined #senlin | 18:04 | |
| *** openstackgerrit has quit IRC | 19:32 | |
| *** openstackgerrit has joined #senlin | 19:34 | |
| *** ChanServ sets mode: +v openstackgerrit | 19:34 | |
| *** openstackgerrit has quit IRC | 19:36 | |
| *** catinthe_ has quit IRC | 20:34 | |
| *** openstack has joined #senlin | 20:47 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!