| *** guoshan has joined #senlin | 00:14 | |
| *** guoshan has quit IRC | 00:58 | |
| *** zhurong has joined #senlin | 01:18 | |
| *** yanyanhu has joined #senlin | 01:20 | |
| openstackgerrit | Merged openstack/senlin-dashboard: Updated from global requirements https://review.openstack.org/392835 | 01:32 |
|---|---|---|
| openstackgerrit | Qiming Teng proposed openstack/senlin: Remove dead code about cluster check/recover https://review.openstack.org/393017 | 01:33 |
| *** guoshan has joined #senlin | 01:40 | |
| *** guoshan has quit IRC | 01:44 | |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Remove some dead code in rpc client https://review.openstack.org/393020 | 01:45 |
| *** guoshan has joined #senlin | 01:45 | |
| *** elynn has joined #senlin | 01:48 | |
| *** elynn has quit IRC | 01:53 | |
| openstackgerrit | Merged openstack/senlin: Updated from global requirements https://review.openstack.org/392834 | 01:54 |
| *** elynn has joined #senlin | 01:54 | |
| openstackgerrit | Merged openstack/senlin: Add request/response sample for profile validate API doc https://review.openstack.org/389572 | 01:54 |
| openstackgerrit | Merged openstack/senlin: Add request/response sample for policy validate API doc https://review.openstack.org/389576 | 01:54 |
| openstackgerrit | miaohb proposed openstack/senlin: Add filters "policy_name" and "policy_type" for policy binding list https://review.openstack.org/388505 | 01:59 |
| *** elynn has quit IRC | 02:23 | |
| Qiming | ruijie, online? | 02:25 |
| ruijie | yes, Qiming | 02:26 |
| Qiming | about replace nodes | 02:26 |
| Qiming | I'm wondering how the command line interface would be | 02:26 |
| Qiming | do you have any thoughts on that? | 02:27 |
| ruijie | No, Qiming, have not thought about that | 02:27 |
| Qiming | senlin cluster-replace-nodes -m oldnode=newnode <cluster> ? | 02:28 |
| ruijie | how about key-value | 02:28 |
| Qiming | senlin cluster-replace-nodes -m old1=new1,old2=new2... <cluster> ? | 02:30 |
| ruijie | senlin cluster-replace-nodes -m <old1=new1; old2=new2> <cluster> | 02:31 |
| ruijie | yes, Qiming, maybe we can use this | 02:31 |
| Qiming | em, but ';' is a little dangerous | 02:31 |
| Qiming | it can be interpreted by Bash as a separator between two commands | 02:32 |
| ruijie | And, I am thinking if we can add another parameter to let the user to destroy the original node | 02:32 |
| openstackgerrit | Yanyan Hu proposed openstack/senlin: API support for node_delete2 https://review.openstack.org/393030 | 02:33 |
| openstackgerrit | Yanyan Hu proposed openstack/senlin: Remove dead code about node-delete https://review.openstack.org/393031 | 02:33 |
| Qiming | yep, that is possible | 02:33 |
| Qiming | senlin cluster-replace-nodes -m old1=new1[:kill] -m old2=new2[:kill] <cluster> ? | 02:35 |
| ruijie | em, yea. But will that be a little bit complex for user? to decide destiny for every nodes | 02:36 |
| Qiming | by default, we will preserve the replaced nodes | 02:37 |
| ruijie | yes, Qiming, we can do that, let the user chose the nodes to destroy | 02:38 |
| Qiming | it is always a trade-off between flexibility and simplicity | 02:38 |
| *** elynn has joined #senlin | 02:38 | |
| Qiming | anyway | 02:39 |
| Qiming | I'm asking this question because ... at the API layer, we are checking if the old node specified is empty and if the new node specified is empty | 02:39 |
| Qiming | I'm revisiting those code and wondering if that check is needed | 02:40 |
| openstackgerrit | miaohb proposed openstack/senlin: Add filters "policy_name" and "policy_type" for policy binding list https://review.openstack.org/388505 | 02:41 |
| Qiming | if the api accepts a dict, the 'key' part won't be empty, right? | 02:41 |
| ruijie | I can't be, I mean, we may still check that? | 02:42 |
| ruijie | it | 02:42 |
| Qiming | for a valid JSON, the keys cannot be empty | 02:42 |
| Qiming | that check can be skipped IMO | 02:42 |
| Qiming | but for the values, we are about to check them | 02:43 |
| *** elynn has quit IRC | 02:43 | |
| *** elynn has joined #senlin | 02:43 | |
| *** Drago has quit IRC | 02:44 | |
| ruijie | and also, for the value, it won't be empty too? | 02:46 |
| *** yanyanhu has quit IRC | 02:48 | |
| *** yanyanhu has joined #senlin | 02:49 | |
| Qiming | em, from API's perspective, we cannot guarantee that | 02:51 |
| ruijie | Thanks, Qiming. That makes sense. | 02:52 |
| *** senk has quit IRC | 02:57 | |
| openstackgerrit | Yanyan Hu proposed openstack/senlin: API support for node_delete2 https://review.openstack.org/393030 | 03:11 |
| openstackgerrit | Yanyan Hu proposed openstack/senlin: Remove dead code about node-delete https://review.openstack.org/393031 | 03:11 |
| *** Drago5 has joined #senlin | 03:14 | |
| Qiming | ruijie, when checking the request format for replace_nodes, I'm now thinking that destroy operation should not be included, even in future | 03:34 |
| Qiming | the payload, as it is documented, is a dict | 03:34 |
| Qiming | that means we don't have a chance to add more fields for indicating whether node(s) should be destroyed unless we change the protocol | 03:35 |
| ruijie | em | 03:35 |
| ruijie | So, we can only use that parameter to control the whole dict? | 03:36 |
| Qiming | changing the payload to a list of dicts will solve the problem, but we will have to bump the api version | 03:36 |
| ruijie | senlin cluster-replace-nodes -m old1=new1 -m old2=new2 --destroy boolean <cluster> | 03:36 |
| Qiming | yes, that is something doable | 03:37 |
| Qiming | by default, we don't destroy those nodes, em ... makes sense | 03:38 |
| ruijie | Yes, but not flexible as the previous one | 03:38 |
| openstackgerrit | Yanyan Hu proposed openstack/senlin: API support for node_delete2 https://review.openstack.org/393030 | 03:51 |
| openstackgerrit | Yanyan Hu proposed openstack/senlin: Remove dead code about node-delete https://review.openstack.org/393031 | 03:51 |
| openstackgerrit | Yanyan Hu proposed openstack/senlin: Versioned req object and engine support for node delete https://review.openstack.org/392432 | 03:51 |
| *** guoshan has quit IRC | 03:56 | |
| *** elynn has quit IRC | 04:24 | |
| *** guoshan has joined #senlin | 04:57 | |
| *** guoshan has quit IRC | 05:01 | |
| *** Drago5 has quit IRC | 05:32 | |
| *** elynn has joined #senlin | 05:39 | |
| *** elynn has quit IRC | 05:44 | |
| *** elynn has joined #senlin | 05:44 | |
| *** openstackgerrit has quit IRC | 05:48 | |
| *** openstackgerrit has joined #senlin | 05:49 | |
| *** ChanServ sets mode: +v openstackgerrit | 05:49 | |
| *** guoshan has joined #senlin | 05:57 | |
| *** guoshan has quit IRC | 06:02 | |
| openstackgerrit | Merged openstack/senlin: Add filters "policy_name" and "policy_type" for policy binding list https://review.openstack.org/388505 | 06:08 |
| *** guoshan has joined #senlin | 06:15 | |
| *** guoshan has quit IRC | 06:19 | |
| *** guoshan has joined #senlin | 06:20 | |
| ruijie | Hi, Qiming, around? | 06:21 |
| openstackgerrit | miaohb proposed openstack/python-senlinclient: Add filters "policy_type" and "policy_name" for policy binding list https://review.openstack.org/388509 | 06:24 |
| *** zhurong has quit IRC | 06:25 | |
| *** zhurong_ has joined #senlin | 06:25 | |
| Qiming | yes? | 06:28 |
| ruijie | https://review.openstack.org/gitweb?p=openstack/senlin.git;a=blob;f=senlin/engine/actions/node_action.py;h=0eb6a4342b3c24ef688d0f6932c9367aee24fe3b;hb=6e80bdbd5bb2247f2469b3e2632aba42177c84d2#l100 | 06:30 |
| ruijie | Since we already sleep for grace_period | 06:30 |
| ruijie | in cluster action layer | 06:31 |
| ruijie | Do we still need this code | 06:31 |
| Qiming | yes, we still need that | 06:34 |
| Qiming | actually that is a good question | 06:34 |
| Qiming | if you pay attention to line 87 in the same file | 06:34 |
| Qiming | you will see 'self.cause == base.CAUSE_RPC' | 06:35 |
| Qiming | for node deletion, it can be an action triggered directly from API request, i.e. senlin node-delete | 06:35 |
| ruijie | yes, Qiming, saw that | 06:36 |
| Qiming | it can be triggered as a child action of a cluster action, e.g. senlin cluster-delete | 06:36 |
| Qiming | if it is the latter case, the grace_period is handled at the cluster action layer | 06:36 |
| Qiming | in other words, self.cause == base.DERIVED | 06:37 |
| Qiming | if it is the former case, grace period is handled at node action layer | 06:37 |
| ruijie | so, actually, the cluster delete action only execute #104 | 06:37 |
| Qiming | yes, if function do_delete is invoked from within a cluster action, the logic between line 97-102 will be skipped | 06:38 |
| Qiming | and line 106-115 will be skipped as well | 06:38 |
| ruijie | Thanks Qiming. That makes sense. | 06:39 |
| Qiming | np | 06:40 |
| *** zhurong_ has quit IRC | 07:03 | |
| *** zhurong has joined #senlin | 07:04 | |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Add UniqueDict field type https://review.openstack.org/393122 | 07:12 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Request object for replace nodes request https://review.openstack.org/393123 | 07:12 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Engine layer cluster-replace-nodes v2 https://review.openstack.org/393124 | 07:12 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: API support to cluster-replace-nodes v2 https://review.openstack.org/393131 | 07:32 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/senlin-dashboard: Imported Translations from Zanata https://review.openstack.org/389288 | 07:32 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Remove dead engine code about replace nodes https://review.openstack.org/393132 | 07:34 |
| *** openstackgerrit has quit IRC | 07:48 | |
| *** openstackgerrit has joined #senlin | 07:49 | |
| *** ChanServ sets mode: +v openstackgerrit | 07:49 | |
| openstackgerrit | Merged openstack/senlin: Versioned objects for check/recover requests https://review.openstack.org/392640 | 07:57 |
| openstackgerrit | Merged openstack/senlin: Engine support to objectified cluster check/recover https://review.openstack.org/392665 | 08:05 |
| openstackgerrit | Merged openstack/senlin: API layer support to cluster check/recover v2 https://review.openstack.org/392712 | 08:06 |
| openstackgerrit | Yanyan Hu proposed openstack/senlin: Verioned req object for node check/recover https://review.openstack.org/393153 | 08:08 |
| openstackgerrit | Yanyan Hu proposed openstack/senlin: Engine support for node_check2 and node_recover2 https://review.openstack.org/393154 | 08:08 |
| openstackgerrit | Yanyan Hu proposed openstack/senlin: API support for node_check2 and node_receove2 https://review.openstack.org/393155 | 08:08 |
| openstackgerrit | Yanyan Hu proposed openstack/senlin: Remove dead code about node check/recover https://review.openstack.org/393156 | 08:08 |
| openstackgerrit | Merged openstack/senlin: Versioned req object and engine support for node delete https://review.openstack.org/392432 | 08:45 |
| openstackgerrit | Merged openstack/senlin: API support for node_delete2 https://review.openstack.org/393030 | 08:45 |
| openstackgerrit | Merged openstack/senlin: Remove dead code about node-delete https://review.openstack.org/393031 | 08:45 |
| openstackgerrit | Merged openstack/senlin: Add UniqueDict field type https://review.openstack.org/393122 | 08:45 |
| openstackgerrit | Merged openstack/senlin: Tune health manager to use new RPC https://review.openstack.org/392843 | 08:51 |
| openstackgerrit | Merged openstack/senlin: Remove dead code about cluster check/recover https://review.openstack.org/393017 | 08:53 |
| openstackgerrit | Merged openstack/senlin: Remove some dead code in rpc client https://review.openstack.org/393020 | 08:53 |
| *** zhurong has quit IRC | 09:14 | |
| *** elynn has quit IRC | 09:29 | |
| openstackgerrit | Yanyan Hu proposed openstack/senlin: Verioned req object for node check/recover https://review.openstack.org/393153 | 09:32 |
| openstackgerrit | Yanyan Hu proposed openstack/senlin: API support for node_check2 and node_receove2 https://review.openstack.org/393155 | 09:32 |
| openstackgerrit | Yanyan Hu proposed openstack/senlin: Engine support for node_check2 and node_recover2 https://review.openstack.org/393154 | 09:32 |
| openstackgerrit | Yanyan Hu proposed openstack/senlin: Remove dead code about node check/recover https://review.openstack.org/393156 | 09:32 |
| *** yanyanhu has quit IRC | 09:38 | |
| *** yanyanhu has joined #senlin | 09:38 | |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Request object for replace nodes request https://review.openstack.org/393123 | 09:40 |
| *** yanyanhu has quit IRC | 09:42 | |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Request object for replace nodes request https://review.openstack.org/393123 | 09:48 |
| *** zhurong has joined #senlin | 09:49 | |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Engine layer cluster-replace-nodes v2 https://review.openstack.org/393124 | 09:53 |
| *** zhurong has quit IRC | 10:02 | |
| *** zhurong has joined #senlin | 10:04 | |
| openstackgerrit | Qiming Teng proposed openstack/senlin: API support to cluster-replace-nodes v2 https://review.openstack.org/393131 | 10:08 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Remove dead engine code about replace nodes https://review.openstack.org/393132 | 10:11 |
| *** guoshan_ has joined #senlin | 10:46 | |
| *** guoshan has quit IRC | 10:49 | |
| *** guoshan_ has quit IRC | 10:50 | |
| openstackgerrit | Qiming Teng proposed openstack/senlin: API support to cluster-replace-nodes v2 https://review.openstack.org/393131 | 11:15 |
| *** AlexeyAbashkin has quit IRC | 11:30 | |
| *** AlexeyAbashkin has joined #senlin | 11:35 | |
| openstackgerrit | Qiming Teng proposed openstack/senlin: API support to cluster-replace-nodes v2 https://review.openstack.org/393131 | 11:45 |
| *** AlexeyAbashkin has quit IRC | 11:49 | |
| *** AlexeyAbashkin has joined #senlin | 11:50 | |
| *** zzxwill has joined #senlin | 11:56 | |
| *** zzxwill has quit IRC | 11:56 | |
| *** zzxwill has joined #senlin | 11:58 | |
| openstackgerrit | RUIJIE YUAN proposed openstack/senlin: destroy nodes after cluster replace https://review.openstack.org/393286 | 12:27 |
| *** Drago5 has joined #senlin | 12:40 | |
| *** Drago5 has quit IRC | 12:45 | |
| *** Drago5 has joined #senlin | 12:48 | |
| *** Drago5 is now known as Drago | 12:52 | |
| *** zzxwill has quit IRC | 12:57 | |
| *** zzxwill has joined #senlin | 13:00 | |
| *** jruano has joined #senlin | 13:15 | |
| *** jruano has quit IRC | 13:15 | |
| *** Alexey_Abashkin has joined #senlin | 13:27 | |
| *** AlexeyAbashkin has quit IRC | 13:30 | |
| *** zzxwill has quit IRC | 14:00 | |
| *** Drago has quit IRC | 14:46 | |
| *** Drago5 has joined #senlin | 14:52 | |
| *** Drago5 is now known as Drago | 14:53 | |
| *** Alexey_Abashkin_ has joined #senlin | 16:56 | |
| *** Alexey_Abashkin has quit IRC | 16:59 | |
| *** jruano has joined #senlin | 17:26 | |
| *** jruano has quit IRC | 17:57 | |
| *** ruijie has quit IRC | 18:27 | |
| *** jruano has joined #senlin | 18:54 | |
| *** jruano has quit IRC | 19:35 | |
| *** jruano has joined #senlin | 21:39 | |
| *** jruano has quit IRC | 21:40 | |
| *** jruano has joined #senlin | 21:57 | |
| *** yuanying has joined #senlin | 23:41 | |
| *** jruano has quit IRC | 23:43 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!