| *** shu-mutou-AFK is now known as shu-mutou | 00:37 | |
| *** Drago has quit IRC | 00:46 | |
| *** zzxwill has joined #senlin | 01:10 | |
| *** yanyanhu has joined #senlin | 01:48 | |
| *** elynn has joined #senlin | 02:08 | |
| *** elynn_ has joined #senlin | 02:12 | |
| *** elynn has quit IRC | 02:12 | |
| *** zzxwill has quit IRC | 02:30 | |
| *** zzxwill has joined #senlin | 02:30 | |
| openstackgerrit | Merged openstack/senlin: [Trivial] Remove executable privilege of doc/source/conf.py https://review.openstack.org/311013 | 02:34 |
|---|---|---|
| openstackgerrit | Merged openstack/senlin: Revise region placement policy doc for developer https://review.openstack.org/347690 | 02:40 |
| openstackgerrit | Merged openstack/senlin: Revise LB policy doc for developer https://review.openstack.org/347686 | 02:40 |
| openstackgerrit | Merged openstack/senlin: Revise deletion policy doc for developer https://review.openstack.org/347680 | 02:41 |
| openstackgerrit | Merged openstack/senlin: Revise zone placement policy doc for developer https://review.openstack.org/347699 | 02:41 |
| *** yuanying has quit IRC | 02:47 | |
| openstackgerrit | Yanyan Hu proposed openstack/senlin: Integration test for nova server cluster https://review.openstack.org/347654 | 03:14 |
| openstackgerrit | Yanyan Hu proposed openstack/senlin: Integration test for heat stack cluster https://review.openstack.org/348110 | 03:14 |
| openstackgerrit | EldonZhao proposed openstack/senlin: Set node status ERROR when physical id is none https://review.openstack.org/347732 | 03:23 |
| *** Liuqing has joined #senlin | 03:26 | |
| *** zzxwill has quit IRC | 03:47 | |
| *** yuanying has joined #senlin | 03:50 | |
| *** elynn_ has quit IRC | 04:40 | |
| *** Drago1 has joined #senlin | 04:59 | |
| *** Drago1 has joined #senlin | 05:00 | |
| *** elynn_ has joined #senlin | 05:08 | |
| *** elynn__ has joined #senlin | 05:12 | |
| *** elynn_ has quit IRC | 05:13 | |
| *** Drago1 has quit IRC | 05:14 | |
| *** Drago1 has joined #senlin | 05:15 | |
| *** Drago1 has quit IRC | 05:18 | |
| *** zzxwill has joined #senlin | 05:22 | |
| *** Drago1 has joined #senlin | 05:26 | |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Documentation for builtin policies https://review.openstack.org/347630 | 06:01 |
| *** elynn has joined #senlin | 06:27 | |
| *** elynn__ has quit IRC | 06:30 | |
| openstackgerrit | Yanyan Hu proposed openstack/senlin: Make lb timeout configurable https://review.openstack.org/346569 | 06:36 |
| *** elynn has quit IRC | 06:39 | |
| openstackgerrit | Merged openstack/senlin: Add some release notes about recent changes https://review.openstack.org/347600 | 06:39 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/senlin-dashboard: Imported Translations from Zanata https://review.openstack.org/348162 | 07:44 |
| openstackgerrit | Yanyan Hu proposed openstack/senlin: Make lb timeout configurable https://review.openstack.org/346569 | 07:53 |
| *** zzxwill has quit IRC | 07:54 | |
| *** Drago1 has quit IRC | 08:00 | |
| *** zzxwill has joined #senlin | 08:07 | |
| *** shu-mutou has quit IRC | 08:13 | |
| openstackgerrit | EldonZhao proposed openstack/senlin: Set node status ERROR when physical id is none https://review.openstack.org/347732 | 08:20 |
| Qiming | eldon_, there? | 08:26 |
| eldon_ | yes | 08:26 |
| Qiming | thanks for proposing the patch about physical id being None | 08:26 |
| Qiming | but yanyan and I have some suggestions to fix it in a different way, have you checked the review comments? | 08:27 |
| eldon_ | yes, but I think we have caught the exception, and processed it. | 08:28 |
| Qiming | where? | 08:28 |
| eldon_ | https://github.com/openstack/senlin/blob/master/senlin/engine/node.py#254 | 08:30 |
| Qiming | if that is the case, we will not reach line 259, right? | 08:31 |
| eldon_ | yes | 08:32 |
| eldon_ | as I answered yanyan in the review comments | 08:33 |
| Qiming | here is the logic | 08:34 |
| Qiming | if line 253 is throwing an exception that is caught by the 'except' statement on line 254 | 08:35 |
| Qiming | we are already setting the node status to ERROR on line 257, by calling _handle_exception | 08:35 |
| Qiming | the only reason that physical_id is None seems to be some exceptions we failed to catch | 08:36 |
| Qiming | if we can identify that exception, then we can delete line 259-260 | 08:36 |
| eldon_ | yes. | 08:37 |
| Qiming | that is what I'm suggesting | 08:37 |
| eldon_ | sorry, I don't what exceptions I should catch:) | 08:37 |
| Qiming | yep, that is where an investigation is deserved | 08:38 |
| *** Liuqing_ has joined #senlin | 08:39 | |
| *** Liuqing has quit IRC | 08:40 | |
| Qiming | the error is a little bit weird | 08:40 |
| Qiming | if you check this: https://github.com/openstack/senlin/blob/master/senlin/profiles/os/nova/server.py#L388 | 08:40 |
| eldon_ | I think so:) | 08:41 |
| Qiming | we must have got the server object at line 388 | 08:41 |
| eldon_ | And when I create node, we may meet up a lot unexpected exceptions. | 08:41 |
| Qiming | or else, if 'server' is None, we will get an exception on line 388 | 08:41 |
| Qiming | the do_create() method is supposed to return the physical_id which should not be None | 08:42 |
| openstackgerrit | Merged openstack/senlin: Documentation for builtin policies https://review.openstack.org/347630 | 08:42 |
| Qiming | I believe you can find some hints by adding some LOG.error('') lines into the source code to find out the exception types | 08:44 |
| Qiming | to be honest, that is how I am debugging this kind of problems | 08:45 |
| eldon_ | Thanks a lot, Qiming. I will try again:) | 08:50 |
| Qiming | great | 08:50 |
| Qiming | that will be a huge help | 08:50 |
| Qiming | we really want to make sure we are catching all exceptions and getting them handled properly | 08:51 |
| Qiming | or else we are building things on sands ... | 08:51 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Doc for affinity and affinity policy https://review.openstack.org/348180 | 08:54 |
| openstackgerrit | Shan Guo proposed openstack/senlin: Tutorial doc code is out of date https://review.openstack.org/348209 | 10:04 |
| *** Liuqing_ has quit IRC | 10:09 | |
| *** yanyanhu has quit IRC | 10:23 | |
| *** zzxwill has quit IRC | 11:13 | |
| *** Liuqing has joined #senlin | 11:56 | |
| *** Liuqing has quit IRC | 13:51 | |
| *** Liuqing has joined #senlin | 13:52 | |
| *** zzxwill has joined #senlin | 13:54 | |
| *** zzxwill_ has joined #senlin | 13:54 | |
| *** Liuqing has quit IRC | 14:14 | |
| *** Liuqing has joined #senlin | 14:14 | |
| openstackgerrit | Merged openstack/senlin: Tutorial doc code is out of date https://review.openstack.org/348209 | 14:30 |
| *** Liuqing has quit IRC | 15:16 | |
| *** Liuqing has joined #senlin | 15:16 | |
| *** openstackgerrit has quit IRC | 15:18 | |
| *** openstackgerrit has joined #senlin | 15:19 | |
| *** ChanServ sets mode: +v openstackgerrit | 15:19 | |
| *** yuanying_ has joined #senlin | 15:20 | |
| *** yuanying has quit IRC | 15:22 | |
| *** zzxwill has quit IRC | 15:25 | |
| *** zzxwill_ has quit IRC | 15:25 | |
| *** Drago has joined #senlin | 15:30 | |
| *** Drago has joined #senlin | 15:31 | |
| *** Liuqing has quit IRC | 15:50 | |
| *** Drago1 has joined #senlin | 21:31 | |
| *** Drago has quit IRC | 21:33 | |
| *** Drago1 has quit IRC | 21:35 | |
| *** Drago has joined #senlin | 21:35 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!