| *** yuanying has quit IRC | 00:27 | |
| *** yuanying has joined #senlin | 00:27 | |
| *** yanyanhu has joined #senlin | 01:32 | |
| *** Drago has quit IRC | 01:35 | |
| *** bran has quit IRC | 01:57 | |
| *** bran has joined #senlin | 01:59 | |
| *** Drago1 has joined #senlin | 02:02 | |
| *** Drago1 has quit IRC | 02:02 | |
| *** Drago1 has joined #senlin | 02:02 | |
| *** elynn has joined #senlin | 02:03 | |
| *** R_lixh has quit IRC | 02:06 | |
| *** R_lixh has joined #senlin | 02:07 | |
| *** elynn has quit IRC | 02:08 | |
| *** elynn has joined #senlin | 02:08 | |
| *** ChanServ sets mode: +o Qiming | 02:14 | |
| Qiming | service gerritbot status | 02:18 |
|---|---|---|
| *** yuanying has quit IRC | 02:50 | |
| *** yuanying has joined #senlin | 02:52 | |
| *** pleia2 has joined #senlin | 03:11 | |
| *** ChanServ sets mode: +o Qiming | 03:14 | |
| Qiming | op ChanServ | 03:15 |
| *** Drago1 has quit IRC | 03:29 | |
| *** yuanying has quit IRC | 03:33 | |
| *** yuanying has joined #senlin | 03:34 | |
| *** Qiming has left #senlin | 03:45 | |
| *** Qiming has joined #senlin | 03:45 | |
| *** ChanServ sets mode: +o Qiming | 03:56 | |
| *** elynn has quit IRC | 03:57 | |
| *** yuanying has quit IRC | 04:05 | |
| *** yuanying has joined #senlin | 04:07 | |
| *** elynn has joined #senlin | 04:29 | |
| *** elynn has quit IRC | 04:34 | |
| *** elynn has joined #senlin | 04:34 | |
| *** zhenguo_ has joined #senlin | 04:54 | |
| *** haiwei_ has joined #senlin | 05:41 | |
| *** haiwei_ has quit IRC | 05:54 | |
| *** Qiming has left #senlin | 06:40 | |
| *** Qiming has joined #senlin | 06:40 | |
| elynn | Why I can't see any message when a new patchset submitted? | 07:05 |
| Qiming | openstackgerrit is not in the channel | 07:21 |
| Qiming | event when pleia2 had helped checked/restarted that gerritbot, it is still not joining us | 07:22 |
| elynn | We are abandoned by him ┑(￣Д ￣)┍ | 07:25 |
| *** ChanServ sets mode: +o Qiming | 07:56 | |
| *** xuhaiwei has quit IRC | 08:25 | |
| *** shu-mutou-AFK has quit IRC | 08:25 | |
| Qiming | exit | 08:31 |
| *** Qiming has left #senlin | 08:31 | |
| *** Qiming has joined #senlin | 08:31 | |
| Qiming | sigh, tried several ways to get gerrit back | 08:31 |
| Qiming | have to idea how to fix it, have to wait for help from infra team | 08:32 |
| Qiming | elynn, noticed your patch https://review.openstack.org/#/c/326869/ | 08:34 |
| elynn | yes | 08:34 |
| Qiming | maybe we have things overlapped between yours and this one: https://review.openstack.org/#/c/329316/ | 08:34 |
| elynn | Sorry didn't notice your patch. | 08:34 |
| Qiming | np | 08:35 |
| Qiming | can you help check this: https://review.openstack.org/#/c/329316/1/senlin/profiles/base.py | 08:35 |
| elynn | I can abandon mine. | 08:35 |
| Qiming | and see if it makes better sense? | 08:35 |
| Qiming | well ... | 08:35 |
| Qiming | that is not necessary | 08:35 |
| Qiming | what I want to discuss is this | 08:36 |
| elynn | I think you should use NotImplementedError() | 08:36 |
| Qiming | we can have do_create, do_delete to return NotImplementedError | 08:36 |
| Qiming | it is fine | 08:36 |
| Qiming | with and without '()' | 08:36 |
| Qiming | for do_update, and others, we should log a warning | 08:37 |
| Qiming | or else, we are forcing every sub-class to override them, even if they are doing that only to avoid the exception | 08:37 |
| elynn | Okay, only do_create and do_delete return error. Let me check if this patch fix the bug #1590255 | 08:38 |
| openstack | bug 1590255 in senlin "Node recover with not supported operation will get weird result" [Undecided,New] https://launchpad.net/bugs/1590255 | 08:38 |
| Qiming | no, it is not an exact fix for that bug | 08:38 |
| Qiming | if we agree that logging a warning is a better option for do_update, do_check, do_get_details ... etc | 08:39 |
| Qiming | then maybe we should merge the two patches | 08:39 |
| Qiming | I can easily abandon mine | 08:39 |
| Qiming | because the patch contains nothing else | 08:40 |
| elynn | If only log warning, why we return True? is it better return False | 08:40 |
| elynn | ? | 08:40 |
| Qiming | in case that is a mistake | 08:41 |
| Qiming | it is not an error | 08:41 |
| Qiming | if we are returning false, then we'd better raise an exception | 08:42 |
| Qiming | because we are forcing a profile writer to override it | 08:42 |
| elynn | I think it's fine for me, so plugin developer won't need to override all functions. | 08:42 |
| Qiming | ya | 08:43 |
| elynn | I can rebase my patch on yours and fix the bug | 08:43 |
| Qiming | trying to be a little bit nice to developers | 08:43 |
| Qiming | thx | 08:43 |
| *** Qiming is now known as Qiming_afk | 08:43 | |
| *** Qiming_afk is now known as Qiming | 09:06 | |
| *** elynn has quit IRC | 10:09 | |
| *** jdandrea_ has joined #senlin | 10:22 | |
| *** yanyanhu has quit IRC | 10:24 | |
| *** jdandrea has quit IRC | 10:25 | |
| *** fungi has joined #senlin | 12:01 | |
| *** fungi has left #senlin | 12:02 | |
| *** elynn has joined #senlin | 12:56 | |
| *** yanyanhu has joined #senlin | 13:00 | |
| *** elynn has quit IRC | 14:00 | |
| *** yanyanhu has quit IRC | 14:04 | |
| *** Drago has joined #senlin | 15:01 | |
| *** Drago has quit IRC | 15:01 | |
| *** Drago has joined #senlin | 15:02 | |
| *** Drago1 has joined #senlin | 15:39 | |
| *** Drago1 has quit IRC | 15:39 | |
| *** Drago1 has joined #senlin | 15:39 | |
| *** Drago has quit IRC | 15:40 | |
| *** Drago1 has quit IRC | 15:52 | |
| *** Drago has joined #senlin | 16:03 | |
| *** Drago has quit IRC | 17:01 | |
| *** Drago has joined #senlin | 17:02 | |
| *** Drago has quit IRC | 17:02 | |
| *** Drago has joined #senlin | 17:03 | |
| *** Drago has quit IRC | 18:07 | |
| *** Drago has joined #senlin | 18:11 | |
| *** Drago has quit IRC | 18:22 | |
| *** Drago has joined #senlin | 18:23 | |
| *** Drago has quit IRC | 18:23 | |
| *** Drago has joined #senlin | 18:24 | |
| *** Drago has quit IRC | 18:59 | |
| *** Drago has joined #senlin | 18:59 | |
| *** Drago1 has joined #senlin | 19:01 | |
| *** Drago has quit IRC | 19:01 | |
| *** Drago1 has quit IRC | 19:01 | |
| *** Drago has joined #senlin | 19:01 | |
| *** openstackstatus has quit IRC | 22:25 | |
| *** openstack has joined #senlin | 22:29 | |
| *** Drago has quit IRC | 22:46 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!