| *** Qiming_ has quit IRC | 00:14 | |
| openstackgerrit | Merged openstack/senlin-dashboard: Add detach policy in manage-policies forms https://review.openstack.org/285781 | 00:22 |
|---|---|---|
| *** Qiming_ has joined #senlin | 01:14 | |
| *** idonotknow_ has joined #senlin | 01:23 | |
| openstackgerrit | Merged openstack/senlin: Refactor cluster detach policy operation https://review.openstack.org/285801 | 01:32 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Refactor node create operation in cluster action https://review.openstack.org/285862 | 01:42 |
| *** zzxwill has joined #senlin | 01:48 | |
| *** Yanyanhu has joined #senlin | 01:56 | |
| openstackgerrit | Merged openstack/senlin: Refactor cluster update policy operation https://review.openstack.org/285802 | 01:58 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Refactor node update operation in cluster action https://review.openstack.org/285864 | 01:59 |
| *** elynn has joined #senlin | 02:00 | |
| openstackgerrit | Merged openstack/senlin: Remove event logs in lbaas driver https://review.openstack.org/285194 | 02:03 |
| *** elynn has quit IRC | 02:04 | |
| *** elynn has joined #senlin | 02:05 | |
| *** Qiming_ has quit IRC | 02:07 | |
| *** Qiming has joined #senlin | 02:08 | |
| openstackgerrit | Merged openstack/senlin: Enable cluster registry and health check in Health Manager https://review.openstack.org/282299 | 02:11 |
| openstackgerrit | Merged openstack/senlin: Fix cluster status_reason setting when actions failed https://review.openstack.org/285619 | 02:11 |
| openstackgerrit | Merged openstack/senlin: Refactor action create operation https://review.openstack.org/285803 | 02:15 |
| elynn | Morning | 02:16 |
| openstackgerrit | Merged openstack/senlin: Refactor webhook trigger operation https://review.openstack.org/285809 | 02:17 |
| openstackgerrit | Merged openstack/senlin: Refactor node create operation in cluster action https://review.openstack.org/285862 | 02:25 |
| openstackgerrit | Merged openstack/senlin: Refactor node update operation in cluster action https://review.openstack.org/285864 | 02:25 |
| openstackgerrit | Merged openstack/senlin: Remove unused `paramiko` https://review.openstack.org/283690 | 02:35 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Refactor node delete operation in cluster action https://review.openstack.org/285866 | 02:35 |
| *** Yanyanhu has quit IRC | 02:44 | |
| *** Yanyanhu has joined #senlin | 02:45 | |
| Yanyanhu | hi, guys, does senlin-engine works correctly in your env? | 02:46 |
| Yanyanhu | I got an error when starting senlin-engine | 02:47 |
| elynn | Haven't try it, let me have a try. | 02:47 |
| Yanyanhu | which complains context obj doesn't have session property | 02:47 |
| Yanyanhu | elynn, thanks :) | 02:47 |
| elynn | I get this error ... AttributeError: 'dict' object has no attribute 'session' | 02:49 |
| elynn | I get this error AttributeError: 'dict' object has no attribute 'session' | 02:49 |
| Yanyanhu | yes, the same error | 02:49 |
| Yanyanhu | let me check the reason. Guess context is not used correctly in some cases | 02:49 |
| elynn | Cause by this patch ? https://review.openstack.org/#/c/282299/ | 02:54 |
| Yanyanhu | ah, possible | 02:56 |
| lixinhui | elynn, yanyna | 02:56 |
| lixinhui | yes，I may commit into a patch quickly to remove the block then provide fix soon | 02:56 |
| Yanyanhu | lixinhui, thanks a lot :) | 02:57 |
| Yanyanhu | in line 67 | 02:57 |
| Yanyanhu | you may need to convert the context from dict to context obj :) | 02:58 |
| Yanyanhu | or use admin_context I think | 02:59 |
| lixinhui | Okay, Thanks, Yanyan. I will check and tune it son | 03:00 |
| lixinhui | s/son/soon | 03:00 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Refactor add nodes operation in cluster action https://review.openstack.org/285870 | 03:01 |
| openstackgerrit | Di XiaoLi proposed openstack/python-senlinclient: Update OSC metavars https://review.openstack.org/285871 | 03:04 |
| openstackgerrit | Cindia-blue proposed openstack/senlin: Quick Fix to Remove the block when Engine Start https://review.openstack.org/285872 | 03:14 |
| openstackgerrit | Merged openstack/senlin: Quick Fix to Remove the block when Engine Start https://review.openstack.org/285872 | 03:29 |
| *** Yanyanhu has quit IRC | 03:33 | |
| *** Yanyanhu has joined #senlin | 03:33 | |
| *** zzxwill has quit IRC | 03:42 | |
| openstackgerrit | Merged openstack/senlin: Refactor node delete operation in cluster action https://review.openstack.org/285866 | 03:46 |
| openstackgerrit | Merged openstack/senlin: Refactor add nodes operation in cluster action https://review.openstack.org/285870 | 03:50 |
| *** elynn has quit IRC | 03:52 | |
| *** zzxwill has joined #senlin | 03:52 | |
| *** Qiming_ has joined #senlin | 04:35 | |
| *** Qiming has quit IRC | 04:35 | |
| *** zzxwill has quit IRC | 04:36 | |
| *** elynn has joined #senlin | 04:42 | |
| *** elynn has quit IRC | 04:47 | |
| *** elynn has joined #senlin | 04:48 | |
| *** zzxwill has joined #senlin | 05:08 | |
| *** yuanying has quit IRC | 05:24 | |
| *** yuanying_ has joined #senlin | 05:24 | |
| haiwei_ | hi all , back to office now, long time no see | 05:34 |
| Qiming_ | welcome | 05:41 |
| *** sridhar_ram has joined #senlin | 05:42 | |
| *** sridhar_ram has quit IRC | 05:42 | |
| haiwei_ | it seems a lot of jobs have been done in the last week | 05:42 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Refactor cluster recover action https://review.openstack.org/285892 | 05:44 |
| Qiming_ | haiwei_, everything is okay with you? | 05:49 |
| haiwei_ | yes, a little terribel at first, got much better these two days, | 05:51 |
| haiwei_ | and broke out 2 days in advance | 05:51 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Add unit test for cluster check action https://review.openstack.org/285896 | 06:21 |
| Qiming_ | glad to know you are recovering | 06:23 |
| haiwei_ | thanks | 06:23 |
| *** idonotknow__ has joined #senlin | 06:31 | |
| *** idonotknow_ has quit IRC | 06:32 | |
| *** idonotknow__ has left #senlin | 06:35 | |
| *** idonotknow__ has joined #senlin | 06:35 | |
| Qiming_ | hi, need some eyes on this: https://review.openstack.org/#/c/285635/ | 06:46 |
| Qiming_ | the goal is to generalizing it into a generic affinity prolicy since server_group resource is finally supported by sdk | 06:47 |
| Qiming_ | however, the policy is still making use of some DRS specific calls which are not exposed from openstacksdk | 06:47 |
| Qiming_ | if we cannot get such support 'simulated' in certain way, we have to drop DRS support completely | 06:49 |
| Qiming_ | idonotknow__, please help review | 06:49 |
| Qiming_ | thx | 06:49 |
| * Qiming_ going out for starbucks | 06:49 | |
| *** elynn_ has joined #senlin | 06:53 | |
| *** elynn has quit IRC | 06:55 | |
| lixinhui | Qiming_, I just reviewed that. Seems server_group create/get/delete are supported these days | 06:56 |
| lixinhui | what specfic calls your patch can not today? | 06:57 |
| *** Ayush_ has joined #senlin | 07:03 | |
| Yanyanhu | hi, lixinhui, this patch works now https://review.openstack.org/285172 | 07:24 |
| Yanyanhu | I think you can apply it for healthmonitor test in lbaas v2 environemnt | 07:24 |
| lixinhui | Super, thanks, Yanyanhu :) | 07:25 |
| Yanyanhu | the healthmonitor can be created successfully and it will check member using specified method. But I didn't test it using real workload since I don't have a complete test bed in my local env :) | 07:25 |
| Yanyanhu | no problem. If you meet any issue, plz just ping me | 07:25 |
| Yanyanhu | oh, BTW, the path_arg patch is still needed for pool_member created | 07:26 |
| Yanyanhu | it is still hung there at sdk side... | 07:26 |
| lixinhui | Okay, I will keep local sdk for this with the patch and 0.7.4 | 07:27 |
| Qiming_ | lixinhui, by DRS specific calls, I mean the get_hypervisor_by_id() and similar calls | 07:38 |
| lixinhui | ... | 07:39 |
| lixinhui | Bran once have some patch about this | 07:39 |
| Qiming_ | get_hypervisors() is not supported on SDK either | 07:39 |
| lixinhui | I do not know if we can get it into sdk | 07:39 |
| lixinhui | I mean timeline | 07:39 |
| lixinhui | I can keep work on that | 07:39 |
| Qiming_ | without those patches landed somewhere, we won't get the policy working | 07:40 |
| lixinhui | I see | 07:43 |
| lixinhui | Just forgot this thing | 07:43 |
| lixinhui | I will check Byane's comments on that patch then return to you | 07:43 |
| Qiming_ | ok | 07:54 |
| Qiming_ | dixiaoli, there? | 07:59 |
| dixiaoli | yes | 07:59 |
| Qiming_ | just trying the osc plugin, it works great! | 08:00 |
| Qiming_ | got a question regarding the object show command | 08:00 |
| Qiming_ | openstack cluster node show 4b5 | 08:00 |
| Qiming_ | +---------------+--------------------------------------+ | 08:00 |
| Qiming_ | | Field | Value | | 08:00 |
| Qiming_ | +---------------+--------------------------------------+ | 08:00 |
| Qiming_ | | status | ACTIVE | | 08:00 |
| Qiming_ | | domain | None | | 08:00 |
| Qiming_ | | tags | {} | | 08:00 |
| Qiming_ | | profile_id | 22ec1344-dc3e-44b9-8713-469ca9fd9fac | | 08:00 |
| Qiming_ | | updated_at | None | | 08:00 |
| Qiming_ | | profile_name | pstack | | 08:00 |
| Qiming_ | | cluster_id | cc39fc17-df6f-46eb-a6ca-8e84bca3c632 | | 08:00 |
| Qiming_ | | user | 5e5bf8027826429c96af157f68dc9072 | | 08:00 |
| Qiming_ | | physical_id | 7845e8da-81a8-4ca5-b644-0fc348ba3a86 | | 08:00 |
| Qiming_ | | status_reason | Creation succeeded | | 08:00 |
| Qiming_ | | id | 4b578c22-fd50-481f-8947-543ea907f028 | | 08:00 |
| Qiming_ | | index | 1 | | 08:00 |
| Qiming_ | | name | node-cc39fc17-001 | | 08:01 |
| Qiming_ | | data | {} | | 08:01 |
| Qiming_ | | created_at | 2016-02-28T10:01:08 | | 08:01 |
| Qiming_ | | project | 42d9e9663331431f97b75e25136307ff | | 08:01 |
| Qiming_ | | init_at | 2016-02-28T10:01:05 | | 08:01 |
| Qiming_ | | role | | | 08:01 |
| Qiming_ | | metadata | {} | | 08:01 |
| Qiming_ | +---------------+--------------------------------------+ | 08:01 |
| Qiming_ | I'm seeing that the Field column is not ordered | 08:01 |
| dixiaoli | Qiming_, let me have a try | 08:03 |
| Qiming_ | okay | 08:03 |
| *** idonotknow_ has joined #senlin | 08:12 | |
| *** lixinhui_ has joined #senlin | 08:13 | |
| *** idonotknow__ has quit IRC | 08:14 | |
| dixiaoli | Qiming_, yes,it is my mistake. | 08:15 |
| dixiaoli | Use "return zip(*sorted(six.iteritems(node)))" in _show_node will return the sorted columns. | 08:16 |
| Qiming_ | dixiaoli, not a mistake, just something we can improve | 08:16 |
| Qiming_ | will that induce a lot overhead? | 08:16 |
| lixinhui_ | Qiming, Yanyanhu | 08:16 |
| dixiaoli | Qiming_, okay, will update it | 08:16 |
| lixinhui_ | I got this error with context | 08:16 |
| lixinhui_ | http://paste.openstack.org/show/488506/ | 08:16 |
| lixinhui_ | Qiming_ | 08:17 |
| Yanyanhu | yes | 08:17 |
| lixinhui_ | I once asked tis question before | 08:17 |
| Yanyanhu | need a patch here | 08:17 |
| Yanyanhu | just as we discussed this morning | 08:17 |
| lixinhui_ | what is the proper way to get context at the very beginning | 08:17 |
| lixinhui_ | of service creation | 08:17 |
| lixinhui_ | Okay, Yanyanhu | 08:18 |
| lixinhui_ | admin_context? | 08:18 |
| Yanyanhu | hmm, I think maybe we should build a context of the owner of cluster | 08:18 |
| Yanyanhu | for this health check | 08:18 |
| Qiming_ | dixiaoli, I just tried 'columns = sorted(list(six.iterkeys(cluster))) | 08:18 |
| Qiming_ | ' | 08:18 |
| Yanyanhu | let me think about it | 08:18 |
| Qiming_ | dixiaoli, event this 'columns = sorted(six.iterkeys(cluster))' works for me | 08:19 |
| Yanyanhu | the simplest way is using admin context | 08:19 |
| lixinhui_ | Okay, I will try this | 08:20 |
| Yanyanhu | oh, maybe we should use the context of the health policy owner | 08:20 |
| Yanyanhu | since he/she is the one that make senlin check cluster status periodically | 08:20 |
| Qiming_ | cannot read the pasted content | 08:21 |
| Yanyanhu | lixinhui_, I think you can try that context :) | 08:21 |
| lixinhui_ | :) | 08:21 |
| Qiming_ | an exception thrown in health_manager.py ? | 08:22 |
| Qiming_ | line 135, when registering cluster? | 08:22 |
| Qiming_ | which version of code ? | 08:22 |
| Yanyanhu | Qiming_, not at the time registering | 08:22 |
| Yanyanhu | the context used in health_manager.py is actually a dict | 08:23 |
| Yanyanhu | not context obj | 08:23 |
| Qiming_ | the contexts says this: File "/opt/stack/senlin/senlin/engine/health_manager.py", line 135, in register_cluster\n | 08:23 |
| Yanyanhu | so db api complains no session attribute in context | 08:23 |
| Qiming_ | I'm not seeing the code line 135 in this way ... | 08:23 |
| Yanyanhu | oh, right, my mistake | 08:23 |
| dixiaoli | Qiming_, good. we need sort the columns.I will submit a patch to update it. | 08:23 |
| Yanyanhu | it happened in that case as well | 08:23 |
| Qiming_ | yes, you are right, it seems the context was not correctly intializied | 08:24 |
| Qiming_ | but without looking at the source code, tihs log is not helpful at all | 08:25 |
| Yanyanhu | Qiming_, yes, that's right | 08:25 |
| Yanyanhu | this should be an internal error I think | 08:25 |
| Yanyanhu | I mean not a user-faced error, just a bug of service | 08:26 |
| Qiming_ | my line 135 of health_manager is this: | 08:27 |
| Qiming_ | 135 def unregister_cluster(self, cluster_id): | 08:27 |
| Yanyanhu | me too | 08:28 |
| Qiming_ | okay, this line is wrong | 08:28 |
| Qiming_ | http://git.openstack.org/cgit/openstack/senlin/tree/senlin/engine/health_manager.py#n128 | 08:29 |
| Qiming_ | it is abusing the return value from get_service_context() | 08:29 |
| Qiming_ | get_service_context() returns a dict, not a RequestContext object | 08:29 |
| Yanyanhu | yes | 08:29 |
| lixinhui_ | I have change it by enlin_context.RequestContext.from_dict(params) | 08:30 |
| lixinhui_ | Them DBError 'RequestContext' object has no attribute 'translate' | 08:31 |
| lixinhui_ | Then DBError 'RequestContext' object has no attribute 'translate' | 08:31 |
| lixinhui_ | I am trying with ctx = senlin_context.get_admin_context() | 08:32 |
| Yanyanhu | admin context is ok I think | 08:32 |
| Qiming_ | http://git.openstack.org/cgit/openstack/senlin/tree/senlin/engine/health_manager.py#n28 | 08:33 |
| Qiming_ | that is something we need to clean as well | 08:33 |
| Qiming_ | we are importing context twice | 08:33 |
| Yanyanhu | sight | 08:33 |
| Yanyanhu | sigh | 08:33 |
| lixinhui_ | Clean it | 08:35 |
| lixinhui_ | cleaned it | 08:35 |
| *** lixinhui_ has quit IRC | 08:37 | |
| openstackgerrit | Di XiaoLi proposed openstack/python-senlinclient: Sort resource show columns https://review.openstack.org/285939 | 08:44 |
| Qiming_ | lixinhui, reformated your trace log | 08:54 |
| Qiming_ | it looks like your environment setting has triggered some language specific unicode handling logic | 08:54 |
| Qiming_ | I have never met that before | 08:54 |
| lixinhui | cool | 08:57 |
| lixinhui | Today, who vmware office is super slow | 08:57 |
| Qiming_ | it could be cause by this ... | 08:58 |
| lixinhui | vmware network condition is very slow | 08:58 |
| Qiming_ | http://git.openstack.org/cgit/openstack/senlin/tree/senlin/db/sqlalchemy/api.py#n1238 | 08:58 |
| Qiming_ | don't understand why are we not using session directly there ... | 08:59 |
| Yanyanhu | lixinhui, our wifi is broken for the whole day :) | 08:59 |
| Yanyanhu | not much better | 09:00 |
| lixinhui | I think admin_conext work well | 09:00 |
| lixinhui | will check it again | 09:00 |
| lixinhui | feel better, Yanyanhu | 09:00 |
| lixinhui | Qiming_, I will rebuilt the env and find why | 09:01 |
| openstackgerrit | Merged openstack/senlin: Documentation for deletion policy https://review.openstack.org/283558 | 09:04 |
| Qiming_ | lixinhui, there are something not correct in the db api | 09:07 |
| lixinhui | oh? | 09:09 |
| lixinhui | after change to admin_context, start, attach and detach works now | 09:10 |
| lixinhui | but need full tests by this time | 09:11 |
| Qiming_ | it is not about which context | 09:11 |
| *** Yanyanhu has quit IRC | 09:12 | |
| lixinhui | go ahead | 09:15 |
| *** zzxwill has quit IRC | 09:18 | |
| openstackgerrit | Merged openstack/python-senlinclient: Update OSC metavars https://review.openstack.org/285871 | 09:30 |
| openstackgerrit | Merged openstack/senlin: Revise vSphere DRS policy https://review.openstack.org/285635 | 09:31 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Refactor cluster recover action https://review.openstack.org/285892 | 09:39 |
| *** elynn_ has quit IRC | 09:49 | |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Refactor cluster recover action https://review.openstack.org/285892 | 09:50 |
| Qiming_ | this is insane | 09:51 |
| Qiming_ | cannot trigger ci at all: https://review.openstack.org/#/c/285892/ | 09:51 |
| Qiming_ | the code was submitted 4 hours ago | 09:51 |
| *** Qiming_ has quit IRC | 10:20 | |
| *** zzxwill has joined #senlin | 10:46 | |
| *** idonotknow_ has quit IRC | 10:59 | |
| *** Qiming has joined #senlin | 11:16 | |
| *** Ayush_ has quit IRC | 11:24 | |
| *** zzxwill has quit IRC | 11:27 | |
| *** elynn_ has joined #senlin | 11:55 | |
| *** elynn_ has quit IRC | 12:00 | |
| -openstackstatus- NOTICE: Infra currently has a long backlog. Please be patient and where possible avoid rechecks while it catches up. | 12:07 | |
| lixinhui | Qiming, I found the inccorrect with db | 13:27 |
| lixinhui | I am preparing the patch | 13:27 |
| lixinhui | actually that is caused by illegal format | 13:28 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Optimize the registry claim function https://review.openstack.org/286043 | 13:35 |
| Qiming | what format? | 13:35 |
| Qiming | you are always talking about something without giving me any context, !!! | 13:35 |
| *** zzxwill has joined #senlin | 13:41 | |
| lixinhui | Qiming, about this problem http://paste.openstack.org/show/488557/ | 13:48 |
| Qiming | okay, I know that is a problem | 13:50 |
| Qiming | you were talking about something's format is wrong | 13:50 |
| Qiming | but I have no idea what you are referring to | 13:51 |
| lixinhui | Sign | 13:51 |
| *** elynn has joined #senlin | 13:51 | |
| lixinhui | Just a fake alarm | 13:51 |
| lixinhui | I once think the root cause for this is wrong format by augments so the expecption is thown out | 13:52 |
| lixinhui | but find it will happend since the first time to use the DB | 13:52 |
| lixinhui | in health_manager | 13:52 |
| Qiming | okay | 13:54 |
| Qiming | my belief is that I don't trust any test cases | 13:55 |
| Qiming | I trust the code itself | 13:55 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Fix various problems in health manager https://review.openstack.org/286058 | 14:00 |
| Qiming | lixinhui, ^ | 14:01 |
| Qiming | partial fix | 14:01 |
| Qiming | still reading the code | 14:01 |
| elynn | Hi Qiming | 14:02 |
| Qiming | yes, elynn | 14:02 |
| elynn | about https://review.openstack.org/#/c/283472 | 14:03 |
| elynn | I'm thinking about fixing it in senlin side. | 14:03 |
| Qiming | okay? | 14:03 |
| Qiming | not quite sure I understand your intent | 14:04 |
| elynn | oh, I update the bug description. | 14:05 |
| Qiming | the proposal looks interesting at first sight | 14:05 |
| Qiming | get_file function is poison | 14:06 |
| elynn | yes, but can't get rid of it ... | 14:06 |
| Qiming | since heat already provides a get_file function | 14:07 |
| Qiming | whey don't we try get it dirtier? | 14:07 |
| Qiming | get_file: today accepts a filename | 14:07 |
| Qiming | it can be improved to accept an optional parameter, e.g. 'type' | 14:08 |
| Qiming | which defaults to 'raw' | 14:08 |
| Qiming | that means the file content will be dumped into the template directly | 14:08 |
| Qiming | you can have 'type' set to 'yaml' | 14:09 |
| Qiming | then you will treat the file as a YAML source and dump the content there as a dict | 14:09 |
| Qiming | 'str_json', as a new function, doesn't look very appealing, to be honest | 14:09 |
| elynn | Hmm, Interesting point. | 14:10 |
| elynn | I'm not so sure I can convince community to make a change to get_file... | 14:11 |
| Qiming | users won't like one more function which is not very frequently used | 14:11 |
| Qiming | actually, it promotes better template composibility | 14:11 |
| Qiming | what do you think | 14:11 |
| Qiming | you can have snippets scattered here and there | 14:11 |
| Qiming | then in a master template, you can combine them together into a working template | 14:12 |
| Qiming | who would hate that? :) | 14:12 |
| Qiming | before proposing that, you can discuss with shardy and see if he has a better idea, regarding str_replace | 14:13 |
| elynn | Qiming, yes, seems modify get_file could do that. | 14:13 |
| elynn | Qiming, yes, I will. If propose it, I think it will only get merged in next release... | 14:14 |
| elynn | just ping shardy, seems he is not available now. Still not figure out how to use str_replace. | 14:14 |
| Qiming | okay | 14:16 |
| elynn | I'm thinking about changing https://github.com/openstack/senlin/blob/master/senlin/profiles/os/heat/stack.py#L49-L53 to string as a workaround? | 14:16 |
| Qiming | well it could be | 14:18 |
| Qiming | I'm thinking of a different format: | 14:18 |
| Qiming | for example | 14:18 |
| Qiming | heat_template_1: &TEMPLATE1 | 14:18 |
| Qiming | heat_template_version: 2013-05-23 | 14:18 |
| Qiming | resources: | 14:18 |
| Qiming | ran: | 14:18 |
| Qiming | type: OS::Heat::RandomString | 14:18 |
| Qiming | type: os.heat.stack | 14:18 |
| Qiming | version: 1.0 | 14:18 |
| Qiming | properties: | 14:18 |
| *** Qiming has quit IRC | 14:19 | |
| *** Qiming has joined #senlin | 14:19 | |
| Qiming | this is effectly laying out the heat raw template side by side with senlin profile content | 14:20 |
| elynn | welcome back Qiming | 14:20 |
| elynn | what do you mean &TEMPLATE1 ? | 14:21 |
| Qiming | it is builtin cross-reference supported by YAML | 14:21 |
| elynn | like alias? | 14:22 |
| Qiming | &SOMETHING defines a location | 14:22 |
| Qiming | *SOMETHING references that content | 14:22 |
| Qiming | after the yaml is parsed, you can reference the template content via data['properties']['template'] as if the content is there | 14:23 |
| elynn | Seems still need to put template content into the same yaml file? | 14:24 |
| Qiming | yep | 14:27 |
| Qiming | but the readability is greatly improved | 14:27 |
| Qiming | the philosophy of putting all data into a single file is for ease of version control | 14:28 |
| Qiming | we don't separate parameters, environment, template into many files | 14:28 |
| Qiming | when one or two files changed | 14:28 |
| Qiming | we don't know we are creating the same thing as before | 14:28 |
| Qiming | heat was getting into a big trouble because of this | 14:29 |
| Qiming | all things were scattered everywhere | 14:29 |
| Qiming | convergence is really a headache | 14:29 |
| Qiming | however, a different philosophy is to separate things into many composable units | 14:30 |
| Qiming | then you will need a good version control system to manage those pieces | 14:30 |
| elynn | I'm would like the later separate things philosophy :) it will make things easy to compose. | 14:31 |
| elynn | Let me think about it tomorrow, need to try the ways you said and find a better one. | 14:32 |
| Qiming | okay | 14:32 |
| Qiming | the "senlin way" is way too restrictive | 14:32 |
| Qiming | we can become a little bit "open" in future | 14:33 |
| Qiming | but if we start very "open" today, we won't get a chance to become "restrictive" | 14:33 |
| *** lixinhui_ has joined #senlin | 14:34 | |
| elynn | you always have so many solutions in your mind :) it's enlighten to chat with you. | 14:35 |
| Qiming | ... | 14:35 |
| elynn | ;) | 14:36 |
| *** elynn has quit IRC | 14:38 | |
| Qiming | gate is terrible today | 14:38 |
| *** lixinhui_ has quit IRC | 14:41 | |
| *** lixinhui_ has joined #senlin | 14:45 | |
| openstackgerrit | Merged openstack/senlin: Refactor cluster recover action https://review.openstack.org/285892 | 15:37 |
| *** zzxwill has quit IRC | 15:43 | |
| *** Qiming has quit IRC | 15:52 | |
| *** lixinhui_ has quit IRC | 16:18 | |
| *** openstackgerrit has quit IRC | 17:18 | |
| *** openstackgerrit has joined #senlin | 17:19 | |
| openstackgerrit | Merged openstack/senlin: Fix various problems in health manager https://review.openstack.org/286058 | 18:05 |
| *** Qiming has joined #senlin | 23:30 | |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Add unit test for cluster check action https://review.openstack.org/285896 | 23:35 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!