| xuhaiwei | Qiming, didn't see your messages yesterday, I will think about the patch | 00:25 |
|---|---|---|
| *** Qiming has quit IRC | 00:27 | |
| *** Liuqing has joined #senlin | 01:09 | |
| *** Yanyanhu has joined #senlin | 01:11 | |
| *** dixiaoli has quit IRC | 01:21 | |
| *** Qiming has joined #senlin | 01:22 | |
| *** Yanyan has joined #senlin | 01:27 | |
| *** Yanyanhu has quit IRC | 01:30 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/senlin: Updated from global requirements https://review.openstack.org/273302 | 01:32 |
| *** elynn has joined #senlin | 02:11 | |
| *** lixinhui_ has joined #senlin | 02:14 | |
| *** elynn_ has joined #senlin | 02:17 | |
| *** elynn has quit IRC | 02:18 | |
| *** lixinhui_ has quit IRC | 02:20 | |
| *** dixiaoli has joined #senlin | 02:21 | |
| *** cschulz_ has quit IRC | 02:21 | |
| *** lixinhui_ has joined #senlin | 02:22 | |
| *** lixinhui_ has quit IRC | 02:22 | |
| openstackgerrit | Merged openstack/senlin: Updated from global requirements https://review.openstack.org/273302 | 02:25 |
| *** elynn_ has quit IRC | 02:27 | |
| openstackgerrit | Merged openstack/senlin: Improve size parameter checking function https://review.openstack.org/272963 | 02:28 |
| openstackgerrit | Merged openstack/senlin: Make node-delete return an action ID https://review.openstack.org/272947 | 02:42 |
| *** elynn has joined #senlin | 02:47 | |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Fix DB concurrency problem https://review.openstack.org/273319 | 02:48 |
| Qiming | hi guys | 02:48 |
| Qiming | please help review 273319 above | 02:48 |
| Qiming | I believe we are experiencing some inconsistency problems again, reported by some colleages in IBM | 02:49 |
| Yanyan | ok | 02:49 |
| Yanyan | will check it | 02:49 |
| Qiming | there might be some performance hurts | 02:49 |
| Yanyan | any bug report on it? | 02:49 |
| Qiming | but the correctness always has a higher priority than that | 02:49 |
| Yanyan | Qiming, that's for sure | 02:50 |
| Yanyan | Qiming, actually xujun also asked me the question that how we ensure the consistency when acquiring lock of cluster | 02:51 |
| Yanyan | my answer is it relies on the transaction supported by db | 02:52 |
| Qiming | it is still annoying | 02:52 |
| Yanyan | looks like we still need more attention on this issue | 02:52 |
| Qiming | I'm guessing that oslo.db has a better model on this | 02:52 |
| Yanyan | yes... | 02:53 |
| elynn | Maybe... | 02:53 |
| Yanyan | hope so, since it's their duty I believe | 02:53 |
| Qiming | mistral already complained about this, and they have come up with their own transaction manager | 02:53 |
| Qiming | but the transaction manager is fragile also, just saw some complaints on mailinglist | 02:53 |
| Qiming | Currently we are still using EngineFascade, which has been renamed to LegacyEngineFacade internally in oslo.db | 02:54 |
| Yanyan | do need spend sometime on oslo.db | 02:54 |
| Qiming | yep | 02:55 |
| Yanyan | to learn its latest support | 02:55 |
| Qiming | it is about the stability of our engine | 02:55 |
| Yanyan | yes, we have to address this issue in Mitaka I think | 02:55 |
| Qiming | agreed | 02:55 |
| Yanyan | will spend sometime on it. Maybe we can leave a workitem in etherpad | 02:56 |
| Yanyan | leave for while, talk later | 02:56 |
| Qiming | ok | 02:56 |
| *** dixiaoli_ has joined #senlin | 03:09 | |
| *** elynn has quit IRC | 03:11 | |
| *** dixiaoli has quit IRC | 03:12 | |
| *** elynn has joined #senlin | 03:13 | |
| *** elynn has quit IRC | 03:18 | |
| *** elynn has joined #senlin | 03:18 | |
| Qiming | elynn | 03:33 |
| elynn | Hi Qiming | 03:34 |
| Qiming | the service DB APIs are new inventions | 03:34 |
| Qiming | they are not carrying context as parameters | 03:34 |
| Qiming | each time it is getting a new db session | 03:34 |
| Qiming | so it is blocking the change related to db concurrency fix | 03:34 |
| Qiming | I'm working on that | 03:34 |
| elynn | So In the future, new db api always accept a ctx as parameters? | 03:35 |
| elynn | Just for convenience , I didn't pass ctx as a parameters. | 03:36 |
| Qiming | it is breaking our assumptions about DB | 03:36 |
| elynn | Do you need any help? | 03:36 |
| Qiming | I'm fine | 03:37 |
| Qiming | almost complete | 03:37 |
| elynn | Not very familiar with db, sorry about that. | 03:39 |
| Qiming | okay | 03:40 |
| *** bdrich has joined #senlin | 03:55 | |
| openstackgerrit | Ethan Lynn proposed openstack/senlin: Don't set verbose in default group https://review.openstack.org/273333 | 04:05 |
| *** gongysh has joined #senlin | 04:10 | |
| *** elynn_ has joined #senlin | 04:15 | |
| *** elynn has quit IRC | 04:17 | |
| *** Liuqing has quit IRC | 04:20 | |
| *** Liuqing has joined #senlin | 04:21 | |
| *** elynn__ has joined #senlin | 04:22 | |
| *** elynn_ has quit IRC | 04:24 | |
| *** bdrich has quit IRC | 04:24 | |
| *** bdrich has joined #senlin | 04:25 | |
| *** xuhaiwei has quit IRC | 04:26 | |
| *** xuhaiwei has joined #senlin | 04:26 | |
| *** elynn__ has quit IRC | 04:32 | |
| *** elynn__ has joined #senlin | 05:09 | |
| *** elynn__ has quit IRC | 05:13 | |
| *** elynn has joined #senlin | 05:13 | |
| xuhaiwei | hi, Qiming, want to discuss about the action status and cluster status | 05:33 |
| xuhaiwei | when creating a cluster, if the action status is in [CANCEL, TIMEOUT, ERROR], the cluster will be set to ERROR status, but when updating a cluster, if action status is not OK, cluster will be set to WARNING status | 05:35 |
| zigo | Is version 0.1.0 of senlin-dashboard ready to be packaged in Debian? | 05:42 |
| xuhaiwei | zigo, I think it is in pypi now | 05:46 |
| zigo | xuhaiwei: I don't use PyPi tarballs, I generate an orig.tar.xz using git archive. :) | 05:47 |
| zigo | I'm working on senlin-dashboard right now. | 05:47 |
| zigo | It should be ready in a bit. | 05:47 |
| openstackgerrit | Merged openstack/senlin: Don't set verbose in default group https://review.openstack.org/273333 | 05:48 |
| zigo | xuhaiwei: There's no "enabled" folder in senlin-dashboard, it'd be nice to have one, and not ask anyone to edit local_settings.py | 05:49 |
| zigo | (which is always a pain) | 05:49 |
| Qiming | Liuqing, please help confirm? | 05:49 |
| zigo | Could this be fixed? | 05:49 |
| zigo | Oh, saw it ... | 05:50 |
| zigo | The README.rst talks about a _50_senlin.py file, though I can't find it anywhere. | 05:51 |
| zigo | Am I missing something? | 05:51 |
| zigo | Liuqing: ^ | 05:51 |
| openstackgerrit | Merged openstack/senlin: Fix cluster_create function https://review.openstack.org/272985 | 05:54 |
| zigo | Hey, who's from 99Cloud, who's from Huawei over here? | 05:59 |
| zigo | I may know some of you, and didn't even notice! 囧 | 05:59 |
| zigo | I just did when writing debian/copyright ... | 05:59 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Fix service DB API https://review.openstack.org/273319 | 06:00 |
| Qiming | Liuqing is from 99cloud | 06:00 |
| Qiming | zhenguo is from Huawei | 06:00 |
| zigo | Qiming: And yourself? | 06:01 |
| Qiming | zigo, I'm with IBM | 06:01 |
| zigo | Liuqing: So, you're in 上海 then, right? | 06:01 |
| Qiming | Liuqing is from Wuxi (无锡) I guess | 06:01 |
| zigo | Liuqing: Maybe we can meet when I'm there after new year. | 06:01 |
| zigo | Oh... | 06:02 |
| zigo | I thought 99Cloud was only in Shanghai. | 06:02 |
| zigo | M. 张 is a friend. | 06:02 |
| Qiming | :) | 06:03 |
| zigo | Qiming: If you're with IBM, I guess you're in Beijing, right? | 06:04 |
| Qiming | yes, zigo | 06:05 |
| openstackgerrit | Merged openstack/senlin: Fix cluster-resize parameter checking https://review.openstack.org/272998 | 06:09 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Fix service DB API https://review.openstack.org/273319 | 06:14 |
| *** bdrich has quit IRC | 06:15 | |
| *** Yanyan has quit IRC | 06:19 | |
| *** Yanyan has joined #senlin | 06:19 | |
| Liuqing | zigo, and you? | 06:20 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Fix DB coherency problem (again) https://review.openstack.org/273349 | 06:21 |
| *** gongysh has quit IRC | 06:22 | |
| Qiming | eyes needed on 273319 please | 06:23 |
| Qiming | elynn, please see if it makes senses | 06:23 |
| elynn | Hi Qiming , I saw your patch | 06:24 |
| elynn | Just curious, lock api doesn't use context parameters, why they pass the tests? | 06:24 |
| Qiming | not sure | 06:26 |
| Qiming | we never get bandwidth to migrate from context to db_session | 06:26 |
| Qiming | that will help us get a better idea about the db session thing | 06:27 |
| elynn | Hi Qiming, these 2 codes needs fix too. https://github.com/openstack/senlin/blob/master/senlin/cmd/manage.py#L66 and https://github.com/openstack/senlin/blob/master/senlin/cmd/manage.py#L87 | 06:32 |
| Qiming | elynn, can you help? | 06:33 |
| Qiming | maybe as a dependent patch? | 06:33 |
| Qiming | I'm laying another patch over this one already | 06:34 |
| Qiming | I mean the DB coherency one | 06:34 |
| elynn | I got error from senlin engine: Service 94341336-faf3-488c-8526-28ba37e8f05c update failed: 'NoneType' object has no attribute 'update' | 06:35 |
| Qiming | what ? | 06:35 |
| Qiming | what context ? | 06:36 |
| elynn | in service update | 06:36 |
| elynn | if values is None: values = {} | 06:36 |
| elynn | you remove it. | 06:36 |
| elynn | so values.update will raise error. | 06:36 |
| Qiming | I replaced it | 06:36 |
| Qiming | which patch are you talking about? | 06:37 |
| Qiming | I'm switching between so many patches | 06:37 |
| elynn | https://review.openstack.org/#/c/273319/3/senlin/db/sqlalchemy/api.py | 06:37 |
| elynn | L1200 | 06:37 |
| elynn | L1199 | 06:37 |
| Qiming | what's the difference? | 06:38 |
| elynn | values is None now, and values.update raise error | 06:38 |
| Qiming | oh, shit | 06:38 |
| elynn | unit tests doesn't cover it , my bad... | 06:39 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Fix service DB API https://review.openstack.org/273319 | 06:40 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Fix service DB API https://review.openstack.org/273319 | 06:42 |
| Qiming | Yanyan, I'm proposing another patch for 237074 | 06:52 |
| openstackgerrit | Merged openstack/senlin: Add size checking for cluster scaling https://review.openstack.org/273074 | 06:53 |
| Yanyan | ok, cool | 06:53 |
| Yanyan | will check it | 06:53 |
| Qiming | oh no | 06:53 |
| Qiming | it is merged ... | 06:53 |
| Yanyan | ah... | 06:53 |
| Yanyan | yes, just workflow +1 | 06:53 |
| Qiming | okay, will propose a new patch for this | 06:53 |
| Yanyan | maybe a patch :) | 06:53 |
| Yanyan | yep | 06:53 |
| *** junxu has joined #senlin | 06:53 | |
| Yanyan | a new patch | 06:53 |
| openstackgerrit | Merged openstack/senlin: Fix service DB API https://review.openstack.org/273319 | 06:58 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Fix DB coherency problem (again) https://review.openstack.org/273349 | 07:05 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Fix DB coherency problem (again) https://review.openstack.org/273349 | 07:20 |
| *** junxu has quit IRC | 07:23 | |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Fix cluster resize service call https://review.openstack.org/273365 | 07:25 |
| Qiming | Yanyan, ^ 273365 is an attempt to fix the problem about resize operation | 07:25 |
| *** junxu has joined #senlin | 07:25 | |
| Yanyan | got it | 07:26 |
| Qiming | It is about handling the case where you only specify min_size and/or max_size | 07:26 |
| Yanyan | ok | 07:26 |
| Qiming | will add test cases for cluster_resize ... | 07:26 |
| Qiming | cannot believe my eyes | 07:26 |
| Qiming | we don't have unit test for cluster_resize ... | 07:26 |
| Yanyan | no problem. Just that use case is unusual | 07:27 |
| Yanyan | really? | 07:27 |
| Qiming | you can help double check | 07:27 |
| Qiming | really unbelievable | 07:27 |
| Yanyan | ok, will check it and add it if that's true... | 07:28 |
| Qiming | I'm working on the unit tests | 07:28 |
| Yanyan | ok | 07:28 |
| Yanyan | hi, Qiming, just quick look at it and found unit test for cluster_resize action is there | 07:29 |
| Qiming | cluster_resize action ? | 07:29 |
| Qiming | I mean the cluster_resize() function in engine/service | 07:29 |
| Yanyan | yes, found several cases for do_resize method | 07:29 |
| Yanyan | oh | 07:29 |
| Yanyan | ah, that's true... | 07:30 |
| Qiming | em | 07:30 |
| *** junxu has quit IRC | 07:58 | |
| xuhaiwei | Hi I have a question about senlin node metadata | 08:18 |
| xuhaiwei | how is metadata used? it seems node's metadata has no relationship with nova instance's metadata | 08:19 |
| openstackgerrit | Yanyan Hu proposed openstack/senlin: Support property update for os.heat.stack profile https://review.openstack.org/273385 | 08:24 |
| Qiming | senlin node metadata is currently not sent to the profile layer, xuhaiwei | 08:27 |
| Qiming | That is something we can improve if you have a use case | 08:27 |
| *** dixiaoli has joined #senlin | 08:35 | |
| *** dixiaoli_ has quit IRC | 08:35 | |
| openstackgerrit | Merged openstack/senlin: Fix DB coherency problem (again) https://review.openstack.org/273349 | 08:37 |
| xuhaiwei | Qiming, I just noticed that when leaving a node, metadata is fetch from nova instance, since this metadata has no relationship with node's metadata, why should we get it? and it should be always {} | 08:38 |
| xuhaiwei | s/when leaving a node/when leaving a node from a cluster/ | 08:39 |
| xuhaiwei | Yanyan, any idea about this? | 08:42 |
| Yanyan | hi, xuhaiwei, node's metadata will not be {} if it belongs to a cluster | 08:43 |
| Yanyan | cluster information will be injected when nova server was created | 08:43 |
| Yanyan | let me find the code | 08:43 |
| xuhaiwei | Yanyan, I mean nova instance's metadata is always {}, see this https://github.com/openstack/senlin/blob/master/senlin/profiles/os/nova/server.py#L686 | 08:45 |
| xuhaiwei | because if you don't put anything into instance's metadata when boot it, it will be blank | 08:46 |
| Yanyan | hmm, my fault, it is {} by default http://git.openstack.org/cgit/openstack/senlin/tree/senlin/engine/actions/cluster_action.py#n122 | 08:46 |
| Yanyan | hi, xuhaiwei, that's two thing I think | 08:47 |
| xuhaiwei | yes, senlin node metadata and nova instance metadata is different | 08:47 |
| Yanyan | right | 08:48 |
| xuhaiwei | I am curious why should we fetch nova instance's metadata when leaving a node from a cluster | 08:48 |
| Yanyan | ah, actually we hope cluster info should be there after node is created | 08:48 |
| Qiming | xuhaiwei, when a join a node to a cluster, we modify the metadata of the nova server | 08:48 |
| Yanyan | so we just partially implemented it | 08:49 |
| Qiming | when you are doing autoscaling or some other monitoring stuff | 08:49 |
| Qiming | you will need to tell which cluster a nova server belongs to | 08:49 |
| Qiming | or else you won't be able to calculate, say, the average CPU utilization across a cluster | 08:49 |
| xuhaiwei | ok, thanks , that makes sense | 08:50 |
| Yanyan | xuhaiwei, this is also what heat is doing in its asg resource :) | 08:50 |
| xuhaiwei | got it | 08:50 |
| Yanyan | to let ceilometer know how to make evaluation based on metering data of VMs | 08:51 |
| Yanyan | hi, Qiming, if it's ok, lets merge this patch https://review.openstack.org/273365 | 08:51 |
| Yanyan | it works. And need it for functional test rework | 08:52 |
| Qiming | yes, Yanyan | 08:57 |
| Qiming | functional tests need to be revised after this patch because engine is doing a little bit more stricter checking now | 08:57 |
| Yanyan | yes | 08:58 |
| Yanyan | will add 400 status_code to acceptable status list | 08:58 |
| Qiming | yep | 08:59 |
| Qiming | you know what | 08:59 |
| Qiming | currently the functional tests are only testing the normal behavior | 08:59 |
| Yanyan | right :) | 09:00 |
| Yanyan | it doesn't cover exceptional cases | 09:00 |
| Qiming | we are never testing how the service/api behaves under bad parameters | 09:00 |
| Yanyan | yes | 09:00 |
| Yanyan | need to add it | 09:01 |
| Qiming | actually, we touched this topic briefly during midcycle meetup | 09:01 |
| Qiming | we may need to think of a tempest test bundle | 09:01 |
| Yanyan | yes | 09:01 |
| Qiming | which performs api surface tests | 09:01 |
| Yanyan | to test api completeness | 09:01 |
| Qiming | we may also need to improve the api docs, solidify what are the exceptions to expect if you are requesting a cluster to dance | 09:02 |
| openstackgerrit | Merged openstack/senlin: Fix cluster resize service call https://review.openstack.org/273365 | 09:02 |
| Yanyan | yes, actually I found the API doc of most services don't provide detailed description about exceptional resp code | 09:03 |
| Qiming | nova is doing a good job in this space | 09:03 |
| Yanyan | they just list normal status and error status list | 09:03 |
| Qiming | yep, at least they have documented things like this: | 09:05 |
| Qiming | Error response codes | 09:05 |
| Qiming | computeFault (400, 500, …), serviceUnavailable (503), badRequest (400), unauthorized (401), forbidden (403), badMethod (405) | 09:05 |
| Yanyan | yea | 09:05 |
| Qiming | this is for the GET /v2.1/{tenant_id}/servers call | 09:06 |
| Yanyan | actually more detailed explanation will be helpful for user although it really difficult to cover all possible exceptional cased in API doc | 09:06 |
| Yanyan | s/cased/cases | 09:07 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Add unit test for cluster_resize in engine https://review.openstack.org/273403 | 09:07 |
| Qiming | yep | 09:07 |
| Qiming | Yanyan, about patch #273385 | 09:15 |
| Qiming | it looks good | 09:16 |
| Qiming | just want to raise a point in the test case: https://review.openstack.org/#/c/273385/1/senlin/tests/unit/profiles/test_heat_stack.py | 09:16 |
| Yanyan | ok | 09:16 |
| Qiming | we should avoid using MagicMock() | 09:16 |
| Yanyan | yes, agree | 09:16 |
| Yanyan | I should remove them from existing code | 09:16 |
| Qiming | the reason is that MagicMock() make some errors go unnoticed | 09:16 |
| Qiming | okay, can be follow-up | 09:17 |
| Yanyan | I remeber you talked with Tangchen about this issue :) | 09:17 |
| Qiming | don't need to change this one I think | 09:17 |
| Qiming | e.g. | 09:17 |
| Qiming | profile._check_action_complete = mock.MagicMock(return_value=True) | 09:17 |
| Qiming | this can be just profile._check_action_complete.return_value = True | 09:18 |
| Qiming | because profile itself is a Mock already | 09:18 |
| Yanyan | ok | 09:18 |
| Yanyan | if not, will use mock.patch.object | 09:18 |
| Qiming | yep | 09:19 |
| Qiming | just learned how to patch a constructor | 09:19 |
| Yanyan | that can be mocked as well? | 09:20 |
| Qiming | refer to mock-1.0.1 documentation section 2.3.6 | 09:20 |
| Yanyan | ok | 09:20 |
| Qiming | mock.patch.object seems don't work for __init__ | 09:20 |
| Qiming | oh ... wait | 09:21 |
| Qiming | in your test case, profile is real object | 09:22 |
| Yanyan | yes, so I think mock.patch.object can be used | 09:23 |
| Qiming | nop | 09:23 |
| Qiming | you should patch your object instance using 'self.patchobject(obj, 'method_name', return_value=something)' | 09:23 |
| openstackgerrit | Ethan Lynn proposed openstack/senlin: Re-enable lock breaker https://review.openstack.org/262151 | 09:24 |
| openstackgerrit | Ethan Lynn proposed openstack/senlin: Trival fix to service report https://review.openstack.org/273409 | 09:24 |
| Yanyan | oh, just learned something :) | 09:24 |
| openstackgerrit | xu-haiwei proposed openstack/senlin: Fix server_metadata_update return value when leaving a node from cluster https://review.openstack.org/273410 | 09:28 |
| Qiming | xuhaiwei, what are we getting from 'replace_server_metadata()' and 'update_server_metadata()' ? | 09:36 |
| openstackgerrit | Yanyan Hu proposed openstack/senlin: Support property update for os.heat.stack profile https://review.openstack.org/273385 | 09:37 |
| *** Yanyan has quit IRC | 09:42 | |
| *** Qiming has quit IRC | 09:54 | |
| xuhaiwei | Qiming, I only tried update_server_metadata | 10:10 |
| xuhaiwei | it worked | 10:10 |
| *** Liuqing has quit IRC | 10:13 | |
| openstackgerrit | Ethan Lynn proposed openstack/senlin: Re-enable lock breaker https://review.openstack.org/262151 | 10:30 |
| openstackgerrit | Ethan Lynn proposed openstack/senlin: Trival fix to service report https://review.openstack.org/273409 | 10:30 |
| *** elynn has quit IRC | 10:50 | |
| *** Qiming has joined #senlin | 10:54 | |
| xuhaiwei | Qiming, I only tried update_server_metadata | 11:03 |
| xuhaiwei | it worked | 11:03 |
| Qiming | xuhaiwei, when you create a nova server with metadata | 11:04 |
| Qiming | what will happen? | 11:04 |
| xuhaiwei | will test replace_server_metadata tomorrow | 11:04 |
| xuhaiwei | you mean using 'nova boot' to boot a server? | 11:04 |
| Qiming | we should not rely on the return value of update_server_metadata or replace_server_metadata to determine whether the do_join/do_leave is successful | 11:05 |
| xuhaiwei | if using 'nova boot --meta xxx=ddd', metadata will be store in instance property | 11:05 |
| Qiming | I mean a nova server profile, with server metadata set to something {'key': 'value'} | 11:05 |
| xuhaiwei | but update_server_metadata method only return 'metadata' to senlin | 11:06 |
| xuhaiwei | I did not try that case | 11:06 |
| Qiming | you still dont get the idea? | 11:06 |
| xuhaiwei | I tried to add a node to a cluster, the nova instance's metadata will be updated | 11:07 |
| xuhaiwei | that works fine | 11:07 |
| Qiming | ignore the test results please | 11:07 |
| Qiming | it is only part of the storey | 11:08 |
| Qiming | https://review.openstack.org/#/c/273410/1/senlin/engine/node.py | 11:08 |
| Qiming | line 343 | 11:08 |
| Qiming | what is that line testing? | 11:08 |
| xuhaiwei | I didn't try 'I mean a nova server profile, with server metadata set to something {'key': 'value'}', I will try it | 11:08 |
| Qiming | it is testing the return value from leave_cluster | 11:09 |
| xuhaiwei | 343 is testing whether return value is {} or {'cluster': xxx} | 11:09 |
| Qiming | okay, how can you be sure that the value will be {} if a node is being removed from a cluster? | 11:09 |
| xuhaiwei | if it is {} it means nova_leave succeeded | 11:09 |
| xuhaiwei | yes, I got it, it is not sufficient | 11:10 |
| xuhaiwei | I didn't realize that nova instance metadata can also be inputed by creating a node | 11:11 |
| Qiming | a server can be created with some metadata | 11:11 |
| Qiming | http://git.openstack.org/cgit/openstack/senlin/tree/senlin/profiles/os/nova/server.py#n177 | 11:11 |
| xuhaiwei | yes, I will fix it tomorrow | 11:11 |
| Qiming | the cluster key is only something we injected, we never know whether the server has some other data assigned | 11:11 |
| Qiming | great | 11:11 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: One more test case for deletion policy https://review.openstack.org/273523 | 13:15 |
| openstackgerrit | Cindia-blue proposed openstack/python-senlinclient: Add node check and recover into CLI https://review.openstack.org/273524 | 13:16 |
| Ayush | hello all, I just see that the bin folder from the master has been misplaced? Is there any reason? | 13:28 |
| Ayush | Actually it contains the scripts to start the services from devstack | 13:29 |
| Qiming | Ayush, the subdir was removed | 13:30 |
| openstackgerrit | Cindia-blue proposed openstack/senlin: Fix Error in Base Recover https://review.openstack.org/273535 | 13:30 |
| Ayush | Qiming, Is there any particular reason behind it? | 13:30 |
| Qiming | Ayush, searching | 13:31 |
| *** Liuqing has joined #senlin | 13:32 | |
| *** achatterjee_ has joined #senlin | 13:32 | |
| Qiming | https://review.openstack.org/#/c/267375/ | 13:32 |
| Ayush | Thanks Qiming | 13:33 |
| Qiming | Ayush, the reason is that we are letting pbr to take full control of the service install | 13:33 |
| Ayush | ok | 13:35 |
| Qiming | after a normal install, you will find senlin-api, senlin-engine, senlin-manage binaries under /usr/bin | 13:35 |
| Qiming | lixinhui, there? | 13:36 |
| Qiming | hopefully, still there? | 13:36 |
| *** cschulz has joined #senlin | 13:37 | |
| *** dixiaoli_ has joined #senlin | 13:37 | |
| openstackgerrit | Cindia-blue proposed openstack/python-senlinclient: Add node check and recover into CLI https://review.openstack.org/273524 | 13:38 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-senlinclient: Updated from global requirements https://review.openstack.org/273543 | 13:41 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/senlin: Updated from global requirements https://review.openstack.org/273545 | 13:41 |
| lixinhui | yes | 13:42 |
| lixinhui | Qiming | 13:42 |
| Qiming | hi, I'm blocking your client patch not because it is bad, the reason is because dependency | 13:43 |
| Qiming | the client operation won't work until sdk/server side fixes are in place | 13:43 |
| lixinhui | work | 13:43 |
| lixinhui | thanks for expalantion, Qiming, I see | 13:44 |
| *** Liuqing has quit IRC | 13:44 | |
| lixinhui | I will submit openstacksdk patch very soon | 13:44 |
| lixinhui | hope not long block there | 13:44 |
| Qiming | it won't be, :) | 13:45 |
| lixinhui | :) | 13:45 |
| Qiming | -2 to make sure it won't get merged accidentally | 13:45 |
| lixinhui | okay | 13:45 |
| *** Liuqing has joined #senlin | 13:47 | |
| *** Liuqing has quit IRC | 13:52 | |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Trivial: Make parse_exception cover all cases https://review.openstack.org/273554 | 13:56 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Fix service_get call in keystone driver https://review.openstack.org/273560 | 14:07 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Remove useless function from db model https://review.openstack.org/273569 | 14:29 |
| *** achatterjee_ has quit IRC | 14:36 | |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Add missing options registration for webhook https://review.openstack.org/273586 | 14:42 |
| Qiming | cschulz, ^ | 14:42 |
| *** Qiming has quit IRC | 15:24 | |
| *** dixiaoli_ has quit IRC | 15:46 | |
| *** pratikmallya has joined #senlin | 15:57 | |
| *** bdrich has joined #senlin | 16:30 | |
| *** pratikma_ has joined #senlin | 16:33 | |
| *** pratikmallya has quit IRC | 16:34 | |
| *** pratikmallya has joined #senlin | 16:48 | |
| *** pratikma_ has quit IRC | 16:51 | |
| *** Ayush has quit IRC | 17:15 | |
| *** bdrich has quit IRC | 17:55 | |
| *** jdandrea has quit IRC | 18:27 | |
| *** jdandrea has joined #senlin | 18:28 | |
| *** bdrich has joined #senlin | 19:18 | |
| *** pratikma_ has joined #senlin | 19:41 | |
| *** pratikmallya has quit IRC | 19:43 | |
| *** pratikma_ has quit IRC | 20:33 | |
| *** pratikmallya has joined #senlin | 20:41 | |
| *** cschulz has quit IRC | 21:05 | |
| *** pratikma_ has joined #senlin | 21:32 | |
| *** pratikmallya has quit IRC | 21:33 | |
| *** pratikma_ has quit IRC | 22:17 | |
| *** Qiming has joined #senlin | 23:32 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!