*** lvdongbing has joined #senlin | 00:31 | |
openstackgerrit | xu-haiwei proposed openstack/senlin: Fix SDK exception message parse https://review.openstack.org/243959 | 00:42 |
---|---|---|
openstackgerrit | Merged openstack/senlin: Correct set the default value for min_size/max_size https://review.openstack.org/245011 | 00:47 |
*** pm90_ has quit IRC | 01:03 | |
*** pm90_ has joined #senlin | 01:27 | |
*** zhenguo has quit IRC | 01:36 | |
*** pm90_ has quit IRC | 01:41 | |
*** zhenguo has joined #senlin | 01:43 | |
*** shu has joined #senlin | 01:48 | |
*** Yanyanhu has joined #senlin | 01:59 | |
*** elynn has joined #senlin | 02:01 | |
openstackgerrit | xu-haiwei proposed openstack/senlin: Fix SDK exception message parse https://review.openstack.org/243959 | 02:04 |
openstackgerrit | Merged openstack/senlin: Fix SDK exception message parse https://review.openstack.org/243959 | 02:47 |
*** Qiming has joined #senlin | 02:55 | |
Qiming | morning | 03:01 |
Yanyanhu | morning | 03:01 |
Yanyanhu | in NYC now :) | 03:01 |
xuhaiwei | a happy journey | 03:02 |
Qiming | yes | 03:04 |
Yanyanhu | have you got the chance to talk with Julio | 03:05 |
Yanyanhu | he was expecting your visit :) | 03:05 |
Qiming | everything was ... cursory | 03:07 |
Qiming | yep, we met, also with Matt and Sandy | 03:07 |
Yanyanhu | yea, most time in travel or in the progress of preparation for travel | 03:09 |
Yanyanhu | so you will stay in ny for 2 days? | 03:09 |
*** lvdongbing has quit IRC | 03:31 | |
*** lvdongbing has joined #senlin | 03:34 | |
*** Qiming has quit IRC | 03:40 | |
*** Qiming has joined #senlin | 03:40 | |
*** Qiming has quit IRC | 03:42 | |
*** Qiming has joined #senlin | 03:44 | |
*** Qiming_ has joined #senlin | 03:54 | |
*** gongysh has joined #senlin | 03:55 | |
*** Qiming has quit IRC | 03:57 | |
Qiming_ | very hungry, but got nothing to eat | 04:07 |
Qiming_ | sigh ... | 04:07 |
Qiming_ | should not chose this place to stay, it is in the middle of nowhere | 04:08 |
xuhaiwei | you should take some bread with you when you are outside of China | 04:08 |
xuhaiwei | not including Japan | 04:09 |
xuhaiwei | Qiming, about sending mail to api-wg, is there already a thread about the API response format? I didn't find it | 04:15 |
Qiming_ | one minute | 04:16 |
Qiming_ | https://review.openstack.org/#/c/167793/ | 04:17 |
elynn | o/ | 04:23 |
*** Qiming_ has quit IRC | 04:31 | |
*** shu has quit IRC | 04:44 | |
*** shu has joined #senlin | 04:45 | |
*** xuhaiwei has quit IRC | 04:58 | |
*** elynn has quit IRC | 05:20 | |
openstackgerrit | Ethan Lynn proposed openstack/senlin: Pick up Lock Break from TODO items https://review.openstack.org/244471 | 05:38 |
openstackgerrit | Ethan Lynn proposed openstack/senlin: Pick up Lock Breaker from TODO items https://review.openstack.org/244471 | 05:40 |
*** xuhaiwei has joined #senlin | 05:41 | |
openstackgerrit | Yanyan Hu proposed openstack/senlin: [WIP]Enable initiative action selecting in start_action https://review.openstack.org/244026 | 05:59 |
*** elynn has joined #senlin | 06:10 | |
*** lvdongbing has quit IRC | 06:36 | |
*** hightall has joined #senlin | 06:43 | |
*** elynn_ has joined #senlin | 06:53 | |
*** elynn_ has quit IRC | 07:09 | |
*** elynn_ has joined #senlin | 07:11 | |
*** zhenguo has quit IRC | 07:15 | |
*** zhenguo has joined #senlin | 07:19 | |
*** Qiming_ has joined #senlin | 07:49 | |
openstackgerrit | Yanyan Hu proposed openstack/senlin: Import correct DB api model for unit test https://review.openstack.org/245653 | 07:52 |
Qiming_ | got up | 07:52 |
Qiming_ | cannot sleep | 07:52 |
xuhaiwei | what about answering a question? Qiming_ | 08:00 |
Yanyanhu | hi, Qiming_ | 08:00 |
Qiming_ | ok | 08:00 |
elynn_ | morning Qiming_ | 08:01 |
xuhaiwei | still remember this patch? https://review.openstack.org/#/c/225560/2 | 08:01 |
Qiming_ | yes | 08:01 |
Qiming_ | yes, very morning, 3:02 am | 08:02 |
Yanyanhu | Qiming_, tough day... | 08:03 |
Qiming_ | yip | 08:04 |
xuhaiwei | we want to change response code, so when 202 is returned, the body becomes {} | 08:04 |
xuhaiwei | but after 'create' action, we still want to show the object | 08:05 |
Qiming_ | we want to change response code? | 08:05 |
xuhaiwei | yes, as we discussed, we want to change 200 to 202 for 'create' action | 08:05 |
Qiming_ | that patch was because Heat is returning 202 | 08:05 |
Qiming_ | so you are not talking about that patch | 08:06 |
xuhaiwei | heat stack update? | 08:06 |
Qiming_ | it is about senlin's return code? | 08:06 |
xuhaiwei | yes | 08:06 |
xuhaiwei | the line 269 if resp.status_code == 202: will make the body empty | 08:08 |
Qiming_ | ... which file are you talking about? | 08:10 |
xuhaiwei | sorry | 08:10 |
Qiming_ | you were pointing me to the heat stack update code in sdk | 08:10 |
xuhaiwei | openstack/transport.py | 08:10 |
*** hightall has quit IRC | 08:11 | |
xuhaiwei | https://github.com/openstack/python-openstacksdk/blob/master/openstack/transport.py#L269 | 08:11 |
Qiming_ | okay | 08:12 |
Qiming_ | see what you are saying | 08:12 |
Qiming_ | if the resp.status_code is 202, the client side can choose to issue a GET call | 08:12 |
Qiming_ | in that GET call, it will get the object representation | 08:12 |
Qiming_ | in an ideal implementation, the 202 response should carry a location field (as api-wg suggested) in header | 08:13 |
openstackgerrit | Merged openstack/senlin: Pick up Lock Breaker from TODO items https://review.openstack.org/244471 | 08:13 |
Qiming_ | using that header, the client side would be able to get the latest object status | 08:14 |
Qiming_ | it is a "stupid" process, but it is the only correct way to handle async object operations | 08:15 |
xuhaiwei | currently, when I changed 200 to 202 in 'create' action, the next 'get' action will fail, because it can't get the object's id | 08:16 |
xuhaiwei | take cluster_create action for an example | 08:17 |
Qiming_ | that is because the previous 202 didn't return a location for you | 08:17 |
xuhaiwei | I think so | 08:17 |
xuhaiwei | the location is in the body ,right? | 08:17 |
Qiming_ | please read the spec | 08:17 |
Qiming_ | we want to be conformant to the spec, which means we have to check it through | 08:18 |
Qiming_ | http://git.openstack.org/cgit/openstack/api-wg/tree/guidelines/http.rst#n105 | 08:18 |
Qiming_ | got what I mean? | 08:19 |
xuhaiwei | got it I think | 08:19 |
xuhaiwei | so the header change should be done in SDK? | 08:20 |
Qiming_ | no, the server should do it | 08:20 |
xuhaiwei | ok, I will try it | 08:20 |
Qiming_ | SDK is not supposed to manipulate the response header | 08:20 |
Qiming_ | yep, please | 08:20 |
elynn_ | Hi Qiming_, do you have time to bump senlinclient version? | 08:37 |
*** lvdongbing has joined #senlin | 08:38 | |
Qiming_ | need a vnc access to do that | 08:42 |
elynn_ | ok... | 08:43 |
elynn_ | do you need any jump machine? | 08:43 |
Qiming_ | no | 08:43 |
Qiming_ | [tengqm@node1 python-senlinclient]$ git push gerrit 0.1.5 | 08:53 |
Qiming_ | Counting objects: 1, done. | 08:53 |
Qiming_ | Writing objects: 100% (1/1), 540 bytes | 0 bytes/s, done. | 08:53 |
Qiming_ | Total 1 (delta 0), reused 0 (delta 0) | 08:53 |
Qiming_ | remote: Processing changes: refs: 1, done | 08:53 |
Qiming_ | To https://tengqm:ZcK4qjpWkuIY@review.openstack.org/openstack/python-senlinclient.git | 08:53 |
Qiming_ | * [new tag] 0.1.5 -> 0.1.5 | 08:53 |
Qiming_ | just bumped | 08:53 |
Qiming_ | will appear some time later on pypi | 08:53 |
Qiming_ | then you can propose a version bump on global requirements | 08:53 |
elynn_ | cool, thanks! | 08:53 |
elynn_ | yes, I will. | 08:53 |
openstackgerrit | Yanyan Hu proposed openstack/senlin: Move action status definition to consts module https://review.openstack.org/245667 | 09:13 |
*** Qiming_ has quit IRC | 09:14 | |
*** lvdongbing has quit IRC | 09:36 | |
openstackgerrit | Ethan Lynn proposed openstack/senlin: Add engine_alive for engine status check https://review.openstack.org/243483 | 09:47 |
openstackgerrit | Yanyan Hu proposed openstack/senlin: Move action status definition to consts module https://review.openstack.org/245667 | 09:55 |
*** zhenguo has quit IRC | 09:58 | |
*** Yanyanhu has quit IRC | 10:07 | |
*** openstackgerrit has quit IRC | 10:16 | |
*** openstackgerrit has joined #senlin | 10:17 | |
*** elynn has quit IRC | 10:45 | |
*** Liuqing has joined #senlin | 11:23 | |
*** gongysh has quit IRC | 11:26 | |
*** elynn_ has quit IRC | 11:27 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/senlin: Updated from global requirements https://review.openstack.org/245255 | 11:50 |
*** Qiming_ has joined #senlin | 12:04 | |
*** Qiming_ has quit IRC | 12:14 | |
*** Qiming_ has joined #senlin | 12:15 | |
*** zhenguo has joined #senlin | 12:22 | |
*** Qiming_ has quit IRC | 12:30 | |
*** elynn_ has joined #senlin | 12:47 | |
*** openstack has joined #senlin | 12:51 | |
openstackgerrit | Liuqing Jing proposed openstack/senlin-dashboard: The profile spec should be readonly while updating profile https://review.openstack.org/245753 | 13:06 |
*** lvdongbing has joined #senlin | 13:08 | |
*** lvdongbing has quit IRC | 13:10 | |
*** lvdongbing has joined #senlin | 13:10 | |
openstackgerrit | Liuqing Jing proposed openstack/senlin-dashboard: Add link for physical id https://review.openstack.org/245756 | 13:15 |
*** pm90_ has joined #senlin | 13:15 | |
*** lvdongbing has quit IRC | 13:19 | |
*** lvdongbing has joined #senlin | 13:20 | |
*** lvdongbing has quit IRC | 13:21 | |
*** Liuqing has quit IRC | 13:29 | |
*** Liuqing has joined #senlin | 13:29 | |
*** lkarm has joined #senlin | 13:51 | |
*** Qiming_ has joined #senlin | 14:02 | |
*** Qiming_ has quit IRC | 14:07 | |
*** zhenguo has quit IRC | 14:08 | |
*** Qiming_ has joined #senlin | 14:11 | |
openstackgerrit | Merged openstack/senlin: Updated from global requirements https://review.openstack.org/245255 | 14:19 |
*** pm90__ has joined #senlin | 14:42 | |
*** pm90_ has quit IRC | 14:44 | |
*** jdandrea has joined #senlin | 14:45 | |
*** Qiming_ has quit IRC | 15:09 | |
*** Qiming_ has joined #senlin | 15:20 | |
openstackgerrit | Liuqing Jing proposed openstack/senlin-dashboard: Support creating policy https://review.openstack.org/245824 | 15:24 |
*** Qiming_ has quit IRC | 15:24 | |
*** pm90__ is now known as pratikmallya | 15:26 | |
*** Liuqing has quit IRC | 15:29 | |
*** pratikmallya has quit IRC | 15:34 | |
*** pratikmallya has joined #senlin | 15:41 | |
*** pratikmallya has quit IRC | 16:05 | |
*** Qiming_ has joined #senlin | 16:16 | |
*** Qiming_ has quit IRC | 16:21 | |
*** pratikmallya has joined #senlin | 16:31 | |
*** pratikma_ has joined #senlin | 16:33 | |
*** pratikmallya has quit IRC | 16:36 | |
*** Qiming_ has joined #senlin | 16:45 | |
*** Qiming_ has quit IRC | 16:58 | |
*** elynn_ has quit IRC | 16:59 | |
*** lkarm has quit IRC | 17:27 | |
*** lkarm has joined #senlin | 17:28 | |
*** lkarm has quit IRC | 17:32 | |
*** Qiming has joined #senlin | 18:29 | |
*** lkarm has joined #senlin | 18:36 | |
*** lkarm has quit IRC | 18:40 | |
*** Qiming has quit IRC | 18:41 | |
*** Qiming has joined #senlin | 18:49 | |
*** Qiming has quit IRC | 18:54 | |
*** pratikma_ is now known as pratikmallya | 19:00 | |
*** Qiming has joined #senlin | 19:59 | |
*** lkarm has joined #senlin | 20:05 | |
*** Qiming has quit IRC | 20:05 | |
*** pratikmallya has quit IRC | 21:25 | |
*** Qiming has joined #senlin | 21:37 | |
*** pratikmallya has joined #senlin | 21:38 | |
*** pratikma_ has joined #senlin | 21:39 | |
*** pratikmallya has quit IRC | 21:43 | |
*** pratikma_ has quit IRC | 21:45 | |
*** Qiming has quit IRC | 21:45 | |
*** pratikmallya has joined #senlin | 22:17 | |
*** pratikma_ has joined #senlin | 22:18 | |
*** pratikmallya has quit IRC | 22:18 | |
*** pratikmallya has joined #senlin | 22:19 | |
*** pratikma_ has quit IRC | 22:22 | |
*** lkarm has quit IRC | 23:06 | |
*** lkarm has joined #senlin | 23:07 | |
*** lkarm has quit IRC | 23:11 | |
*** Qiming has joined #senlin | 23:27 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!