| *** Qiming_ has joined #senlin | 00:07 | |
| *** Qiming_ has quit IRC | 00:40 | |
| *** jruano has quit IRC | 01:50 | |
| *** mathspanda has joined #senlin | 01:57 | |
| *** Shijia has joined #senlin | 01:57 | |
| *** mathspanda has quit IRC | 02:24 | |
| *** mathspanda has joined #senlin | 02:24 | |
| *** mathspanda has quit IRC | 02:26 | |
| *** mathspanda has joined #senlin | 02:26 | |
| *** jdandrea has quit IRC | 02:26 | |
| *** mathspanda has quit IRC | 02:39 | |
| openstackgerrit | xu-haiwei proposed stackforge/senlin: Make deletion policy work for cluster resize action https://review.openstack.org/228760 | 03:05 |
|---|---|---|
| *** jruano has joined #senlin | 03:21 | |
| *** Shijia has quit IRC | 03:41 | |
| *** Shijia has joined #senlin | 03:42 | |
| *** jruano has quit IRC | 03:48 | |
| *** Shijia has quit IRC | 03:50 | |
| *** Shijia has joined #senlin | 04:10 | |
| *** Qiming has joined #senlin | 05:29 | |
| *** xuhaiwei has quit IRC | 05:33 | |
| *** xuhaiwei has joined #senlin | 05:36 | |
| xuhaiwei | Qiming, are you around? | 06:25 |
| Qiming | hi | 06:25 |
| xuhaiwei | sorry , just saw your comment, give me a few minutes | 06:26 |
| Qiming | ok | 06:26 |
| xuhaiwei | your comment makes sense to me, just one question, the pre_op is a common method which will be used to hanlder other actions like SCALE_IN, is it ok to add get_resize_count to it? | 06:31 |
| Qiming | it is okay to add a test in it | 06:31 |
| xuhaiwei | ok | 06:32 |
| Qiming | if the current action is CLUSTER_RESIZE, then we do get_resize_count | 06:32 |
| xuhaiwei | got it | 06:32 |
| Qiming | what matters more is we want to keep the cluster action handler agnostic to the policies attached | 06:33 |
| Qiming | but a policy may on the contrary do different things regarding the actions handled | 06:33 |
| Qiming | in other words, we are struggling to keep action handlers from being hijacked by any particular policy | 06:34 |
| Qiming | there might be a lot variants to a policy | 06:34 |
| Qiming | after all, policies are plug-ins | 06:34 |
| Qiming | they are cheap, they can be modified freely | 06:35 |
| Qiming | hope this philosophy makes sense to you | 06:35 |
| xuhaiwei | I dont know why actions handle will do the opposite to the policy? actions handle is always controlled by policy, isnt is | 06:36 |
| xuhaiwei | it | 06:36 |
| Qiming | actions should work despite of any policies | 06:36 |
| Qiming | we don't want to make a lot assumptions (customizations) in action handlers | 06:37 |
| xuhaiwei | you mean action will do differently with policy attached or detached? | 06:37 |
| Qiming | it will eventually make the action handlers very complicated to maintain | 06:37 |
| Qiming | action handlers only cares about inputs, policy data and outputs | 06:38 |
| Qiming | take the CLUSTER_RESIZE handler (i.e. do_resize()) for example | 06:38 |
| Qiming | it is probably okay to make it aware of certain policy data, certain inputs | 06:39 |
| Qiming | but we should avoid customize it to any named policy | 06:39 |
| Qiming | if those policies want to have an impact on the action handler, they should do it by customizing the inputs | 06:40 |
| Qiming | or the policy data | 06:40 |
| xuhaiwei | yes, agree | 06:40 |
| Qiming | this is not well documented | 06:41 |
| Qiming | the framework is still taking shape | 06:41 |
| xuhaiwei | that's why we should fix the problem on the deletion policy side but not the action side | 06:41 |
| Qiming | yep | 06:42 |
| Qiming | if the deletion policy cannot handle CLUSTER_RESIZE action, it is the policy to be blamed, not the action handler | 06:43 |
| Qiming | there will be cases where we need to improve the action handler so that it can understand more policy_data, but those cases should be treated as a protocol change | 06:45 |
| xuhaiwei | yes | 06:45 |
| *** pm90_ has joined #senlin | 06:49 | |
| *** pm90_ has quit IRC | 07:20 | |
| openstackgerrit | xu-haiwei proposed stackforge/senlin: Make deletion policy work for cluster resize action https://review.openstack.org/231885 | 08:10 |
| Qiming | xuhaiwei, posted comments to your patch | 08:41 |
| Qiming | please check if it makes sense to you | 08:41 |
| *** shu has quit IRC | 09:30 | |
| *** Shijia has quit IRC | 10:07 | |
| *** Shijia has joined #senlin | 10:07 | |
| *** Shijia_ has joined #senlin | 10:15 | |
| *** Shijia has quit IRC | 10:19 | |
| *** Shijia_ has quit IRC | 11:03 | |
| *** Shijia has joined #senlin | 11:04 | |
| *** Shijia_ has joined #senlin | 11:04 | |
| *** Shijia has quit IRC | 11:08 | |
| *** lawrancejing has joined #senlin | 12:14 | |
| openstackgerrit | lawrancejing proposed stackforge/senlin-dashboard: Add profile spec properties in profile table https://review.openstack.org/229493 | 12:34 |
| *** Shijia_ has quit IRC | 12:35 | |
| openstackgerrit | lawrancejing proposed stackforge/senlin-dashboard: Add profile spec column in profile table https://review.openstack.org/229493 | 13:27 |
| openstackgerrit | lawrancejing proposed stackforge/senlin-dashboard: Use profile type form spec https://review.openstack.org/231994 | 13:34 |
| *** jruano has joined #senlin | 14:02 | |
| *** pm90_ has joined #senlin | 14:33 | |
| *** pm90__ has joined #senlin | 14:38 | |
| *** pm90_ has quit IRC | 14:40 | |
| openstackgerrit | lawrancejing proposed stackforge/senlin-dashboard: Support creating profile form yaml and file https://review.openstack.org/229474 | 14:49 |
| *** jdandrea has joined #senlin | 14:49 | |
| openstackgerrit | lawrancejing proposed stackforge/senlin-dashboard: Add node table https://review.openstack.org/232060 | 15:31 |
| *** janonymous_ has joined #senlin | 15:31 | |
| *** lawrancejing has quit IRC | 15:31 | |
| *** lawrancejing has joined #senlin | 15:32 | |
| *** lawrancejing has quit IRC | 15:33 | |
| *** janonymous_ has quit IRC | 15:50 | |
| *** Qiming has quit IRC | 16:00 | |
| *** pm90__ has quit IRC | 16:04 | |
| *** pm90_ has joined #senlin | 16:44 | |
| *** pm90__ has joined #senlin | 16:49 | |
| *** pm90_ has quit IRC | 16:52 | |
| *** jdandrea has quit IRC | 17:07 | |
| *** jdandrea has joined #senlin | 17:12 | |
| *** pm90__ has quit IRC | 20:11 | |
| *** jruano has quit IRC | 20:39 | |
| *** pm90_ has joined #senlin | 21:05 | |
| *** pm90__ has joined #senlin | 21:15 | |
| *** pm90_ has quit IRC | 21:17 | |
| *** pm90__ has quit IRC | 22:56 | |
| *** pm90_ has joined #senlin | 22:59 | |
| *** yuanying has quit IRC | 23:16 | |
| *** yuanying has joined #senlin | 23:19 | |
| *** lawrancejing has joined #senlin | 23:44 | |
| *** lawrancejing has quit IRC | 23:44 | |
| *** lawrancejing has joined #senlin | 23:54 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!