| *** openstack has joined #senlin | 00:35 | |
| *** Qiming has joined #senlin | 01:10 | |
| Qiming | morning | 01:10 |
|---|---|---|
| admin__ | morning, Qiming | 01:10 |
| Qiming | admin__, free to have a quick call? | 01:11 |
| admin__ | call me by 13810678441 | 01:11 |
| admin__ | thanks | 01:11 |
| admin__ | or let me know your number | 01:11 |
| Qiming | calling | 01:12 |
| *** zhenguo has joined #senlin | 01:17 | |
| openstackgerrit | Zhenguo Niu proposed stackforge/senlin-dashboard: Add cluster dashboard https://review.openstack.org/216762 | 01:21 |
| *** lawrance_ has joined #senlin | 01:41 | |
| *** Yanyanhu has joined #senlin | 01:45 | |
| *** mathspanda has joined #senlin | 01:48 | |
| *** elynn has joined #senlin | 02:01 | |
| *** lawrance_ has quit IRC | 02:03 | |
| *** lawrance_ has joined #senlin | 02:03 | |
| xuhaiwei | Yanyanhu, morning | 02:03 |
| Yanyanhu | hi, morning | 02:04 |
| openstackgerrit | Merged stackforge/senlin-dashboard: Add cluster dashboard https://review.openstack.org/216762 | 02:04 |
| xuhaiwei | Just saw this patch, https://review.openstack.org/#/c/214090/16/senlin/tests/functional/api.py | 02:04 |
| xuhaiwei | line42, when ignore_missing=True, should only return 200 i think | 02:05 |
| *** lawrance_ has quit IRC | 02:07 | |
| Qiming | xuhaiwei, agree | 02:17 |
| Yanyanhu | hi, xuhaiwei, sorry just left for a while | 02:18 |
| xuhaiwei | ok | 02:19 |
| Yanyanhu | hi, xuhaiwei, the status_code list defines all status that will be accepted by api client | 02:27 |
| Yanyanhu | therefore when ignore_missing is defined as True, both 200 and 404 will be acceptable for api client | 02:28 |
| Yanyanhu | otherwise, when api client accpet and 404 status code, it will raise an exception | 02:28 |
| xuhaiwei | I think when ignore_missing is True, exception will not be raised | 02:29 |
| Yanyanhu | right | 02:30 |
| xuhaiwei | just return None to the client | 02:30 |
| Yanyanhu | nope, since the status code check and filtering is done in client side | 02:31 |
| Yanyanhu | not provided by backend service | 02:31 |
| Yanyanhu | api client just get the real resp status code and decide whether to raise exception | 02:31 |
| Yanyanhu | I should add some parameter descriptions for api_request function to explain the logic :) | 02:32 |
| xuhaiwei | don't understand well what you said | 02:35 |
| Yanyanhu | hmm, you can image the api client we implemented in senlin functional test is just openstacksdk | 02:35 |
| Yanyanhu | usually we use sdk to talk with other services' | 02:35 |
| xuhaiwei | yes | 02:36 |
| Yanyanhu | if we define ignore_missing as true when performing get_xxx operation, sdk will not raise exception when 404 code is return by backend service, right? | 02:36 |
| xuhaiwei | yes | 02:37 |
| Yanyanhu | that's because sdk accepts both 200 and 404 as legal resp status code | 02:37 |
| xuhaiwei | right | 02:38 |
| Yanyanhu | therefore, it won't treat NotFound as an exception and raise it to user | 02:38 |
| Yanyanhu | our api client will behave like this as well :) | 02:38 |
| Yanyanhu | if you defined ignore_missing as True, both 200 and 404 will be treated as expected resp status code | 02:39 |
| xuhaiwei | I think I got you | 02:39 |
| Yanyanhu | ;) | 02:39 |
| xuhaiwei | if ignore_missing is False, we should check whether exception is happened? | 02:40 |
| Yanyanhu | right | 02:40 |
| xuhaiwei | good | 02:40 |
| openstackgerrit | Yanyan Hu proposed stackforge/senlin: Define _build_connection_params in policy base module https://review.openstack.org/216936 | 03:04 |
| *** jdandrea has quit IRC | 03:23 | |
| *** lawrance_ has joined #senlin | 03:26 | |
| openstackgerrit | OpenStack Proposal Bot proposed stackforge/senlin: Updated from global requirements https://review.openstack.org/216972 | 05:21 |
| *** Yanyanhu has quit IRC | 05:26 | |
| *** Yanyanhu has joined #senlin | 05:27 | |
| openstackgerrit | Yanyan Hu proposed stackforge/senlin: Define _build_connection_params in policy base module https://review.openstack.org/216936 | 05:32 |
| openstackgerrit | Yanyan Hu proposed stackforge/senlin: Define _build_connection_params in policy base module https://review.openstack.org/216936 | 05:35 |
| Yanyanhu | hi, Qiming, I'm now working on using senlin generic driver to manage keystone_v3 driver. One question I'm wondering is whether we should invoke interfaces provided by keystone driver through generic driver interface in all cases | 06:17 |
| Yanyanhu | just like what we discussed about runing heat without keystone | 06:18 |
| Yanyanhu | although senlin is an openstack service, but I think it can also be run without keystone service although some extra work is needed to make this possible | 06:19 |
| Yanyanhu | so besides profile and policy modules, shoud we also invoke identity related interfaces using senlin generic driver in some other modules like trust middleware or webhook | 06:22 |
| Qiming | that is a great idea | 06:41 |
| Qiming | the only concern is about time | 06:42 |
| Qiming | we won't make it before L-3 | 06:42 |
| Yanyanhu | yes. I think we can do it step by step | 06:42 |
| Qiming | there are more important work than that | 06:42 |
| Yanyanhu | right | 06:42 |
| Yanyanhu | so we just provide basic support for managing keystone client using senlin generic driver | 06:42 |
| Yanyanhu | in current stage | 06:43 |
| Yanyanhu | then we can try to think about this issue and find possible solution in future | 06:43 |
| Qiming | yes | 06:47 |
| *** lawrance_ has quit IRC | 07:14 | |
| *** lawrance_ has joined #senlin | 07:15 | |
| *** mathspanda has quit IRC | 07:54 | |
| openstackgerrit | Qiming Teng proposed stackforge/senlin: Fix webhook triggering logic https://review.openstack.org/216751 | 08:02 |
| openstackgerrit | xu-haiwei proposed stackforge/senlin: Catch all the driver exceptions on node engine layer https://review.openstack.org/216139 | 08:05 |
| openstackgerrit | Yanyan Hu proposed stackforge/senlin: Define _build_connection_params in policy base module https://review.openstack.org/216936 | 08:10 |
| *** Yanyanhu has quit IRC | 08:25 | |
| *** Yanyanhu has joined #senlin | 08:25 | |
| Qiming | xuhaiwei, 216139 looks good, pls fix the pep8 error | 08:32 |
| xuhaiwei | ok | 08:38 |
| openstackgerrit | Merged stackforge/senlin: Define _build_connection_params in policy base module https://review.openstack.org/216936 | 08:40 |
| openstackgerrit | xu-haiwei proposed stackforge/senlin: Fail webhook creation if url is not correctly created https://review.openstack.org/216508 | 08:40 |
| openstackgerrit | xu-haiwei proposed stackforge/senlin: Catch all the driver exceptions on node engine layer https://review.openstack.org/216139 | 08:43 |
| openstackgerrit | Qiming Teng proposed stackforge/senlin: Minor tweaks to the drivers base https://review.openstack.org/217036 | 08:48 |
| openstackgerrit | xu-haiwei proposed stackforge/senlin: Catch all the driver exceptions on node engine layer https://review.openstack.org/216139 | 08:55 |
| openstackgerrit | Yanyan Hu proposed stackforge/senlin: Use senlin generic driver to manege keystone driver https://review.openstack.org/217045 | 09:07 |
| Qiming | Yanyanhu, please help check 217036 above? | 09:09 |
| Yanyanhu | sure, have looked at it and I think it's ok | 09:10 |
| Yanyanhu | just wait for gate's verification | 09:10 |
| Qiming | ok | 09:10 |
| Yanyanhu | will rebase 217045 on it and 216751 | 09:10 |
| Qiming | ok | 09:11 |
| openstackgerrit | Merged stackforge/senlin: Fix webhook triggering logic https://review.openstack.org/216751 | 09:11 |
| openstackgerrit | Yanyan Hu proposed stackforge/senlin: Use senlin generic driver to manege keystone driver https://review.openstack.org/217045 | 09:25 |
| openstackgerrit | Qiming Teng proposed stackforge/senlin: Removal of debugging code https://review.openstack.org/217062 | 09:45 |
| openstackgerrit | Merged stackforge/senlin: Minor tweaks to the drivers base https://review.openstack.org/217036 | 09:46 |
| openstackgerrit | Yanyan Hu proposed stackforge/senlin: Use senlin generic driver to manege keystone driver https://review.openstack.org/217045 | 09:48 |
| openstackgerrit | Merged stackforge/senlin: Removal of debugging code https://review.openstack.org/217062 | 10:13 |
| openstackgerrit | Merged stackforge/senlin: Use senlin generic driver to manege keystone driver https://review.openstack.org/217045 | 10:14 |
| openstackgerrit | Merged stackforge/senlin: Catch all the driver exceptions on node engine layer https://review.openstack.org/216139 | 10:18 |
| *** lawrance_ has quit IRC | 10:19 | |
| *** Yanyanhu has quit IRC | 10:20 | |
| Qiming | heading home | 10:21 |
| *** Qiming has quit IRC | 10:26 | |
| *** elynn has quit IRC | 11:34 | |
| *** Qiming has joined #senlin | 11:53 | |
| *** lawrance_ has joined #senlin | 12:34 | |
| *** lkarm has joined #senlin | 12:37 | |
| openstackgerrit | Merged stackforge/senlin: Check wait_for_lb_ready method's return value https://review.openstack.org/215430 | 13:33 |
| *** jdandrea has joined #senlin | 13:44 | |
| openstackgerrit | Zhenguo Niu proposed stackforge/senlin-dashboard: Add senlinclient exceptions to horizon types https://review.openstack.org/217212 | 14:12 |
| openstackgerrit | OpenStack Proposal Bot proposed stackforge/python-senlinclient: Updated from global requirements https://review.openstack.org/217227 | 14:18 |
| openstackgerrit | OpenStack Proposal Bot proposed stackforge/senlin: Updated from global requirements https://review.openstack.org/216972 | 14:18 |
| lawrance_ | zhengguo, should we add "senlin-dashboard" into openstack/requirements-project.txt? | 14:27 |
| lawrance_ | or later | 14:28 |
| zhenguo | lawrance: yes, the patches are in review progress, hope to be merged soon. | 14:47 |
| zhenguo | lawrance: see https://review.openstack.org/#/c/216575/ | 14:48 |
| lawrance_ | yep | 14:52 |
| *** Qiming has quit IRC | 14:54 | |
| openstackgerrit | Merged stackforge/senlin-dashboard: Add senlinclient exceptions to horizon types https://review.openstack.org/217212 | 15:35 |
| openstackgerrit | Merged stackforge/python-senlinclient: Updated from global requirements https://review.openstack.org/217227 | 15:53 |
| openstackgerrit | Merged stackforge/senlin: Updated from global requirements https://review.openstack.org/216972 | 15:56 |
| *** lawrance_ has quit IRC | 15:56 | |
| openstackgerrit | Zhenguo Niu proposed stackforge/senlin-dashboard: Wrap senlin client object https://review.openstack.org/217291 | 16:21 |
| *** lkarm has quit IRC | 16:52 | |
| *** lkarm has joined #senlin | 16:53 | |
| *** lkarm has quit IRC | 16:55 | |
| *** lkarm has joined #senlin | 16:55 | |
| *** lkarm has quit IRC | 17:41 | |
| *** lkarm has joined #senlin | 17:41 | |
| *** lkarm_ has joined #senlin | 17:43 | |
| *** lkarm has quit IRC | 17:46 | |
| *** openstackgerrit has quit IRC | 18:17 | |
| *** openstackgerrit has joined #senlin | 18:17 | |
| *** zhenguo has quit IRC | 18:23 | |
| *** openstackgerrit has quit IRC | 21:01 | |
| *** openstackgerrit has joined #senlin | 21:02 | |
| *** lkarm_ has quit IRC | 21:22 | |
| *** Qiming has joined #senlin | 23:39 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!