| *** xuhaiwei_ has quit IRC | 00:35 | |
| *** ChrisSen has joined #senlin | 00:42 | |
| *** ChrisSen has quit IRC | 00:47 | |
| *** Qiming has joined #senlin | 00:50 | |
| *** jdandrea has quit IRC | 01:02 | |
| *** xuhaiwei has joined #senlin | 01:09 | |
| openstackgerrit | Merged stackforge/senlin: Changes literal ation names to consts.<action_name> to make action creation consistent. https://review.openstack.org/209131 | 01:19 |
|---|---|---|
| *** Qiming has quit IRC | 01:22 | |
| *** Yanyanhu has joined #senlin | 01:25 | |
| *** ChrisSen has joined #senlin | 01:27 | |
| *** jruano has quit IRC | 01:30 | |
| openstackgerrit | Yanyan Hu proposed stackforge/senlin: Add test case for LoadBalancer driver(2) https://review.openstack.org/203956 | 01:30 |
| *** jruano has joined #senlin | 01:44 | |
| *** Zhenqi has joined #senlin | 01:49 | |
| *** Qiming has joined #senlin | 02:01 | |
| ChrisSen | When updating the name of a profile with metadata attached, the name is changed successfully and no error messages occur, but the metadata gets lost: | 02:01 |
| ChrisSen | http://paste.openstack.org/show/407739/ | 02:01 |
| *** elynn has joined #senlin | 02:03 | |
| Yanyanhu | ChrisSen, that's true, I think there is a bug here | 02:12 |
| Yanyanhu | I guess the senlinclient could provide incorrect default value for metadata(e.g. {}) when doing profile-update operation | 02:15 |
| openstackgerrit | xu-haiwei proposed stackforge/senlin: Do not update other properties if exception happens https://review.openstack.org/209026 | 02:16 |
| Yanyanhu | since engine service will only ignore metadata when it is None, so the error happened. | 02:17 |
| Yanyanhu | http://git.openstack.org/cgit/stackforge/senlin/tree/senlin/engine/service.py#n240 | 02:17 |
| Yanyanhu | so maybe we should not add 'metadata' field to params when it is not provide in cmd line | 02:20 |
| Yanyanhu | http://git.openstack.org/cgit/stackforge/python-senlinclient/tree/senlinclient/v1/shell.py#n170 | 02:21 |
| Yanyanhu | hi, ChrisSen, you can propose a patch for this :) | 02:23 |
| *** Tennyson has joined #senlin | 02:26 | |
| *** mathspanda has joined #senlin | 02:26 | |
| ChrisSen | Should I report a bug in senlin or python-senlinclient? | 02:31 |
| ChrisSen | Yanyanhu, you are right, you just have to change one line in the senlinclient/v1/shell.py and it seems to work. | 02:38 |
| *** Yanyanhu has quit IRC | 02:38 | |
| xuhaiwei | so you can report the bug to senlinclient, and give a patch for it, ChrisSen | 02:42 |
| *** Yanyanhu has joined #senlin | 02:48 | |
| Yanyanhu | hi, ChrisSen, sorry just dropped | 02:48 |
| Yanyanhu | I think you can report a bug in python-senlinclient | 02:48 |
| openstackgerrit | Qiming Teng proposed stackforge/senlin: Add config reload capability to wsgi https://review.openstack.org/207968 | 02:48 |
| Yanyanhu | since if user try to update metadata to '{}', this request should be accepted | 02:48 |
| Yanyanhu | if they mean to do this | 02:49 |
| openstackgerrit | Merged stackforge/senlin: Fix UnboundLocalError when updating a cluster without nodes https://review.openstack.org/209025 | 02:52 |
| openstackgerrit | Merged stackforge/senlin: Updated from global requirements https://review.openstack.org/209095 | 02:52 |
| openstackgerrit | Qiming Teng proposed stackforge/senlin: Base trigger implementation https://review.openstack.org/206527 | 02:55 |
| openstackgerrit | Qiming Teng proposed stackforge/python-senlinclient: Preparation for senlinclient test cases https://review.openstack.org/209327 | 03:01 |
| openstackgerrit | xu-haiwei proposed stackforge/senlin: Do not update other properties if exception happens https://review.openstack.org/209026 | 03:04 |
| xuhaiwei | I will have a vocation this afternoon, see you tomorrow guys | 03:14 |
| Qiming | see you | 03:14 |
| openstackgerrit | Qiming Teng proposed stackforge/senlin: Base trigger implementation https://review.openstack.org/206527 | 03:18 |
| Yanyanhu | hi, Qiming, about this patch proposed by haiwei https://review.openstack.org/#/c/209026/3 | 03:37 |
| Yanyanhu | so this is just an interim solution right? | 03:37 |
| Yanyanhu | since it actually didn't solve the problem | 03:37 |
| Yanyanhu | until we finish the TODO in the comment | 03:38 |
| Yanyanhu | also related test case is missing I think | 03:38 |
| openstackgerrit | Yanyan Hu proposed stackforge/senlin: [WIP]Start point of Senlin functional tests https://review.openstack.org/208355 | 03:43 |
| openstackgerrit | Yanyan Hu proposed stackforge/senlin: [WIP]Start point of Senlin functional tests https://review.openstack.org/208355 | 03:45 |
| openstackgerrit | Merged stackforge/senlin: Fix node join/leave cluster error https://review.openstack.org/208392 | 03:45 |
| *** jruano has quit IRC | 03:55 | |
| *** jruano has joined #senlin | 03:57 | |
| *** Yanyan has joined #senlin | 04:00 | |
| *** Yanyanhu has quit IRC | 04:02 | |
| *** Yanyanhu has joined #senlin | 04:03 | |
| *** Yanyan has quit IRC | 04:04 | |
| *** Zhenqi has quit IRC | 04:21 | |
| *** jruano has quit IRC | 04:46 | |
| openstackgerrit | Yanyan Hu proposed stackforge/senlin: [WIP]Start point of Senlin functional tests https://review.openstack.org/208355 | 05:29 |
| openstackgerrit | Yanyan Hu proposed stackforge/senlin: Add os.senlin.test profile type https://review.openstack.org/209366 | 06:25 |
| Yanyanhu | hi, Qiming, thanks for review of functional test patch. Just gave some answers there. | 06:29 |
| Qiming | which one? | 06:29 |
| Yanyanhu | BTW, I have proposed a patch to add a os.senlin.test profile type which could be useful for functional test | 06:29 |
| Yanyanhu | the WIP one | 06:30 |
| Yanyanhu | both the answer and question are in patchset 6... | 06:30 |
| Yanyanhu | https://review.openstack.org/208355 | 06:30 |
| Qiming | okay | 06:30 |
| Qiming | comments to line 124 is special | 06:30 |
| Qiming | self.catalogs is not intialized in __init__ | 06:31 |
| Yanyanhu | you mean the __init__ of TestSenlinAPIClient? | 06:31 |
| Qiming | when I'm writing code like this, I'm always getting an error like 'catalogs' is not an attribute | 06:31 |
| Yanyanhu | hmm, weird. It works in my env | 06:32 |
| Qiming | so ... I was doubting whether you have executed that line in particular | 06:32 |
| Yanyanhu | let me have a look | 06:32 |
| Qiming | ok | 06:32 |
| Yanyanhu | hi, Qiming, this line really worked, just added some log there to test it. | 06:34 |
| Yanyanhu | hmm, not sure why not attribute error happened | 06:34 |
| Yanyanhu | I will add an initialization of this attr in __init__ | 06:34 |
| Qiming | umm | 06:37 |
| Qiming | that is weird | 06:37 |
| Yanyanhu | yes | 06:38 |
| Yanyanhu | hi, Qiming, about the test profile type, you mean we dynamic enable it when doing functional test? | 06:40 |
| Yanyanhu | e.g. cp test.py into senlin/profile/os/senlin and modify entry_point, then restart senlin service? | 06:41 |
| Qiming | yes, it is supposed to be registered before you want to do something | 06:41 |
| Yanyanhu | hmm, ok | 06:41 |
| Yanyanhu | just feel maybe it's helpful for user to verify senlin without other services, like nova | 06:41 |
| Qiming | don't think it will be used by users without causing confusion though | 06:42 |
| Yanyanhu | but agree that they can do similar thing manually | 06:42 |
| Yanyanhu | just like what we do in functional test | 06:42 |
| Qiming | they are not developers | 06:42 |
| Qiming | why do they bother to care this | 06:42 |
| Yanyanhu | ok | 06:42 |
| Yanyanhu | will put them into tests/functional directory | 06:43 |
| Qiming | another approach in some projects is to provide stubs for the "other" services | 06:45 |
| Qiming | for example, suppose a server_get() will always returning some data | 06:45 |
| Yanyanhu | ok | 06:46 |
| Yanyanhu | will make some investigation about this | 06:46 |
| openstackgerrit | Yanyan Hu proposed stackforge/senlin: Fix some errors in profile unit test https://review.openstack.org/209371 | 06:50 |
| Qiming | hi, all | 06:55 |
| Qiming | need some helps on reviewing this: https://review.openstack.org/#/c/206527/ | 06:55 |
| Yanyanhu | got it | 06:55 |
| openstackgerrit | Merged stackforge/senlin: Fix some errors in profile unit test https://review.openstack.org/209371 | 07:05 |
| openstackgerrit | Yanyan Hu proposed stackforge/senlin: [WIP]Start point of Senlin functional tests https://review.openstack.org/208355 | 07:39 |
| *** xuhaiwei has quit IRC | 07:53 | |
| Qiming | hi Yanyanhu | 07:55 |
| Yanyanhu | hello | 07:55 |
| Qiming | just noticed that you are using admin endpoint for functional test | 07:55 |
| Yanyanhu | ok, no problem, just not sure about some usage | 07:55 |
| Qiming | ok | 07:57 |
| ChrisSen | I created some clusters and tried to filter the list of clusters, but all of them are displayed, even the ones that don't match the filter criteria: | 07:58 |
| ChrisSen | http://paste.openstack.org/show/408089/ | 07:58 |
| Qiming | ChrisSen, looks like the same issue at senlinclient? | 08:06 |
| openstackgerrit | Merged stackforge/senlin: Base trigger implementation https://review.openstack.org/206527 | 08:08 |
| openstackgerrit | Yanyan Hu proposed stackforge/senlin: Add SenlinTest profile type https://review.openstack.org/209366 | 08:08 |
| Qiming | ChrisSen, can reproduce this situation, seems like caused by python-openstacksdk | 08:11 |
| ChrisSen | ok. So is there any action required for me? | 08:18 |
| *** mathspanda has quit IRC | 08:20 | |
| Qiming | ChrisSen, I'm looking into it | 08:21 |
| *** mathspanda has joined #senlin | 08:21 | |
| Qiming | please file a bug if okay for you | 08:21 |
| ChrisSen | I can do that. In which project (senlin, python-senlinclient or something else)? | 08:22 |
| Qiming | in senlinclient I think | 08:23 |
| Qiming | the metadata creation problem still exists? | 08:25 |
| Qiming | the other day, a related bug led us to somewhere here, remember? http://git.openstack.org/cgit/stackforge/python-senlinclient/tree/senlinclient/common/utils.py#n110 | 08:26 |
| ChrisSen | I created a bug for the filter issue. | 08:28 |
| Qiming | okay, maybe this is related to another bug here: https://bugs.launchpad.net/senlin/+bug/1480770 | 08:29 |
| openstack | Launchpad bug 1480770 in senlin "Misleading documentation for creating profile with metadata" [Medium,Triaged] - Assigned to Chris Senzel (csenzel) | 08:29 |
| ChrisSen | We updated the documentation for creating a profile with metadata, but have not been able to commit yet. | 08:30 |
| Qiming | thanks, ChrisSen | 08:37 |
| openstackgerrit | Qiming Teng proposed stackforge/python-senlinclient: Fix filters param passing https://review.openstack.org/209403 | 08:45 |
| Qiming | ChrisSen, check the patch ^ | 08:45 |
| ChrisSen | The patch works fine. | 08:47 |
| Qiming | thanks for spotting this, it was a serious mistake | 08:49 |
| Qiming | all filters param wasn't treated correctly before. | 08:49 |
| openstackgerrit | Merged stackforge/python-senlinclient: Fix filters param passing https://review.openstack.org/209403 | 09:05 |
| *** Tennyson has quit IRC | 09:33 | |
| *** mathspanda has quit IRC | 09:39 | |
| *** Yanyanhu has quit IRC | 09:40 | |
| *** Yanyanhu has joined #senlin | 09:40 | |
| *** ChrisSen has quit IRC | 10:02 | |
| *** Yanyanhu has quit IRC | 10:15 | |
| *** elynn has quit IRC | 10:29 | |
| *** Qiming has quit IRC | 10:45 | |
| *** jruano has joined #senlin | 10:50 | |
| openstackgerrit | Merged stackforge/python-senlinclient: Preparation for senlinclient test cases https://review.openstack.org/209327 | 10:50 |
| *** ChrisSen has joined #senlin | 11:14 | |
| *** ChrisSen has quit IRC | 11:22 | |
| *** Qiming has joined #senlin | 11:36 | |
| *** mathspanda has joined #senlin | 11:43 | |
| openstackgerrit | Merged stackforge/senlin: Add SenlinTest profile type https://review.openstack.org/209366 | 11:53 |
| openstackgerrit | Qiming Teng proposed stackforge/senlin: Ceilometer alarm trigger support https://review.openstack.org/209494 | 12:44 |
| *** lkarm has joined #senlin | 12:47 | |
| *** mathspanda has quit IRC | 13:04 | |
| *** mathspan_ has joined #senlin | 13:14 | |
| *** mathspan_ has quit IRC | 13:21 | |
| openstackgerrit | Qiming Teng proposed stackforge/senlin: Rename a folder under unit test https://review.openstack.org/209519 | 13:38 |
| *** jdandrea has joined #senlin | 13:39 | |
| openstackgerrit | Merged stackforge/senlin: Rename a folder under unit test https://review.openstack.org/209519 | 14:35 |
| *** jruano has quit IRC | 14:49 | |
| openstackgerrit | Qiming Teng proposed stackforge/senlin: Engine support for triggers https://review.openstack.org/209545 | 14:51 |
| *** Qiming has quit IRC | 15:05 | |
| *** openstackgerrit_ has joined #senlin | 16:30 | |
| *** openstackgerrit_ has quit IRC | 17:05 | |
| *** openstackgerrit_ has joined #senlin | 17:25 | |
| *** openstackgerrit_ has quit IRC | 17:34 | |
| *** openstackgerrit has quit IRC | 18:46 | |
| *** openstackgerrit has joined #senlin | 18:47 | |
| *** lkarm has quit IRC | 20:08 | |
| *** Qiming has joined #senlin | 23:07 | |
| openstackgerrit | Qiming Teng proposed stackforge/senlin: Engine support for triggers https://review.openstack.org/209545 | 23:15 |
| *** xuhaiwei has joined #senlin | 23:39 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!