| *** sacharya has joined #savanna | 00:27 | |
| openstackgerrit | Trevor McKay proposed a change to stackforge/savanna: Add database support for JobBinary objects https://review.openstack.org/42722 | 01:53 |
|---|---|---|
| openstackgerrit | Trevor McKay proposed a change to stackforge/savanna: Add database support for JobBinary objects https://review.openstack.org/42722 | 02:01 |
| tmckay | Question for the morning -- how do I run an individual unit test? My JobBinary test is failing. | 02:27 |
| *** sacharya has quit IRC | 04:00 | |
| *** akuznetsov has joined #savanna | 04:16 | |
| *** ogelbukh has quit IRC | 05:06 | |
| *** akuznetsov has quit IRC | 05:28 | |
| *** nprivalova has joined #savanna | 06:39 | |
| *** nprivalova has quit IRC | 06:51 | |
| *** ruhe has joined #savanna | 06:52 | |
| *** benl has joined #savanna | 07:51 | |
| *** aignatov has quit IRC | 08:00 | |
| *** aignatov has joined #savanna | 08:01 | |
| *** nprivalova has joined #savanna | 08:23 | |
| *** dmitryme has joined #savanna | 08:59 | |
| *** akuznetsov has joined #savanna | 09:11 | |
| *** ruhe has quit IRC | 09:16 | |
| *** ruhe has joined #savanna | 09:18 | |
| *** ruhe has quit IRC | 09:37 | |
| *** akuznetsov has quit IRC | 09:37 | |
| *** akuznetsov has joined #savanna | 09:40 | |
| *** akuznetsov has quit IRC | 09:43 | |
| *** dmitryme has quit IRC | 09:45 | |
| *** dmitryme has joined #savanna | 10:09 | |
| *** nprivalova has quit IRC | 10:14 | |
| *** akuznetsov has joined #savanna | 10:14 | |
| *** ruhe has joined #savanna | 10:16 | |
| *** benl has quit IRC | 10:22 | |
| openstackgerrit | Vadim Rovachev proposed a change to stackforge/savanna: Change requirements.txt https://review.openstack.org/43087 | 10:34 |
| *** nprivalova has joined #savanna | 10:36 | |
| *** SergeyLukjanov has joined #savanna | 10:50 | |
| *** SergeyLukjanov has quit IRC | 10:54 | |
| *** ruhe has quit IRC | 10:59 | |
| *** ruhe has joined #savanna | 11:01 | |
| *** SergeyLukjanov has joined #savanna | 11:03 | |
| *** dina_belova has joined #savanna | 11:05 | |
| *** dmitryme has quit IRC | 11:05 | |
| *** dmitryme has joined #savanna | 11:06 | |
| *** dmitryme has quit IRC | 11:22 | |
| *** ivan1 has joined #savanna | 11:27 | |
| openstackgerrit | Vadim Rovachev proposed a change to stackforge/savanna: Change requirements.txt https://review.openstack.org/43087 | 11:28 |
| openstackgerrit | Vadim Rovachev proposed a change to stackforge/savanna: Limit requests version https://review.openstack.org/43087 | 11:31 |
| *** benl has joined #savanna | 11:33 | |
| *** benl has quit IRC | 11:37 | |
| openstackgerrit | Nikolay Mahotkin proposed a change to stackforge/savanna-extra: Fixing bug getBlockSize in swift patch https://review.openstack.org/43103 | 11:41 |
| openstackgerrit | Nikolay Mahotkin proposed a change to stackforge/savanna-extra: Fixing bug getBlockSize in hadoop patch https://review.openstack.org/43103 | 11:45 |
| *** dina_belova has quit IRC | 11:45 | |
| *** dmitryme has joined #savanna | 11:48 | |
| openstackgerrit | Sergey Lukjanov proposed a change to stackforge/savanna: Limit requests version https://review.openstack.org/43087 | 11:59 |
| *** ruhe has quit IRC | 12:00 | |
| openstackgerrit | A change was merged to stackforge/savanna: Sync OpenStack commons with oslo-incubator https://review.openstack.org/42311 | 12:00 |
| openstackgerrit | Sergey Lukjanov proposed a change to stackforge/savanna: Limit requests version https://review.openstack.org/43087 | 12:02 |
| openstackgerrit | A change was merged to stackforge/savanna: Add __author__ attr check https://review.openstack.org/42719 | 12:04 |
| *** SergeyLukjanov has quit IRC | 12:11 | |
| *** nprivalova has quit IRC | 12:11 | |
| openstackgerrit | Alexander Kuznetsov proposed a change to stackforge/python-savannaclient: Now create methods return a new object https://review.openstack.org/42668 | 12:25 |
| openstackgerrit | Alexander Kuznetsov proposed a change to stackforge/python-savannaclient: Added API for job, data_source and job_origin https://review.openstack.org/42641 | 12:25 |
| *** akuznetsov has quit IRC | 12:31 | |
| *** _crobertsrh is now known as crobertsrh | 12:32 | |
| openstackgerrit | A change was merged to stackforge/savanna: Limit requests version https://review.openstack.org/43087 | 12:33 |
| openstackgerrit | A change was merged to stackforge/savanna: Refactoring cinder support https://review.openstack.org/42655 | 12:33 |
| *** akuznetsov has joined #savanna | 12:36 | |
| openstackgerrit | Chad Roberts proposed a change to stackforge/savanna-dashboard: Adds EDP support in the UI https://review.openstack.org/41482 | 12:40 |
| tmckay | akuzentsov, re raw binary conductor interface, yes, I had the same thought on my way to bed last night :) Too bad deferred column loading doesn't seem to work -- I think it would be tough to support that in savanna. General code that traverses elements would have to be very careful, and exceptions are raised if there is not a session object available. | 12:58 |
| tmckay | akuznetsov, by the way, do you know how to run a single unit test? My unit test for JobBinary fails, I discovered late last night, but I haven't tried to debug yet. | 12:59 |
| *** nprivalova has joined #savanna | 12:59 | |
| *** akuznetsov has quit IRC | 13:01 | |
| tmckay | ah, missed him. | 13:01 |
| *** dmitryme_ has joined #savanna | 13:02 | |
| *** dmitryme has quit IRC | 13:02 | |
| *** dmitryme_ is now known as dmitryme | 13:02 | |
| tmckay | nprivalova, maybe you know the answer -- is there a way to run a single unit test? My test fails, it will be easier to debug if I can run only one. Do I have to write a standalone wrapper? Or can I do it with tox, or some other existing script? | 13:02 |
| *** ruhe has joined #savanna | 13:04 | |
| nprivalova | tmckay, hi! I run tests from IDE | 13:04 |
| tmckay | ah, I use only the command line and tox :) | 13:04 |
| tmckay | well, and emacs | 13:05 |
| nprivalova | tmckay, I see :) Let me find someone who knows | 13:06 |
| tmckay | nprivalova, thanks, I'm sure it's possible. I thought I would ask before I trace through the test code... | 13:07 |
| tmckay | I think savanna/savanna/tests/README.rst needs some more content ;-) | 13:10 |
| *** dina_belova has joined #savanna | 13:11 | |
| *** dina_belova has quit IRC | 13:12 | |
| nprivalova | tmckay, here an example | 13:12 |
| nprivalova | .tox/venv/bin/nosetests -w unit/service/test_instances.py | 13:12 |
| *** dina_belova has joined #savanna | 13:12 | |
| tmckay | nprivalova, ah, thanks | 13:13 |
| *** dina_belova has quit IRC | 13:17 | |
| *** akuznetsov has joined #savanna | 13:20 | |
| tmckay | nprivalova, btw, this will only the edp tests (if you are without your IDE :) ) -> .tox/venv/bin/nosetests --tests=savanna.tests.unit.conductor.manager.test_edp | 13:36 |
| nprivalova | tmckay, ok :) | 13:37 |
| tmckay | oops, pasted the wrong line. | 13:38 |
| tmckay | .tox/venv/bin/nosetests --tests=savanna.tests.unit.conductor.manager.test_edp | 13:38 |
| openstackgerrit | Ivan Berezovskiy proposed a change to stackforge/savanna-extra: Add DIB mysql element https://review.openstack.org/43128 | 13:59 |
| openstackgerrit | Ivan Berezovskiy proposed a change to stackforge/savanna-extra: Add HIVE DIB element https://review.openstack.org/41426 | 13:59 |
| *** dina_belova has joined #savanna | 14:13 | |
| *** sacharya has joined #savanna | 14:15 | |
| *** dina_belova has quit IRC | 14:17 | |
| *** ruhe has quit IRC | 14:17 | |
| *** sacharya has quit IRC | 14:32 | |
| *** akuznetsov has quit IRC | 14:35 | |
| *** akuznetsov has joined #savanna | 14:50 | |
| *** rnirmal has joined #savanna | 14:53 | |
| *** ruhe has joined #savanna | 14:57 | |
| *** akuznetsov has quit IRC | 14:58 | |
| *** akuznetsov has joined #savanna | 14:59 | |
| *** dmitryme has quit IRC | 15:04 | |
| *** sacharya has joined #savanna | 15:04 | |
| *** rnirmal has quit IRC | 15:10 | |
| *** dina_belova has joined #savanna | 15:13 | |
| openstackgerrit | Ivan Berezovskiy proposed a change to stackforge/savanna-extra: Add DIB mysql element https://review.openstack.org/43128 | 15:18 |
| *** dina_belova has quit IRC | 15:18 | |
| tmckay | question all, where do the unit tests create a savanna db? It is not persistent, is it? | 15:19 |
| openstackgerrit | Nadya Privalova proposed a change to stackforge/savanna: First version of job manager https://review.openstack.org/42304 | 15:24 |
| nprivalova | tmckay, try to run tests, but stop it before ending. after that find file with name 'savanna.db' or smth like that | 15:30 |
| tmckay | thanks | 15:31 |
| *** akuznetsov has quit IRC | 15:49 | |
| *** SergeyLukjanov has joined #savanna | 15:49 | |
| *** nprivalova has quit IRC | 15:51 | |
| *** dina_belova has joined #savanna | 15:54 | |
| *** ivan1 has left #savanna | 15:54 | |
| *** ruhe has quit IRC | 16:05 | |
| openstackgerrit | Trevor McKay proposed a change to stackforge/savanna: Add database support for JobBinary objects https://review.openstack.org/42722 | 16:06 |
| *** SergeyLukjanov has quit IRC | 16:16 | |
| *** rnirmal has joined #savanna | 16:18 | |
| *** ruhe has joined #savanna | 16:21 | |
| *** SergeyLukjanov has joined #savanna | 16:28 | |
| *** dina_belova has quit IRC | 16:32 | |
| *** dina_belova has joined #savanna | 16:37 | |
| *** akuznetsov has joined #savanna | 16:38 | |
| *** tmckay is now known as _tmckay | 16:51 | |
| *** ruhe has quit IRC | 17:04 | |
| *** SergeyLukjanov has quit IRC | 17:09 | |
| *** dina_belova has quit IRC | 17:10 | |
| *** dina_belova has joined #savanna | 17:12 | |
| *** dina_belova has quit IRC | 17:15 | |
| *** akuznetsov has quit IRC | 17:25 | |
| *** ruhe has joined #savanna | 17:26 | |
| *** akuznetsov has joined #savanna | 17:28 | |
| *** akuznetsov has quit IRC | 17:41 | |
| *** rnirmal has quit IRC | 17:43 | |
| *** SergeyLukjanov has joined #savanna | 17:43 | |
| openstackgerrit | A change was merged to stackforge/savanna: Added Heap Size provisioning for Oozie https://review.openstack.org/42929 | 17:44 |
| crobertsrh | _tmckay, anyone else: currently job contains input_type and output_type. Should those actually be an input_data_source and output_data_source? I just noticed this while reviewing the job manager code. Job manager requires data_source_id for input and output. It seems like those should be defined in the job itself. | 17:48 |
| *** dina_belova has joined #savanna | 17:54 | |
| *** _tmckay is now known as tmckay | 17:57 | |
| tmckay | crobertsrh I'll take a look... | 17:57 |
| crobertsrh | Ok, I could just be misunderstanding something | 17:57 |
| crobertsrh | I'm just not sure what good it is to have the job store the type of the input/output rather than an actual data_source (id) | 17:58 |
| tmckay | crobertsrh, it could be that the input/output ids are in the JobExecution | 17:58 |
| *** ruhe has quit IRC | 17:58 | |
| tmckay | iirc, a JobExecution ends up essentially being an instance of a Job. | 17:58 |
| crobertsrh | but what use is it to bother with the types of input/output if they're never actually used anywhere? | 17:59 |
| crobertsrh | Right, looking at the code for executing a job lead me down this path. | 17:59 |
| tmckay | crobertsrh, it might be informational, a nod to the user about where the job can pull from/write to. nprivalova is the export | 18:02 |
| crobertsrh | Yeah, I commented on her review. Hope to hear from her tomorrow. | 18:02 |
| tmckay | I know she had put up some notes on the pad... Maybe something there explains it | 18:03 |
| crobertsrh | Ok, I'll see what I can dig up. Thanks. | 18:03 |
| *** rnirmal has joined #savanna | 18:08 | |
| openstackgerrit | Sergey Lukjanov proposed a change to stackforge/python-savannaclient: Update pbr and sync requirements https://review.openstack.org/43172 | 18:09 |
| openstackgerrit | Sergey Lukjanov proposed a change to stackforge/python-savannaclient: Added API for job, data_source and job_origin https://review.openstack.org/42641 | 18:10 |
| openstackgerrit | Sergey Lukjanov proposed a change to stackforge/python-savannaclient: Now create methods return a new object https://review.openstack.org/42668 | 18:13 |
| *** mattf is now known as _mattf | 18:18 | |
| openstackgerrit | Sergey Lukjanov proposed a change to stackforge/savanna: Migrate to pbr https://review.openstack.org/37480 | 18:26 |
| *** _mattf is now known as mattf | 18:27 | |
| openstackgerrit | Matthew Farrellee proposed a change to stackforge/savanna-extra: Add LICENSE file https://review.openstack.org/43177 | 18:39 |
| openstackgerrit | Matthew Farrellee proposed a change to stackforge/savanna-extra: Add missing #! to 81-add-jar https://review.openstack.org/43178 | 18:46 |
| openstackgerrit | A change was merged to stackforge/savanna-extra: Add LICENSE file https://review.openstack.org/43177 | 18:49 |
| *** akuznetsov has joined #savanna | 18:57 | |
| * mattf scratches head a bit on hive & mysql reviews | 19:09 | |
| mattf | the review transaction is gonna be a little convoluted | 19:10 |
| SergeyLukjanov | mattf, yep, it's frustrating | 19:12 |
| mattf | i think i'm going to review mysql only, then copy +1 to the hive review. | 19:14 |
| tmckay | SergeyLukjanov, on query filtering in REST, I was thinking that sometimes you may want to look up by name, and sometimes you may want id. "list all" could be a large response if there are a lot of objects and a user is trying to find a parituclar one. Maybe "/binaries", "/binaries/<id>" and "/binaries/name/<name>" is better? (same for any edp object with a name) | 19:24 |
| SergeyLukjanov | tmckay, I prefer to have some general way to support filtering for all list ops | 19:25 |
| SergeyLukjanov | let's omit it for now and create a bp or issue for it | 19:26 |
| SergeyLukjanov | to don't forget to return back to it when all main features will be implemented | 19:26 |
| tmckay | alright. Do you want to limit the api to (for example) "/binaries" and "binaries/<id>" for list operations for now? | 19:27 |
| tmckay | no names? | 19:27 |
| mattf | hmm -- https://review.openstack.org/#/c/43128/2/elements/mysql/install.d/99-clean-apt | 19:31 |
| mattf | i think i just saw a bug float by about cleaning caches | 19:31 |
| * mattf ponders | 19:31 | |
| SergeyLukjanov | tmckay, yep | 19:32 |
| mattf | soooooo....cleaning cache should happen unconditionally, not just after mysql install | 19:32 |
| mattf | and should really not be part of the mysql review | 19:32 |
| mattf | i'm starting to rethink my position on it being ok to have hive + mysql reviews overlapping like this. | 19:32 |
| tmckay | SergeyLukjanov, okey doke. By the way, I added a datasize field to the JobBinary, I thought "how big" might be something someone is interested in :) Coming soon to a review near you. | 19:33 |
| rnirmal | mattf: so this is having mysql configured specifically for hive right ? | 19:38 |
| mattf | rnirmal, yes. it's about getting mysql & hive in the disk image | 19:40 |
| rnirmal | hmm yeah just looking at it... not sure mysql startup fits in the hive postinstall | 19:41 |
| rnirmal | I wanted to discuss a few other items.. not sure who all are around at this time | 19:43 |
| mattf | i'll have a look at that w/ the next review request. it's kinda messy atm. | 19:43 |
| rnirmal | but wanted to talk about https://blueprints.launchpad.net/savanna/+spec/refactor-v1api today or tomorrow before the meeting and at the meeting | 19:43 |
| mattf | getting it on the agenda for tomorrow seems like a good idea | 19:44 |
| rnirmal | cool I'll add that. | 19:44 |
| rnirmal | I've been wanting to talk about it for the past two meetings and either I've had to leave early or the discussion dovetails into something else :) | 19:45 |
| mattf | well i won't be taking up much time this week | 19:48 |
| *** akuznetsov has quit IRC | 19:49 | |
| rnirmal | there's always plenty to discuss | 19:52 |
| mattf | may have to deal with an uprising when None beats SergeyLukjanov for the PTL position | 19:59 |
| SergeyLukjanov | rnirmal, hi | 20:03 |
| SergeyLukjanov | rnirmal, I was looking at your bp several days ago, but it's very difficult to find some concrete suggestions, could you please add some concrete points to improve? | 20:09 |
| rnirmal | SergeyLukjanov: yes I'll try to refine it more into talking points | 20:12 |
| SergeyLukjanov | rnirmal, thank you | 20:12 |
| rnirmal | that way it will help with discussions. I want to also provide good use case scenarios as well | 20:12 |
| rnirmal | SergeyLukjanov: do you have users already actively using the api | 20:13 |
| *** rnirmal has quit IRC | 20:18 | |
| *** benl has joined #savanna | 20:19 | |
| SergeyLukjanov | rnirmal, I think now is the best time to improve api | 20:21 |
| SergeyLukjanov | btw we're preparing 1.1 version with EDP | 20:21 |
| *** crobertsrh is now known as _crobertsrh | 20:25 | |
| openstackgerrit | Trevor McKay proposed a change to stackforge/savanna: Add database support for JobBinary objects https://review.openstack.org/42722 | 20:33 |
| *** rnirmal has joined #savanna | 20:38 | |
| rnirmal | that sounds good, I'll look at the EDP api as well | 20:39 |
| *** dina_belova has quit IRC | 21:16 | |
| openstackgerrit | Trevor McKay proposed a change to stackforge/savanna: Add a stub API for managing job binaries in the savanna db https://review.openstack.org/42213 | 21:27 |
| *** tmckay has quit IRC | 21:38 | |
| *** tmckay has joined #savanna | 21:40 | |
| *** SergeyLukjanov has quit IRC | 21:45 | |
| *** mattf is now known as _mattf | 21:56 | |
| *** dina_belova has joined #savanna | 22:17 | |
| *** dina_belova has quit IRC | 22:21 | |
| *** dina_belova has joined #savanna | 22:27 | |
| *** dina_belova has quit IRC | 22:32 | |
| *** sacharya has quit IRC | 22:48 | |
| *** benl has quit IRC | 22:53 | |
| *** rnirmal has quit IRC | 23:05 | |
| *** dina_belova has joined #savanna | 23:28 | |
| *** dina_belova has quit IRC | 23:32 | |
| *** jcooley has quit IRC | 23:41 | |
| *** jcooley has joined #savanna | 23:44 | |
| *** sacharya has joined #savanna | 23:51 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!