| *** tosky has joined #refstack | 07:33 | |
| kopecmartin | arxcruz: tosky hi, when you have a moment, please have a look at these: https://review.opendev.org/#/c/739690/ and https://review.opendev.org/#/c/720093/ | 08:51 |
|---|---|---|
| arxcruz | kopecmartin: https://review.opendev.org/#/c/720093/ i would like to hold for now, until i have time to review the cirros image on tripleo, because it's gaving us a lot of trouble how we are setting the cirros version | 08:57 |
| arxcruz | give me one or two days, i'm finishing the skiplist stuff | 08:57 |
| kopecmartin | arxcruz: sure, np | 08:58 |
| kopecmartin | that change is delicate, so better be careful and not to rush things | 08:58 |
| tosky | yep, also because it depends whether we support older tempest with newer tempestconf | 10:23 |
| kopecmartin | tosky: the change is trying to support both behaviours of tempest (with and without img_dir) although this big question will come after tempest drops the img_dir entirely | 10:39 |
| tosky | kopecmartin: is there a way python-tempestconf can hide the change? | 10:41 |
| kopecmartin | tosky: o.O what do you mean_ | 10:41 |
| kopecmartin | ? | 10:41 |
| tosky | does it work with the older versions if we always set img_dir to an empty string and img_file to the full path? | 10:46 |
| kopecmartin | tosky: it does, i explained in the comment in config_tempest/services/image.py .. basically it will work if we use an absolute path, because the old tempest concats the two strings ("" + abspath is still abspath) | 11:59 |
| tosky | uhm, right | 12:01 |
| tosky | I guess it shouldn't be so problematic in the end | 12:01 |
| kopecmartin | maybe not, we'll just need to be careful and not backport the change which removes setting img_dir from tempestconf to releases where old tempest is used | 12:08 |
| tosky | but if it's compatible, why not? | 12:08 |
| kopecmartin | this change is compatible, i was talking about the one which we'll make when tempest drops img_dir | 12:12 |
| tosky | can't we just continue to set it as long we can work with older tempest releases? At most tempest will be ignore it | 12:50 |
| kopecmartin | i guess we can | 13:29 |
| *** davidlenwell has joined #refstack | 19:32 | |
| *** ChanServ sets mode: +o davidlenwell | 19:32 | |
| *** beisner has joined #refstack | 19:42 | |
| *** kopecmartin is now known as kopecmartin|pto | 19:52 | |
| *** fyx has joined #refstack | 19:55 | |
| *** samueldmq has joined #refstack | 20:16 | |
| *** tosky has quit IRC | 22:30 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!