| *** altlogbot_3 has quit IRC | 02:44 | |
| *** altlogbot_0 has joined #refstack | 02:46 | |
| *** kopecmartin|off is now known as kopecmartin | 07:04 | |
| *** tosky has joined #refstack | 07:23 | |
| openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: Replace os-client-config module by openstacksdk https://review.opendev.org/674635 | 07:30 |
|---|---|---|
| kopecmartin | hogepodge: Hi, please, when you have a moment, have a look at the chain of reviews for refstack-client starting by this one: https://review.opendev.org/#/c/673222/ | 07:33 |
| openstackgerrit | Merged openstack/python-tempestconf master: Add Queens, Rocky and Stein job https://review.opendev.org/675105 | 11:52 |
| openstackgerrit | Merged openstack/python-tempestconf master: Replace os-client-config module by openstacksdk https://review.opendev.org/674635 | 13:17 |
| tosky | ... and done | 13:48 |
| kopecmartin | \o/ | 14:01 |
| tosky | kopecmartin: I just noticed two references to os_client_config inside config_tempest/tests/base.py; I wonder how that code can work | 15:20 |
| kopecmartin | :o | 15:21 |
| kopecmartin | let me check | 15:21 |
| kopecmartin | :D the decorator is not used in the code and the other reference just mocks that in the real code, it doesn't have to be really there but if was it would be mocked | 15:24 |
| kopecmartin | ah, i should have noticed .. let me send a follow-up patch | 15:25 |
| kopecmartin | i was just about to create a review for a new release :/ | 15:25 |
| tosky | but how is it working then? :) | 15:25 |
| kopecmartin | that part of the code is old, ~2 years, seems the mock is useless there, the part of the code which should be mocked is not there anymore | 15:37 |
| openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: Remove leftover os_client_config references https://review.opendev.org/675649 | 15:47 |
| *** kopecmartin is now known as kopecmartin|off | 16:29 | |
| *** irclogbot_2 has quit IRC | 16:47 | |
| *** irclogbot_3 has joined #refstack | 16:51 | |
| *** tosky has quit IRC | 23:32 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!