| *** markvoelker has quit IRC | 01:05 | |
| *** markvoelker has joined #refstack | 03:06 | |
| *** markvoelker has quit IRC | 03:40 | |
| *** markvoelker has joined #refstack | 04:37 | |
| *** raukadah is now known as chandankumar | 04:52 | |
| *** markvoelker has quit IRC | 05:10 | |
| *** kopecmartin|off is now known as kopecmartin | 06:04 | |
| *** markvoelker has joined #refstack | 06:07 | |
| *** markvoelker has quit IRC | 06:40 | |
| *** jhesketh has quit IRC | 07:11 | |
| *** tosky has joined #refstack | 07:35 | |
| *** markvoelker has joined #refstack | 07:37 | |
| kopecmartin | hi tosky , at the end I reused run-tempest here https://review.opendev.org/#/c/645240/ can you have a look? | 07:52 |
|---|---|---|
| *** markvoelker has quit IRC | 08:10 | |
| *** markvoelker has joined #refstack | 09:07 | |
| *** markvoelker has quit IRC | 09:40 | |
| *** markvoelker has joined #refstack | 10:37 | |
| *** markvoelker has quit IRC | 11:11 | |
| arxcruz | tosky: kopecmartin chandankumar regarding https://review.opendev.org/#/c/626539/ are you guys okay with that? for me doesn't matter, but a job to test only if the tempest.conf generated with append option works properly should be a python test, not a shell script, it runs quickly, but still | 11:29 |
| arxcruz | if you guys are fine, i will not oppose though | 11:30 |
| tosky | I think that the reason is that it's testing the shell command, not the internal API | 11:32 |
| tosky | how would you rewrite it? | 11:32 |
| * tosky bbl | 11:32 | |
| kopecmartin | i don't know, we may not need it, i wrote it because someone mentioned that tempest.conf should be tested so I tried to start with that | 11:33 |
| arxcruz | so, if the output uses the internal api, and the output is wrong, it means the internal api is wrong | 11:33 |
| arxcruz | i think we need a validation on the final output of the tempest.conf file generated indeed | 11:34 |
| arxcruz | but not sure if that's the best way to do it | 11:34 |
| arxcruz | as i said, up to you guys. If the plan here is to extend that in the future that's cool | 11:35 |
| kopecmartin | hmm, we could write a python script then, as you suggested , i t would parse the tempest.conf and do some checks | 11:37 |
| kopecmartin | so we don't have to merge it, let's leave it there until we know what we want to do with that | 11:38 |
| kopecmartin | I'm more concerned about this review https://review.opendev.org/#/c/645240/ | 11:38 |
| kopecmartin | if no one is against, let's merge that one | 11:38 |
| arxcruz | kopecmartin: fine by me, as far as you add a new story to add more plugins on that :) | 11:54 |
| kopecmartin | arxcruz, does it have to be a special story? for example this heat-tempest-plugin tests were added as a part of a story related to adding support of heat plugin .. so next time when we'll be adding support for another plugin, we'll add tests of that plugin | 12:01 |
| arxcruz | no, just to keep track of this and not get lost in the void | 12:01 |
| *** markvoelker has joined #refstack | 12:06 | |
| *** tosky__ has joined #refstack | 13:21 | |
| *** tosky is now known as Guest72073 | 13:21 | |
| *** tosky__ is now known as tosky | 13:21 | |
| chandankumar | kopecmartin: telemetry skip is merged now, ci is work | 14:23 |
| kopecmartin | \o/ | 14:24 |
| kopecmartin | chandankumar, good work | 14:24 |
| *** chandankumar is now known as raukadah | 14:25 | |
| *** tosky has quit IRC | 15:16 | |
| *** kopecmartin is now known as kopecmartin|off | 15:58 | |
| openstackgerrit | Merged openstack/python-tempestconf master: Add a job for tempest plugins https://review.opendev.org/645240 | 16:09 |
| *** irclogbot_2 has quit IRC | 17:17 | |
| *** irclogbot_1 has joined #refstack | 17:19 | |
| *** tosky has joined #refstack | 21:36 | |
| *** tosky has quit IRC | 23:04 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!