| openstackgerrit | Chandan Kumar proposed openstack/python-tempestconf master: Added python-tempestconf-tempest-devstack-py3 https://review.openstack.org/627923 | 06:04 |
|---|---|---|
| openstackgerrit | Chandan Kumar proposed openstack/python-tempestconf master: Added python-tempestconf-tempest-devstack-py3 https://review.openstack.org/622865 | 06:05 |
| openstackgerrit | Chandan Kumar proposed openstack/python-tempestconf master: Added python-tempestconf-tempest-devstack-py3 https://review.openstack.org/622865 | 07:25 |
| openstackgerrit | Chandan Kumar proposed openstack/python-tempestconf master: [DNM] testing os_tempest https://review.openstack.org/627482 | 07:37 |
| openstackgerrit | Chandan Kumar proposed openstack/python-tempestconf master: [DNM] testing os_tempest https://review.openstack.org/627482 | 07:37 |
| openstackgerrit | Chandan Kumar proposed openstack/python-tempestconf master: [DNM] testing os_tempest https://review.openstack.org/627482 | 07:41 |
| *** arxcruz|next_yr is now known as arxcruz | 07:47 | |
| *** tosky has joined #refstack | 08:14 | |
| openstackgerrit | Chandan Kumar proposed openstack/python-tempestconf master: [DNM] testing os_tempest https://review.openstack.org/627482 | 08:48 |
| *** chandankumar has joined #refstack | 08:50 | |
| chandankumar | tosky: Happy New year :-) | 08:51 |
| chandankumar | tosky: kopecmartin arxcruz https://review.openstack.org/#/c/622865/ python3 stuff finally worked | 08:51 |
| tosky | happy new year! | 08:52 |
| tosky | oh | 08:52 |
| chandankumar | tosky: :-) | 08:52 |
| kopecmartin | happy new year to all of you! | 08:55 |
| kopecmartin | chandankumar, great it worked | 08:55 |
| kopecmartin | however , now we need to figure out a different check for tempest.conf and tempest_profile.conf , because it seems the extensions are discovered not int the same order all the times :/ | 08:55 |
| chandankumar | kopecmartin: there are some configparser warning http://logs.openstack.org/65/622865/32/check/python-tempestconf-tempest-devstack-py3/d019b46/job-output.txt.gz#_2019-01-02_08_00_24_617828 | 08:56 |
| chandankumar | kopecmartin: I am taking that into account also | 08:57 |
| chandankumar | in the same patch also | 08:57 |
| openstackgerrit | Chandan Kumar proposed openstack/python-tempestconf master: Added python-tempestconf-tempest-devstack-py3 https://review.openstack.org/622865 | 09:01 |
| tosky | chandankumar: for configparser, there is a transition class in the six library, please use it | 09:02 |
| chandankumar | tosky: sure, then I will move it to a seperate patch | 09:03 |
| tosky | chandankumar: as it's part of python3 compatibility, please keep it in the same patch | 09:03 |
| tosky | or send it in a patch that should be merged *before* the patch which adds the py3 job | 09:03 |
| tosky | not after | 09:03 |
| chandankumar | sure | 09:05 |
| chandankumar | tosky: actually six is already used there https://review.openstack.org/#/c/622865/33/config_tempest/tempest_conf.py@21 and https://review.openstack.org/#/c/622865/33/config_tempest/main.py@44 | 09:22 |
| tosky | oh, right | 09:23 |
| tosky | so the change should be safe | 09:23 |
| tosky | uhm, maybe not | 09:26 |
| tosky | chandankumar: the change will re-introduce the !safeConfigParser on python2 | 09:27 |
| tosky | chandankumar: other users check for six.PY3 and create a SafeConfigParser or a ConfigParser | 09:29 |
| chandankumar | tosky: ok looking into that | 09:30 |
| chandankumar | tosky: then we will endup putting bunch of if else | 09:34 |
| chandankumar | with six.py3 | 09:35 |
| tosky | yeah, it's not clean, but that's what everyone else is doing | 09:36 |
| chandankumar | tosky: ok I will put a fresh patch with six.py3 | 09:37 |
| tosky | chandankumar: if it's a separate patch, then please revert to SafeConfigParser in the patch which adds the py3 job | 09:37 |
| chandankumar | on it | 09:38 |
| openstackgerrit | Chandan Kumar proposed openstack/python-tempestconf master: Added python-tempestconf-tempest-devstack-py3 https://review.openstack.org/622865 | 09:39 |
| chandankumar | arxcruz: kopecmartin tosky http://logs.openstack.org/65/622865/34/check/python-tempestconf-tempest-devstack-py3/0be23d3/job-output.txt.gz#_2019-01-02_10_10_24_361909 what to do with this diff part | 10:35 |
| chandankumar | ? | 10:35 |
| arxcruz | chandankumar: what you mean? he diff should check for each one of it, splitted by comma, not the full text, since (and here i'm guessing) it comes from a dict that you can't predict the order | 10:37 |
| arxcruz | s/he diff/the diff | 10:37 |
| tosky | chandankumar: as arxcruz says: if you compare sets, compare them as sets | 10:39 |
| kopecmartin | but for that, the file needs to be parsed first | 10:41 |
| chandankumar | arxcruz: tosky so basically we need to rewrite that part so that it should be comparable | 10:41 |
| chandankumar | via sets | 10:41 |
| openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: Create functional-tests role https://review.openstack.org/626539 | 12:29 |
| openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: Create functional-tests role https://review.openstack.org/626539 | 12:33 |
| *** markvoelker has quit IRC | 13:20 | |
| openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: Create functional-tests role https://review.openstack.org/626539 | 14:54 |
| *** kopecmartin is now known as kopecmartin|off | 16:04 | |
| *** tosky has quit IRC | 17:23 | |
| *** markvoelker has joined #refstack | 19:51 | |
| *** tosky has joined #refstack | 22:30 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!