| *** tosky has quit IRC | 00:14 | |
| *** chandankumar has joined #refstack | 04:55 | |
| *** chandankumar is now known as chkumar|ruck | 04:56 | |
| *** chkumar|ruck has quit IRC | 06:37 | |
| *** chandankumar has joined #refstack | 07:14 | |
| *** chandankumar is now known as chkumar|ruck | 07:14 | |
| *** kopecmartin|off is now known as kopecmartin | 07:25 | |
| *** chandankumar has joined #refstack | 07:52 | |
| *** chkumar|ruck has quit IRC | 07:56 | |
| *** chandankumar is now known as chkumar|ruck | 07:57 | |
| kopecmartin | chkumar|ruck, arxcruz hi, flake8 update to 3.6.0 a month ago causes pep job failing http://logs.openstack.org/16/611716/2/check/openstack-tox-pep8/65189b3/job-output.txt.gz#_2018-11-19_22_33_33_089015 | 08:34 |
|---|---|---|
| kopecmartin | do you know where this versions are controlled? because python-tempestconf still uses 2.5.5 and i can't see it in requirements.txt or test-requiremetns.txt | 08:34 |
| kopecmartin | (*pep job failing in refstack-client) | 08:35 |
| *** tosky has joined #refstack | 09:11 | |
| openstackgerrit | Martin Kopec proposed openstack/refstack-client master: Downgrade flake8 from 3.6.0 https://review.openstack.org/618974 | 09:13 |
| *** kopecmartin has left #refstack | 09:14 | |
| *** kopecmartin has joined #refstack | 09:14 | |
| arxcruz | kopecmartin: are we using the upstream job? | 09:25 |
| kopecmartin | arxcruz, I've found the problem, see commit message in https://review.openstack.org/#/c/618974/ | 09:26 |
| kopecmartin | however, I don't know where flake8==2.5.5 is coming from python-tempestconf :/ | 09:26 |
| kopecmartin | bbl | 09:30 |
| *** chkumar246 has joined #refstack | 10:13 | |
| *** chkumar|ruck has quit IRC | 10:15 | |
| *** chkumar246 is now known as chkumar|ruck | 10:18 | |
| kopecmartin | arxcruz, chkumar|ruck , tosky what do you think about it? https://review.openstack.org/#/c/618974/ | 10:42 |
| arxcruz | kopecmartin: -1 | 10:45 |
| kopecmartin | arxcruz, do you know where to find those upstream constraints? I know there was a file, which specified versions openstack projects should use, however i can't find it | 10:52 |
| arxcruz | kopecmartin: https://github.com/openstack/requirements/blob/master/upper-constraints.txt | 10:53 |
| *** chkumar246 has joined #refstack | 10:54 | |
| kopecmartin | arxcruz, flake is not specified there | 10:54 |
| arxcruz | kopecmartin: in that case, I really don't know | 10:55 |
| *** chkumar|ruck has quit IRC | 10:57 | |
| tosky | arxcruz: anarchy in the flake8 | 11:07 |
| tosky | no one managed to work on unifying the version of flake8 needed, sadly | 11:07 |
| arxcruz | tosky: i like a little bit of anarchy | 11:07 |
| tosky | so I think that most of projects defines 2.5.5 in lower-constraints.txt, but that's it | 11:07 |
| kopecmartin | tosky, btw, where is version of flake8 defined in python-tempestconf? | 11:12 |
| tosky | kopecmartin: I don't think that we define it | 11:13 |
| kopecmartin | tosky, hm, so we automagically inherit it from somewhere | 11:14 |
| kopecmartin | so either we can remove flake8 from requirements in refstack-client - if we want to use the older one, or let it be as it is in the patch if we want to use the newer versions | 11:15 |
| kopecmartin | i don't know what's better | 11:15 |
| tosky | as long as we have a version that consistently work on both (tempestconf and refstack-client), that should be fine | 11:16 |
| kopecmartin | so remove flake and pyflakes definitons from test-requirements? | 11:20 |
| kopecmartin | oh, it doesn't work when i remove the definition , i don't know :D | 11:26 |
| tosky | from refstack-client? We should probably even add it to tempestconf | 11:27 |
| tosky | relying on the dependency by magic may break anytime | 11:28 |
| kopecmartin | it depends if it's a good or bad magic :D , but yeah, this one is bad one | 11:28 |
| *** chkumar246 is now known as chkumar|ruck | 11:30 | |
| kopecmartin | so back to the patch in refstack-client, what are we gonna do about it? | 11:31 |
| tosky | what if we contraint it in tempestconf? Would it be propagated to refstack-client? | 11:33 |
| tosky | even if it would be another use of the magic | 11:33 |
| tosky | let's put it this way: if we constraint flake8 in tempestconf, we should probably do the same in refstack-client | 11:34 |
| tosky | kopecmartin: I'd follow arxcruz suggestion and change the title of the review for refstack-client and change downgrade with constraint or some other expression | 11:42 |
| arxcruz | yeah, i don't know if constraint is the right word, but my lack of english vocabulary cannot permit me to express better | 11:43 |
| tosky | "limit" | 11:43 |
| tosky | or whatever else :) | 11:43 |
| *** chkumar246 has joined #refstack | 11:53 | |
| *** chkumar|ruck has quit IRC | 11:56 | |
| *** chkumar has joined #refstack | 12:15 | |
| *** chkumar246 has quit IRC | 12:18 | |
| *** chkumar246 has joined #refstack | 12:54 | |
| *** chkumar246 is now known as chkumar|ruck | 12:54 | |
| *** chkumar has quit IRC | 12:57 | |
| *** chkumar246 has joined #refstack | 13:49 | |
| *** chkumar|ruck has quit IRC | 13:52 | |
| *** chkumar246 has quit IRC | 14:01 | |
| openstackgerrit | Martin Kopec proposed openstack/refstack-client master: Constraint flake8 version https://review.openstack.org/618974 | 14:17 |
| *** chkumar246 has joined #refstack | 14:53 | |
| openstackgerrit | Rabi Mishra proposed openstack/python-tempestconf master: Set region_name from os-client-config to set identity.region https://review.openstack.org/612565 | 15:52 |
| openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: Constraint flake8 and pyflakes versions https://review.openstack.org/619028 | 15:58 |
| *** chkumar246 has quit IRC | 16:16 | |
| *** kopecmartin is now known as kopecmartin|off | 17:28 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!