| *** rmart04 has joined #refstack | 05:46 | |
| *** rmart04 has quit IRC | 06:03 | |
| *** rmart04 has joined #refstack | 06:03 | |
| *** kopecmartin|off is now known as kopecmartin|ruck | 06:09 | |
| *** rmart04 has left #refstack | 06:23 | |
| *** tosky has joined #refstack | 07:45 | |
| arxcruz | chandankumar: tosky i have a question | 09:18 |
|---|---|---|
| arxcruz | chandankumar: what's the difference between the line 130 and the 136 in https://github.com/openstack/python-tempestconf/blame/master/config_tempest/tempest_conf.py#L130-L139 | 09:18 |
| arxcruz | because both do the same, remove the option if it is in the remove list | 09:19 |
| arxcruz | but why check if length is 1 do something, if is bigger than 1 do the same thing but in a different way | 09:19 |
| arxcruz | plus, do we really want to exit the program if a key isn't found, or just a warning ? | 09:19 |
| arxcruz | it might be "questions" :) | 09:20 |
| arxcruz | nevermind about the check lenght, that's a freaking workaround | 09:28 |
| tosky | I was rechecking the history of the change | 09:28 |
| arxcruz | ok, the refstack job on tripleo is failing because it tries to remove a key that doesn't exist, and so don't create the tempest.conf properly | 09:32 |
| arxcruz | i'm fixing it just to show a warning, and continue the work | 09:32 |
| tosky | the question about the duplication of the code paths is relevant though | 09:33 |
| tosky | I probably didn't pay too much attention to it (my bad) when approving the patch | 09:33 |
| tosky | you said that it's workaround? | 09:33 |
| arxcruz | tosky: well, for me yes, because you check if len(remove) == 1 and do something, if not, you set a list without the remove option, but this is how the data structure was set, i'll not change it | 09:37 |
| arxcruz | tosky: nevermind, find the real problem in another place | 09:37 |
| arxcruz | tosky: the code is working, not the best code ever, but it's working, moving on :) | 09:39 |
| tosky | ok :) | 09:39 |
| chandankumar | arxcruz: I have fixed the refstack TQE patch | 09:45 |
| chandankumar | it will work now | 09:45 |
| arxcruz | chandankumar: yes, i notice, and add a comment | 09:45 |
| arxcruz | I hope we can merge this today | 09:45 |
| arxcruz | let's pray for the gods of gates | 09:45 |
| chandankumar | yes yes | 09:45 |
| chandankumar | hope ansible tempest distro patch will land also | 09:46 |
| arxcruz | chandankumar: tbh i would leave that for before, we need to have python-tempestconf, stackviz, etc first | 10:05 |
| arxcruz | then we can focus on distro | 10:05 |
| arxcruz | but ¯\_(ツ)_/¯ | 10:05 |
| chandankumar | arxcruz: it is almost done | 10:06 |
| arxcruz | as i said, i predict we gonna need to change it soon but... | 10:06 |
| arxcruz | chandankumar: you didn't saw the plan, this distro integration was supposed to be one of the last things to do in os_tempest | 10:07 |
| arxcruz | but ...¯\_(ツ)_/¯ | 10:07 |
| chandankumar | arxcruz: on centos side for openstack-ansible-os_Tempest is going to run from rpm | 10:07 |
| arxcruz | chandankumar: I know, but we have other things to do first, plus it wasn't on the sprint... | 10:11 |
| chandankumar | ok | 10:12 |
| arxcruz | but hey, i'm not the UA/TC so... :D | 10:13 |
| chandankumar | hogepodge: Hello | 11:36 |
| chandankumar | hogepodge: how we can update this list https://refstack.openstack.org/api/v1/guidelines/2018.02/tests?target=platform&type=required&alias=true&flag=false to lastest tempest or based on rocky release? | 11:36 |
| *** chandankumar is now known as chkumar|off | 15:35 | |
| *** openstackgerrit has quit IRC | 15:47 | |
| *** openstackgerrit has joined #refstack | 15:49 | |
| *** openstackgerrit has quit IRC | 21:56 | |
| *** openstackgerrit has joined #refstack | 21:58 | |
| *** openstackgerrit has quit IRC | 21:58 | |
| *** openstackgerrit has joined #refstack | 22:00 | |
| *** openstackgerrit has quit IRC | 22:12 | |
| *** openstackgerrit has joined #refstack | 22:14 | |
| *** openstackgerrit has quit IRC | 22:43 | |
| *** tosky has quit IRC | 23:25 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!