| *** xinliang has joined #refstack | 03:50 | |
| *** chandankumar is now known as chkumar|pto | 06:35 | |
| *** kopecmartin has joined #refstack | 06:48 | |
| *** tosky has joined #refstack | 07:36 | |
| openstackgerrit | Arx Cruz proposed openstack/python-tempestconf master: Remove static class loader https://review.openstack.org/590789 | 09:05 |
|---|---|---|
| arxcruz | tosky: ^ | 09:05 |
| tosky | gates :) | 09:09 |
| tosky | arxcruz: also pkgutil and pyclbr are system libraries | 09:10 |
| openstackgerrit | Arx Cruz proposed openstack/python-tempestconf master: Remove static class loader https://review.openstack.org/590789 | 09:11 |
| arxcruz | tosky: done ^ | 09:11 |
| tosky | arxcruz: and the comments about config_tempest_services/services.py? | 09:11 |
| arxcruz | tosky: done as well | 09:11 |
| tosky | oh, right | 09:12 |
| tosky | let's see if it works | 09:12 |
| arxcruz | except for the list compreension that i don't know how to do in that case | 09:12 |
| tosky | it's for a future change | 09:14 |
| tosky | just not forget to do it, it would simplify the code | 09:14 |
| tosky | kopecmartin: so a deprecated option has no effect? My understanding is that it's still valid, it just prints a bit deprecation warning | 09:23 |
| kopecmartin | tosky, it prints deprecation warning which says the option is unusable .. i don't know, i haven't tracked the code, just read the warnings and releasenote | 09:26 |
| tosky | it says that the option is deprecated, not unusable | 09:27 |
| tosky | that's what I get from the warnings, but I didn't test it | 09:28 |
| kopecmartin | yes first sentence of the message says it's deprecated, but the other one continues "... based on CONF.volume.catalog_type which makes this config option unusable...." :D | 09:30 |
| tosky | that's tricky | 09:32 |
| tosky | it probably means that if both are specified, hilarity ensues | 09:33 |
| tosky | but I would ask gmann | 09:33 |
| tosky | it does not mean that the option is not read | 09:33 |
| kopecmartin | tosky, hmm, in python-tempestconf we relies on the case, when both of the options are set - because we can't detect OpenStack version and we need to support older versions too, so I really don't think that a hilarious situation can happen when api_v2/3 and catalog_type are specified ... if does, it would be a bad design on Tempest side | 09:46 |
| kopecmartin | but just to make sure, i asked here https://review.openstack.org/#/c/590158 | 09:46 |
| tosky | yeah, better ask what it means that "makes this config option unusable" | 09:47 |
| openstackgerrit | Arx Cruz proposed openstack/python-tempestconf master: Remove static class loader https://review.openstack.org/590789 | 12:24 |
| *** markvoelker has joined #refstack | 14:55 | |
| openstackgerrit | Arx Cruz proposed openstack/python-tempestconf master: Remove static class loader https://review.openstack.org/590789 | 15:17 |
| arxcruz | tosky: now it's working ^ | 15:17 |
| tosky | noticed | 15:20 |
| arxcruz | tosky: well, previous patch wasn't working properly, the services were set to False, but it was a mistake i did on my local env | 15:20 |
| tosky | uhm, is it something that can be catched by a unit test? | 15:21 |
| arxcruz | tosky: plus, on demo, instead of use list_Services, i use the catalog, because we don't have permission for list_Services, but i put a warning | 15:21 |
| arxcruz | tosky: definitivelly we should test the tempest.conf file generated by tempestconf | 15:21 |
| tosky | we need more unit tests | 15:23 |
| tosky | can you please create a story and list few relevant tests that should be implemented? | 15:23 |
| *** markvoelker has quit IRC | 15:36 | |
| *** kopecmartin has quit IRC | 16:41 | |
| *** openstackgerrit has quit IRC | 17:04 | |
| *** markvoelker has joined #refstack | 21:04 | |
| *** markvoelker has quit IRC | 21:13 | |
| *** tosky has quit IRC | 23:08 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!