| *** chandankumar has quit IRC | 03:05 | |
| *** openstackgerrit has quit IRC | 05:18 | |
| *** chandankumar has joined #refstack | 05:41 | |
| *** kopecmartin has joined #refstack | 05:47 | |
| kopecmartin | arxcruz, hi, around? | 08:02 |
|---|---|---|
| arxcruz | kopecmartin: yes | 08:04 |
| kopecmartin | arxcruz, can you help with this review? https://review.openstack.org/#/c/580975/ | 08:05 |
| kopecmartin | it's regarding your method https://github.com/openstack/python-tempestconf/blob/83e6ecb0791165305ba754e0dd116eb710fbbf2b/config_tempest/credentials.py#L68 | 08:05 |
| kopecmartin | we need to reuse it and I don't know where is the best place to store it so that it's reusable | 08:05 |
| arxcruz | kopecmartin: i had the same problem, so i decided to use in credentials, put it in another place would mean change a bunch of tests, etc | 08:07 |
| arxcruz | kopecmartin: perhaps create an utils.py | 08:07 |
| arxcruz | ? | 08:07 |
| kopecmartin | yeah, i was thinking about something similar, we can create config_tempest/utils.py and put it there | 08:08 |
| chandankumar | arxcruz: kopecmartin https://review.openstack.org/#/c/541273/ is there a way to check in env where a particular api is deprecated? | 08:08 |
| kopecmartin | chandankumar, what do you mean? i put a pudb breakpoint here https://github.com/openstack/python-tempestconf/blob/master/config_tempest/services/volume.py#L30 | 08:10 |
| kopecmartin | and i printed out the versions obtained from the cloud | 08:10 |
| arxcruz | we are checking only v2 and v3 for volume | 08:11 |
| kopecmartin | that's correct and we are filtering out the deprecated versions: https://github.com/openstack/python-tempestconf/blob/master/config_tempest/services/base.py#L134 | 08:12 |
| arxcruz | chandankumar: kopecmartin https://review.openstack.org/#/c/590789/ btw please +2 :) | 08:12 |
| arxcruz | brb | 08:12 |
| kopecmartin | arxcruz, I was going to, I was checking the review in the morning :) | 08:12 |
| chandankumar | kopecmartin: how we are filtering what is deprecated? | 08:13 |
| kopecmartin | chandankumar, versions with status = DEPRECATED are not used - https://github.com/openstack/python-tempestconf/blob/master/config_tempest/services/base.py#L134 | 08:14 |
| chandankumar | kopecmartin: ok | 08:15 |
| kopecmartin | chandankumar, so regarding that review , i see only one option .. if refstack tests requires to use those v2 tests, we will need to hardcode an override in refstack_client.py so that volume-feature-enabled.api_v2 is set to True | 08:16 |
| chandankumar | kopecmartin: yes that is what I am thinking | 08:17 |
| chandankumar | kopecmartin: let me update the patch | 08:17 |
| kopecmartin | with a TODO comment that it's temporary and will be removed as soon as .. | 08:17 |
| chandankumar | kopecmartin: arxcruz we need to plan for next sprint also | 08:17 |
| chandankumar | from ideabox, we need to prepare tempest plugins for rocky release in RDO | 08:18 |
| kopecmartin | chandankumar, let me know when you have time and we can do it .. btw since Friday I'm on PTO one week | 08:18 |
| chandankumar | release tempestconf-2.0.0 next week | 08:18 |
| chandankumar | kopecmartin: arxcruz let's talk during today's scrum call | 08:19 |
| chandankumar | kopecmartin: I will be on PTO probably after 26 Aug | 08:19 |
| kopecmartin | ok | 08:19 |
| arxcruz | kopecmartin: chandankumar please review my patch it's my last card for this scrum | 09:11 |
| arxcruz | i want it finished | 09:11 |
| arxcruz | plus tomorrow i'll be on pto | 09:11 |
| kopecmartin | arxcruz, waiting for rdo gates, I'll plus 2 it than :) | 09:11 |
| kopecmartin | 20 min | 09:11 |
| kopecmartin | arxcruz, done :) | 09:32 |
| kopecmartin | arxcruz, chandankumar, please have a look on this https://review.openstack.org/#/c/583504/ | 09:33 |
| arxcruz | kopecmartin: thanks, no issues this time, no comments, clean patch, and at patchset 1 :D | 09:33 |
| kopecmartin | arxcruz, good job ;) | 09:36 |
| *** tosky has joined #refstack | 09:59 | |
| tosky | arxcruz: I had to -2 | 09:59 |
| arxcruz | :O | 09:59 |
| arxcruz | tosky: so, what? i mean, we are discovering from the catalog name | 10:00 |
| arxcruz | ¯\_(ツ)_/¯ | 10:01 |
| tosky | that's incorrect | 10:01 |
| tosky | there are "services" without catalog names | 10:01 |
| tosky | (horizon) | 10:01 |
| *** openstackgerrit has joined #refstack | 10:01 | |
| openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: Create utils.py https://review.openstack.org/591326 | 10:01 |
| tosky | there are services with multiple catalog names (volume) | 10:01 |
| arxcruz | yes, but right now the discovering is being done via catalog | 10:02 |
| arxcruz | we get the list of catalog, do a match, and get the proper class | 10:02 |
| tosky | what is the point of a change that does not fix the issues which is supposed to fix? | 10:02 |
| tosky | in my mind, "implement dynamic discovery" means "do the discovery of the classes as it should be done, in a generic way, getting all children of Services" | 10:03 |
| arxcruz | well, the change wasn't related to this, it was to automatically get the proper class without the need to have a dict hardcoded | 10:03 |
| tosky | don't use the service name | 10:03 |
| tosky | no argument | 10:03 |
| tosky | just define a new class property with the name of the service, unrelated to the service name, and you can get stuff like horizon in | 10:04 |
| arxcruz | we don't even have a class for horizon i think, it's just a method | 10:06 |
| tosky | yes, but that's not the point | 10:06 |
| tosky | this change does not address the fact that a) there are "services" with no catalog b) there are services with possibly more catalog | 10:07 |
| arxcruz | ok, so you realize i'll just create a property that will return the same as get_catalog right ? | 10:07 |
| tosky | not the same | 10:07 |
| tosky | the one for volume can just be "volume" | 10:07 |
| tosky | and so on | 10:08 |
| tosky | it's not the same, that's my point; if it was the same semantic object, I would not have complained | 10:08 |
| tosky | you don't even need a method for that - it can be just a directly property | 10:09 |
| arxcruz | tosky: but for example | 10:09 |
| tosky | the point is: some children of Services may not have a catalog name or a unique catalog name; all the children of Services have a unique internal identifier | 10:09 |
| arxcruz | we have volume and volume3 | 10:09 |
| tosky | and they are covered both by services/volume.py | 10:10 |
| arxcruz | tosky: not really, if volume is getting from Service while volumev3 from ServiceVolume | 10:11 |
| arxcruz | if you try to add volume as ServiceVolume you get an error | 10:12 |
| arxcruz | anyway, i'll do what you ask, but not today, and i'll be on pto the whole week because new wow expansion | 10:12 |
| arxcruz | so, i'll fix it next week | 10:12 |
| tosky | wow expansion? | 10:12 |
| tosky | what is ServiceVolume? | 10:12 |
| arxcruz | also then i think we should start to get the list of services not from the catalog, but from service list | 10:12 |
| arxcruz | VolumeService i don't remember the name from the top of my head | 10:13 |
| arxcruz | from services/volume.py | 10:13 |
| arxcruz | wow = world of warcraft | 10:13 |
| tosky | VolumeService handles both v2 and v3 volume service | 10:14 |
| tosky | the service is one, it has different entry points | 10:14 |
| tosky | and sure, get the service list should not depend on the catalog, that's my entire point :) | 10:15 |
| *** tosky has quit IRC | 10:19 | |
| openstackgerrit | Chandan Kumar proposed openstack/refstack-client master: Generate tempest.conf automatically using refstack-client https://review.openstack.org/541273 | 11:19 |
| chandankumar | kopecmartin: ^^ done as discussed | 11:23 |
| *** tosky has joined #refstack | 11:41 | |
| kopecmartin | chandankumar, good, but one thing | 11:46 |
| kopecmartin | chandankumar, why are you replacing = for a space but then split through a comma? https://review.openstack.org/#/c/541273/68..69/refstack_client/refstack_client.py@455 | 11:48 |
| kopecmartin | oh, sorry, i get it | 11:48 |
| kopecmartin | tosky, btw, what do you say on this https://review.openstack.org/#/c/583504/ .. I have finally implemented (at least partially) the argument to the gates | 12:00 |
| chandankumar | kopecmartin: I think I am doing something wrong there | 12:01 |
| tosky | kopecmartin: I've seen the notes; I was just a bit unsure about the hidden failure if done the other way | 12:02 |
| tosky | so I said myself "ok, I will recheck it later" | 12:02 |
| kopecmartin | tosky, i don't think there is a hidden failure, at least i can't image where . . i would say it's just some settings .. | 12:03 |
| kopecmartin | ok sure | 12:03 |
| chandankumar | kopecmartin: not sure what is that | 12:04 |
| *** tosky has quit IRC | 12:35 | |
| openstackgerrit | Liron Kuchlani proposed openstack/python-tempestconf master: Add support for volume api microversion https://review.openstack.org/580975 | 12:43 |
| openstackgerrit | Chandan Kumar proposed openstack/refstack-client master: Generate tempest.conf automatically using refstack-client https://review.openstack.org/541273 | 13:08 |
| chandankumar | kopecmartin: ^^ it will work now | 13:08 |
| kopecmartin | chandankumar, extra_overrides is undefined | 13:23 |
| openstackgerrit | Liron Kuchlani proposed openstack/python-tempestconf master: Add support for volume api microversion https://review.openstack.org/580975 | 13:42 |
| openstackgerrit | Chandan Kumar proposed openstack/refstack-client master: Generate tempest.conf automatically using refstack-client https://review.openstack.org/541273 | 14:30 |
| *** kopecmartin has quit IRC | 15:00 | |
| *** kopecmartin has joined #refstack | 15:15 | |
| chandankumar | kopecmartin arxcruz hogepodge I have updated the patch please have a look https://review.openstack.org/541273 | 15:20 |
| kopecmartin | chandankumar, nice, and from the logs can be see, that volume api_v2 tests were not skipped! | 15:30 |
| kopecmartin | *seen | 15:31 |
| *** kopecmartin has quit IRC | 16:20 | |
| *** openstackgerrit has quit IRC | 17:19 | |
| hogepodge | chandankumar: lgtm, +2/+1 | 18:05 |
| hogepodge | thanks | 18:05 |
| hogepodge | There's one more variable that I think we need to set, but we can send up a new patch to handle that | 18:06 |
| hogepodge | I need to investigate it a bit more. | 18:06 |
| *** mgagne_ has joined #refstack | 19:24 | |
| *** davidlenwell has quit IRC | 19:25 | |
| *** serverascode_ has quit IRC | 19:25 | |
| *** tommylikehu has quit IRC | 19:25 | |
| *** mgagne has quit IRC | 19:25 | |
| *** openstackgerrit has joined #refstack | 21:07 | |
| openstackgerrit | Merged openstack/refstack-client master: Remove usage of tempest install_venv scripts https://review.openstack.org/564080 | 21:07 |
| chandankumar | hogepodge: thanks :-) https://review.openstack.org/#/c/562956/ this one is also needed i think | 21:18 |
| chandankumar | hogepodge: thanks for keeping the patience, guiding us :-) | 21:18 |
| openstackgerrit | Merged openstack/refstack-client master: Generate tempest.conf automatically using refstack-client https://review.openstack.org/541273 | 21:47 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!