Tuesday, 2018-06-19

*** lifeless_ has joined #refstack00:05
*** lifeless has quit IRC00:05
*** lifeless_ has quit IRC01:43
*** lifeless has joined #refstack01:45
*** markvoelker has quit IRC05:01
openstackgerrityatin proposed openstack/python-tempestconf master: Handle role creation as they are not case-sensitive  https://review.openstack.org/57635605:24
*** lifeless has quit IRC05:53
*** lifeless has joined #refstack05:53
*** markvoelker has joined #refstack07:01
*** kopecmartin has joined #refstack07:30
openstackgerritmegan guiney proposed openstack/refstack master: Subunit Data upload API  https://review.openstack.org/53068107:30
*** tosky has joined #refstack07:34
toskyuhm uhm07:34
*** markvoelker has quit IRC07:36
arxcruztosky: ping08:05
toskyarxcruz: pong (please ping with a reason, no need to wait for the pong to explain the issue)08:06
arxcruzyou looks like filip now :)08:06
toskyno, it's just right - it wastes less time from all sides08:06
arxcruztosky: so https://review.openstack.org/#/c/568869/ swift enabled, admin tests failing08:06
toskyif I'm away, I can just answer directly when I'm back, and not wait for the pong08:07
toskyarxcruz: admin test failing for demo only? Didn't I mention that it looks correct to me?08:07
toskytest.api.admin tests should always work for users with admin permissions08:07
toskyI think08:07
toskywe may recheck on #openstack-qa08:08
arxcruztosky: yes, correct to fail, but enabling swift, the skip reason is missed08:08
toskyarxcruz: does it mean that in the normal set of tests we skip other admin tests for other services, but not for swift?08:08
toskyor that the admin tests for other services work?08:09
toskyI know that I can dig the log, but you probably checked already08:09
arxcruztosky: on admin job, it pass, on demo job it fails, the admin tests are being skipped if swift is disabled, if enabled, it runs even with demo user08:10
toskyarxcruz: the question is: how is that, with a demo user, admin tests are run only for swift? Do we explicitly skip admin tests for other services?08:10
toskyare they not part of the default selector that we use?08:11
arxcruztosky: they are part, but without swift = True, these tests are skipped08:11
arxcruzcheck other patches, and you'll see admin tests being skipped on demo jobs08:12
toskyarxcruz: well, let's check the condition that triggers tests like tempest.api.identity.admin etc then08:14
arxcruztosky: already check, it checks for admin credentials08:15
arxcruzbut i don't know why when swift is enabled, this tests run08:15
toskythen it may be something else08:15
toskyit must be there08:15
toskylet's compare tempest.conf for https://review.openstack.org/#/c/575233/ and https://review.openstack.org/#/c/568869/08:17
kopecmartinalready doing that, why accounts.yaml generated in ...869 patch is longer, with more credentials?08:18
toskyehm, that's a starting point08:19
kopecmartinthere is a role "admin"08:19
kopecmartini don't know how this works, but it's about the changes to the roles08:20
kopecmartinmaybe08:20
toskyand then why it did not affect https://review.openstack.org/#/c/568869/ ? The review was updated after the keystone change08:20
kopecmartinhow did not affect, the gates for the patch are failing now08:21
toskynot the demo job08:21
toskyjobs*08:21
toskyups, I meant the other review08:22
toskythe lat run of https://review.openstack.org/#/c/57523308:22
kopecmartinoh, i see, maybe there is a change in that review, it doesn't have to be related to already merged code08:23
toskydo you have the environment to test 568869 locally?08:23
kopecmartinIt just looks strange and suspicious that suddenly the accounts.yaml contains ResellerAdmin and admin roles08:23
toskyin an up-to-date devstack or packstack environment?08:23
kopecmartini should have08:24
toskymaybe 575233 would fail anyway if swift is forced as enabled08:24
toskythat would be a good test08:24
openstackgerritMartin Kopec proposed openstack/python-tempestconf master: DNM: Enable swift and test 575233  https://review.openstack.org/57642408:27
toskythat's a stretch version of "test locally" :D08:28
kopecmartinwell :D08:28
*** lifeless has quit IRC08:28
kopecmartinmy guess is, that swift makes tempest account generator to use roles which affects the tempest tests08:29
toskyI agree with that, the only difference in the tempest.conf is the operator_role = admin line in the [object-storage] section when the tests fail (568869)08:30
toskynow, the question is why08:30
toskykopecmartin: uhm, why do we rely still on tempest account-generator? Don't we have our own way to create accounts.yaml now?08:32
arxcruztosky: if a accounts generator option in tempest is true, it will try to create the accounts08:32
toskyarxcruz: where "it" is?08:33
*** markvoelker has joined #refstack08:33
arxcruztosky: let me check08:33
toskyarxcruz: right now we invoke tempest account-generator explicitly in roles/generate-accounts-file08:33
kopecmartintosky, hm, it's because we have concurrency = 2 and in that case the simple minimal accounts.yaml is not enough08:34
*** luzC_ has quit IRC08:34
toskykopecmartin: do you mean that the new code which creates accounts.yaml does not produce a real usable accounts.yaml?08:35
tosky(because we would need more accounts?)08:35
tosky(for other reasons?)08:35
kopecmartinit produces, but only for concurrency = 1, if i get it right08:35
kopecmartinyes, bigger concurrency , more accounts08:35
arxcruzkopecmartin: where are you seeing this code ?08:36
*** rmart04 has joined #refstack08:36
toskykopecmartin: but then is refstack-client always running without concurrency? Because otherwise it's not useful08:36
*** luzC has joined #refstack08:36
kopecmartinarxcruz, https://github.com/openstack/python-tempestconf/blob/master/playbooks/python-tempestconf-tempest-packstack.yaml#L5708:37
kopecmartinarxcruz, https://github.com/openstack/python-tempestconf/blob/master/roles/generate-accounts-file/tasks/main.yaml08:37
kopecmartintosky, yes, i think the refstack is running with concurrency = 108:38
toskyoki08:38
kopecmartintosky, https://github.com/openstack/refstack-client/blob/master/etc/accounts.yaml.sample#L208:38
toskyso then, regardless of how we use it (and I still think that we should use our own generator more in some test), tempest account-generator should be investigated08:38
kopecmartinand there is also a comment, that swift needs roles, that's why08:38
toskybut that's not relevant08:39
kopecmartinso the comment explains why we use tempest generator and also why swift's accounts yaml file  is different08:39
kopecmartinis not?08:39
toskyit just says that the minimal file is not working with swift08:39
toskyit does not explain:08:40
tosky- why adding operator_role = admin in the swift section writes down also other roles in tempest.conf08:40
toskyand then why those roles affect, for example, identity tests, if the credentials specified are not admin08:41
kopecmartinadmin role in operator role is there i guess  because https://review.openstack.org/#/c/568869/32/config_tempest/services/object_storage.py@5708:42
toskyyes, the problem it's not why it's there08:42
kopecmartinwe need to find out, what triggers admin tests - admin role in operator section, or content of accounts.yaml08:43
toskythink about the usage of tempest account-generator for a "normal" user who would like who generates accounts.yaml and would like to run the tests using a non admin user08:43
toskyregardless of tempestconf08:43
toskyyes, that too (I suspect more the content of accounts.yaml, but let's see, the scientific method needs experimental proof)08:44
arxcruztosky: https://github.com/openstack/tempest/blob/master/tempest/test.py#L282-L28708:51
arxcruzthis is where it check for admin08:52
arxcruzso admin is in cls.credentials08:52
toskyarxcruz: not only that, it's important the next if, credentails is_admin_available08:53
arxcruzoh boy08:54
arxcruztosky: https://github.com/openstack/tempest/blob/master/tempest/common/credentials_factory.py#L16508:54
toskyoh, makes sense08:55
toskybut if we use accounts.yaml, shouldn't we test dynamic credentials to False?08:56
openstackgerrityatin proposed openstack/python-tempestconf master: Handle role creation as they are not case-sensitive  https://review.openstack.org/57635608:56
openstackgerritChandan Kumar proposed openstack/python-tempestconf master: Use healthcheck api to determine swift service  https://review.openstack.org/56886908:58
arxcruztosky: dynamic_credentials is set to False08:58
toskyarxcruz: then it's the next if, maybe? elif CONF.auth.test_accounts_file:08:59
toskyor it could be get_configured_admin_credentials08:59
toskyneeds manual debugging08:59
arxcruztosky: it's set09:00
arxcruzthe test_accounts_file is set to /etc/openstack/accounts.yaml09:01
openstackgerrityatin proposed openstack/python-tempestconf master: Handle role creation as they are not case-sensitive  https://review.openstack.org/57635609:04
*** markvoelker has quit IRC09:06
kopecmartinso if admin is removed from roles in accounts.yaml , the admin tests are skipped as expected .. so why it's there?09:11
openstackgerritArx Cruz proposed openstack/python-tempestconf master: DNM - Testing collect logs  https://review.openstack.org/57644409:15
toskyyes, why is it assigned to all generated users?09:15
arxcruzkopecmartin: no idea09:15
arxcruzso, where's this accounts.yaml file is being generated ?09:16
arxcruzif someone already know, i can dig into the code09:16
toskyarxcruz: see the role mentioned before09:18
kopecmartinthis tool generates that09:19
kopecmartinhttps://github.com/openstack/tempest/blob/master/tempest/cmd/account_generator.py09:19
arxcruzokay, turns out the accounts.yaml uses tempest09:20
arxcruzso let's see why is this creating the admin09:20
kopecmartinbecause of this probably09:20
kopecmartinhttps://github.com/openstack/tempest/blob/master/tempest/cmd/account_generator.py#L12009:20
kopecmartinhttps://github.com/openstack/tempest/blob/master/tempest/cmd/account_generator.py#L16209:20
toskyuhm, does it (spec) apply for each user created?09:21
toskyweird09:21
toskyresources.extend(generate_resources(cred_provider, opts.admin))09:22
toskyand there is an if admin:09:22
arxcruzhttps://github.com/openstack/tempest/blob/master/tempest/cmd/account_generator.py#L15709:22
toskyyes, I was wondering about that opts.admin, do we pass it?09:23
kopecmartinit's true we are creating the accounts.yaml with admin credentials, because there are needed admin credentials in the file ..09:24
kopecmartinwe don't pass it explicitely09:24
kopecmartin*explicitly09:24
arxcruznope09:24
kopecmartinmaybe we can add --with-admin False?09:24
toskyas I said, it needs manual debugging09:25
arxcruzbut the default is False09:25
toskywe are speculating, and while reading the code could lead to the solution, there are many variables around and it could be easier to see where it fails exactly in a live execution09:26
* kopecmartin is checking09:29
arxcruztosky: agree09:30
arxcruzeven beter if we can do a bj session with a sharing screen09:30
arxcruzfrom what I notice, the accounts.yaml are creating accounts with role: admin09:31
toskythat's what kopecmartin pointed out, yes09:31
arxcruzand the https://github.com/openstack/tempest/blob/master/tempest/common/credentials_factory.py#L17209:31
arxcruzcalls https://github.com/openstack/tempest/blob/master/tempest/lib/common/preprov_creds.py#L33109:32
arxcruzthat calls at some point https://github.com/openstack/tempest/blob/master/tempest/lib/common/preprov_creds.py#L32609:32
arxcruzso, role admin is available, then return true to is_admin_available09:32
openstackgerritArx Cruz proposed openstack/python-tempestconf master: DNM - Testing collect logs  https://review.openstack.org/57644409:44
arxcruzkopecmartin: let me know when you have the env so we can bj and debug this09:47
arxcruzthis is high priority (at least for our team, except for tosky) since it's blocking the master prod chain09:48
kopecmartinarxcruz, I already have it, first, i was able to reproduce it .. but when inserted pudb breakpoints there everything works as expected :/ I'm gonna try from the beginning09:49
toskyarxcruz: it's high priority for everyone if it's blocking the production chain, but I'd like to avoid a butchered solution, thanks09:51
arxcruztosky: sure, i just say at least for us, because i don't know how your project works :)09:52
toskyI can start debugging this in a proper way too, but I think it's pointless to have different people do exactly the same task multiple time at this point09:52
arxcruzyup, let's debug in a bj session09:52
toskymy project is blocked thanks to the keystone change09:52
arxcruzbut i need a few minutes09:52
arxcruz15-2009:53
* tosky bbl09:53
*** markvoelker has joined #refstack10:03
kopecmartinFound it10:04
kopecmartinarxcruz, tosky for generating accounts.yaml a tempest.conf is needed, .. due to recent changes in roles, when the tempestconf is run as admin, object-storage has a admin operator role10:12
kopecmartinand that role makes tempest account-generator to use admin role in accounts.yaml ...10:13
kopecmartinSo i just override the operator role to Member, when tempest.conf for account-generator is generated and it should be ok10:13
arxcruzkopecmartin: wait a sec10:16
arxcruzwe need operator_role as admin for tripleo jobs10:16
arxcruztosky: so, it seems that chandankumar just overwrite my patchset on his patch :(10:18
kopecmartinarxcruz, it will not be affected, the change will affect only demo jobs and only the tempest.conf used for generation of accounts.yaml, not the tempest.conf used for running tempest tests10:18
arxcruzkopecmartin: do you have the patch already ?10:21
arxcruzlet's merge it ASAP10:21
kopecmartinarxcruz, one second, writing a commit message :D10:21
openstackgerritArx Cruz proposed openstack/python-tempestconf master: Use healthcheck api to determine swift service  https://review.openstack.org/56886910:26
openstackgerritMartin Kopec proposed openstack/python-tempestconf master: Fix operator_role value for account-generator  https://review.openstack.org/57647210:26
arxcruzcome on! I want to +2 your patch :D10:26
kopecmartinarxcruz,  https://review.openstack.org/57647210:26
openstackgerritArx Cruz proposed openstack/python-tempestconf master: Use healthcheck api to determine swift service  https://review.openstack.org/56886910:27
arxcruzawesome, i jupdate chandankumar patch with a depends-on10:27
kopecmartinhopefully it will work, I'm going for a lunch, which will take a little longer, in 3 hours I'll be back10:36
*** markvoelker has quit IRC10:37
openstackgerritArx Cruz proposed openstack/python-tempestconf master: Use healthcheck api to determine swift service  https://review.openstack.org/56886910:40
openstackgerritNir Magnezi proposed openstack/python-tempestconf master: Configure tempest for Octavia tests  https://review.openstack.org/57117711:12
openstackgerritNir Magnezi proposed openstack/python-tempestconf master: DNM: Test Octavia  https://review.openstack.org/57506311:13
*** lifeless has joined #refstack11:19
*** lifeless has quit IRC11:28
*** lifeless has joined #refstack11:28
*** markvoelker has joined #refstack11:34
chandankumararxcruz: kopecmartin tosky Anything needed from my side on this patch https://review.openstack.org/56886911:53
arxcruzchandankumar: yes, don't do any changes11:54
chandankumararxcruz: sure11:54
*** markvoelker has quit IRC12:01
*** markvoelker has joined #refstack12:02
toskyuhm, I'm still not sure12:16
toskyI mean, if we are forcing that role, isn't it exactly what we wanted to avoid with https://review.openstack.org/568869 ?12:17
chandankumartosky: please comment on this revew what are the things I am missing on this one https://review.openstack.org/54127312:22
chandankumari will update later tomorrow morning12:22
toskywe have kind of other urgent stuff...12:23
chandankumarack12:23
toskyarxcruz: so, about https://review.openstack.org/568869, why that if service == 'object-store': special case?12:27
toskyI think I already asked about it: why should that be a special case?12:27
arxcruztosky: removed on latest patch12:29
toskyarxcruz: not that one12:30
arxcruztosky: sorry, i'm not following12:31
toskyhttps://review.openstack.org/#/c/568869/36/config_tempest/services/services.py line 211 on the right12:31
arxcruztosky: shit, removing12:32
chandankumararxcruz: tosky then where are setting to false? swift service or check service availability will take care of that how?12:33
toskyI just raised the point that there should be no special exceptions12:33
toskyat least, no new special exceptions12:34
openstackgerritArx Cruz proposed openstack/python-tempestconf master: Use healthcheck api to determine swift service  https://review.openstack.org/56886912:34
arxcruztosky: done12:34
arxcruztosky: habemus tempest.conf and tempest log12:35
arxcruzhttp://logs.openstack.org/44/576444/2/check/python-tempestconf-tempest-devstack-demo/01a85c4/controller/logs/12:35
chandankumarif no special exception, without heathcheck how we can se to false?12:35
chandankumarfor swift case?12:35
toskywrite the code so that it's general12:36
toskysee my comment to patch 2012:36
arxcruzkopecmartin: shit huh, failed because of tripleo12:40
toskyarxcruz: I think we need the other patch by ykarel first12:42
toskywhich depends on another patch on instack12:42
arxcruztosky: instack patch still ongoing12:42
toskyargh12:43
openstackgerritArx Cruz proposed openstack/python-tempestconf master: DNM - Testing collect logs  https://review.openstack.org/57644412:45
openstackgerritNir Magnezi proposed openstack/python-tempestconf master: Configure tempest for Octavia tests  https://review.openstack.org/57117713:41
openstackgerritNir Magnezi proposed openstack/python-tempestconf master: DNM: Test Octavia  https://review.openstack.org/57506313:41
kopecmartinarxcruz, did it work?14:12
arxcruzkopecmartin: what ?14:12
arxcruznothing is working lol14:12
kopecmartin:D , I meant that patch, did it fix the issue with credentials?14:13
toskywhich of the 14135 open patches?14:14
* kopecmartin looking for a link, but review.openstack is too slow14:15
kopecmartinthis one https://review.openstack.org/#/c/576472/14:15
kopecmartini was out for last three hours14:16
toskykopecmartin: my question about that patch is: is it to fix the issues with demo jobs in python-tempestconf? But the tripleo jobs should work anyway because the role assigned to swift is overridden ?14:18
kopecmartintosky, it should fix the issue with admin tests, it's not touching anything what is related to tripleo, I noticed the tripleo job failed multiple times since yesterday with other patches too14:20
kopecmartinso the tripleo failure is unrelated to that patch14:20
toskyI know that the tripleo failure is unrelated, we are waiting for two (or 3) fixes on tripleo14:20
toskyand one in tempestconf related to the keystone change14:21
toskythe question is: will the tripleo job work after their (non tempestconf) issues are fixed, or will they require another fix related to the issue fixed in 576472?14:21
kopecmartingreat, one could think it's Monday today :D14:23
kopecmartinI don't know what's the problem with tripleo, if they will fix everything from their side, the job should work14:23
toskypki14:23
toskyoki*14:23
toskylet's see, we can't merge anything anyway14:23
toskyuh, healthcheck passed (with the exception of tripleo), did you checke the logs already?14:28
arxcruztosky: checking right now14:31
arxcruztosky: 40 minutes run, doesn't even touch tempestconf code14:31
toskyI mean, the logs of the devstack and packstack jobs14:34
toskyand apparently object_storage tests were executed, and admin tests skipped14:34
toskynice14:34
toskythanks also to the underlying patch14:35
toskybut we can't do anyting until the other patch under recheck is merged (hoping that it will fix the gates)14:35
kopecmartintosky, arxcruz I know gates are not working now, but any objections on this? https://review.openstack.org/#/c/575233/15:24
kopecmartinso that I can fix them meanwhile15:24
arxcruzkopecmartin: gates are supposed to be working now15:25
arxcruzi would not like to see anything on the gates before fix the pipeline15:25
kopecmartinoh, great!15:25
toskyyeah, that was my idea as well15:43
toskyurgent fixes first15:43
arxcruzkopecmartin: http://logs.openstack.org/69/568869/37/check/python-tempestconf-tempest-devstack-demo/1581bd6/job-output.txt.gz#_2018-06-19_15_12_17_91760716:04
arxcruzstill failing one job on demo16:04
kopecmartinarxcruz, I've seen it before, it's flaky, I remember recheck helped last times16:06
arxcruzkopecmartin: ok16:18
*** rmart04 has quit IRC16:22
toskyarxcruz: should we recheck 576472?16:38
arxcruztosky: yes16:39
*** kopecmartin has quit IRC17:11
*** lifeless_ has joined #refstack17:12
*** lifeless has quit IRC17:12
*** lifeless has joined #refstack21:59
*** lifeless_ has quit IRC21:59
openstackgerritLuigi Toscano proposed openstack/python-tempestconf master: More compatibility with Python 3  https://review.openstack.org/57477323:16
openstackgerritLuigi Toscano proposed openstack/python-tempestconf master: More Python 3 porting: filter and map  https://review.openstack.org/57587423:16
*** lifeless_ has joined #refstack23:41
*** lifeless has quit IRC23:42
*** tosky has quit IRC23:45

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!