| *** xinliang has quit IRC | 01:14 | |
| *** xinliang has joined #refstack | 01:30 | |
| *** lifeless_ has joined #refstack | 03:08 | |
| *** lifeless has quit IRC | 03:09 | |
| *** lifeless has joined #refstack | 03:29 | |
| *** lifeless_ has quit IRC | 03:29 | |
| *** kopecmartin has joined #refstack | 06:16 | |
| *** tosky has joined #refstack | 07:29 | |
| arxcruz|ruck | tosky: https://review.openstack.org/#/c/566537/ | 08:41 |
|---|---|---|
| arxcruz|ruck | good morning :) | 08:41 |
| tosky | arxcruz|ruck: I'm behind with the reviews, catching up after 2 days of PTO | 08:48 |
| arxcruz|ruck | tosky: how you dare to take 2 days of pto? | 08:49 |
| arxcruz|ruck | shame on you | 08:49 |
| *** openstackgerrit has joined #refstack | 09:35 | |
| openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: List and create swift roles https://review.openstack.org/571981 | 09:35 |
| openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: Move configuring of services to services class https://review.openstack.org/570876 | 09:38 |
| openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: List and create swift roles https://review.openstack.org/571981 | 09:40 |
| arxcruz|ruck | tosky: regarding https://review.openstack.org/#/c/570876/ | 09:52 |
| arxcruz|ruck | i don't remember a irc discussion as well, but i remember talking about have a method set_tempest_defaults or something like that being called to all the services to set the defaults | 09:53 |
| arxcruz|ruck | because today we are setting it in several places, it would be nice to have it in one single place for each service | 09:53 |
| arxcruz|ruck | tosky: which i did in https://review.openstack.org/#/c/570157/6/config_tempest/services/base.py | 09:53 |
| arxcruz|ruck | https://review.openstack.org/#/c/570157/6/config_tempest/services/services.py | 09:54 |
| tosky | arxcruz|ruck: sure, and that's in fact what I was asking | 09:57 |
| tosky | why it is not done in that review? | 09:57 |
| tosky | what are the methods which can't be changed to use set_default_tempest_options? | 09:57 |
| tosky | if it's not done in that review, it should be planned for another review before the new release - this is what I remember from the discussion and the IRC logs seems to match | 09:58 |
| arxcruz|ruck | tosky: no idea, but you can have a set_default_tempest_options for each service and call the other methods from there | 09:58 |
| tosky | I know! | 09:58 |
| tosky | that's what I was advocating | 09:58 |
| tosky | the point of the review is that it was not done | 09:58 |
| kopecmartin | tosky, arxcruz|ruck check my comment there https://review.openstack.org/#/c/570876/3 | 10:05 |
| tosky | kopecmartin: sure, and those are not reasons to not do the change IMHO | 10:05 |
| tosky | let me answer to each point | 10:05 |
| chkumar246 | markvoelker: thanks | 10:13 |
| kopecmartin | tosky, i didn't say we should not refactor it, I agree it needs some changes but not as part of that change | 10:16 |
| tosky | kopecmartin: sure, fine; but that's different from what you wrote in the comment today (pointing to technical issues) | 10:18 |
| *** eglute_s has joined #refstack | 10:19 | |
| tosky | if you answered "the unification of other methods may take more time and refactoring and will follow up on it" I would not said anything :) | 10:20 |
| *** eglute has quit IRC | 10:20 | |
| kopecmartin | tosky, I'm sorry it sounded differently than I thought, it was just summarizing the facts why i didn't do "quick" refactoring (renaming to set_default_tempest_options) | 10:20 |
| kopecmartin | tosky, yeah, i should have added a note under the comment, that the idea of refactoring needs to be done, but not in that review, because it needs more, bigger changes unrelated to that review :) | 10:21 |
| tosky | np :) | 10:22 |
| tosky | ok, oki | 10:22 |
| tosky | kopecmartin: now, before approving that review we need https://review.openstack.org/#/c/570799/ and I was rechecking reno documentation | 10:24 |
| tosky | namely https://docs.openstack.org/reno/latest/user/usage.html#editing-a-release-note | 10:24 |
| tosky | and deprecation does not seem to fit the case | 10:27 |
| tosky | I was checking other repositories and it seems maybe for "upgrade" | 10:27 |
| tosky | but that's seems a bit a stretch too | 10:27 |
| tosky | in this specific case at least | 10:28 |
| chkumar246 | kopecmartin: one little improvement https://review.openstack.org/571981 since you created the role, you need to the role to that project | 10:47 |
| chkumar246 | *to assign the role | 10:47 |
| *** lifeless_ has joined #refstack | 11:21 | |
| *** lifeless has quit IRC | 11:22 | |
| kopecmartin | tosky, we can use other section :D | 11:27 |
| openstackgerrit | Merged openstack/python-tempestconf master: Don't expose user credentials https://review.openstack.org/570749 | 11:51 |
| openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: Validation support https://review.openstack.org/570799 | 11:54 |
| openstackgerrit | Merged openstack/python-tempestconf master: Load deployer input file automatically https://review.openstack.org/566537 | 12:04 |
| openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: Generate accounts.yaml https://review.openstack.org/570781 | 12:14 |
| chkumar246 | tosky: I am going to unpin the tempestconf from master in RDO | 12:14 |
| tosky | and master only | 12:19 |
| chkumar246 | tosky: https://review.rdoproject.org/r/#/c/14023/ | 12:23 |
| *** openstackgerrit has quit IRC | 12:34 | |
| *** beisner is now known as beisner-sick | 13:22 | |
| kopecmartin | chkumar246, why do we need to assign the role to a project? actually why do we need to create a role at all? | 13:28 |
| kopecmartin | if we want to assign a role, we need to know the project which the role will be assigned to .. but how to choose that project? what if that doesn't exists? .. | 13:28 |
| chkumar246 | kopecmartin: we need a role so that while running swift tests it can be used | 14:14 |
| chkumar246 | kopecmartin: but I think when a user creates a role that is already gets associated with it | 14:15 |
| chkumar246 | kopecmartin: so i think that assigning is not needed | 14:15 |
| kopecmartin | chkumar246, the role created by tempestconf is not listed in `openstack role assignment list` , is that a problem? | 14:16 |
| tosky | chkumar246: are you sure that the automatic assignment happens? | 14:19 |
| chkumar246 | kopecmartin: tosky I need to check that | 14:19 |
| kopecmartin | tosky, chkumar246 any idea when admin_* were moved from identity to auth section? https://github.com/openstack/python-tempestconf/blob/master/etc/default-overrides.conf#L66 | 14:35 |
| chkumar246 | kopecmartin: https://review.gerrithub.io/c/redhat-openstack/python-tempestconf/+/357879 made that change | 14:39 |
| tosky | if the memory helps me, following some tempest change | 14:41 |
| kopecmartin | chkumar246, yes, on python-tempestconf side, but i mean since when (which version) tempest uses auth.admin_* and not identity.admin_* .. | 14:41 |
| chkumar246 | tosky: kopecmartin https://github.com/openstack/tempest/commit/ed6e586b9f8f0ada10af7711f297afa01b2b7754 | 14:44 |
| chkumar246 | tempest-12.0.0 | 14:44 |
| chkumar246 | from newton we are on 13 | 14:45 |
| kopecmartin | chkumar246, great, so it means, we can remove it | 14:48 |
| chkumar246 | kopecmartin: yup sire | 14:51 |
| chkumar246 | kopecmartin: remove from TQE also | 14:56 |
| *** lifeless_ has quit IRC | 15:08 | |
| *** openstackgerrit has joined #refstack | 15:16 | |
| openstackgerrit | Chandan Kumar proposed openstack/python-tempestconf master: [DNM] patch to test backward compatibilty/ container check https://review.openstack.org/570524 | 15:16 |
| chkumar246 | kopecmartin: in devstack Member role is assigned to user and project | 15:23 |
| chkumar246 | against which we are testing | 15:24 |
| chkumar246 | in pythontempestconf jobs swift is disabled | 15:24 |
| kopecmartin | chkumar246, i have a patch which should enable swift for testing purposes https://review.openstack.org/#/c/571985/ | 15:26 |
| chkumar246 | kopecmartin: ack I will rebase it with my patch | 15:58 |
| *** chkumar246 is now known as chandankumar | 16:24 | |
| *** tosky has quit IRC | 16:47 | |
| openstackgerrit | Merged openstack/python-tempestconf master: Validation support https://review.openstack.org/570799 | 16:52 |
| *** kopecmartin has quit IRC | 17:00 | |
| *** markvoelker has quit IRC | 17:59 | |
| *** markvoelker has joined #refstack | 18:00 | |
| *** lifeless has joined #refstack | 19:34 | |
| *** lifeless_ has joined #refstack | 20:49 | |
| *** lifeless has quit IRC | 20:50 | |
| *** lifeless has joined #refstack | 22:31 | |
| *** lifeless_ has quit IRC | 22:31 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!