| *** lifeless has quit IRC | 01:22 | |
| *** lifeless has joined #refstack | 01:27 | |
| *** lifeless has quit IRC | 01:46 | |
| *** lifeless has joined #refstack | 01:53 | |
| *** jhesketh has quit IRC | 02:37 | |
| *** jhesketh has joined #refstack | 02:37 | |
| *** mtreinish has quit IRC | 02:44 | |
| *** mtreinish has joined #refstack | 02:45 | |
| *** openstackgerrit has quit IRC | 02:46 | |
| *** eglute has quit IRC | 02:46 | |
| *** openstackgerrit has joined #refstack | 02:47 | |
| *** eglute has joined #refstack | 02:47 | |
| *** mgagne has quit IRC | 02:50 | |
| *** lifeless has quit IRC | 02:50 | |
| *** markvoelker has quit IRC | 02:50 | |
| *** ekhugen_alt has quit IRC | 02:50 | |
| *** mgagne has joined #refstack | 02:50 | |
| *** lifeless has joined #refstack | 02:51 | |
| *** markvoelker has joined #refstack | 02:51 | |
| *** ekhugen_alt has joined #refstack | 02:51 | |
| *** markvoelker has quit IRC | 04:19 | |
| *** markvoelker has joined #refstack | 04:22 | |
| *** kopecmartin has joined #refstack | 05:55 | |
| openstackgerrit | Chandan Kumar proposed openstack/python-tempestconf master: Allow non admin users to upload image to glance https://review.openstack.org/568252 | 06:33 |
|---|---|---|
| *** lifeless has quit IRC | 06:50 | |
| *** lifeless has joined #refstack | 06:56 | |
| *** tosky has joined #refstack | 07:14 | |
| *** lifeless has quit IRC | 07:54 | |
| *** xinliang has joined #refstack | 08:19 | |
| *** markvoelker has quit IRC | 09:15 | |
| * tosky goes through the reviews backlog | 09:17 | |
| openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: Move configuring services to services class https://review.openstack.org/570876 | 09:20 |
| *** lifeless has joined #refstack | 09:24 | |
| chandankumar | kopecmartin: https://review.openstack.org/#/c/570822/ is will fix the gate | 09:26 |
| openstackgerrit | Chandan Kumar proposed openstack/python-tempestconf master: Use healthcheck api to determine swift service https://review.openstack.org/568869 | 09:28 |
| tosky | kopecmartin: is https://review.openstack.org/570876 an intermediate step in the process of moving the various methods to discover specific services into each class? | 09:44 |
| kopecmartin | tosky, well, kind of, I need to add some code to configure swift and I noticed that that code can be moved to services instead .. | 09:46 |
| tosky | kopecmartin: sure, and long term each check_<foo>_service should be a call too <service_instance>.check_service | 09:52 |
| tosky | so the question is whether to do this now or later (but soon :) | 09:52 |
| chandankumar | tosky: once we are done with temepstconf 2.0.0, we can do the moving those pieces | 09:54 |
| tosky | chandankumar: what is the main driver of 2.0.0 then? I though that it was service refactoring to isolate service configuration | 09:55 |
| chandankumar | tosky: that was my thought that once we release 2.0.0 which will work with refstack and with other stable branches then we can move services, if others want we can start moving right now | 10:02 |
| tosky | chandankumar: my though is that old things can stay with the old code pre-refactoring, no need to branch again if we keep the interface stable | 10:03 |
| tosky | and about moving right now, the review above in fact does already moves stuff; it would just need a tiny little move more and that would clean the code a lot | 10:03 |
| chandankumar | tosky: sorry stable branches means 2.0.0 should work with stable/pike, ocata and other | 10:03 |
| chandankumar | tosky: sure then let's move the things then | 10:04 |
| tosky | chandankumar: my general guideline would be: if you are going to change anyway a certain piece code, try to shape it towards the modularized version | 10:05 |
| tosky | if you don't change it, ok, the work can be done later, but if you change it... | 10:06 |
| tosky | do it "in the proper way"! | 10:06 |
| tosky | a slightly higher cost now, less technical debt later | 10:06 |
| chandankumar | sure, will do that then | 10:10 |
| tosky | thanks | 10:11 |
| *** markvoelker has joined #refstack | 10:16 | |
| *** markvoelker has quit IRC | 10:51 | |
| openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: Don't expose user credentials https://review.openstack.org/570749 | 11:05 |
| openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: Don't expose user credentials https://review.openstack.org/570749 | 11:06 |
| kopecmartin | chandankumar, do you also know what's with tripleo-ci gates? | 11:26 |
| kopecmartin | chandankumar, | 11:27 |
| kopecmartin | https://review.openstack.org/#/c/570749/ | 11:27 |
| chandankumar | kopecmartin: the same error effected everywhere | 11:47 |
| *** markvoelker has joined #refstack | 11:48 | |
| openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: Generate accounts.yaml https://review.openstack.org/570781 | 11:51 |
| openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: Validation support https://review.openstack.org/570799 | 12:09 |
| *** markvoelker has quit IRC | 12:21 | |
| kopecmartin | tosky, about this https://review.openstack.org/#/c/570749/ and the default value | 12:30 |
| kopecmartin | so it's fine as it is right now ? | 12:31 |
| tosky | kopecmartin: it's fine as it is right now: write_credentials=True describes the behavior before the patch | 12:41 |
| tosky | I wrote "False" by mistake | 12:41 |
| kopecmartin | tosky, I'm just checking | 12:42 |
| kopecmartin | and about fix/feature , i don't know | 12:42 |
| kopecmartin | i don't mind to rename it | 12:42 |
| kopecmartin | it's kind of both :D | 12:42 |
| tosky | yeah, uhm | 12:43 |
| tosky | arxcruz|ruck, chandankumar: is https://review.openstack.org/#/c/570749/ a fix or a feature (for the release notes)? | 12:44 |
| arxcruz|ruck | no idea | 12:57 |
| arxcruz|ruck | i'm very busy guys, that's the reason i'm not reviewing the patches very often :( | 12:58 |
| arxcruz|ruck | but i would say this is a fix for a bug that is expose passwords | 12:58 |
| openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: Move configuring of services to services class https://review.openstack.org/570876 | 13:16 |
| *** markvoelker has joined #refstack | 13:17 | |
| tosky | arxcruz|ruck: but it's not a bug to have credentials in tempest.conf | 13:20 |
| arxcruz|ruck | it's a requirement for refstack | 13:20 |
| arxcruz|ruck | if i understood correctly | 13:20 |
| tosky | it's a problem if you need to publish tempest.conf somewhere publicly, which is the use case of refstack | 13:20 |
| tosky | yes, a problem if you publish the file | 13:20 |
| tosky | but it's not a problem in tempest or tempestconf | 13:21 |
| tosky | it avoids you to edit the file afterwards | 13:21 |
| tosky | so implementing this feature allows refstack-client users to skip one step before publishing tempest.conf | 13:21 |
| tosky | this is my reason to consider this change a feature | 13:22 |
| *** markvoelker has quit IRC | 13:22 | |
| arxcruz|ruck | tosky: okay, makes sense, sounds good, let's add a release file | 13:28 |
| arxcruz|ruck | kopecmartin: ^ | 13:28 |
| tosky | arxcruz|ruck: the file was there already, because you can add a release file also for fixes :) | 13:31 |
| arxcruz|ruck | tosky: so... | 13:31 |
| tosky | the question was about the category used in the yaml file | 13:31 |
| tosky | "features" or "fixes" | 13:32 |
| *** markvoelker has joined #refstack | 13:33 | |
| openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: Don't expose user credentials https://review.openstack.org/570749 | 13:40 |
| chandankumar | tosky: kopecmartin please have a look at this review https://review.openstack.org/568869 | 14:05 |
| openstackgerrit | Chandan Kumar proposed openstack/python-tempestconf master: Use healthcheck api to determine swift service https://review.openstack.org/568869 | 14:06 |
| *** markvoelker has quit IRC | 14:24 | |
| *** markvoelker has joined #refstack | 14:26 | |
| *** markvoelker has quit IRC | 14:30 | |
| *** lifeless_ has joined #refstack | 14:31 | |
| *** lifeless has quit IRC | 14:32 | |
| kopecmartin | tosky, tomorrow and the next day I'm on PTO, but I'll rebase or edit patches if it will be needed .. | 14:52 |
| tosky | kopecmartin: and I will be on PTO (again :) on Thursday and Friday | 14:53 |
| *** kopecmartin has quit IRC | 14:56 | |
| *** lifeless_ has quit IRC | 15:24 | |
| *** markvoelker has joined #refstack | 16:52 | |
| *** markvoelker_ has joined #refstack | 16:53 | |
| *** markvoelker has quit IRC | 16:57 | |
| *** markvoelker_ has quit IRC | 18:33 | |
| *** markvoelker has joined #refstack | 18:42 | |
| *** ekhugen has joined #refstack | 18:51 | |
| *** ekhugen_alt has quit IRC | 18:53 | |
| *** markvoelker has quit IRC | 19:18 | |
| *** markvoelker has joined #refstack | 19:19 | |
| *** markvoelker has quit IRC | 19:22 | |
| *** lifeless has joined #refstack | 19:34 | |
| *** markvoelker has joined #refstack | 19:49 | |
| *** markvoelker_ has joined #refstack | 19:50 | |
| *** markvoelker has quit IRC | 19:54 | |
| *** tosky has quit IRC | 22:02 | |
| *** tosky has joined #refstack | 22:06 | |
| *** lifeless has quit IRC | 22:07 | |
| *** lifeless has joined #refstack | 23:10 | |
| *** lifeless_ has joined #refstack | 23:23 | |
| *** lifeless has quit IRC | 23:25 | |
| *** tosky has quit IRC | 23:25 | |
| *** openstackstatus has joined #refstack | 23:44 | |
| *** ChanServ sets mode: +v openstackstatus | 23:44 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!