| openstackgerrit | Merged openstack/python-tempestconf master: Filter deprecated versions out https://review.openstack.org/568695 | 01:40 |
|---|---|---|
| openstackgerrit | Merged openstack/python-tempestconf master: Make tempestconf easier to use as an library https://review.openstack.org/562672 | 02:26 |
| *** kopecmartin has joined #refstack | 06:50 | |
| chandankumar | luzC_: around? | 07:14 |
| *** kopecmartin has quit IRC | 07:54 | |
| *** markvoelker has quit IRC | 07:55 | |
| *** kopecmartin has joined #refstack | 07:56 | |
| *** tosky has joined #refstack | 08:02 | |
| *** arxcruz has quit IRC | 08:30 | |
| chandankumar | tosky: regarding this review https://review.openstack.org/568252 allow creating an image for all user | 08:51 |
| chandankumar | what i found that image with public visibility is created by admin only | 08:51 |
| chandankumar | tosky: but from refstack point of view does image is created by admin itself or non-admin can create the image with private visibility? | 08:52 |
| chandankumar | tosky: I need help here | 08:52 |
| tosky | refstack point of view? | 08:53 |
| tosky | there is just the test and API point of view | 08:53 |
| tosky | I would go back one step: what problem are you trying to solve exactly with the change? | 08:53 |
| chandankumar | tosky: I wanted to allow users(admin, non-admin) to upload image without create | 08:54 |
| tosky | and what was the goal? | 08:55 |
| chandankumar | so that image is passed the image_ref and image_ref_alt will be setted automatically after image upload | 08:55 |
| tosky | does tempest expct that image_ref is a public image? | 08:56 |
| tosky | (same for image_ref_alt) | 08:56 |
| chandankumar | tosky: there is no mention of that anywhere | 08:56 |
| *** markvoelker has joined #refstack | 08:56 | |
| chandankumar | it should be public or private | 08:56 |
| tosky | so the question to investigate here should be: does it matter that the image is public or private? It may need to be private if you test with admin credentials | 08:57 |
| chandankumar | but in tempestconf we have https://github.com/openstack/python-tempestconf/blob/master/config_tempest/services/image.py#L145 | 08:57 |
| tosky | because then you test with more users | 08:57 |
| tosky | but does it matter when you test with non-admin credentials and you have the credentials of a poor user who can only create private images? | 08:57 |
| tosky | if it matters, and you need public images, then no, you need to setup the image beforehand, in the environment, or provide one if you can't | 08:58 |
| tosky | if it does not matter, which means that using a private image does not restrict even more the set of tests that you can execute with your non-admin credentials, then just create it as private | 08:59 |
| tosky | you will always set it as public if you can (aka admin) | 08:59 |
| chandankumar | tosky: If i understand correctly, you mean to say for admin use public, set ot private for non-admin if it does not block non-admin tests | 09:14 |
| tosky | yes: for admin you can create as public, so do it; for non-admin, as you wrote: if the private image does not restrict the testing, let the user create it as private | 09:15 |
| tosky | if it's not possible, well, there is nothing that we can do | 09:15 |
| *** arxcruz has joined #refstack | 09:23 | |
| *** markvoelker has quit IRC | 09:30 | |
| openstackgerrit | Chandan Kumar proposed openstack/python-tempestconf master: [WIP]Allow non admin users to upload image to glance https://review.openstack.org/568252 | 09:44 |
| chandankumar | tosky: thanks, :-) | 09:44 |
| *** rmart04 has joined #refstack | 09:53 | |
| chandankumar | kopecmartin: arxcruz planning sprint 14 ahead https://review.rdoproject.org/etherpad/p/tempest-sprint-14 | 10:05 |
| chandankumar | feel free to add your ideas there | 10:05 |
| arxcruz | chandankumar: if you use this format https://etherpad.openstack.org/p/arxcruz-test you can use my script that will generate the cards, and tasks, etc, etc | 10:06 |
| chandankumar | arxcruz: sure, I will format that once things are finalized, it would be easier | 10:07 |
| arxcruz | chandankumar: https://github.com/arxcruz/trellopad | 10:07 |
| arxcruz | it's not error safe so it must be properly formatted the etherpad | 10:08 |
| tosky | and remember to add the relevant stories to storyboard (the sprint planning is your own internal thing) with proper tasks | 10:13 |
| *** markvoelker has joined #refstack | 10:28 | |
| *** markvoelker has quit IRC | 11:00 | |
| *** markvoelker has joined #refstack | 11:15 | |
| kopecmartin | tosky, chandankumar arxcruz , why is this stuck on verified label? https://review.openstack.org/#/c/568827/ | 11:49 |
| kopecmartin | it seems, there is some kind of error | 11:49 |
| kopecmartin | gates passed | 11:49 |
| tosky | kopecmartin: its dependency | 12:21 |
| tosky | "this looks good, even if the patch will probably have to wait" means "it depends on the tempest patch, so it won't be merged until the tempest patch is merged" | 12:21 |
| kopecmartin | tosky, oh, i forgot | 12:25 |
| kopecmartin | tosky, I'm rechecking all the other reviews and I totally forgot about the dependency :D, ok never mind | 12:26 |
| tosky | yeah, it happened to me too, I know the feeling | 12:27 |
| *** rmart04 has quit IRC | 15:01 | |
| *** rmart04 has joined #refstack | 15:05 | |
| *** rmart04 has quit IRC | 15:46 | |
| *** rmart04 has joined #refstack | 15:56 | |
| *** rmart04 has quit IRC | 16:06 | |
| *** kopecmartin has quit IRC | 17:44 | |
| *** tosky has quit IRC | 18:39 | |
| *** tosky has joined #refstack | 18:42 | |
| *** xinliang has quit IRC | 23:08 | |
| *** xinliang has joined #refstack | 23:20 | |
| *** tosky has quit IRC | 23:42 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!