| openstackgerrit | megan guiney proposed openstack/refstack master: allow for the addition of new capability sources https://review.openstack.org/547246 | 01:05 |
|---|---|---|
| *** jschluet has quit IRC | 04:31 | |
| *** jschlueter has joined #refstack | 04:34 | |
| *** markvoelker has quit IRC | 05:08 | |
| *** markvoelker has joined #refstack | 06:09 | |
| *** kopecmartin has joined #refstack | 06:10 | |
| openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: [DNM] Add devstack job with mistral enabled https://review.openstack.org/565690 | 06:12 |
| *** markvoelker has quit IRC | 06:44 | |
| *** tosky has joined #refstack | 07:29 | |
| *** markvoelker has joined #refstack | 07:41 | |
| *** markvoelker has quit IRC | 08:13 | |
| *** markvoelker has joined #refstack | 09:10 | |
| openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: A service can have no endpoints https://review.openstack.org/566003 | 09:20 |
| *** markvoelker has quit IRC | 09:44 | |
| *** markvoelker has joined #refstack | 10:41 | |
| *** markvoelker has quit IRC | 11:14 | |
| openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: Fix flaky unit test https://review.openstack.org/566040 | 11:59 |
| *** markvoelker has joined #refstack | 12:11 | |
| *** markvoelker has quit IRC | 12:20 | |
| *** markvoelker has joined #refstack | 12:20 | |
| tosky | kopecmartin: added +2 on 565236, and a comment about how to proceed with the splitting | 12:54 |
| tosky | kopecmartin: the idea is that you should not touch SERVICE_NAMES to add new services, but the content of SERVICE_NAMES should be provided by the classes derived from Service | 12:55 |
| kopecmartin | tosky, hmm, so you want to make it more automated so that we don't have to hardcode service names? | 12:57 |
| tosky | kopecmartin: no, the names should be hardcoded | 12:58 |
| tosky | I'm saying that they should not be in SERVICE_NAMES; that dict should not exist at all | 12:58 |
| tosky | for each service we already have a class derived from Service - can't we use those classes? | 12:58 |
| tosky | a class attribute | 12:58 |
| kopecmartin | i see | 13:00 |
| kopecmartin | yes we sure can somehow, we can add it to the sprint card chandankumar created for our next sprint | 13:01 |
| chandankumar | kopecmartin: tosky added the bug list also herehttps://trello.com/c/efqE5XMr/734-sprint-13-refactor-python-tempestconf | 13:01 |
| chandankumar | kopecmartin: feel free to dump them as comments | 13:02 |
| tosky | kopecmartin: the point behind the idea of those services class is that, whenever possible (so maybe keystone could have some exceptions), information about a service should be isolated and encapsulated in a class | 13:02 |
| tosky | so you just dump a new class with all the information about that service and everything works | 13:03 |
| kopecmartin | tosky maybe we don't even need a new class, we already have a 'Services' class which has a information about all the services classes | 13:05 |
| kopecmartin | I'll take a look | 13:05 |
| tosky | kopecmartin: I didn't mean a new class :) | 13:05 |
| tosky | rephrasing: the idea of those service class (derived from Services) is that [...] information about a service should be isolated in (such) a class | 13:06 |
| kopecmartin | I understand .. btw about the cp error .. I tried to remove the file, because i thought it was created by devstack during mistral installation with some kind of special permissions, but removal of the file didn't help :D | 13:09 |
| kopecmartin | I'm not sure if it's important to debug it | 13:10 |
| tosky | not for that specific review; but it may popup again if you need to create a job with mistral | 13:11 |
| tosky | or in another case | 13:11 |
| *** designbybeck has quit IRC | 14:40 | |
| openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: A service can have no endpoints https://review.openstack.org/566003 | 15:26 |
| *** kopecmartin has quit IRC | 15:29 | |
| *** openstackgerrit has quit IRC | 19:05 | |
| *** openstackgerrit has joined #refstack | 20:14 | |
| openstackgerrit | megan guiney proposed openstack/refstack master: Convert from bower usage to npm https://review.openstack.org/559459 | 20:14 |
| openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: Fix flaky unit test https://review.openstack.org/566040 | 21:40 |
| openstackgerrit | megan guiney proposed openstack/refstack master: Convert from bower usage to npm https://review.openstack.org/559459 | 21:46 |
| openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: Improve role docs, remove unused var https://review.openstack.org/565792 | 22:09 |
| openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: A service can have no endpoints https://review.openstack.org/566003 | 23:17 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!