| *** cjvolzka has quit IRC | 00:35 | |
| *** _sarob has quit IRC | 01:31 | |
| openstackgerrit | Merged openstack/refstack: update angular bootstrap lib version https://review.openstack.org/280187 | 01:53 |
|---|---|---|
| *** markvoelker_ has quit IRC | 02:34 | |
| *** _sarob has joined #refstack | 03:03 | |
| *** _sarob has quit IRC | 03:08 | |
| *** _sarob has joined #refstack | 03:12 | |
| *** _sarob has quit IRC | 03:15 | |
| *** _sarob has joined #refstack | 03:17 | |
| *** krotscheck_dr is now known as krotscheck_afk | 03:18 | |
| *** esker has joined #refstack | 03:27 | |
| *** _sarob has quit IRC | 03:34 | |
| *** markvoelker has joined #refstack | 03:34 | |
| *** markvoelker has quit IRC | 03:39 | |
| *** _sarob has joined #refstack | 03:49 | |
| *** cjvolzka has joined #refstack | 03:52 | |
| *** cjvolzka has quit IRC | 03:52 | |
| *** _sarob has quit IRC | 04:14 | |
| *** _sarob has joined #refstack | 05:22 | |
| *** _sarob has quit IRC | 05:32 | |
| *** _sarob has joined #refstack | 05:32 | |
| *** markvoelker has joined #refstack | 05:36 | |
| *** markvoelker has quit IRC | 05:40 | |
| *** _sarob has quit IRC | 05:41 | |
| *** _sarob has joined #refstack | 05:41 | |
| *** _sarob has quit IRC | 05:57 | |
| *** _sarob has joined #refstack | 05:57 | |
| *** _sarob has quit IRC | 06:01 | |
| *** _sarob has joined #refstack | 06:01 | |
| *** _sarob has quit IRC | 06:02 | |
| *** resker has joined #refstack | 06:13 | |
| *** esker has quit IRC | 06:15 | |
| *** resker has quit IRC | 06:30 | |
| *** esker has joined #refstack | 06:53 | |
| *** esker has quit IRC | 07:31 | |
| *** markvoelker has joined #refstack | 07:36 | |
| *** markvoelker has quit IRC | 07:40 | |
| *** esker has joined #refstack | 07:50 | |
| *** esker has quit IRC | 08:31 | |
| *** esker has joined #refstack | 08:41 | |
| *** esker has quit IRC | 09:30 | |
| *** esker has joined #refstack | 09:34 | |
| *** markvoelker has joined #refstack | 09:37 | |
| *** markvoelker has quit IRC | 09:42 | |
| *** esker has quit IRC | 11:31 | |
| *** markvoelker has joined #refstack | 11:38 | |
| *** markvoelker has quit IRC | 11:42 | |
| *** esker has joined #refstack | 11:43 | |
| *** esker has quit IRC | 12:27 | |
| *** esker has joined #refstack | 12:36 | |
| *** Deng has quit IRC | 12:53 | |
| *** markvoelker has joined #refstack | 12:54 | |
| *** markvoelker has quit IRC | 12:58 | |
| *** markvoelker has joined #refstack | 13:04 | |
| *** krotscheck_afk is now known as krotscheck | 13:05 | |
| *** edmondsw has joined #refstack | 13:28 | |
| openstackgerrit | Andrey Pavlov proposed openstack/refstack: WIP: new Refstack model. https://review.openstack.org/281679 | 13:59 |
| *** cjvolzka has joined #refstack | 14:23 | |
| *** esker has quit IRC | 14:26 | |
| *** openstackgerrit_ has quit IRC | 14:43 | |
| *** openstackgerrit_ has joined #refstack | 15:00 | |
| *** esker has joined #refstack | 15:20 | |
| *** esker has quit IRC | 15:25 | |
| *** coolsvap|away has quit IRC | 16:03 | |
| *** coolsvap|away has joined #refstack | 16:09 | |
| *** esker has joined #refstack | 17:08 | |
| *** esker has quit IRC | 17:29 | |
| *** pilgrimstack has quit IRC | 17:56 | |
| *** _sarob has joined #refstack | 18:22 | |
| *** krotscheck has quit IRC | 18:25 | |
| *** dmellado has quit IRC | 18:25 | |
| *** krotscheck has joined #refstack | 18:25 | |
| *** dmellado has joined #refstack | 18:26 | |
| *** lifeless has quit IRC | 18:27 | |
| *** christiana has quit IRC | 18:27 | |
| *** lifeless has joined #refstack | 18:27 | |
| *** andrey-mp has joined #refstack | 18:51 | |
| *** alexandrelevine has joined #refstack | 18:58 | |
| catherineD | hello ... | 19:01 |
| andrey-mp | hi | 19:02 |
| catherineD | andrey-mp: sorry you have to stay late on a Friday ... | 19:02 |
| andrey-mp | but I'm at home ) | 19:02 |
| catherineD | Let's wait a few mins | 19:03 |
| catherineD | Paul is on vacation today ... | 19:05 |
| alexandrelevine | hi | 19:05 |
| catherineD | we can talk about the pypi package for RefStack ... Paul submitted 2 patches for RefStack to use pypi ... andrey-mp: is one of the reviewers | 19:06 |
| catherineD | alexandrelevine: hi | 19:06 |
| andrey-mp | one is already merged (to project-config) | 19:06 |
| andrey-mp | but second has a WIP=-1 from Paul | 19:07 |
| andrey-mp | and I don't know why | 19:07 |
| catherineD | yea he is still testing | 19:07 |
| catherineD | https://etherpad.openstack.org/p/refstack-meeting-16-02-15 | 19:07 |
| alexandrelevine | catherineD: Have you seen my questions in the mailing list? Do you think they make sense? | 19:07 |
| catherineD | let's discuss item 9 | 19:07 |
| catherineD | alexandrelevine: I response ... | 19:07 |
| catherineD | we can come back to alexandrelevine: email to DefCore later | 19:08 |
| alexandrelevine | catherineD: Oh, you did. Thanks a lot. Just received it. | 19:08 |
| catherineD | https://refstack.openstack.org/api/v1/results?signed works as designed | 19:09 |
| catherineD | it returns every tests (share, not share) that the user created | 19:10 |
| catherineD | and that is what used to list in "My Results" | 19:10 |
| andrey-mp | catherineD: I thought it returns only signed tests | 19:11 |
| catherineD | yes only signed test | 19:11 |
| andrey-mp | because we can't decide which test is it if it is not signed | 19:11 |
| catherineD | signed tests of the user that include share , not share uploaded by the user | 19:11 |
| alexandrelevine | catherineD: The supposed problem is with simple request, without "signed" filter. | 19:12 |
| *** _sarob has quit IRC | 19:12 | |
| andrey-mp | f | 19:12 |
| catherineD | without signed it will return everything that is public plus what ever crested by the user | 19:13 |
| andrey-mp | (and shared) | 19:13 |
| catherineD | shared and not shared (one sec let me verify) | 19:15 |
| alexandrelevine | catherineD: "It doesn't return signed but not shared results belonging to the user sending the request" | 19:15 |
| *** esker has joined #refstack | 19:15 | |
| catherineD | checking .. | 19:16 |
| andrey-mp | i understand code as - without signed it returns all not signed results + all shared results | 19:17 |
| andrey-mp | https://github.com/openstack/refstack/blob/master/refstack/db/sqlalchemy/api.py#L229 | 19:17 |
| catherineD | andrey-mp: you are right .. it does not return "not shared" that is a bug | 19:18 |
| *** _sarob has joined #refstack | 19:18 | |
| catherineD | andrey-mp: you want to log a bug? | 19:18 |
| andrey-mp | let's discuss it first | 19:18 |
| catherineD | k | 19:19 |
| andrey-mp | fixing of this bug will affect showing private user tests in tab 'community results' | 19:19 |
| catherineD | andrey-mp: only when the user log in | 19:19 |
| andrey-mp | yeah | 19:19 |
| andrey-mp | is it suitable? | 19:19 |
| catherineD | andrey-mp: not suitable for the UI | 19:20 |
| catherineD | because the UI labled "community results" which should only be shared records | 19:20 |
| andrey-mp | but in UI we can't filter it normally due to paging :) | 19:20 |
| catherineD | but from REST API ... it should return everything that the user have privilege to | 19:21 |
| andrey-mp | what we wil do with UI side? | 19:21 |
| catherineD | andrey-mp: the ui will display less items then the page allow | 19:22 |
| andrey-mp | and sometimes we can see empty page... (because all results on this page is not 'community results') | 19:23 |
| catherineD | andrey-mp: that is a valid concern | 19:23 |
| andrey-mp | alexandrelevine: what do you think? | 19:24 |
| alexandrelevine | catherineD: We can introduce more filters. Like "public". It'll return all signed and unsigned but publicly available. | 19:25 |
| catherineD | andrey-mp: the other option is to add filer | 19:25 |
| alexandrelevine | and the list without filters would return everything available. | 19:25 |
| catherineD | :-) | 19:25 |
| catherineD | yea | 19:25 |
| alexandrelevine | I guess the same filter we can introduce to other REST APIs if we really want to do server-side paging/sorting/filtering. | 19:26 |
| andrey-mp | alexandrelevine: right now 'signed' word is present in query part of URL. | 19:26 |
| catherineD | alexandrelevine: for test results ... the only sorting right now is on upload date | 19:26 |
| alexandrelevine | catherineD: I agree. I'm thinking about common approach to all other REST APIs. | 19:27 |
| alexandrelevine | catherineD: However, obviously, sorting by CloudID would be very useful for test results. | 19:27 |
| alexandrelevine | catherineD: It'll be much more useful than "by date". Maybe we should introduce filter for this in Mitaka. It'll greatly improve user experience. | 19:28 |
| catherineD | alexandrelevine: I agree ... this is why I want us to carefully thinking about the API | 19:28 |
| andrey-mp | what is the last decision about filter param in REST API? | 19:28 |
| catherineD | alexandrelevine: I would suggest that we makethe improvement in the new API s first ... | 19:29 |
| catherineD | design the APIs based and improve from the lession learned | 19:30 |
| alexandrelevine | catherineD: It doesn't much matter - mechanisms should be all very similar, so when you add something or change something in one place - the same in others should be much easier. But the value is huge. | 19:30 |
| catherineD | alexandrelevine: I understand that is why we will select the important feature to implemented first ... at the test results listing time ... we believe sort by data is important and did not implement sort by cpid ... | 19:31 |
| catherineD | but we did filter by CPID | 19:31 |
| catherineD | so after fitlering the user will have a small list of results with one CPID and sorted by date | 19:32 |
| alexandrelevine | catherineD: Ok, so you vote for server-side filtering/paging/sorting? Don't want simple REST APIs and paging client-side? | 19:32 |
| catherineD | it is not perfect but are the import feature at the time | 19:32 |
| andrey-mp | (btw, tag is working now and new commits don't go to production) | 19:33 |
| catherineD | no I vote for implementing pagind and filtering at the REST API level ... as I have written the REST aPI spec | 19:33 |
| catherineD | andrey-mp: yea we are good for that ... | 19:34 |
| alexandrelevine | catherineD: Yes, Andrey is right, now everything should be merged faster, right? | 19:34 |
| alexandrelevine | catherineD: REST API level means server-side. Ok. | 19:34 |
| catherineD | but I still want to control what is being merged tp RefStack ... I really do not want us to do a lot of clean up | 19:34 |
| alexandrelevine | catherineD: We won't. But we need to move faster. | 19:34 |
| alexandrelevine | (sorry to push :) ) | 19:34 |
| catherineD | so far the RefStack site does not have a lot of issues becayse we have been careful in code merge and put code on line incrementally | 19:35 |
| catherineD | alexandrelevine: we do not move as fast because we disagree | 19:35 |
| catherineD | I am not saying that disagreement is not good | 19:35 |
| catherineD | I ams saying that we have more aspects to consider ... which I believe is good for the long run | 19:36 |
| alexandrelevine | catherineD: I take it when we agree we'll move fast :) | 19:36 |
| catherineD | exactly ... | 19:36 |
| catherineD | and we disagree because of different perspective that we have | 19:36 |
| catherineD | and if we take sometime to ion out the different opinions ... our slowness actually will have line issues or even line down situation | 19:38 |
| catherineD | so I would rather we move faster bu do not mind we take time to do the right thing | 19:38 |
| alexandrelevine | catherineD: Ok, let's put it as one of the outcomes of this meeting: We'll do the right thing :) | 19:39 |
| catherineD | so for the list results .. I think it is a bug in the REST API that it does not return everything ... as for the UI ... we can add a filter at the REST API level ... | 19:40 |
| catherineD | to list all public test results | 19:40 |
| alexandrelevine | agree | 19:41 |
| catherineD | the thing is this bug a high priority for us now? of course we will log the bug ... I would rather us to concentrate on vendor registraion for Mitaka | 19:41 |
| alexandrelevine | It's very easy to fix. We'll squeeze it in at some point. Don't worry. | 19:42 |
| catherineD | alexandrelevine: I know we can implement with adding a public filfer ... but is that what we want .. or we should add a query liek type and let the filter be as type in (public, signd ...) | 19:43 |
| alexandrelevine | catherineD: I'll think about it. We'll need to commonize it for all REST APIs so I'll suggest later. | 19:44 |
| catherineD | so I suggest that let's us gain a bit more experience in the vendor, user, product API in terms of filtering and sorting and then fix older API later | 19:45 |
| andrey-mp | catherineD: good point :) | 19:45 |
| catherineD | let 's set a uniform way for RefStack API so our API is predictable and therefore user friendly | 19:46 |
| catherineD | but definitely log a bug for the lis resutls ... | 19:46 |
| catherineD | I have hard stop in 13 mins ... let's talk about user management | 19:47 |
| andrey-mp | catherineD: could you file a bug? | 19:47 |
| catherineD | andrey-mp: I will | 19:47 |
| andrey-mp | thank you! | 19:47 |
| alexandrelevine | catherineD: What about user management? | 19:48 |
| catherineD | andrey-mp: THANK YOU!!! for finding the bug | 19:48 |
| catherineD | what do we want to use as the identifier for the user : v1/vendors/{vendor_id}/users/{user_email} or v1/vendors/{vendor_id}/users/{user_openid} | 19:48 |
| catherineD | I think either email or openid would be enough | 19:49 |
| alexandrelevine | user_openid | 19:49 |
| catherineD | I vote for email because that is what we use to log into openid | 19:49 |
| alexandrelevine | definitely not email. | 19:49 |
| alexandrelevine | id should be used in all requests for all entities. | 19:49 |
| alexandrelevine | All REST APIs should work with IDs. | 19:49 |
| alexandrelevine | So if for user we choose openid as id - then that's what it is. | 19:50 |
| catherineD | I am confuse ... from your email to DefCore ... I thought you say that OpenID is hard to get | 19:50 |
| alexandrelevine | catherineD: No. I said it's useless in terms of displaying. | 19:50 |
| catherineD | I don't mind either way .. | 19:50 |
| alexandrelevine | catherineD: And I said it's hard to get for poor Vendor. Not for our UI. It'll get it from the list of users. | 19:50 |
| catherineD | so we use OpenID as andrey-mp: had commented we have to encode it | 19:51 |
| alexandrelevine | perfect | 19:51 |
| catherineD | if we want to use it on the URI | 19:51 |
| andrey-mp | base64 encoding | 19:51 |
| catherineD | so that would become a string from the REST API point of view | 19:52 |
| andrey-mp | yes | 19:52 |
| catherineD | ok | 19:52 |
| catherineD | I will update the API spec so we can discuss if neede on Monday ... | 19:53 |
| andrey-mp | could we discuss this review https://review.openstack.org/#/c/281299/ on Monday meeting? | 19:53 |
| catherineD | we can discuss a bit now .. | 19:54 |
| andrey-mp | perfect | 19:54 |
| andrey-mp | I want to get some reviews | 19:55 |
| catherineD | what would be the advantage on create flag vs calling the method api_utils.check_user_is_foundation_admin() directly? saving cpu process? | 19:55 |
| andrey-mp | main problem here - is to have additional flag in profile REST and have same flag in JS state | 19:56 |
| catherineD | ok I see the point ... between server and JS (client) | 19:57 |
| andrey-mp | rendering of some pages needs to know user privileges to render elements | 19:57 |
| catherineD | should is_admin be is_foundation_admin ? because down the road we may have vendor admin? or we have to document somewhere that the term "admin" is used foundation admin? | 19:58 |
| alexandrelevine | catherineD: no. It shouldn't | 19:58 |
| alexandrelevine | catherineD: We'll handle vendor admin differently when the time comes. | 19:58 |
| catherineD | alexandrelevine: please explain | 19:58 |
| andrey-mp | user can be admin of several vendors for example | 19:59 |
| andrey-mp | but foundation only one | 19:59 |
| catherineD | my concern is at the JS level ... the code will get the flag of is_admin? do the reader know that means foundation admin? T | 19:59 |
| alexandrelevine | catherineD: foundation admin is a privilege and affects everything. Vendor admin would be in some particular lists or actions and we might want to use various permissions like can_add or can_list or something. | 19:59 |
| catherineD | alexandrelevine I know | 20:00 |
| andrey-mp | i can rename it to is_foundation_admin but we can define term 'admin' as foundation admin | 20:00 |
| alexandrelevine | catherineD: In any case - admin is the superuser. No need to add foundation_admin. Whatever we do with the vendor admin, is_admin means superuser. | 20:00 |
| andrey-mp | where we can define 'admin = foundation admin' ? | 20:01 |
| alexandrelevine | andrey-mp: We shouldn't. Admin - means superuser. No need to bother anymore. | 20:01 |
| catherineD | andrey-mp: I don't mind either way : rename or document ... but we need to do one of it for the new coder to RefStack to read the code eaiser ... | 20:01 |
| andrey-mp | oh, ok | 20:01 |
| *** davidlenwell has quit IRC | 20:01 | |
| alexandrelevine | I think I have to go. Can we continue Monday? Hopefully we'll get some more answers from DefCore as well. | 20:02 |
| catherineD | ok thx andrey-mp: alexandrelevine: | 20:02 |
| andrey-mp | catherineD: I vote for document somewhere | 20:02 |
| alexandrelevine | thank you. bye. | 20:02 |
| andrey-mp | thank you! | 20:02 |
| *** alexandrelevine has quit IRC | 20:02 | |
| andrey-mp | byu | 20:02 |
| andrey-mp | bye | 20:03 |
| catherineD | andrey-mp: yep document is good thx | 20:03 |
| *** andrey-mp has quit IRC | 20:05 | |
| *** davidlenwell has joined #refstack | 20:06 | |
| *** ChanServ sets mode: +o davidlenwell | 20:06 | |
| *** christiana has joined #refstack | 20:34 | |
| *** _sarob has quit IRC | 20:38 | |
| *** _sarob has joined #refstack | 20:42 | |
| *** _sarob has quit IRC | 20:47 | |
| *** _sarob has joined #refstack | 20:50 | |
| *** _sarob has quit IRC | 20:55 | |
| *** _sarob has joined #refstack | 20:55 | |
| *** sarob_ has joined #refstack | 21:02 | |
| *** _sarob has quit IRC | 21:04 | |
| *** pilgrimstack has joined #refstack | 21:12 | |
| *** edmondsw has quit IRC | 21:44 | |
| openstackgerrit | Catherine Diep proposed openstack/refstack: REST API specification for vendor user management. https://review.openstack.org/277313 | 22:22 |
| *** sarob_ has quit IRC | 22:24 | |
| openstackgerrit | Catherine Diep proposed openstack/refstack: REST API specification for vendor user management. https://review.openstack.org/277313 | 22:35 |
| *** _sarob has joined #refstack | 22:36 | |
| *** _sarob has quit IRC | 22:37 | |
| *** _sarob has joined #refstack | 22:37 | |
| *** _sarob has quit IRC | 22:37 | |
| *** _sarob has joined #refstack | 22:37 | |
| *** pilgrimstack has quit IRC | 23:25 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!