| *** pvaneck has quit IRC | 00:34 | |
| *** geoffarnold has quit IRC | 00:54 | |
| *** mtreinish has quit IRC | 02:28 | |
| openstackgerrit | david liu proposed openstack/refstack: Refstack pop up window should remain open before users click close. https://review.openstack.org/225063 | 02:58 |
|---|---|---|
| *** mtreinish has joined #refstack | 02:59 | |
| *** mtreinish has quit IRC | 04:18 | |
| *** mtreinish has joined #refstack | 04:23 | |
| *** erw has quit IRC | 07:41 | |
| *** serverascode has quit IRC | 07:41 | |
| *** serverascode has joined #refstack | 09:54 | |
| *** erw has joined #refstack | 09:54 | |
| *** edmondsw has joined #refstack | 12:33 | |
| *** geoffarnold has joined #refstack | 15:39 | |
| *** cody-somerville has joined #refstack | 16:50 | |
| *** catherineD has quit IRC | 17:14 | |
| *** catherineD has joined #refstack | 17:17 | |
| *** catherineD has quit IRC | 17:20 | |
| *** cody-somerville has quit IRC | 17:23 | |
| *** pvaneck has joined #refstack | 18:35 | |
| openstackgerrit | Merged openstack/refstack: Remove old capabilities assets https://review.openstack.org/225252 | 18:50 |
| pvaneck | krotscheck: Hey, seem to be having an issue with the npm-run-lint job reporting success even when there are lint errors as seen on https://review.openstack.org/#/c/226050 | 19:22 |
| pvaneck | wondering if you know what could cause that | 19:22 |
| pvaneck | running: "npm lint --silent || npm run lint --silent" locally does show the errors and a non-zero exit code, but for some reason this isn't the case in the gate check | 19:28 |
| krotscheck | pvaneck: Hrm. | 19:44 |
| krotscheck | pvaneck: It's running "npm lint" not "npm run lint" | 19:45 |
| krotscheck | I can look a bit deeper, have to take the missus out for a lunch | 19:46 |
| pvaneck | krotscheck sure, thanks | 19:46 |
| pvaneck | since "npm lint" fails, shouldn't it then run "npm run lint"? | 19:48 |
| *** cody-somerville has joined #refstack | 19:50 | |
| *** cody-somerville has quit IRC | 19:50 | |
| *** cody-somerville has joined #refstack | 19:50 | |
| pvaneck | hmm even if it did just run "npm lint", wouldn't that produce a non-zero exit code and mark the job as failure | 19:53 |
| *** cody-somerville has quit IRC | 20:18 | |
| krotscheck | pvaneck: Yeah, I know | 21:42 |
| *** cody-somerville has joined #refstack | 21:47 | |
| *** cody-somerville has quit IRC | 21:59 | |
| *** davidlenwell has quit IRC | 22:08 | |
| krotscheck | pvaneck: The issue appears to be the fact that yaml seems to use | as some kind of a script-block signifier, and the || later confuses it. | 22:08 |
| *** davidlenwell has joined #refstack | 22:09 | |
| *** ChanServ sets mode: +o davidlenwell | 22:09 | |
| *** edmondsw has quit IRC | 22:10 | |
| krotscheck | Im wrong | 22:13 |
| pvaneck | krotscheck: So it does have something to do with how the command with the || is being interpreted? | 22:20 |
| krotscheck | Beats me? I'm digging around JJB right now to see what's up, but I may have to try a different kind ofs cript | 22:39 |
| krotscheck | pvaneck: Turns out that npm@1.x, which is default on trusty, returns exit code 0 when an invalid CLI command is passed. | 23:42 |
| openstackgerrit | Paul Van Eck proposed openstack/refstack: Do not merge - Testing npm-lint-gate https://review.openstack.org/226050 | 23:50 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!