rdogerrit | Marios Andreou proposed rdo-jobs master: Drop old EDPM related roles and jobs https://review.rdoproject.org/r/c/rdo-jobs/+/49081 | 05:53 |
---|---|---|
*** amoralej|off is now known as amoralej | 06:00 | |
rdogerrit | Joel Capitao proposed openstack/os-testr-distgit rpm-master: Switch to pyproject-rpm-macros https://review.rdoproject.org/r/c/openstack/os-testr-distgit/+/49025 | 06:47 |
amoralej | jcapitao[m], karolinku[m] it seems all ci jobs are failing | 06:48 |
amoralej | are you observing the same? | 06:48 |
jcapitao[m] | I noticed yesterday https://review.rdoproject.org/r/c/openstack/wsme-distgit/+/49021 | 06:49 |
jcapitao[m] | RETRY_LIMIT | 06:49 |
jcapitao[m] | so it's sill the case apparently | 06:49 |
karolinku[m] | seen thin morning, on promo dahboard | 06:59 |
rdogerrit | Karolina Kula proposed config master: Create yoga branch for missing project https://review.rdoproject.org/r/c/config/+/49083 | 07:12 |
rdogerrit | Karolina Kula proposed rdo-jobs master: Add rpmlint filters for microversion-parse https://review.rdoproject.org/r/c/rdo-jobs/+/49093 | 08:01 |
rdogerrit | Karolina Kula proposed openstack/keystonemiddleware-distgit rpm-master: Switch to pyproject-rpm-macros https://review.rdoproject.org/r/c/openstack/keystonemiddleware-distgit/+/48989 | 08:49 |
amoralej | ci seems in better shape now | 10:39 |
rdogerrit | Alfredo Moralejo proposed openstack/glance_store-distgit rpm-master: Switch to pyproject-rpm-macros https://review.rdoproject.org/r/c/openstack/glance_store-distgit/+/49068 | 10:52 |
amoralej | jcapitao[m], karolinku[m] ^ testing the extras approach | 10:52 |
rdogerrit | Alfredo Moralejo proposed openstack/glean-distgit rpm-master: Switch to pyproject-rpm-macros https://review.rdoproject.org/r/c/openstack/glean-distgit/+/49069 | 11:05 |
amoralej | jcapitao[m], karolinku[m] ^ and that's the approach for removing sphinx when with_docs = 0 | 11:06 |
rdogerrit | Alfredo Moralejo proposed openstack/glean-distgit rpm-master: DNM test with_docs 0 https://review.rdoproject.org/r/c/openstack/glean-distgit/+/49094 | 11:06 |
amoralej | testing it ^ | 11:06 |
jcapitao[m] | it's working fine | 11:21 |
jcapitao[m] | 👍️ | 11:21 |
amoralej | compare-deps job does not know how to handle new packages added, i'll test it manually | 11:24 |
amoralej | works like a charm | 11:36 |
rdogerrit | Marios Andreou proposed rdo-jobs master: Add periodic version of data plane adoption crc/standalone job https://review.rdoproject.org/r/c/rdo-jobs/+/48837 | 11:59 |
rdogerrit | Alfredo Moralejo proposed config master: Make Karolina core reviewer of releng https://review.rdoproject.org/r/c/config/+/49095 | 12:04 |
rdogerrit | Merged openstack/os-service-types-distgit rpm-master: Switch to pyproject-rpm-macros https://review.rdoproject.org/r/c/openstack/os-service-types-distgit/+/49055 | 12:08 |
*** amoralej is now known as amoralej|lunch | 12:10 | |
jcapitao[m] | amoralej: I left a comment in https://review.rdoproject.org/r/c/openstack/glean-distgit/+/49069 | 12:11 |
rdogerrit | Joel Capitao proposed rdo-jobs master: Use diff instead of sdiff https://review.rdoproject.org/r/c/rdo-jobs/+/49096 | 12:21 |
rdogerrit | Merged rdoinfo master: [neutron] Unpin neutron-lib Wallaby https://review.rdoproject.org/r/c/rdoinfo/+/49091 | 12:28 |
rdogerrit | Joel Capitao proposed openstack/sphinx-feature-classification-distgit rpm-master: Switch to pyproject-rpm-macros https://review.rdoproject.org/r/c/openstack/sphinx-feature-classification-distgit/+/48975 | 12:41 |
rdogerrit | Merged rdo-jobs master: Add rpmlint filters for microversion-parse https://review.rdoproject.org/r/c/rdo-jobs/+/49093 | 12:42 |
rdogerrit | Joel Capitao proposed openstack/ovsdbapp-distgit rpm-master: Switch to pyproject-rpm-macros https://review.rdoproject.org/r/c/openstack/ovsdbapp-distgit/+/49035 | 12:48 |
rdogerrit | Joel Capitao proposed rdo-jobs master: Use diff instead of sdiff https://review.rdoproject.org/r/c/rdo-jobs/+/49096 | 12:57 |
*** amoralej|lunch is now known as amoralej | 13:13 | |
rdogerrit | Joel Capitao proposed openstack/wsme-distgit rpm-master: Switch to pyproject-rpm-macros https://review.rdoproject.org/r/c/openstack/wsme-distgit/+/49021 | 13:15 |
rdogerrit | Joel Capitao proposed rdo-jobs master: Remove extra EOL https://review.rdoproject.org/r/c/rdo-jobs/+/49097 | 13:18 |
jcapitao[m] | karolinku: ^ I merged it too fast :/ | 13:19 |
amoralej | jcapitao[m], i just replied | 13:19 |
jcapitao[m] | mmmh really ? | 13:20 |
jcapitao[m] | we hit the issue in Karolina's patch | 13:20 |
amoralej | it shouldn't | 13:21 |
amoralej | where? | 13:21 |
jcapitao[m] | lemme find it | 13:21 |
jcapitao[m] | karolinku: do you remember the patch ? ^ | 13:21 |
amoralej | what was the issue ? | 13:21 |
jcapitao[m] | with repo_bootstrap | 13:21 |
amoralej | it complaint about undeclared ? | 13:21 |
jcapitao[m] | yep | 13:21 |
amoralej | mmm | 13:21 |
* jcapitao[m] looking for the patch | 13:23 | |
amoralej | keystoneauth1 | 13:23 |
amoralej | no, that's different issue | 13:23 |
amoralej | i guess | 13:23 |
jcapitao[m] | amoralej: https://review.rdoproject.org/r/c/openstack/mistral-extra-distgit/+/49049 | 13:24 |
jcapitao[m] | https://review.rdoproject.org/r/c/openstack/mistral-extra-distgit/+/49049/5..6/python-mistral-extra.spec | 13:24 |
jcapitao[m] | between PS5 and PS6 | 13:24 |
jcapitao[m] | parse error in expression: 0%{rhosp} == 0 | 13:25 |
jcapitao[m] | error: /builddir/build/SPECS/python-mistral-extra.spec:8: bad %if condition: 0%{rhosp} == 0 | 13:25 |
jcapitao[m] | https://logserver.rdoproject.org/49/49049/5/check/DLRN-rpmbuild-centos9/67d427b/job-output.txt | 13:25 |
amoralej | lemme do a test | 13:26 |
amoralej | note that dlrn is not touching with_doc | 13:26 |
amoralej | that is missing ? in %{?rhosp} | 13:27 |
jcapitao[m] | damn | 13:28 |
amoralej | adding ? would have fixed it | 13:28 |
jcapitao[m] | my assumption was false | 13:28 |
amoralej | but anyway, ordering it also fixed it | 13:28 |
amoralej | actually i thought ? was not needed for that behavior | 13:29 |
amoralej | but you can check with rpmspec -P the behaviour is correct | 13:29 |
amoralej | i mean it takes the real value even if it's defined after the condition | 13:29 |
amoralej | when using ?, so not asuming default value | 13:29 |
jcapitao[m] | thank you for the clarification | 13:30 |
jcapitao[m] | that's interesting | 13:30 |
jcapitao[m] | amoralej: https://review.rdoproject.org/r/c/rdo-jobs/+/49097 | 13:31 |
jcapitao[m] | could you review it to fix CI ^ ? | 13:31 |
amoralej | the behavior is tricky | 13:34 |
jcapitao[m] | I should use that rpmspec -P more often | 13:37 |
amoralej | it's very useful | 13:37 |
amoralej | so, if you 1. define a, 2. if 0%{?a} 3. redefine a | 13:38 |
amoralej | then it uses the value defined in a | 13:38 |
amoralej | i mean, in 2 | 13:38 |
amoralej | but if you don't define in a but only | 13:38 |
amoralej | 1. if 0%{?a} 2. redefine a | 13:39 |
amoralej | then it takes the value defined in 2 | 13:39 |
amoralej | not the default value of 0 | 13:39 |
amoralej | but if you use if %{a}, it complains | 13:39 |
amoralej | even if you define later | 13:40 |
amoralej | it's not intuitive | 13:40 |
rdogerrit | Merged rdo-jobs master: Remove extra EOL https://review.rdoproject.org/r/c/rdo-jobs/+/49097 | 13:42 |
jcapitao[m] | I just tested what you said | 13:42 |
jcapitao[m] | indeed | 13:42 |
jcapitao[m] | that's weird | 13:43 |
amoralej | i would expect it only complains if the macro is undefined as it uses the value if it's later but... who knows | 13:44 |
jcapitao[m] | so I left a comment in mistral-extra patch to reuse the "?" | 13:46 |
rdogerrit | Joel Capitao proposed rdo-jobs master: Use diff instead of sdiff https://review.rdoproject.org/r/c/rdo-jobs/+/49096 | 13:58 |
jcapitao[m] | amoralej: I replied in https://review.rdoproject.org/r/c/rdo-jobs/+/49096 | 13:58 |
amoralej | right! i should have checked man page before, sorry | 14:00 |
jcapitao[m] | no worries :) | 14:00 |
jcapitao[m] | I reviewed all passing review btw | 14:01 |
jcapitao[m] | I put on hold https://review.rdoproject.org/r/c/openstack/oslo-serialization-distgit/+/49075 | 14:02 |
jcapitao[m] | waiting for the upstream patch to be merged | 14:02 |
rdogerrit | Joel Capitao proposed openstack/tooz-distgit rpm-master: Switch to pyproject-rpm-macros https://review.rdoproject.org/r/c/openstack/tooz-distgit/+/49018 | 14:11 |
*** blarnath is now known as d34dh0r53 | 14:13 | |
karolinku[m] | sorry for the EOF! | 14:14 |
jcapitao[m] | it's my bad too, I merged to fast | 14:16 |
rdogerrit | Merged rdo-jobs master: Use diff instead of sdiff https://review.rdoproject.org/r/c/rdo-jobs/+/49096 | 14:18 |
rdogerrit | Joel Capitao proposed openstack/tooz-distgit rpm-master: Switch to pyproject-rpm-macros https://review.rdoproject.org/r/c/openstack/tooz-distgit/+/49018 | 14:24 |
rdogerrit | Joel Capitao proposed openstack/tooz-distgit rpm-master: Switch to pyproject-rpm-macros https://review.rdoproject.org/r/c/openstack/tooz-distgit/+/49018 | 14:48 |
rdogerrit | Joel Capitao proposed openstack/tooz-distgit rpm-master: Switch to pyproject-rpm-macros https://review.rdoproject.org/r/c/openstack/tooz-distgit/+/49018 | 15:06 |
rdogerrit | Joel Capitao proposed rdo-jobs master: Use dnf repoquery for compare-deps job https://review.rdoproject.org/r/c/rdo-jobs/+/49098 | 15:37 |
rdogerrit | Joel Capitao proposed openstack/tooz-distgit rpm-master: Switch to pyproject-rpm-macros https://review.rdoproject.org/r/c/openstack/tooz-distgit/+/49018 | 15:38 |
*** amoralej is now known as amoralej|off | 16:09 | |
rdogerrit | Karolina Kula proposed rdo-infra/releng master: Add with_doc condition https://review.rdoproject.org/r/c/rdo-infra/releng/+/49099 | 16:20 |
rdogerrit | Karolina Kula proposed rdo-infra/releng master: Add with_doc condition https://review.rdoproject.org/r/c/rdo-infra/releng/+/49099 | 16:21 |
rdogerrit | Joel Capitao proposed rdo-jobs master: Use dnf repoquery for compare-deps job https://review.rdoproject.org/r/c/rdo-jobs/+/49098 | 16:22 |
rdogerrit | Joel Capitao proposed rdo-jobs master: Handle extras subpkg in compare jobs https://review.rdoproject.org/r/c/rdo-jobs/+/49098 | 16:46 |
*** dtantsur_ is now known as dtantsur | 23:50 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!