| *** finnekit7 is now known as finnekit | 07:44 | |
| d1nuc0m | Hi all, a quick question about puppet-manila: should it be possible to include at the same time manila::share and manila::share::generic or are they mutually exclusive? Including them both gives a double declaration of DEFAULT backend | 08:33 |
|---|---|---|
| tkajinam | d1nuc0m, hmmm I wasn't aware of that duplicate. However I wonder why you use manila::share::generic instead of manila::backend::generic . | 09:13 |
| d1nuc0m | tkajinam, like using a manila::backend::generic resource to configure the DEFAULT backend? | 09:15 |
| tkajinam | it does not configure default backend. You maybe able to configure some options commonly loaded by multiple generic backends, but I don't know how much it would be better than setting the same options in each backend | 09:17 |
| tkajinam | another problem with manila::share::<generic> is that some of the options conflict between them so you can't use ::generic and ::netapp at the same time even though you have both backend in you setup | 09:17 |
| tkajinam | probably the right way is to deprecate all manila::share;:* and solely use manila::backend::* | 09:18 |
| d1nuc0m | tkajinam I am using manila::share to configure share options in manila.conf, then I'd like to set driver_handles_share_servers for the generic share driver | 09:23 |
| tkajinam | d1nuc0m, if you want generic share driver then you can use manila::backend::generic defined resource type | 09:23 |
| tkajinam | instead of manila::share::generic class | 09:23 |
| tkajinam | oh, wait | 09:24 |
| tkajinam | so the manila::backend::generic defined resource type has driver_handles_share_servers parameter | 09:25 |
| tkajinam | https://github.com/openstack/puppet-openstack-integration/blob/master/manifests/manila.pp#L113-L136 | 09:25 |
| tkajinam | this is how I expect you configure share backends | 09:25 |
| tkajinam | d1nuc0m, https://opendev.org/x/packstack/src/branch/master/packstack/puppet/modules/packstack/manifests/manila/backend/generic.pp#L5-L9 | 09:32 |
| opendevreview | Takashi Kajinami proposed openstack/puppet-manila master: Deprecate support for backend options in [DEFAULT] section https://review.opendev.org/c/openstack/puppet-manila/+/932594 | 09:33 |
| d1nuc0m | Ok, thanks, so I should *not* configure backends in the DEFAULT section at all | 09:33 |
| d1nuc0m | tkajinam ? | 09:33 |
| tkajinam | yes | 09:33 |
| tkajinam | you are correct | 09:33 |
| tkajinam | yes/no in English is sometimes quite confusing for non-native | 09:34 |
| d1nuc0m | Thanks tkajinam | 09:34 |
| tkajinam | d1nuc0m, by the way I think we discussed some problems with oidc configuration in puppet-keystone some time ago, right ? | 09:35 |
| d1nuc0m | Yes, you're right | 09:35 |
| d1nuc0m | I was slowly adding some parameter such as in https://review.opendev.org/c/openstack/puppet-keystone/+/923194, then I got engaged also in other internal projects | 09:36 |
| tkajinam | d1nuc0m, I guess I finally understood the problem you described from the change proposed in keystone | 09:36 |
| tkajinam | https://review.opendev.org/c/openstack/keystone/+/925553 | 09:36 |
| tkajinam | I updated master and 2024.1 according to that change, hope it does not kill you. https://review.opendev.org/c/openstack/puppet-keystone/+/928755 | 09:37 |
| tkajinam | jusy fyi | 09:37 |
| d1nuc0m | Thanks a lot! It does not cause problems, instead it allows me to remove a workaround I used (file_line at setup end) to have a proper URL, I have to implement it | 09:38 |
| tkajinam | :-) | 09:38 |
| tkajinam | I guess the updated configuration is what you wanted to have (and implemented by hacks) | 09:39 |
| tkajinam | in case you get chance to try updated version then please check it :-) | 09:40 |
| d1nuc0m | tkajinam, Yes, I'll check it ASAP (RN the testbed is down due to hypervisor maintenance and I don't want to directly edit production XD) | 09:44 |
| tkajinam | d1nuc0m, thanks and take your time | 09:51 |
| opendevreview | Takashi Kajinami proposed openstack/puppet-manila master: generic: Drop redundant hard-coded defaults https://review.opendev.org/c/openstack/puppet-manila/+/932602 | 11:42 |
| opendevreview | Takashi Kajinami proposed openstack/puppet-manila master: Deprecate support for backend options in [DEFAULT] section https://review.opendev.org/c/openstack/puppet-manila/+/932594 | 12:38 |
| opendevreview | Takashi Kajinami proposed openstack/puppet-manila master: generic: Drop redundant hard-coded defaults https://review.opendev.org/c/openstack/puppet-manila/+/932602 | 12:43 |
| *** iurygregory_ is now known as iurygregory | 12:57 | |
| opendevreview | Takashi Kajinami proposed openstack/puppet-manila master: generic: Drop redundant hard-coded defaults https://review.opendev.org/c/openstack/puppet-manila/+/932602 | 14:30 |
| opendevreview | Takashi Kajinami proposed openstack/puppet-manila master: generic: Drop redundant hard-coded defaults https://review.opendev.org/c/openstack/puppet-manila/+/932602 | 14:56 |
| opendevreview | Takashi Kajinami proposed openstack/puppet-manila master: generic: Drop redundant hard-coded defaults https://review.opendev.org/c/openstack/puppet-manila/+/932602 | 15:07 |
| opendevreview | Takashi Kajinami proposed openstack/puppet-manila master: generic: Drop redundant hard-coded defaults https://review.opendev.org/c/openstack/puppet-manila/+/932602 | 21:41 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!