| opendevreview | Francesco Di Nucci proposed openstack/puppet-keystone master: feat: add openidc_metadata_dir to federation::oidc https://review.opendev.org/c/openstack/puppet-keystone/+/923135 | 06:29 |
|---|---|---|
| opendevreview | Francesco Di Nucci proposed openstack/puppet-keystone master: feat: add param for additional OIDC locations https://review.opendev.org/c/openstack/puppet-keystone/+/923194 | 07:30 |
| d1nuc0m | tkajinam, sorry to bother, when possible could you have a look to tests for https://review.opendev.org/c/openstack/puppet-keystone/+/923135? I used the existing ones as example, but pipeline fails stating that the value of the error message can't be converted to numeric | 08:58 |
| opendevreview | Francesco Di Nucci proposed openstack/puppet-keystone master: feat: add param for additional OIDC locations https://review.opendev.org/c/openstack/puppet-keystone/+/923194 | 09:03 |
| opendevreview | Takashi Kajinami proposed openstack/puppet-keystone master: Fix invalid error message handling https://review.opendev.org/c/openstack/puppet-keystone/+/923238 | 13:23 |
| opendevreview | Takashi Kajinami proposed openstack/puppet-keystone master: Fix invalid string concatenation https://review.opendev.org/c/openstack/puppet-keystone/+/923238 | 13:24 |
| tkajinam | d1nuc0m, ^^^ | 13:24 |
| tkajinam | idk why it hasn't been caught ... ugh | 13:24 |
| opendevreview | Takashi Kajinami proposed openstack/puppet-keystone master: feat: add openidc_metadata_dir to federation::oidc https://review.opendev.org/c/openstack/puppet-keystone/+/923135 | 13:32 |
| d1nuc0m | tkajinam, so how does it work now? Anyway I guess I'll wait for your patch merge and rebase (?) | 13:43 |
| d1nuc0m | And thanks a lot :) | 13:43 |
| opendevreview | Takashi Kajinami proposed openstack/puppet-keystone master: feat: add openidc_metadata_dir to federation::oidc https://review.opendev.org/c/openstack/puppet-keystone/+/923135 | 13:58 |
| tkajinam | d1nuc0m, it may fail with ugly puppet errors instead of the expected messages. | 13:59 |
| tkajinam | I already rebased your patch on mine (these are now in the same chain) so you don't have to care about rebase. | 14:00 |
| d1nuc0m | tkajinam, thanks, I owe you a drink | 14:18 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!