| opendevreview | Takashi Kajinami proposed openstack/puppet-swift master: Support for barbican_endpoint in kms_keymaster https://review.opendev.org/c/openstack/puppet-swift/+/921932 | 03:26 |
|---|---|---|
| zigo | tkajinam: Hi there! Was there something wrong when my puppet-swift patch was uploaded ? Looked like a gerrit bug to me or something... | 10:05 |
| tkajinam | zigo, The patch set 5 you uploaded had one failing unit test so I uploaded patch set 6 with that fixed | 10:14 |
| tkajinam | I'm not aware of any other problems | 10:15 |
| zigo | Ok, thanks a lot. | 10:25 |
| zigo | Oh I see. with_ensure('absent') -> with_value('<SERVICE DEFAULT>') | 10:27 |
| zigo | Next time I'll know. | 10:27 |
| opendevreview | Mauricio Harley proposed openstack/puppet-keystone master: Add memcache_expire_time to the configuration https://review.opendev.org/c/openstack/puppet-keystone/+/922084 | 10:36 |
| tobias-urdin | d1nuc0m: sorry for late reply, here is the response from infra on that question | 13:12 |
| tobias-urdin | 15:09:21 <tobias-urdin> what handles the url for the "issues" button on a project in gitea? https://opendev.org/openstack/puppet-openstacklib the issues url is wrong (not pointing to the launchpad issue) while puppet-nova is pointing correct | 13:12 |
| tobias-urdin | 15:10:18 <fungi> tobias-urdin: in openstack/project-config the gerrit/projects.yaml file determines that | 13:12 |
| tobias-urdin | 15:11:12 <fungi> if it has "groups: puppet-openstack" then that's overriding the issues link to go to the puppet-openstack project in launchpad | 13:12 |
| tobias-urdin | 15:11:32 <fungi> if groups is not specified, it assumes the project name on lp is the same as the repo name | 13:12 |
| tobias-urdin | 15:11:59 <tobias-urdin> fungi: ack, thanks – that makes sense why some is specific and some others is not | 13:12 |
| fungi | yep, propose a change to adjust whatever you need in that file | 13:13 |
| d1nuc0m | tobias-urdin, I guess this (https://opendev.org/openstack/project-config/src/branch/master/gerrit/projects.yaml#L5090) is the file, removing groups does not have any unintended side effects? | 13:16 |
| tobias-urdin | d1nuc0m: yes as i think it removes us from the project, i don't think they have any way to override it for custom groups like that, if you want to check you can ask in #openstack-infra | 13:17 |
| fungi | unless the project is relying on storyboard, the only things groups does is override the project name when referring to or updating bugs in launchpad | 13:18 |
| fungi | if storyboard is in use, groups indicates what project groups that project should be included in | 13:19 |
| fungi | but in this case it's just saying what project name to use on launchpad rather than having it be the same as the repository name | 13:19 |
| d1nuc0m | Ok thanks, tkajinam puppet-openstacklib is not using storyboard, am I right? | 13:20 |
| fungi | if the entry doesn't have "use-storyboard: true" then it's not | 13:20 |
| fungi | you'll see other repos in projects.yaml with use-storyboard set (defaults to false if not specified) | 13:21 |
| d1nuc0m | fungi, thanks | 13:21 |
| tobias-urdin | cool, then we can probably clean all that up to get correct urls for multiple puppet-openstack owned projects | 13:22 |
| d1nuc0m | tobias-urdin, fungi is this ok? https://review.opendev.org/c/openstack/project-config/+/922105 | 13:27 |
| tkajinam | d1nuc0m, https://review.opendev.org/c/openstack/project-config/+/922107 covers a few other projects, too | 13:30 |
| d1nuc0m | tkajinam, thanks | 13:31 |
| tkajinam | idk why we haven't caught these earlier. I'm sure we have maintained puppet-openstacklib bugs for some time but haven't noticed any unmaintained bugs there | 13:31 |
| tkajinam | but anyway we can fix these now | 13:31 |
| fungi | looking | 13:47 |
| fungi | tkajinam: did you confirm all those projects actually exist on lp? assuming so, but wanted to make sure | 13:48 |
| tkajinam | fungi, yes but we might need some treatment for puppet-openstack-extras | 14:09 |
| tkajinam | lp project name is https://bugs.launchpad.net/puppet-openstack-extras while the repository name is puppet-openstack_extras | 14:09 |
| fungi | tkajinam: yeah, you probably need to "groups: puppet-openstack-extras" on that one | 14:16 |
| tkajinam | fungi, ok. I restored the group override for extras with the group name adjusted | 14:41 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!