Tuesday, 2021-12-14

opendevreviewzhongshengping proposed openstack/puppet-zaqar master: Prepare Yoga M2  https://review.opendev.org/c/openstack/puppet-zaqar/+/81997703:17
opendevreviewzhongshengping proposed openstack/puppet-placement master: Prepare Yoga M2  https://review.opendev.org/c/openstack/puppet-placement/+/81996803:19
opendevreviewzhongshengping proposed openstack/puppet-manila master: Prepare Yoga M2  https://review.opendev.org/c/openstack/puppet-manila/+/81998003:20
opendevreviewzhongshengping proposed openstack/puppet-cinder master: Prepare Yoga M2  https://review.opendev.org/c/openstack/puppet-cinder/+/81997003:21
opendevreviewRocky proposed openstack/puppet-swift master: Add rsync parameters for object server  https://review.opendev.org/c/openstack/puppet-swift/+/82164604:38
*** ysandeep|out is now known as ysandeep05:27
*** ysandeep is now known as ysandeep|lunch07:26
*** amoralej|off is now known as amoralej08:15
*** ysandeep|lunch is now known as ysandeep08:41
opendevreviewMerged openstack/puppet-glance master: Fix wrong class used in unit tests  https://review.opendev.org/c/openstack/puppet-glance/+/82162908:44
*** ysandeep is now known as ysandeep|afk09:35
opendevreviewMerged openstack/puppet-openstack_extras master: auth_file: Deprecate tenant_name parameter  https://review.opendev.org/c/openstack/puppet-openstack_extras/+/82155410:02
opendevreviewMerged openstack/puppet-openstack_extras master: auth_file: Clean up deprecated *_domain parameters  https://review.opendev.org/c/openstack/puppet-openstack_extras/+/82155610:10
opendevreviewMerged openstack/puppet-sahara master: Add support for more parameters about periodic tasks  https://review.opendev.org/c/openstack/puppet-sahara/+/82149310:24
opendevreviewMerged openstack/puppet-sahara master: Support tunable parameters for coordination  https://review.opendev.org/c/openstack/puppet-sahara/+/82149410:24
*** ysandeep|afk is now known as ysandeep10:32
*** jpena|off is now known as jpena11:42
*** ysandeep is now known as ysandeep|brb12:21
opendevreviewTakashi Kajinami proposed openstack/puppet-horizon master: Update description of OPENSTACK_API_VERSIONS  https://review.opendev.org/c/openstack/puppet-horizon/+/82170112:42
*** ysandeep|brb is now known as ysandeep12:48
opendevreviewTakashi Kajinami proposed openstack/puppet-horizon master: Describe default of OPENSTACK_HYPERVISOR_FEATURES['enable_quotas']  https://review.opendev.org/c/openstack/puppet-horizon/+/82170212:49
amoralejtkajinam, https://github.com/openstack/puppet-placement/commit/53594681fa0251170367ec153170843489e274fa is the new problem for packstack, that change the defaults13:10
amoraleji'll squash the fix with your patch for rabbitmq deps13:10
amoralejok?13:10
*** amoralej is now known as amoralej|lunch13:16
tkajinamamoralej|lunch, yes13:44
tkajinamno problem13:45
*** amoralej|lunch is now known as amoralej14:04
amoralejtkajinam, nova-compute is tagged as nova-service, so it fails as the compute node is executed in a different puppet run14:08
tkajinamyeah14:08
amoralejis there a way to establish that ordering rule but only if both classes are defined?14:08
amoralejor we may use Service[whatever]14:08
tkajinamthat's why I initially used weak ref using Class... and mentioned it would break multinode deployment14:08
amoralejsimilar with ceilometer-polling14:10
amoralejClass[Rabbitmq]' for relationship on 'Service[ceilometer-polling]' 14:10
amoralejhttps://15ad68a81e62a995aef4-43aabb4aae4dce483640460c00b42163.ssl.cf5.rackcdn.com/821594/5/check/packstack-centos8s-integration-scenario003/c7e992b/logs/latest/manifests/149.202.191.90_compute.pp.log.txt14:10
*** ysandeep is now known as ysandeep|out14:13
tkajinamlet me check which resource I can use14:13
tkajinamI initially though of using Service<| name == 'rabbitmq' |> but I need to find the exact resource which manage rabbitmq users14:14
amoralejtkajinam, https://github.com/redhat-openstack/packstack/blob/master/packstack/puppet/modules/packstack/manifests/amqp/enable_rabbitmq.pp14:16
amoralejthat's what starts rabbit in this case14:16
amoraleji'm not sure we create separated users in rabbit, tbh14:16
amoralejlemme check14:16
amoralejnote we have Service['rabbitmq-server'] in deps there14:17
tkajinamhttps://github.com/voxpupuli/puppet-rabbitmq/blob/master/manifests/install/rabbitmqadmin.pp#L48-L5714:17
tkajinamhmm. it might not this one14:18
tkajinamoh, ok. so seems Service resource should be enough14:19
amoralejtkajinam, https://github.com/redhat-openstack/packstack/blob/master/packstack/puppet/modules/packstack/manifests/amqp/enable_rabbitmq.pp#L32-L3314:20
amoralejso, we are creating the user from rabbitmq class14:20
* tkajinam is updating the patch14:20
amoralejso, the plan is to use weak deps with Service ?14:21
amoralejtkajinam, update your local copy of the patch to get the placement fix14:21
tkajinamamoralej, yeah I pulled the latest change14:29
tkajinamamoralej, just submitted the updated version14:29
tkajinamuser name/password is written in config file so the rabbitmq user should be available when rabbitmq is started14:30
tkajinamso requiring rabbitmq-server service should be enough14:30
tkajinamService<| name == 'rabbitmq-server' |>  is ignored if there is not service resource with name => 'rabbitmq-server' so is supposed to work in compute nodes as well14:31
amoralejtkajinam, at least jobs are passing puppet apply steps, so looks promising15:14
amoralejtkajinam++15:14
tkajinamamoralej, that's nice :-)15:14
opendevreviewMerged openstack/puppet-heat master: Use native support to define RequestHeader statement  https://review.opendev.org/c/openstack/puppet-heat/+/82109115:25
opendevreviewMerged openstack/puppet-heat master: Clean up direct dependencies on puppetlabs-apache  https://review.opendev.org/c/openstack/puppet-heat/+/82109215:25
amoralejtkajinam, all jobs passed! :)15:43
tkajinamamoralej, great!15:44
tkajinamI'll make sure I check packstack as well when merging breaking change. I did it in the past after I broke something but recently I didn't pay much attention to it...15:46
tkajinam(though I don't know what was the exact trigger of that dependency issue15:47
opendevreviewMerged openstack/puppet-neutron stable/xena: Change authentication method for Mellanox sdn controller  https://review.opendev.org/c/openstack/puppet-neutron/+/81831916:26
amoralejtkajinam, we run jobs periodically with packstack, that's where we usually find this type of issues16:27
amoralejsaid this, good to check proactively for cases where we think we may have issues16:27
*** amoralej is now known as amoralej|off17:26
*** jpena is now known as jpena|off17:37
opendevreviewMerged openstack/puppet-cinder master: Deprecate service validation for cinder-api  https://review.opendev.org/c/openstack/puppet-cinder/+/82157418:29
opendevreviewMerged openstack/puppet-glance master: Deprecate service validation for glance-api  https://review.opendev.org/c/openstack/puppet-glance/+/82157818:46
opendevreviewMerged openstack/puppet-watcher master: Deprecate service validation for watcher-api  https://review.opendev.org/c/openstack/puppet-watcher/+/82157918:53
opendevreviewMerged openstack/puppet-ironic master: Add support for [conductor] bootloader  https://review.opendev.org/c/openstack/puppet-ironic/+/82136418:56
opendevreviewMerged openstack/puppet-keystone master: Enable credential setup by default  https://review.opendev.org/c/openstack/puppet-keystone/+/82156719:28
opendevreviewMerged openstack/puppet-openstack-integration master: Neutron: Avoid usage of built-in service validation  https://review.opendev.org/c/openstack/puppet-openstack-integration/+/82158519:28
opendevreviewMerged openstack/puppet-openstack-integration master: Aodh: Replace deprecated aodh::auth by aodh::service_credentials  https://review.opendev.org/c/openstack/puppet-openstack-integration/+/77325619:28
opendevreviewMerged openstack/puppet-keystone master: Deprecate support for member_role_id/name  https://review.opendev.org/c/openstack/puppet-keystone/+/82156919:36
opendevreviewMerged openstack/puppet-keystone master: Deprecate unused admin_endpoint  https://review.opendev.org/c/openstack/puppet-keystone/+/82157019:42
opendevreviewMerged openstack/puppet-nova master: Deprecate service validation for nova-api  https://review.opendev.org/c/openstack/puppet-nova/+/82157719:55

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!