| openstackgerrit | Rocky proposed openstack/puppet-manila master: Add LVM backend https://review.opendev.org/c/openstack/puppet-manila/+/783821 | 00:34 |
|---|---|---|
| *** iurygregory has quit IRC | 01:16 | |
| *** iurygregory has joined #puppet-openstack | 01:17 | |
| *** iurygregory has quit IRC | 01:18 | |
| *** iurygregory has joined #puppet-openstack | 01:18 | |
| openstackgerrit | Merged openstack/puppet-openstack-integration stable/train: [Ussuri and before] Bump puppet-memcached for tls support https://review.opendev.org/c/openstack/puppet-openstack-integration/+/783801 | 01:32 |
| openstackgerrit | Merged openstack/puppet-swift master: Drop the tripleo-puppet-undercloud job https://review.opendev.org/c/openstack/puppet-swift/+/783190 | 02:08 |
| *** iurygregory has quit IRC | 02:08 | |
| *** iurygregory has joined #puppet-openstack | 02:09 | |
| openstackgerrit | Merged openstack/puppet-oslo master: metadata.json: debian 11 https://review.opendev.org/c/openstack/puppet-oslo/+/783098 | 02:25 |
| openstackgerrit | Takashi Kajinami proposed openstack/puppet-ovn stable/victoria: Set external_ids:ovn-chassis-mac-mappings https://review.opendev.org/c/openstack/puppet-ovn/+/782759 | 02:29 |
| openstackgerrit | Takashi Kajinami proposed openstack/puppet-ovn stable/victoria: Set external_ids:ovn-chassis-mac-mappings https://review.opendev.org/c/openstack/puppet-ovn/+/782759 | 02:30 |
| *** rcernin has quit IRC | 02:31 | |
| openstackgerrit | Takashi Kajinami proposed openstack/puppet-ovn stable/victoria: Set external_ids:ovn-chassis-mac-mappings https://review.opendev.org/c/openstack/puppet-ovn/+/782759 | 02:32 |
| openstackgerrit | Takashi Kajinami proposed openstack/puppet-ovn stable/ussuri: Set external_ids:ovn-chassis-mac-mappings https://review.opendev.org/c/openstack/puppet-ovn/+/782763 | 02:35 |
| *** rcernin has joined #puppet-openstack | 02:38 | |
| openstackgerrit | Takashi Kajinami proposed openstack/puppet-ovn stable/train: Set external_ids:ovn-chassis-mac-mappings https://review.opendev.org/c/openstack/puppet-ovn/+/782765 | 02:38 |
| *** rcernin has quit IRC | 03:07 | |
| *** rcernin has joined #puppet-openstack | 03:07 | |
| *** rcernin has quit IRC | 03:07 | |
| *** rcernin has joined #puppet-openstack | 03:09 | |
| *** rcernin has quit IRC | 03:11 | |
| *** rcernin has joined #puppet-openstack | 03:12 | |
| *** rcernin has quit IRC | 03:14 | |
| *** rcernin has joined #puppet-openstack | 03:14 | |
| *** rcernin has quit IRC | 03:16 | |
| *** rcernin has joined #puppet-openstack | 03:16 | |
| *** rcernin has quit IRC | 03:18 | |
| *** rcernin has joined #puppet-openstack | 03:19 | |
| *** ykarel|away has joined #puppet-openstack | 04:20 | |
| *** ykarel|away is now known as ykarel | 04:39 | |
| openstackgerrit | Takashi Kajinami proposed openstack/puppet-oslo stable/ussuri: DNM: Testing gate https://review.opendev.org/c/openstack/puppet-oslo/+/783996 | 04:46 |
| openstackgerrit | Takashi Kajinami proposed openstack/puppet-vswitch stable/ussuri: WIP: Add missing puppet-openstacklib to dependencies https://review.opendev.org/c/openstack/puppet-vswitch/+/783999 | 04:57 |
| *** ysandeep|away is now known as ysandeep | 05:59 | |
| *** gfidente|afk is now known as gfidente | 06:21 | |
| openstackgerrit | Merged openstack/puppet-openstack_extras master: metadata.json: debian 11 https://review.opendev.org/c/openstack/puppet-openstack_extras/+/783104 | 07:00 |
| openstackgerrit | Merged openstack/puppet-cinder master: metadata.json: debian 11 https://review.opendev.org/c/openstack/puppet-cinder/+/782976 | 07:04 |
| openstackgerrit | Merged openstack/puppet-ceilometer master: metadata.json: debian 11 https://review.opendev.org/c/openstack/puppet-ceilometer/+/782955 | 07:04 |
| tkajinam | tobias-urdin, do you have any idea about the reason unit tests with puppet 5 fails on this patch ? https://review.opendev.org/c/openstack/puppet-vswitch/+/783858 | 07:24 |
| tkajinam | seems like the is_service_default function is not properly detected | 07:25 |
| *** rcernin has quit IRC | 07:25 | |
| tkajinam | but I don't see that issue with puppet 6 tests. and I don't see the same issue, either in puppet-oslo ussuri which is using the same function... https://review.opendev.org/c/openstack/puppet-oslo/+/783996 | 07:25 |
| openstackgerrit | Merged openstack/puppet-nova stable/ussuri: Revert "Remove parameter nova::compute::pci_passthrough" https://review.opendev.org/c/openstack/puppet-nova/+/772659 | 07:28 |
| tobias-urdin | tkajinam: iirc there was a breakage in puppet 5 regarding the new puppet functions API | 07:31 |
| tobias-urdin | but it seems stable/ussuri openstacklib already has those fixes so can't be that | 07:31 |
| tobias-urdin | unless they broke something again | 07:31 |
| tobias-urdin | so no real good idea | 07:31 |
| tkajinam | yeah | 07:31 |
| tkajinam | I'll have another look later... it's very strange that some other modules using is_service_default are passing ussuri job... | 07:33 |
| tobias-urdin | tkajinam: try adding openstacklib to metadata.json | 07:33 |
| tobias-urdin | see if they broke that | 07:33 |
| *** tosky has joined #puppet-openstack | 07:33 | |
| tobias-urdin | same puppet version for those jobs? | 07:34 |
| tkajinam | tobias-urdin, ahh, ok https://review.opendev.org/c/openstack/puppet-vswitch/+/783999 | 07:34 |
| tkajinam | seems like it solved the problem https://review.opendev.org/c/openstack/puppet-vswitch/+/783858/2 | 07:34 |
| tkajinam | I see that puppet-openstacklib is included by puppet-vswitch... I think we should add that dependency | 07:35 |
| tkajinam | https://github.com/openstack/puppet-vswitch/blob/stable/ussuri/manifests/params.pp#L4 | 07:35 |
| tkajinam | https://github.com/openstack/puppet-vswitch/blob/stable/train/manifests/params.pp | 07:35 |
| openstackgerrit | Tobias Urdin proposed openstack/puppet-vswitch stable/ussuri: WIP: Add missing puppet-openstacklib to dependencies https://review.opendev.org/c/openstack/puppet-vswitch/+/783999 | 07:36 |
| tobias-urdin | that would be a nasty introduced bug though by puppet | 07:36 |
| tobias-urdin | since that behavior was introduced in puppet 6 | 07:36 |
| tkajinam | yeah | 07:36 |
| tkajinam | oh, wait. ignore that | 07:37 |
| tkajinam | we need another patch to trigger unit tests :-( | 07:37 |
| openstackgerrit | Takashi Kajinami proposed openstack/puppet-vswitch stable/ussuri: WIP: Add missing puppet-openstacklib to dependencies https://review.opendev.org/c/openstack/puppet-vswitch/+/783999 | 07:38 |
| *** ysandeep is now known as ysandeep|lunch | 07:47 | |
| *** ykarel has quit IRC | 08:01 | |
| *** dpawlik0 is now known as dpawlik | 08:08 | |
| *** derekh has joined #puppet-openstack | 08:30 | |
| openstackgerrit | Takashi Kajinami proposed openstack/puppet-vswitch master: Add missing openstacklib to dependencies https://review.opendev.org/c/openstack/puppet-vswitch/+/784027 | 08:33 |
| openstackgerrit | Merged openstack/puppet-zaqar master: Drop the tripleo-puppet-undercloud job https://review.opendev.org/c/openstack/puppet-zaqar/+/783188 | 08:38 |
| *** ykarel has joined #puppet-openstack | 08:43 | |
| *** ykarel is now known as ykarel|lunch | 08:43 | |
| openstackgerrit | Takashi Kajinami proposed openstack/puppet-vswitch master: Add missing openstacklib to dependencies https://review.opendev.org/c/openstack/puppet-vswitch/+/784027 | 08:53 |
| *** ysandeep|lunch is now known as ysandeep | 09:07 | |
| *** derekh has quit IRC | 09:21 | |
| *** derekh has joined #puppet-openstack | 09:21 | |
| openstackgerrit | Thomas Goirand proposed openstack/puppet-keystone master: Add support for keystone_uwsgi_config in Debian https://review.opendev.org/c/openstack/puppet-keystone/+/780918 | 09:24 |
| zigo | tkajinam: About https://review.opendev.org/c/openstack/puppet-keystone/+/782274, would that work if I get a variable in params.pp for the default policy_dirs location, with something that would depend on the OS ? | 09:28 |
| zigo | What would be the location for CentOS then? | 09:29 |
| zigo | My issue with the way policy_dirs is handled currently, is that whatever I am doing, puppet-openstack simply removes the policy_dirs directive, and I end up with having no policy file configured at all, which is very annoying. | 09:30 |
| zigo | We can end-up with different defaults depending on the OS, so that it matches the pacakging, I very much agree with that, though at the same time, it's urgent to do something because we're moving away from the .json policy files. | 09:31 |
| tkajinam | zigo, do we really need to put the explicit value ? | 09:31 |
| tkajinam | zigo, https://github.com/openstack/oslo.policy/blob/master/oslo_policy/opts.py#L61 | 09:31 |
| tkajinam | if I'm not mistake it is supposed to include /etc/<service name>/policy.d by default | 09:32 |
| zigo | Oh ok. Well I felt weird that the policy_dirs was being removed by default for me ... | 09:32 |
| zigo | IMO that shouldn't be the default puppet-openstack behavior. | 09:33 |
| zigo | Also, if I'm not mistaking, it's either a policy_file directive, OR a policy_dirs, I don't think it can be both (I'd have to validate that point though...). | 09:33 |
| openstackgerrit | Thomas Goirand proposed openstack/puppet-keystone master: configure policy_dirs by default https://review.opendev.org/c/openstack/puppet-keystone/+/782274 | 09:35 |
| tkajinam | as far as I've checked the current implementation of oslo.policy, it looks like loading both policy_file and files under policy_dirs | 09:36 |
| tkajinam | so my points are | 09:36 |
| tkajinam | - it would be better to avoid redefining the redundant default | 09:36 |
| tkajinam | - if making the default value different from the one from service then we should be much more careful | 09:36 |
| tkajinam | - if that definition is always required in Debian packages then it would make more sense to implement solution applicable to the deployment without puppet | 09:37 |
| tkajinam | as we do with <service-name>-dist.conf in rdo... | 09:37 |
| tkajinam | zigo, my -1 was mainly because I thought you are defining the value different from service defaults | 09:40 |
| zigo | tkajinam: That's not the case, it's very much what appears to be the default, as much as I can tell. | 09:42 |
| tkajinam | zigo, then we can use os_service_default instead of the hard coded value | 09:44 |
| zigo | Ok, doing that then. | 09:44 |
| openstackgerrit | Thomas Goirand proposed openstack/puppet-keystone master: configure policy_dirs by default https://review.opendev.org/c/openstack/puppet-keystone/+/782274 | 09:45 |
| zigo | Thanks for your input. | 09:46 |
| tkajinam | zigo, np. | 09:46 |
| tkajinam | zigo, please update unit tests and add a release note | 09:46 |
| tkajinam | ;-) | 09:46 |
| tkajinam | zigo, and seems you didn't update the default in parameter description | 09:47 |
| zigo | Ok. | 09:50 |
| openstackgerrit | Thomas Goirand proposed openstack/puppet-keystone master: configure policy_dirs by default https://review.opendev.org/c/openstack/puppet-keystone/+/782274 | 09:54 |
| openstackgerrit | Takashi Kajinami proposed openstack/puppet-oslo master: Do not convert policy_dirs to comma-separated list https://review.opendev.org/c/openstack/puppet-oslo/+/784059 | 10:03 |
| openstackgerrit | Takashi Kajinami proposed openstack/puppet-oslo master: Do not convert policy_dirs to comma-separated list https://review.opendev.org/c/openstack/puppet-oslo/+/784059 | 10:04 |
| *** ykarel|lunch is now known as ykarel | 10:04 | |
| *** rcernin has joined #puppet-openstack | 10:06 | |
| openstackgerrit | Takashi Kajinami proposed openstack/puppet-oslo master: Do not convert policy_dirs to comma-separated list https://review.opendev.org/c/openstack/puppet-oslo/+/784059 | 10:07 |
| *** rcernin has quit IRC | 10:08 | |
| *** rcernin has joined #puppet-openstack | 10:08 | |
| *** derekh has quit IRC | 10:26 | |
| *** derekh has joined #puppet-openstack | 10:26 | |
| openstackgerrit | Thomas Goirand proposed openstack/puppet-keystone master: Allow to configure policy_dirs https://review.opendev.org/c/openstack/puppet-keystone/+/782274 | 10:37 |
| openstackgerrit | Rocky proposed openstack/puppet-manila master: Add LVM backend https://review.opendev.org/c/openstack/puppet-manila/+/783821 | 11:18 |
| *** Caterpillar2 is now known as Caterpillar | 11:31 | |
| *** dtantsur|afk is now known as dtantsur | 11:34 | |
| zigo | tkajinam: Even though it failed setting-up centos repos, unit tests are passing for https://review.opendev.org/c/openstack/puppet-keystone/+/780918 so I believe a recheck will make it pass. | 11:44 |
| *** rcernin has quit IRC | 12:31 | |
| openstackgerrit | Takashi Kajinami proposed openstack/puppet-swift stable/train: DNM: Test unit tests https://review.opendev.org/c/openstack/puppet-swift/+/784099 | 13:15 |
| openstackgerrit | Takashi Kajinami proposed openstack/puppet-swift stable/train: DNM: fix the broken unit tests with tls patch https://review.opendev.org/c/openstack/puppet-swift/+/784101 | 13:20 |
| openstackgerrit | Takashi Kajinami proposed openstack/puppet-keystone master: Allow to configure policy_dirs https://review.opendev.org/c/openstack/puppet-keystone/+/782274 | 13:26 |
| openstackgerrit | Takashi Kajinami proposed openstack/puppet-swift stable/train: Add parameter memcache_max_connections https://review.opendev.org/c/openstack/puppet-swift/+/784042 | 13:31 |
| openstackgerrit | Takashi Kajinami proposed openstack/puppet-swift stable/train: Add TLS options for swift memcached client https://review.opendev.org/c/openstack/puppet-swift/+/775609 | 13:31 |
| openstackgerrit | Merged openstack/puppet-ovn stable/victoria: Set external_ids:ovn-chassis-mac-mappings https://review.opendev.org/c/openstack/puppet-ovn/+/782759 | 13:46 |
| *** rcernin has joined #puppet-openstack | 14:12 | |
| *** rcernin has quit IRC | 14:17 | |
| openstackgerrit | Merged openstack/puppet-ovn stable/ussuri: Set external_ids:ovn-chassis-mac-mappings https://review.opendev.org/c/openstack/puppet-ovn/+/782763 | 14:22 |
| *** rcernin has joined #puppet-openstack | 14:31 | |
| *** rcernin has quit IRC | 14:35 | |
| *** ykarel is now known as ykarel|away | 14:40 | |
| openstackgerrit | Merged openstack/puppet-barbican stable/victoria: Add support for always_set_cka_sensitive parameter https://review.opendev.org/c/openstack/puppet-barbican/+/782530 | 14:54 |
| openstackgerrit | Merged openstack/puppet-ovn stable/train: Set external_ids:ovn-chassis-mac-mappings https://review.opendev.org/c/openstack/puppet-ovn/+/782765 | 14:56 |
| *** morazi has quit IRC | 15:00 | |
| openstackgerrit | Alexey Stupnikov proposed openstack/puppet-barbican stable/ussuri: Add support for always_set_cka_sensitive parameter https://review.opendev.org/c/openstack/puppet-barbican/+/784043 | 15:10 |
| *** morazi has joined #puppet-openstack | 15:22 | |
| *** rcernin has joined #puppet-openstack | 15:26 | |
| *** rcernin has quit IRC | 15:31 | |
| *** ykarel|away has quit IRC | 15:37 | |
| *** ysandeep is now known as ysandeep|away | 15:47 | |
| *** derekh has quit IRC | 17:00 | |
| *** dtantsur is now known as dtantsur|afk | 17:04 | |
| openstackgerrit | Merged openstack/puppet-vswitch stable/victoria: Add support for vlan_limit option https://review.opendev.org/c/openstack/puppet-vswitch/+/783215 | 17:06 |
| *** rcernin has joined #puppet-openstack | 17:27 | |
| *** rcernin has quit IRC | 17:35 | |
| *** gfidente is now known as gfidente|afk | 17:59 | |
| *** rcernin has joined #puppet-openstack | 19:31 | |
| *** rcernin has quit IRC | 19:36 | |
| *** hjensas has quit IRC | 20:10 | |
| *** rcernin has joined #puppet-openstack | 20:30 | |
| *** rcernin has quit IRC | 21:05 | |
| *** rcernin has joined #puppet-openstack | 21:05 | |
| *** rcernin has quit IRC | 21:30 | |
| *** rcernin has joined #puppet-openstack | 21:55 | |
| *** rcernin has quit IRC | 22:00 | |
| *** rcernin has joined #puppet-openstack | 22:13 | |
| *** rcernin has quit IRC | 22:18 | |
| *** rcernin has joined #puppet-openstack | 22:32 | |
| *** rcernin has quit IRC | 22:32 | |
| *** rcernin has joined #puppet-openstack | 22:33 | |
| zigo | tkajinam: As predicted, it now passes: https://review.opendev.org/c/openstack/puppet-keystone/+/780918 | 23:18 |
| zigo | Is it in good enough shape for you as well now? | 23:18 |
| zigo | tobias-urdin: ^ | 23:20 |
| zigo | tobias-urdin: Also this one: https://review.opendev.org/c/openstack/puppet-keystone/+/782274 | 23:20 |
| * zigo goes to sleep | 23:21 | |
| *** tosky has quit IRC | 23:30 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!