| *** rcernin has joined #puppet-openstack | 00:00 | |
| openstackgerrit | Merged openstack/puppet-openstacklib master: Prepare Wallaby RC1 https://review.opendev.org/c/openstack/puppet-openstacklib/+/783151 | 00:49 |
|---|---|---|
| openstackgerrit | Merged openstack/puppet-rally master: Prepare Wallaby RC1 https://review.opendev.org/c/openstack/puppet-rally/+/783165 | 00:51 |
| openstackgerrit | Merged openstack/puppet-barbican master: Prepare Wallaby RC1 https://review.opendev.org/c/openstack/puppet-barbican/+/783157 | 00:51 |
| openstackgerrit | Merged openstack/puppet-neutron master: Prepare Wallaby RC1 https://review.opendev.org/c/openstack/puppet-neutron/+/783181 | 00:53 |
| openstackgerrit | Takashi Kajinami proposed openstack/puppet-openstack-integration master: nova: Set the images_type parameter https://review.opendev.org/c/openstack/puppet-openstack-integration/+/783586 | 01:10 |
| openstackgerrit | Takashi Kajinami proposed openstack/puppet-openstack-integration master: nova: Set the images_type parameter https://review.opendev.org/c/openstack/puppet-openstack-integration/+/783586 | 01:14 |
| openstackgerrit | Takashi Kajinami proposed openstack/puppet-openstack-integration master: nova: Set the images_type parameter https://review.opendev.org/c/openstack/puppet-openstack-integration/+/783586 | 01:42 |
| *** rcernin has quit IRC | 03:06 | |
| *** rcernin has joined #puppet-openstack | 03:11 | |
| *** ykarel__ has joined #puppet-openstack | 03:40 | |
| *** ykarel__ is now known as ykarel | 04:16 | |
| *** paladox has quit IRC | 04:20 | |
| *** ysandeep|away is now known as ysandeep | 05:16 | |
| openstackgerrit | Pranali Deore proposed openstack/puppet-glance master: Add new parameter required for secure RBAC configuration https://review.opendev.org/c/openstack/puppet-glance/+/783605 | 07:03 |
| *** rpittau|afk is now known as rpittau | 07:15 | |
| *** rcernin has quit IRC | 07:29 | |
| *** ysandeep is now known as ysandeep|lunch | 08:09 | |
| *** derekh has joined #puppet-openstack | 08:27 | |
| *** tosky has joined #puppet-openstack | 08:28 | |
| *** derekh has quit IRC | 08:31 | |
| *** derekh has joined #puppet-openstack | 08:31 | |
| zigo | tkajinam: Hey, could I bother you with reviewing https://review.opendev.org/c/openstack/puppet-keystone/+/780918 ? | 08:39 |
| zigo | It passes unit tests now... | 08:40 |
| openstackgerrit | Takashi Kajinami proposed openstack/puppet-openstacklib master: Add support for uwsgi configuration https://review.opendev.org/c/openstack/puppet-openstacklib/+/781230 | 08:46 |
| openstackgerrit | Takashi Kajinami proposed openstack/puppet-openstacklib master: Add unit tests for openstacklib::wsgi::uwsgi https://review.opendev.org/c/openstack/puppet-openstacklib/+/783620 | 08:46 |
| *** rcernin has joined #puppet-openstack | 08:48 | |
| tkajinam | zigo, it passes unit tests because these test cases you added are not invoked | 08:52 |
| zigo | tkajinam: Oh... Why aren't they run? | 08:52 |
| tkajinam | zigo, you need to add | 08:52 |
| tkajinam | it_behaves_like 'keystone::wsgi::uwsgi' | 08:53 |
| tkajinam | between L33 and L34 | 08:53 |
| *** ykarel is now known as ykarel|lunch | 08:53 | |
| tkajinam | zigo, let me post 2 more comments. these are just minor ones | 08:54 |
| tkajinam | (sorry these are not so much minor ... maybe | 08:56 |
| openstackgerrit | Tobias Urdin proposed openstack/puppet-openstack-integration master: DNM: Test Puppet 7 with CentOS 8 Stream https://review.opendev.org/c/openstack/puppet-openstack-integration/+/778749 | 08:57 |
| zigo | tkajinam: We do need service_name => 'keystone' in Debian... | 08:58 |
| tkajinam | zigo, I know that is required in Debian | 08:58 |
| tkajinam | zigo, but I don't think that parameter is currently explicitly required from keystone::wsgi::uwsgi | 08:58 |
| tkajinam | I mean, without that pre_condition unit tests are supposed to pass | 08:58 |
| tkajinam | then we can remove it... or make these tests run only for Debian | 08:58 |
| zigo | Ok, I'm removing it then. | 08:59 |
| zigo | tkajinam: We aren't testing in Debian (yet), so we can't do that (yet). | 08:59 |
| tkajinam | zigo, I meant something like this https://github.com/openstack/puppet-nova/blob/master/spec/classes/nova_compute_libvirt_spec.rb#L390-L395 | 09:00 |
| *** rcernin has quit IRC | 09:00 | |
| zigo | Something like this: | 09:00 |
| zigo | case facts[:osfamily] | 09:01 |
| zigo | when 'Debian' | 09:01 |
| zigo | doesn't select Debian, it selects Debian + Ubuntu. | 09:01 |
| openstackgerrit | Thomas Goirand proposed openstack/puppet-keystone master: Add support for keystone_uwsgi_config in Debian https://review.opendev.org/c/openstack/puppet-keystone/+/780918 | 09:01 |
| tkajinam | you can also add logic to check :operatingsystem as well | 09:01 |
| zigo | No... :) | 09:02 |
| tkajinam | to eliminate ubuntu | 09:02 |
| zigo | os_package_type | 09:02 |
| tkajinam | ah, yeah | 09:02 |
| tkajinam | but just removing that pre_condition would be the simplest solution | 09:02 |
| tkajinam | here | 09:02 |
| zigo | But then it wont be tested at all, no? | 09:02 |
| zigo | (since we aren't testing in Debian...) | 09:03 |
| zigo | I did remove the pre_condition so it should be ok. | 09:03 |
| zigo | Thanks for your help! | 09:03 |
| tkajinam | zigo, I'm afraid you missed my comment on uwsgi.pp | 09:04 |
| zigo | :/ | 09:04 |
| tkajinam | that manifest doesn't reply on openstacklib while your tests expect it does | 09:04 |
| zigo | Haven't we discuss that this first patch in puppet-keystone must be merged first? | 09:05 |
| zigo | Also, I'm not so sure anymore that we need the added complexity of using openstacklib anymore, since this keystone patch is a lot more simple now. | 09:06 |
| zigo | Your thoughts? | 09:06 |
| tkajinam | zigo, maybe we can just leave implementation in openstacklib atm | 09:07 |
| tkajinam | one benefit would be that we don't need to put that logic to show warning message in each modules | 09:07 |
| tkajinam | but in a single place | 09:08 |
| tkajinam | zigo, I think we can start without openstacklib. if you see any requirement to put complicated logic then we can consider implementing the base class at that time | 09:10 |
| tkajinam | so... it would be enough once you fix the unit test | 09:10 |
| zigo | Ok. | 09:10 |
| zigo | Thanks for your comments. | 09:10 |
| zigo | I'll ping you when it passes unit tests. | 09:11 |
| tkajinam | zigo, ok. I'll check the patch tonight or early tomorrow | 09:12 |
| zigo | I'm currently done with packaging Wallaby RC1, and debugging my first install with puppet... :) | 09:13 |
| tkajinam | that's nice | 09:14 |
| *** gfidente has joined #puppet-openstack | 09:24 | |
| *** ysandeep|lunch is now known as ysandeep | 09:26 | |
| *** ykarel|lunch is now known as ykarel | 09:27 | |
| *** dtantsur|afk is now known as dtantsur | 09:41 | |
| *** rcernin has joined #puppet-openstack | 09:52 | |
| *** rcernin has quit IRC | 10:07 | |
| *** rcernin has joined #puppet-openstack | 10:07 | |
| *** rcernin has quit IRC | 10:20 | |
| *** rcernin has joined #puppet-openstack | 10:27 | |
| *** rcernin has quit IRC | 10:38 | |
| *** rcernin has joined #puppet-openstack | 10:52 | |
| *** rcernin has quit IRC | 11:05 | |
| openstackgerrit | Merged openstack/puppet-openstack-integration stable/victoria: Do not use mirror host for Ceph Luminous https://review.opendev.org/c/openstack/puppet-openstack-integration/+/773657 | 11:23 |
| *** dtantsur is now known as dtantsur|brb | 11:28 | |
| *** paladox has joined #puppet-openstack | 12:32 | |
| *** radez has joined #puppet-openstack | 12:34 | |
| openstackgerrit | Takashi Kajinami proposed openstack/puppet-openstack-integration master: Bump puppet-memcached for tls support https://review.opendev.org/c/openstack/puppet-openstack-integration/+/783644 | 12:40 |
| openstackgerrit | Takashi Kajinami proposed openstack/puppet-openstack-integration master: Bump puppet-memcached for tls support https://review.opendev.org/c/openstack/puppet-openstack-integration/+/783644 | 12:45 |
| openstackgerrit | Takashi Kajinami proposed openstack/puppet-openstack-integration stable/ussuri: [Ussuri and before] Bump puppet-memcached for tls support https://review.opendev.org/c/openstack/puppet-openstack-integration/+/783646 | 12:56 |
| openstackgerrit | Merged openstack/puppet-openstack-integration stable/victoria: Add non-voting litmus jobs on CentOS8 Stream https://review.opendev.org/c/openstack/puppet-openstack-integration/+/779606 | 12:57 |
| openstackgerrit | Takashi Kajinami proposed openstack/puppet-openstack-integration stable/ussuri: [Ussuri and before] Bump puppet-memcached for tls support https://review.opendev.org/c/openstack/puppet-openstack-integration/+/783646 | 12:57 |
| openstackgerrit | Takashi Kajinami proposed openstack/puppet-openstack-integration stable/ussuri: [Ussuri and before] Bump puppet-memcached for tls support https://review.opendev.org/c/openstack/puppet-openstack-integration/+/783646 | 12:58 |
| openstackgerrit | Takashi Kajinami proposed openstack/puppet-openstack-integration stable/ussuri: [Ussuri and before] Bump puppet-memcached for tls support https://review.opendev.org/c/openstack/puppet-openstack-integration/+/783646 | 13:00 |
| openstackgerrit | Takashi Kajinami proposed openstack/puppet-openstack-integration stable/ussuri: [Ussuri and before] Bump puppet-memcached for tls support https://review.opendev.org/c/openstack/puppet-openstack-integration/+/783646 | 13:00 |
| tkajinam | tobias-urdin, ^^^ sorry about my frequent update :-( | 13:01 |
| tkajinam | this one should be final version | 13:01 |
| tkajinam | tobias-urdin, just fyi I'll backport this to stable/train later. | 13:02 |
| openstackgerrit | Takashi Kajinami proposed openstack/puppet-openstack-integration stable/ussuri: [Ussuri and before] Bump puppet-memcached for tls support https://review.opendev.org/c/openstack/puppet-openstack-integration/+/783646 | 13:02 |
| tkajinam | sorry this is the real final one X-P | 13:02 |
| *** dtantsur|brb is now known as dtantsur | 13:15 | |
| *** ykarel_ has joined #puppet-openstack | 13:39 | |
| *** ykarel has quit IRC | 13:42 | |
| openstackgerrit | Merged openstack/puppet-nova master: Prepare Wallaby RC1 https://review.opendev.org/c/openstack/puppet-nova/+/783180 | 13:44 |
| zigo | tkajinam: Now my keystone_uwsgi_config patch fails: https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_c26/780918/10/check/puppet-openstack-unit-6.21-ubuntu-focal/c262e89/job-output.txt | 13:46 |
| *** ade_lee_afk is now known as ade_lee | 13:46 | |
| zigo | keystone::wsgi::uwsgi on ubuntu-20.04-x86_64 behaves like keystone::wsgi::uwsgi with default parameters is expected to contain Openstacklib::Wsgi::Uwsgi[keystone_wsgi] with processes => 8, threads => 32 and listen_queue_size => 100 | 13:47 |
| zigo | expected that the catalogue would contain Openstacklib::Wsgi::Uwsgi[keystone_wsgi] | 13:47 |
| tkajinam | zigo, because that still uses openstacklib implementation | 13:47 |
| tkajinam | that still expects * I mean | 13:47 |
| zigo | Ah, right. | 13:47 |
| zigo | Hum... | 13:48 |
| tkajinam | you should update implementation in that spec file so that it expects direct usage of keystone_uwsgi_config | 13:48 |
| zigo | tkajinam: Something like this? | 13:49 |
| zigo | it { should contain_keystone_uwsgi_config.with( | 13:49 |
| zigo | :processes => facts[:os_workers_keystone], | 13:49 |
| zigo | :threads => 32, | 13:49 |
| zigo | :listen_queue_size => 100, | 13:49 |
| zigo | )} | 13:49 |
| zigo | Ah no. | 13:49 |
| zigo | I'll have a look at other unit tests... | 13:49 |
| zigo | This, right? | 13:53 |
| zigo | it { | 13:53 |
| zigo | is_expected.to contain_keystone_uwsgi_config('uwsgi/processes').with_value('8') | 13:53 |
| zigo | is_expected.to contain_keystone_uwsgi_config('uwsgi/threads').with_value('32') | 13:53 |
| zigo | is_expected.to contain_keystone_uwsgi_config('uwsgi/listen').with_value('100') | 13:53 |
| zigo | } | 13:53 |
| *** ysandeep is now known as ysandeep|afk | 13:53 | |
| openstackgerrit | Thomas Goirand proposed openstack/puppet-keystone master: Add support for keystone_uwsgi_config in Debian https://review.opendev.org/c/openstack/puppet-keystone/+/780918 | 13:53 |
| zigo | Let's see if that works now ... :) | 13:54 |
| *** ysandeep|afk is now known as ysandeep | 13:57 | |
| *** rcernin has joined #puppet-openstack | 14:01 | |
| *** rcernin has quit IRC | 14:06 | |
| *** ykarel_ is now known as ykarel | 14:55 | |
| openstackgerrit | Tobias Urdin proposed openstack/puppet-openstack-integration master: WIP: Add Puppet 7 testing https://review.opendev.org/c/openstack/puppet-openstack-integration/+/778749 | 15:08 |
| openstackgerrit | Tobias Urdin proposed openstack/puppet-openstack-integration master: WIP: Add Puppet 7 testing https://review.opendev.org/c/openstack/puppet-openstack-integration/+/778749 | 15:17 |
| openstackgerrit | Tobias Urdin proposed openstack/puppet-openstack-integration master: WIP: Add Puppet 7 testing https://review.opendev.org/c/openstack/puppet-openstack-integration/+/778749 | 15:24 |
| *** ysandeep is now known as ysandeep|dinner | 15:28 | |
| *** ykarel is now known as ykarel|away | 15:33 | |
| *** ykarel|away has quit IRC | 15:42 | |
| *** derekh has quit IRC | 16:03 | |
| *** derekh has joined #puppet-openstack | 16:03 | |
| *** rpittau is now known as rpittau|afk | 16:08 | |
| *** gfidente has quit IRC | 16:09 | |
| *** gfidente has joined #puppet-openstack | 16:17 | |
| *** ysandeep|dinner is now known as ysandeep | 16:47 | |
| *** ysandeep is now known as ysandeep|away | 16:57 | |
| *** gfidente is now known as gfidente|afk | 17:26 | |
| *** dtantsur is now known as dtantsur|afk | 18:07 | |
| *** derekh has quit IRC | 20:56 | |
| openstackgerrit | Merged openstack/puppet-nova master: Add images_type https://review.opendev.org/c/openstack/puppet-nova/+/776931 | 22:02 |
| *** rcernin has joined #puppet-openstack | 22:24 | |
| *** rcernin has quit IRC | 22:24 | |
| *** rcernin has joined #puppet-openstack | 22:24 | |
| *** derekh has joined #puppet-openstack | 22:48 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!