| *** ade_lee has quit IRC | 00:12 | |
| *** ade_lee has joined #puppet-openstack | 00:14 | |
| *** owalsh has quit IRC | 00:50 | |
| *** owalsh has joined #puppet-openstack | 00:52 | |
| *** mmethot has quit IRC | 02:13 | |
| *** mmethot has joined #puppet-openstack | 02:13 | |
| *** mschuppert has quit IRC | 02:46 | |
| *** openstackgerrit has joined #puppet-openstack | 02:47 | |
| openstackgerrit | Merged openstack/puppet-nova master: vcpu_pin_set gets set under [compute] instead of [DEFAULT] https://review.opendev.org/698919 | 02:47 |
|---|---|---|
| *** jtomasek has joined #puppet-openstack | 12:36 | |
| *** jtomasek has quit IRC | 13:00 | |
| *** jistr has quit IRC | 14:05 | |
| *** jistr has joined #puppet-openstack | 14:05 | |
| tobias-urdin | cgoncalves: EmilienM mwhahaha this commit broke puppet-octavia https://review.opendev.org/#/c/694832/ | 15:24 |
| tobias-urdin | and was backported to all versions... | 15:24 |
| tobias-urdin | 2019-12-13 16:12:27 +0000 Puppet (err): Evaluation Error: Error while evaluating a Resource Statement, Duplicate declaration: Octavia_config[nova/enable_anti_affinity] is already declared at (file: /etc/puppetlabs/code/modules/octavia/manifests/controller.pp, line: 189); cannot redeclare (file: /etc/puppetlabs/code/modules/octavia/manifests/nova.pp, line: 48) (file: | 15:24 |
| tobias-urdin | /etc/puppetlabs/code/modules/octavia/manifests/nova.pp, line: 48, column: 3) | 15:24 |
| tobias-urdin | the options already existed in octavia::nova | 15:24 |
| openstackgerrit | Tobias Urdin proposed openstack/puppet-octavia master: Revert "Add parameters for amphora anti-affinity" https://review.opendev.org/699067 | 15:25 |
| openstackgerrit | Tobias Urdin proposed openstack/puppet-octavia master: Revert "Add parameters for amphora anti-affinity" https://review.opendev.org/699067 | 15:27 |
| openstackgerrit | Tobias Urdin proposed openstack/puppet-octavia stable/queens: Revert "Add parameters for amphora anti-affinity" https://review.opendev.org/699068 | 15:28 |
| openstackgerrit | Tobias Urdin proposed openstack/puppet-octavia stable/rocky: Revert "Add parameters for amphora anti-affinity" https://review.opendev.org/699069 | 15:28 |
| openstackgerrit | Tobias Urdin proposed openstack/puppet-octavia stable/stein: Revert "Add parameters for amphora anti-affinity" https://review.opendev.org/699070 | 15:28 |
| openstackgerrit | Tobias Urdin proposed openstack/puppet-octavia stable/train: Revert "Add parameters for amphora anti-affinity" https://review.opendev.org/699071 | 15:28 |
| EmilienM | tobias-urdin: sorry | 15:30 |
| EmilienM | tobias-urdin: i'm afraid of the revert if it breaks tripleo | 15:31 |
| EmilienM | I'll let cgoncalves decide and figure outy | 15:31 |
| EmilienM | cgoncalves: ^ please take a look | 15:31 |
| tobias-urdin | sure, both those options exist all the way from queens and up so should be an easy swap hopefully | 15:32 |
| tobias-urdin | https://review.opendev.org/#/q/I7d271c0184750aa90be59a25944c29fec3c3afd2 | 15:32 |
| EmilienM | tobias-urdin: where do you see the failure? | 15:33 |
| tobias-urdin | in our internal ci | 15:34 |
| EmilienM | sorry for that :-( | 15:34 |
| EmilienM | tobias-urdin: do you want me to approve the reverts? | 15:35 |
| tobias-urdin | no worries, i can pin unless you are sure it's not used in tripleo | 15:36 |
| EmilienM | let me verify | 15:36 |
| EmilienM | give me 2 min | 15:36 |
| EmilienM | tobias-urdin: https://github.com/openstack/tripleo-heat-templates/blob/0281b35e6aadc3e15b706c65133208b53c91b949/deployment/octavia/octavia-base.yaml#L274 | 15:38 |
| EmilienM | it's used :/ | 15:38 |
| EmilienM | could you use the new parameter? | 15:38 |
| EmilienM | octavia::controller::anti_affinity_policy | 15:38 |
| tobias-urdin | using the octavia::nova class to set the [nova] config options | 15:39 |
| tobias-urdin | would need to move all those out to octavia_config's :( | 15:39 |
| EmilienM | oh I see | 15:42 |
| EmilienM | we should rather call the octavia::nova for this option | 15:42 |
| EmilienM | instead of octavia::controller | 15:42 |
| EmilienM | is that correct? | 15:42 |
| EmilienM | i can do that | 15:42 |
| EmilienM | let me update tripleo | 15:43 |
| EmilienM | so we can revert ok? | 15:43 |
| tobias-urdin | i'll fix it | 15:43 |
| EmilienM | we don't include octavia::nova in puppet-tripleo | 15:44 |
| EmilienM | so we need to add it first | 15:44 |
| EmilienM | then in THT replace the hieradata | 15:44 |
| EmilienM | let me do it, no worries | 15:44 |
| EmilienM | tobias-urdin: where do you configure octavia::nova ? | 15:47 |
| EmilienM | on worker? api? etc | 15:47 |
| EmilienM | or everywhere? | 15:47 |
| EmilienM | ah you sent patches alraedy, I'll abandon mine | 15:47 |
| tobias-urdin | yeah, worker | 15:48 |
| EmilienM | tobias-urdin: +2 to your patches | 15:48 |
| EmilienM | tobias-urdin: sorry for the mess | 15:48 |
| tobias-urdin | no worries, i can probably get some time free to fix up testing for octavia that was never finished https://review.opendev.org/#/c/597600/ | 15:49 |
| EmilienM | yeah :-( | 15:49 |
| EmilienM | I'm out, have a good weekend | 15:49 |
| tobias-urdin | you too! | 15:49 |
| EmilienM | thx | 15:50 |
| *** rascasoft has quit IRC | 19:55 | |
| *** rascasoft has joined #puppet-openstack | 19:58 | |
| *** pkopec has joined #puppet-openstack | 21:57 | |
| *** pkopec has quit IRC | 22:06 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!