hogepodge | Essentially dropping the patches now would just turn into a copy-paste job for them, but there are other modules that we want to swap out also. | 00:00 |
---|---|---|
mwhahaha | k | 00:00 |
mwhahaha | can we have the list prior to them starting work to make sure it is actually something that would be good for them to work on? | 00:01 |
mwhahaha | because its not beneficial for them to try and swap core modules that we won't be able to merge so late in the cycle | 00:01 |
mwhahaha | swapping any modules has packaging related issues as well which would need to be addressed | 00:01 |
mwhahaha | which i hadn't done since i was only seeing if it actually feasable | 00:02 |
*** ade_lee has quit IRC | 00:02 | |
*** tosky has quit IRC | 00:02 | |
*** ade_lee has joined #puppet-openstack | 00:02 | |
*** ekultails has quit IRC | 00:02 | |
hogepodge | Modules to look at replacing: (antonlindstrom/puppet-powerdns -> sensson/powerdns), (duritong/puppet-sysctl -> thias/puppet-sysctl), (puppetlabs/puppetlabs-vcsrepo -> voxpupuli/puppet-git_resource) | 00:06 |
mwhahaha | the sysctl one is incompatible | 00:06 |
*** markvoelker has joined #puppet-openstack | 00:06 | |
mwhahaha | so we'll see on that one | 00:06 |
mwhahaha | that one is also used by other dependencies i believe | 00:06 |
mwhahaha | we'll need to get those packaged in RDO as well | 00:07 |
mwhahaha | so yea send a note to the ML to raise the idea and we can help point out the places that will need to be addressed | 00:07 |
* mwhahaha wanders off | 00:09 | |
*** diablo_rojo has joined #puppet-openstack | 00:25 | |
*** markvoelker has quit IRC | 00:40 | |
*** rascasoft has joined #puppet-openstack | 00:51 | |
*** rascasoft has quit IRC | 01:03 | |
*** markvoelker has joined #puppet-openstack | 01:37 | |
*** markvoelker has quit IRC | 02:10 | |
*** mschuppert has quit IRC | 02:14 | |
*** skramaja has joined #puppet-openstack | 02:27 | |
*** rcernin has quit IRC | 02:32 | |
*** rascasoft has joined #puppet-openstack | 02:53 | |
*** rascasoft has quit IRC | 03:01 | |
*** markvoelker has joined #puppet-openstack | 03:04 | |
openstackgerrit | Merged openstack/puppet-ceph master: Deprecate keystone v2.0 functionality https://review.openstack.org/638922 | 03:40 |
openstackgerrit | Merged openstack/puppet-ceph master: Deprecated Keystone v2.0 and PKI tokens in Keystone RGW https://review.openstack.org/638923 | 03:50 |
openstackgerrit | Merged openstack/puppet-openstack-integration master: Change chardet installation to a exec https://review.openstack.org/639215 | 03:54 |
*** rascasoft has joined #puppet-openstack | 04:06 | |
*** rascasoft has quit IRC | 04:16 | |
*** ykarel has joined #puppet-openstack | 04:19 | |
openstackgerrit | Merged openstack/puppet-cinder master: PowerMax driver - rebranding VMAX to PowerMax https://review.openstack.org/625716 | 04:24 |
*** janki has joined #puppet-openstack | 04:33 | |
openstackgerrit | Merged openstack/puppet-swift master: Use validate_legacy https://review.openstack.org/638873 | 04:35 |
openstackgerrit | Merged openstack/puppet-ceph master: Use validate_legacy https://review.openstack.org/636050 | 04:38 |
*** ykarel has quit IRC | 05:54 | |
*** ykarel has joined #puppet-openstack | 05:55 | |
*** rascasoft has joined #puppet-openstack | 06:50 | |
*** markvoelker has quit IRC | 06:51 | |
*** jtomasek has joined #puppet-openstack | 06:53 | |
*** rascasoft has quit IRC | 06:59 | |
*** rascasoft has joined #puppet-openstack | 07:10 | |
*** mschuppert has joined #puppet-openstack | 07:18 | |
*** dpawlik has joined #puppet-openstack | 07:25 | |
*** pgaxatte has joined #puppet-openstack | 07:37 | |
*** markvoelker has joined #puppet-openstack | 07:52 | |
*** amoralej|off is now known as amoralej | 08:15 | |
*** markvoelker has quit IRC | 08:25 | |
*** tosky has joined #puppet-openstack | 08:41 | |
*** jpena|off is now known as jpena | 08:57 | |
*** markvoelker has joined #puppet-openstack | 09:23 | |
*** hjensas has quit IRC | 09:23 | |
*** janki has quit IRC | 09:30 | |
*** janki has joined #puppet-openstack | 09:30 | |
openstackgerrit | Rajesh Tailor proposed openstack/puppet-nova stable/queens: Fail to live migration if instance has NUMA topology https://review.openstack.org/638129 | 09:35 |
*** derekh has joined #puppet-openstack | 09:41 | |
*** ykarel is now known as ykarel|lunch | 09:44 | |
*** chem has joined #puppet-openstack | 09:53 | |
*** markvoelker has quit IRC | 09:57 | |
*** owalsh_ has joined #puppet-openstack | 09:57 | |
*** owalsh has quit IRC | 09:58 | |
*** hjensas has joined #puppet-openstack | 10:05 | |
*** owalsh has joined #puppet-openstack | 10:09 | |
*** owalsh_ has quit IRC | 10:10 | |
*** hjensas has quit IRC | 10:11 | |
*** hjensas has joined #puppet-openstack | 10:12 | |
tobias-urdin | lyarwood: would you mind explaining this one https://review.openstack.org/#/c/639284/ | 10:13 |
tobias-urdin | i dont get it :D | 10:13 |
lyarwood | I'm such a wordsmith. :) | 10:16 |
lyarwood | tobias-urdin: just on a call, but in short we can't define the connection param against the ::nova class _and_ deploy the extracted service | 10:17 |
lyarwood | tobias-urdin: if we do `nova-manage db_api sync` ends up trying to talk to the nova_placement db that doesn't exist | 10:18 |
*** dpawlik has quit IRC | 10:20 | |
lyarwood | tobias-urdin: happy to rewrite that awful commit message if it would help | 10:20 |
*** chem has quit IRC | 10:21 | |
*** chem has joined #puppet-openstack | 10:21 | |
*** ykarel|lunch is now known as ykarel | 10:23 | |
tobias-urdin | lyarwood: hm still not sure, so we have placement_database_connection in ::nova, ::nova::db, ::nova::placement and ::placement | 10:27 |
tobias-urdin | nova::db pick()'s ::nova and ::nova::db placement_database_connection params | 10:27 |
tobias-urdin | ::nova and ::nova::placement doesn't use their respective param at all (::nova is for backward compatibility btw) | 10:27 |
tobias-urdin | where does ::nova::placement::placement_database_connection come into the picture? | 10:27 |
lyarwood | I was sure the pick was using the ::nova param no? | 10:28 |
tobias-urdin | https://github.com/openstack/puppet-nova/blob/master/manifests/db.pp#L108 | 10:31 |
lyarwood | right, and that isn't being picked up at all in the jobs | 10:31 |
lyarwood | nova is just using the api DB for placement | 10:31 |
lyarwood | my bad | 10:31 |
lyarwood | http://logs.openstack.org/11/634211/8/check/puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous/9d76fdc/logs/etc/nova/nova.conf.txt.gz | 10:31 |
tobias-urdin | the end goal, and i think i have a task on my todo list as well, is to that the *_database_connection only exposed from <module>::db classes | 10:31 |
tobias-urdin | it's just insane how much we've been able to push this cycle and that's a big change and i don't think we want to combine that with the major logging change we did this cycle | 10:32 |
tobias-urdin | (that removed all the logging pick()'s, like we want to do with db as well, is my hope) | 10:32 |
* tobias-urdin checking link | 10:34 | |
*** dpawlik has joined #puppet-openstack | 10:35 | |
tobias-urdin | lyarwood: yeah, the picks enforces the classes in the manifests to be ordered in a specific way which is something i want to move away from | 10:38 |
tobias-urdin | its probably the issue here as well, sec now i'm on a call :p | 10:39 |
openstackgerrit | Merged openstack/puppet-ceph master: Change Keystone RGW default role from Member to member https://review.openstack.org/638924 | 10:45 |
tobias-urdin | lyarwood: back now | 10:48 |
tobias-urdin | but that change https://review.openstack.org/#/c/639284 couldn't have mad a difference did it? | 10:49 |
*** markvoelker has joined #puppet-openstack | 10:53 | |
tobias-urdin | i think what's needed is, when we deploy placement with puppet-nova nova::placement_database_connection must be set to propert db url (in openstack_integration::nova) | 10:59 |
tobias-urdin | when we deploy with puppet-placement nova::placement_database_connection must be keep as undef (default value is undef) so nova::db will default placement_database_connection to $::os_service_default | 10:59 |
tobias-urdin | and puppet-placement will setup that config option in placement config | 11:00 |
tobias-urdin | ahhh messy.. should have gotten rid of that stuff this cycle | 11:00 |
lyarwood | aaaaaaaaaand back, sorry it's back to back calls all morning | 11:02 |
*** dpawlik has quit IRC | 11:04 | |
lyarwood | so that's fine but I can't think of a way of doing that optionally within the nova POI class | 11:04 |
lyarwood | unless you're talking about doing it in the fixtures | 11:04 |
lyarwood | and passing it down | 11:05 |
lyarwood | couldn't we just add nova::placement::placement_database_connection to the pick list in https://github.com/openstack/puppet-nova/blob/master/manifests/db.pp#L108 ? | 11:06 |
tobias-urdin | that would be adding a parameter to the openstack_integration::nova i guess so we can set it from scenario | 11:08 |
tobias-urdin | imo would be better if we could skip adding those, even if they are added as deprecated without a release note | 11:09 |
lyarwood | right, I think adding nova::placement::placement_database_connection to the pick list in puppet-nova is the way to go here | 11:10 |
tobias-urdin | wouldn't you rather hack testing than the module that consumers would use though? | 11:11 |
tobias-urdin | that change would be pick, then pick on the value from the first pick hm | 11:11 |
tobias-urdin | brb, grabing lunch | 11:14 |
*** markvoelker has quit IRC | 11:26 | |
*** dpawlik has joined #puppet-openstack | 11:35 | |
*** dpawlik has quit IRC | 11:39 | |
*** dpawlik has joined #puppet-openstack | 11:41 | |
openstackgerrit | Lee Yarwood proposed openstack/puppet-openstack-integration master: nova: Extract placement deployment into a separate class https://review.openstack.org/634211 | 12:20 |
openstackgerrit | Lee Yarwood proposed openstack/puppet-openstack-integration master: placement: Use puppet-placement to deploy an extracted service https://review.openstack.org/615568 | 12:20 |
*** morazi has joined #puppet-openstack | 12:22 | |
*** markvoelker has joined #puppet-openstack | 12:22 | |
openstackgerrit | Tom Barron proposed openstack/puppet-manila stable/queens: Support cephfs_volume_mode parameter https://review.openstack.org/639645 | 12:24 |
openstackgerrit | Lee Yarwood proposed openstack/puppet-openstack-integration master: nova: Extract placement deployment into a separate class https://review.openstack.org/634211 | 12:24 |
openstackgerrit | Lee Yarwood proposed openstack/puppet-openstack-integration master: placement: Use puppet-placement to deploy an extracted service https://review.openstack.org/615568 | 12:24 |
*** amoralej is now known as amoralej|lunch | 12:25 | |
lyarwood | tobias-urdin: ^ without changes to puppet-nova, jumping on yet more calls for a few hours now, I'll check back later this afternoon once CI is finished. | 12:34 |
lyarwood | nvm already failing, I'll sort that out now | 12:34 |
*** jpena is now known as jpena|lunch | 12:36 | |
openstackgerrit | Lee Yarwood proposed openstack/puppet-openstack-integration master: nova: Extract placement deployment into a separate class https://review.openstack.org/634211 | 12:36 |
openstackgerrit | Lee Yarwood proposed openstack/puppet-openstack-integration master: placement: Use puppet-placement to deploy an extracted service https://review.openstack.org/615568 | 12:37 |
*** markvoelker has quit IRC | 12:56 | |
*** ekultails has joined #puppet-openstack | 13:08 | |
*** derekh has quit IRC | 13:22 | |
openstackgerrit | Lee Yarwood proposed openstack/puppet-openstack-integration master: placement: Use puppet-placement to deploy an extracted service https://review.openstack.org/615568 | 13:31 |
*** skramaja has quit IRC | 13:34 | |
*** jpena|lunch is now known as jpena | 13:40 | |
*** markvoelker has joined #puppet-openstack | 13:53 | |
*** janki has quit IRC | 13:53 | |
*** derekh has joined #puppet-openstack | 13:57 | |
*** amoralej|lunch is now known as amoralej | 14:09 | |
*** ykarel is now known as ykarel|afk | 14:20 | |
*** markvoelker has quit IRC | 14:25 | |
*** jpena is now known as jpena|brb | 15:02 | |
*** dpawlik has quit IRC | 15:03 | |
*** ykarel|afk is now known as ykarel | 15:06 | |
*** markvoelker has joined #puppet-openstack | 15:22 | |
*** jpena|brb is now known as jpena | 15:45 | |
*** markvoelker has quit IRC | 15:56 | |
openstackgerrit | Merged openstack/puppet-keystone master: Use validate_legacy https://review.openstack.org/638813 | 16:02 |
*** ykarel is now known as ykarel|away | 16:03 | |
*** ykarel|away is now known as ykarel | 16:04 | |
lyarwood | tobias-urdin: https://review.openstack.org/#/q/topic:placement-deployment-deprecation+status:open & https://review.openstack.org/#/q/topic:puppet-placement-extraction+status:open are hopefully ready for review now. | 16:14 |
*** ykarel_ has joined #puppet-openstack | 16:43 | |
*** ykarel has quit IRC | 16:46 | |
*** gouthamr has quit IRC | 16:48 | |
*** gouthamr has joined #puppet-openstack | 16:50 | |
*** markvoelker has joined #puppet-openstack | 16:53 | |
openstackgerrit | Merged openstack/puppet-nova stable/rocky: Fail to live migration if instance has NUMA topology https://review.openstack.org/638128 | 16:56 |
*** ykarel_ is now known as ykarel|away | 16:59 | |
*** dpawlik has joined #puppet-openstack | 17:17 | |
*** dpawlik has quit IRC | 17:24 | |
*** markvoelker has quit IRC | 17:25 | |
*** trown is now known as trown|lunch | 17:28 | |
*** ykarel|away has quit IRC | 17:51 | |
*** sai_p_ has joined #puppet-openstack | 17:52 | |
*** jpena is now known as jpena|off | 18:11 | |
*** jtomasek has quit IRC | 18:15 | |
*** markvoelker has joined #puppet-openstack | 18:22 | |
*** trown|lunch is now known as trown | 18:25 | |
*** amoralej is now known as amoralej|off | 18:43 | |
*** markvoelker has quit IRC | 18:56 | |
*** morazi has quit IRC | 19:07 | |
openstackgerrit | eran bendror proposed openstack/puppet-nova master: bugid 1767132 - align intance name template weith controller https://review.openstack.org/639796 | 19:44 |
*** markvoelker has joined #puppet-openstack | 19:53 | |
*** morazi has joined #puppet-openstack | 20:22 | |
*** markvoelker has quit IRC | 20:26 | |
*** tosky has quit IRC | 20:36 | |
*** mmethot has quit IRC | 21:06 | |
*** jaosorior has quit IRC | 21:08 | |
*** markvoelker has joined #puppet-openstack | 21:23 | |
*** mmethot has joined #puppet-openstack | 21:42 | |
*** markvoelker has quit IRC | 21:56 | |
*** derekh has quit IRC | 22:09 | |
*** trown is now known as trown|outtypewww | 22:15 | |
*** ekultails has quit IRC | 22:20 | |
*** mmethot has quit IRC | 22:57 | |
*** rcernin has joined #puppet-openstack | 23:06 | |
*** rascasoft has quit IRC | 23:10 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!